GNU bug report logs - #77096
31.0.50; Theme names disappear in customize-themes

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77096 in the body.
You can then email your comments to 77096 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Theme names disappear in customize-themes
Date: Tue, 18 Mar 2025 06:53:01 -0300

After emacs -Q:
M-x customize-themes
Select any theme, with the keyboard or with the mouse.
The theme gets activated, but all theme names disappear.


In GNU Emacs 31.0.50 (build 69, x86_64-pc-linux-gnu, GTK+ Version
 3.24.33, cairo version 1.16.0) of 2025-03-18 built on tbb-desktop
Repository revision: 739d18dc41234824f4f01bfaa2313510e2df14a7
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12201001
System Description: Ubuntu 22.04.5 LTS

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINERAMA XINPUT2 XPM XRANDR
GTK3 ZLIB

Important settings:
  value of $LC_MONETARY: es_AR.UTF-8
  value of $LC_NUMERIC: es_AR.UTF-8
  value of $LC_TIME: es_AR.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug lisp-mnt message mailcap yank-media puny
dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg
rfc6068 epg-config gnus-util text-property-search time-date subr-x
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo gtk
x-toolkit xinput2 x multi-tty move-toolbar make-network-process
tty-child-frames emacs)

Memory information:
((conses 16 39573 10979) (symbols 48 5473 0) (strings 32 12934 2380)
 (string-bytes 1 311205) (vectors 16 9551)
 (vector-slots 8 113960 5194) (floats 8 21 3) (intervals 56 236 0)
 (buffers 992 10))

Message #8 received at 77096 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 77096 <at> debbugs.gnu.org
Subject: Re: bug#77096: 31.0.50; Theme names disappear in customize-themes
Date: Tue, 18 Mar 2025 07:06:18 -0300

[Message part 1 (text/plain, inline)]

This is a result of my changes in:

commit 85113fcda97970bc2468f409278e27d6570fc76f
Author: Mauro Aranda <maurooaranda <at> gmail.com>
Date:   Fri Jan 17 17:12:08 2025 -0300

    Prepare markers for insertions inside of a widget

    Recreating child widgets without recreating the parent widget
    may lead to situations where the parent widget doesn't cover its
    children or buttons entirely anymore.  This bug manifests as a
    faulty fontification of children or buttons, for example.
    (Bug#69941)

    * lisp/wid-edit.el (widget--prepare-markers-for-inside-insertion)
    (widget--prepare-markers-for-outside-insertion): New functions.
    (widget-default-create): Use them.

    * test/lisp/wid-edit-tests.el (widget-test-insertion-at-parent-markers)
    (widget-test-insertion-at-parent-markers-2): New tests.


But I don't think there's a bug in the wid-edit.el code, rather it's in
customize-themes.  The layout for a line with a theme is like this:
CHECKBOX BUTTON -- THEME-DESCRIPTION

BUTTON has the theme name as a label, and it disappears after toggling
the checkbox.  The code creates BUTTON as a child of CHECKBOX, so the
code is asking for BUTTON to be contained inside CHECKBOX.  It didn't
happen before because of Bug#69941, but I think that what happens now is
what should happen.  Now, when the checkbox gets recreated, it deletes
its child and never creates it back (the cus-theme.el code should be
responsible of telling it to create it back in that case).

But I don't think BUTTON should be a child of CHECKBOX.  In fact, the
usual thing to do with the Widget library is to make it a sibling.  So I
propose the attached patch.

[0001-Fix-widget-relationship-in-customize-themes.patch (text/x-patch, attachment)]

Message #11 received at 77096 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 77096 <at> debbugs.gnu.org
Subject: Re: bug#77096: 31.0.50; Theme names disappear in customize-themes
Date: Wed, 2 Apr 2025 08:12:42 -0300

close 77096
quit


On 18/3/25 07:06, Mauro Aranda wrote:
> This is a result of my changes in:
>
> commit 85113fcda97970bc2468f409278e27d6570fc76f
> Author: Mauro Aranda <maurooaranda <at> gmail.com>
> Date:   Fri Jan 17 17:12:08 2025 -0300
>
>      Prepare markers for insertions inside of a widget
>
>      Recreating child widgets without recreating the parent widget
>      may lead to situations where the parent widget doesn't cover its
>      children or buttons entirely anymore.  This bug manifests as a
>      faulty fontification of children or buttons, for example.
>      (Bug#69941)
>
>      * lisp/wid-edit.el (widget--prepare-markers-for-inside-insertion)
>      (widget--prepare-markers-for-outside-insertion): New functions.
>      (widget-default-create): Use them.
>
>      * test/lisp/wid-edit-tests.el
> (widget-test-insertion-at-parent-markers)
>      (widget-test-insertion-at-parent-markers-2): New tests.
>
>
> But I don't think there's a bug in the wid-edit.el code, rather it's in
> customize-themes.  The layout for a line with a theme is like this:
> CHECKBOX BUTTON -- THEME-DESCRIPTION
>
> BUTTON has the theme name as a label, and it disappears after toggling
> the checkbox.  The code creates BUTTON as a child of CHECKBOX, so the
> code is asking for BUTTON to be contained inside CHECKBOX.  It didn't
> happen before because of Bug#69941, but I think that what happens now is
> what should happen.  Now, when the checkbox gets recreated, it deletes
> its child and never creates it back (the cus-theme.el code should be
> responsible of telling it to create it back in that case).
>
> But I don't think BUTTON should be a child of CHECKBOX.  In fact, the
> usual thing to do with the Widget library is to make it a sibling.  So I
> propose the attached patch.

Pushed to master.  Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.