GNU bug report logs - #77093
[PATCH rust-team 00/18] New Rust packaging workflow based on lockfile importer.

Previous Next

Package: guix-patches;

Reported by: Hilton Chain <hako <at> ultrarare.space>

Date: Tue, 18 Mar 2025 07:18:02 UTC

Severity: normal

Tags: patch

Full log


View this message in rfc822 format

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, 77093 <at> debbugs.gnu.org, Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>, Ludovic Courtès <ludo <at> gnu.org>, Tobias Geerinckx-Rice <me <at> tobias.gr>, Christopher Baines <guix <at> cbaines.net>
Subject: [bug#77093] [PATCH rust-team 10/18] scripts: import: Add two newlines for ‘--insert’ option.
Date: Tue, 18 Mar 2025 13:49:33 +0200
[Message part 1 (text/plain, inline)]
Is this only relevant for packages crated with 'guix import cargo'? If
so we should probably just change the importer to add a newline to the
misbehaving importer.

On Tue, Mar 18, 2025 at 03:24:23PM +0800, Hilton Chain wrote:
> For consistency with ‘insert-expression’.
> 
> * guix/scripts/import.scm (guix-import): Add two newlines when inserting.
> 
> Change-Id: I55b45ca137d175fdf6ee5c0bb2b6b1ca8385750d
> ---
>  guix/scripts/import.scm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/guix/scripts/import.scm b/guix/scripts/import.scm
> index 4fad329cd3..58a84d0db7 100644
> --- a/guix/scripts/import.scm
> +++ b/guix/scripts/import.scm
> @@ -129,6 +129,7 @@ (define-command (guix-import . args)
>                        (let ((port (open-file file "a")))
>                          (pretty-print-with-comments port expr)
>                          (newline port)
> +                        (newline port)
>                          (close-port port)))))))))
>         (import-as-definitions importer args find-and-insert)))
>      ((importer args ...)
> -- 
> 2.48.1
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 13 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.