GNU bug report logs - #77079
31.0.50; Re-parenting tty child frame leaves two instances on display

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Subject: Re: 31.0.50; Re-parenting tty child frame leaves two instances on
 display
Date: Mon, 17 Mar 2025 20:50:52 +0100

martin rudalics <rudalics <at> gmx.at> writes:

> I think we need the following change
>
> diff --git a/src/frame.c b/src/frame.c
> index c1ef26e5dd4..9a4ca7d0682 100644
> --- a/src/frame.c
> +++ b/src/frame.c
> @@ -3706,6 +3706,7 @@ store_frame_param (struct frame *f, Lisp_Object prop, Lisp_Object val)
>         if (NILP (f->parent_frame) != NILP (val))
>   	error ("Making a root frame a child or vice versa is not supported");
>         f->parent_frame = val;
> +      SET_FRAME_GARBAGED (root_frame (f));
>       }
>
>     /* The tty color needed to be set before the frame's parameter
>
> since otherwise re-parenting a child frame, for example, using
>
> (set-frame-parameter tty-3 'parent-frame tty-1)
>
> from my earlier tty-child-frames.el leaves one with two instances of the
> child frame on display.
>
> martin

Yep, for sure.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.