GNU bug report logs - #77079
31.0.50; Re-parenting tty child frame leaves two instances on display

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: martin rudalics <rudalics <at> gmx.at>
Subject: bug#77079: closed (Re: 31.0.50; Re-parenting tty child frame
 leaves two instances on display)
Date: Wed, 19 Mar 2025 08:44:05 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#77079: 31.0.50; Re-parenting tty child frame leaves two instances on display

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 77079 <at> debbugs.gnu.org.

-- 
77079: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77079
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: martin rudalics <rudalics <at> gmx.at>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 77079-done <at> debbugs.gnu.org
Subject: Re: 31.0.50; Re-parenting tty child frame leaves two instances on
 display
Date: Wed, 19 Mar 2025 09:43:24 +0100

Closing this bug.

martin

[Message part 3 (message/rfc822, inline)]

From: martin rudalics <rudalics <at> gmx.at>
To: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Cc: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Subject: 31.0.50; Re-parenting tty child frame leaves two instances on display
Date: Mon, 17 Mar 2025 19:52:41 +0100

I think we need the following change

diff --git a/src/frame.c b/src/frame.c
index c1ef26e5dd4..9a4ca7d0682 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -3706,6 +3706,7 @@ store_frame_param (struct frame *f, Lisp_Object prop, Lisp_Object val)
       if (NILP (f->parent_frame) != NILP (val))
 	error ("Making a root frame a child or vice versa is not supported");
       f->parent_frame = val;
+      SET_FRAME_GARBAGED (root_frame (f));
     }

   /* The tty color needed to be set before the frame's parameter

since otherwise re-parenting a child frame, for example, using

(set-frame-parameter tty-3 'parent-frame tty-1)

from my earlier tty-child-frames.el leaves one with two instances of the
child frame on display.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.