From unknown Tue Jun 17 03:40:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#77062 <77062@debbugs.gnu.org> To: bug#77062 <77062@debbugs.gnu.org> Subject: Status: [PATCH] NS: Correct the accessibility role of Emacs windows Reply-To: bug#77062 <77062@debbugs.gnu.org> Date: Tue, 17 Jun 2025 10:40:04 +0000 retitle 77062 [PATCH] NS: Correct the accessibility role of Emacs windows reassign 77062 emacs submitter 77062 Rudolf Adamkovi=C4=8D severity 77062 normal tag 77062 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 16 21:55:25 2025 Received: (at submit) by debbugs.gnu.org; 17 Mar 2025 01:55:25 +0000 Received: from localhost ([127.0.0.1]:51915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttzhM-000688-Gy for submit@debbugs.gnu.org; Sun, 16 Mar 2025 21:55:24 -0400 Received: from lists.gnu.org ([2001:470:142::17]:32786) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ttzhH-00065x-RO for submit@debbugs.gnu.org; Sun, 16 Mar 2025 21:55:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ttzhC-0006Iu-5y for bug-gnu-emacs@gnu.org; Sun, 16 Mar 2025 21:55:14 -0400 Received: from fhigh-b4-smtp.messagingengine.com ([202.12.124.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ttzh9-0008N8-HJ for bug-gnu-emacs@gnu.org; Sun, 16 Mar 2025 21:55:13 -0400 Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfhigh.stl.internal (Postfix) with ESMTP id 9574B2540171 for ; Sun, 16 Mar 2025 21:55:09 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Sun, 16 Mar 2025 21:55:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamkovic.org; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm2; t=1742176509; x=1742262909; bh=JzBG/iLIjwOchhTUhrQhgm8i1d80anAl OEDP8OxnuFY=; b=b9Uv8jJ3lIcVpyhtl6GZkK63VNml5wBPhMVlTpN7TJSM+sUg BWUVchhiVuQVsrvcTROjPwgiNBe3nK70FVs9mt7SleQVgjMx1mOC9k8K3MH2jZdj ySIM4qDMOngF00hBlk9FjQpbD74+pDMttQkVPZJgNbNKtdHVYkqzKbB9M+IaB0w+ isiM/eh2QsWEuRq9mjboY76j/wAlEOMFS/Q8uwmpcf0xInQ4NkvP/tQoV8Io2UI5 AyXaUspgPLT8kBb1iVlj8Tu6N7pHRMWcVruu7Qiklz5dagaaV3xrdcAlzcW0M4aD esONJcCc+hgGroBmJX+b87OprDftGnd/so1ldg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1742176509; x= 1742262909; bh=JzBG/iLIjwOchhTUhrQhgm8i1d80anAlOEDP8OxnuFY=; b=C DYzHmsmsMC9QpuXux2NLLF+oSSWNNsT0AqAI2/TOB4h9AOvu7zbwO84BiwcDoGA8 L6CTDylvP/PVOR8K2PnIAzpl+6op34tG+B7wyP/CpiVaasZndZnVfwVBmd69fFGn r5EX+AzAGKEbgh9nY2pz2P58ChXS6qerX4naex1ZKk02mRUBg/acVjK/nHlczvHS RC1gLGd3BjwKR9e6obY9kdpER7ZDS+ezbWWzFqQ+CYXeh9YAvkqfZK7U7NzUlBfQ 7JsbaKLJweN6ojDfXDFQrhUzmp6a8VQ2lounC3v0yjQ6vGxuSH5YOwki1J0zbKuI O9bE7OsvlSlrYCvUByoSA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddufeekvdegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvf fufffkgggtsehmtderredttdejnecuhfhrohhmpeftuhguohhlfhcutegurghmkhhovhhi tgcuoehruhguohhlfhesrggurghmkhhovhhitgdrohhrgheqnecuggftrfgrthhtvghrnh epffekfeeuudeftdekveejjeevteffudetjeetgedtffduuedvjeekvdejueeiveffnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhhuugholh hfsegruggrmhhkohhvihgtrdhorhhgpdhnsggprhgtphhtthhopedupdhmohguvgepshhm thhpohhuthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i88214938:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sun, 16 Mar 2025 21:55:08 -0400 (EDT) From: =?utf-8?Q?Rudolf_Adamkovi=C4=8D?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] NS: Correct the accessibility role of Emacs windows X-Debbugs-Cc: Date: Mon, 17 Mar 2025 02:55:05 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=202.12.124.155; envelope-from=rudolf@adamkovic.org; helo=fhigh-b4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --=-=-= Content-Type: text/plain Tags: patch See the commit message in the patch. In GNU Emacs 31.0.50 (build 1, aarch64-apple-darwin24.3.0, NS appkit-2575.40 Version 15.3.1 (Build 24D70)) of 2025-03-17 built on skynet.local Repository revision: eab14d68b2e72b9a6b8b0cc67c9667c2bfbed4f5 Repository branch: master Windowing system distributor 'Apple', version 10.3.2575 System Description: macOS 15.3.1 Configured using: 'configure --with-json --with-tree-sitter --with-sqlite3 --with-native-compilation=aot' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-NS-Correct-the-accessibility-role-of-Emacs-windows.patch >From a8cb24f9069de15b1ac5a31ee85079fbc4376ed9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Mon, 17 Mar 2025 02:25:21 +0100 Subject: [PATCH] NS: Correct the accessibility role of Emacs windows * src/nsterm.m: ([EmacsWindow accessibilityAttributeValue:]): Make the accessibility role of Emacs windows to be "standard window" (AXWindow) instead of "text field" (AXTextField). This matches other applications on NS, as can be verified with any accessibility inspector. All widely used NS ports, such as Emacs Plus, have this patch already applied. As for practical impact, this change makes Emacs, for example, work with tiling window managers, such as Yabai, where many users report problems with Emacs specifically, and are instructed to simply avoid the official NS port of GNU Emacs due to this problem. --- src/nsterm.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nsterm.m b/src/nsterm.m index 46bb3f5dd7a..45526d96910 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -9722,7 +9722,7 @@ - (id)accessibilityAttributeValue:(NSString *)attribute NSTRACE ("[EmacsWindow accessibilityAttributeValue:]"); if ([attribute isEqualToString:NSAccessibilityRoleAttribute]) - return NSAccessibilityTextFieldRole; + return NSAccessibilityWindowRole; if ([attribute isEqualToString:NSAccessibilitySelectedTextAttribute] && curbuf && ! NILP (BVAR (curbuf, mark_active))) -- 2.39.5 (Apple Git-154) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 "Chop your own wood and it will warm you twice." --- Henry Ford; Francis Kinloch, 1819; Henry David Thoreau, 1854 Rudolf Adamkovi=C4=8D [he/him] http://adamkovic.org --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 30 21:34:34 2025 Received: (at 77062) by debbugs.gnu.org; 31 Mar 2025 01:34:34 +0000 Received: from localhost ([127.0.0.1]:38615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tz42r-0003dP-Dn for submit@debbugs.gnu.org; Sun, 30 Mar 2025 21:34:34 -0400 Received: from fhigh-b1-smtp.messagingengine.com ([202.12.124.152]:48147) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tz42m-0003c2-Us for 77062@debbugs.gnu.org; Sun, 30 Mar 2025 21:34:29 -0400 Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id 16FF025401A7 for <77062@debbugs.gnu.org>; Sun, 30 Mar 2025 21:34:23 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Sun, 30 Mar 2025 21:34:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamkovic.org; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1743384862; x=1743471262; bh=UxG9WjJbpEoEZFg3fza/K0vUD+53CjFbIRmUrLG47N4=; b= mUm7/FBJYti8SJGzoJGVV0MmhdnX6yFcmWpT9hfIlvOuMpamvu7QdzOa0j00VnEx jK1E1TqkZGuIAGNw8eZAeRNl8B9qumNf94nX5jcQdRcT94rw3fAt2y28/41887Ba h2dFY69Bg64Wr9U2Y2m3NE+nH9UnI65pZ3N+GaJop1Gc+YG5qnOe8aCMCrTdVB3h atzyuMZyTZAYDkbeqmEsqnGoP9oG18nHNYBHPhfga6pEzV6It99MGm2yLQHIJw1k nINc5UgYZ9u9XZTxQYM4HuV5CsIU0Q3e7UVXIuMqlmb15ispWxNZGHI5VXjjwwGY Nh61WPHl/LZCcalaPK774g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1743384862; x=1743471262; bh=U xG9WjJbpEoEZFg3fza/K0vUD+53CjFbIRmUrLG47N4=; b=hILiKnKrkCewk8XyE FvolcAfCZoXIKrBiYAEqkqBnH0MGT9dH9mI8zGwbdwVXVItCSuVNrrwQnOTw5z9E Bj3v0boAZ3KIJQNKrMt+ToOxtgDvIH6H4vtaCF9o86sCTnLkVctpXZZ9b9sS2wI/ iA3YXAaPpWZ6C/aszzd44cC6X6F7MT6/3UbaAF+bA8/8hH9+5GxCU+kYZweS1Jm7 G/llRr+XsBIbENbLBiPnOVXSKRZqjRgYixrObAHep17qIK4iw6dNb+mCJcS9W/Ey YtXdocamb1JK4nPXvq+h8MVugeYIcPhD1IkPtvEgV3CArZWOj+bugyU+oghHn43R wRnqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddujeekiedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvf fujghffffkgggtgfesthhqredttddtjeenucfhrhhomheptfhuugholhhfucetuggrmhhk ohhvihgtuceorhhuugholhhfsegruggrmhhkohhvihgtrdhorhhgqeenucggtffrrghtth gvrhhnpeehgffhhfefteehiedtveffleffteevudetjeekhedvhfejvedvueekhefgffeh teenucffohhmrghinheprggurghmkhhovhhitgdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehruhguohhlfhesrggurghmkhhovhhi tgdrohhrghdpnhgspghrtghpthhtohepuddpmhhouggvpehsmhhtphhouhhtpdhrtghpth htohepjeejtdeivdesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i88214938:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <77062@debbugs.gnu.org>; Sun, 30 Mar 2025 21:34:22 -0400 (EDT) From: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= To: 77062@debbugs.gnu.org Subject: Re: bug#77062: [PATCH] NS: Correct the accessibility role of Emacs windows In-Reply-To: References: Date: Mon, 31 Mar 2025 03:34:21 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77062 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Rudolf Adamkovi=C4=8D writes: > See the commit message in the patch. Ping. --=20 "Genius is 1% inspiration and 99% perspiration." --- Thomas Alva Edison, 1932 Rudolf Adamkovi=C4=8D [he/him] http://adamkovic.org