GNU bug report logs - #77054
Completion highlighting applied outside completion-lazy-hilit-fn

Previous Next

Full log

View this message in rfc822 format

From: João Távora <joaotavora <at> gmail.com>
To: João Guerra <joca.bt <at> gmail.com>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, Eli Zaretskii <eliz <at> gnu.org>, 77054 <at> debbugs.gnu.org
Subject: bug#77054: Completion highlighting applied outside completion-lazy-hilit-fn
Date: Fri, 21 Mar 2025 12:41:55 +0000

[Message part 1 (text/plain, inline)]

On Fri, Mar 21, 2025, 11:10 João Guerra <joca.bt <at> gmail.com> wrote:

> . Having the completion style
> remove all prior fontification sounds a bit extreme for an interface.
> For me, it makes more sense to be additive, but I don't know what
> Emacs' vision is on this topic.
>

It's up to the style. If you like it additive keep it additive, else do
what Eli suggests.

`completion--twq-all` is doing fontification. This function doesn't
> look like it's part of the completion frontend nor of the completion
> style. Why is it doing fontification? Should it be doing
> fontification?
>

It's part of the table. It does what it has done probably for many years.
If you want to change that behavior for everyone, go ahead, but IME you'll
eventually bother lots of people using simpler setups. If your style is
bothered by it, remove it there just like Eli suggests. In lazy and in
non-lazy situations. IOW the lazy optimization has nothing to do with this.

And if for some reason you're worrying about performance, don't. The lazy
optimization is largely about avoiding premature upfront string
allocations, not propertization. And it more than likely doesn't matter for
file tables anyway which are small compared to symbol obarrays, for
instance.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.