From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 22 04:56:52 2010 Received: (at submit) by debbugs.gnu.org; 22 Dec 2010 09:56:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PVLRE-0004dE-GB for submit@debbugs.gnu.org; Wed, 22 Dec 2010 04:56:52 -0500 Received: from emh02.mail.saunalahti.fi ([62.142.5.108]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PVLRA-0004d0-NF for submit@debbugs.gnu.org; Wed, 22 Dec 2010 04:56:50 -0500 Received: from saunalahti-vams (vs3-11.mail.saunalahti.fi [62.142.5.95]) by emh02-2.mail.saunalahti.fi (Postfix) with SMTP id E1017EFB9E for ; Wed, 22 Dec 2010 12:03:21 +0200 (EET) Received: from emh04.mail.saunalahti.fi ([62.142.5.110]) by vs3-11.mail.saunalahti.fi ([62.142.5.95]) with SMTP (gateway) id A06CE9D8D21; Wed, 22 Dec 2010 12:03:21 +0200 Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh04.mail.saunalahti.fi (Postfix) with ESMTP id B604941BED for ; Wed, 22 Dec 2010 12:03:20 +0200 (EET) From: Jari Aalto To: submit@debbugs.gnu.org Subject: [PATCH] lisp/emacs-lisp/checkdoc.el - Fix Lisp symbol `some-symbol' should appear in quotes Mail-Copies-To: poster Date: Wed, 22 Dec 2010 12:03:19 +0200 Message-ID: <878vziw2e0.fsf@picasso.cante.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Antivirus: VAMS X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) --=-=-= Content-Type: text/plain Package: emacs Version: 23.2+1-5.1 Severity: normal In docstrings like this: Return next limit point of 'status' section in current buffer. The limist are those of top level heading: # Changes to be committed: # Changed but not updated: # Untracked files: See manual page of git-status(1). checkdoc reports: Lisp symbol `git-status' should appear in quotes The following patch adjusts regexp by not matchig strings that are immediately followed by "(". The patch is against 0804bcf 2010-12-22 Merge branch 'master' of git://git.sv.gnu.org/emacs 2010-12-22 Jari Aalto * emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine): Fix "Lisp symbol `some-symbol' should appear in quotes" by not matchig strings that are immediately followed by "(", like manual page refs some-page(1). -- System Information Debian Release: squeeze/sid APT Prefers testing APT policy: (990, testing) (500, unstable) (1, experimental) Architecture: amd64 Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Fri Sep 17 21:50:19 UTC 2010 x86_64 GNU/Linux Locale: LANG=en_DK.UTF-8 -- Versions of packages `emacs depends on'. Depends: emacs23 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-lucid 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-nox 23.2+1-5.1 GNU Emacs is the extensible self-documenting --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-emacs-lisp-checkdoc.el-Fix-Lisp-symbol-some-symbol-s.patch >From f43bab31f13260966c18c0f15062b91cefb6cd32 Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Wed, 22 Dec 2010 11:58:05 +0200 Subject: [PATCH] emacs-lisp/checkdoc.el: Fix "Lisp symbol `some-symbol' should appear in quotes" Organization: Private Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Do not match strings that are immediately followed by "(", like manual page refs some-page(1). Signed-off-by: Jari Aalto --- lisp/emacs-lisp/checkdoc.el | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el index 0a3b3c9..42ac504 100644 --- a/lisp/emacs-lisp/checkdoc.el +++ b/lisp/emacs-lisp/checkdoc.el @@ -1798,7 +1798,9 @@ Replace with \"%s\"? " original replace) (let ((found nil) (start (point)) (msg nil) (ms nil)) (while (and (not msg) (re-search-forward - "[^-([`':a-zA-Z]\\(\\w+[:-]\\(\\w\\|\\s_\\)+\\)[^]']" + ;; Ignore manual page refereces like + ;; git-config(1). + "[^-([`':a-zA-Z]\\(\\w+[:-]\\(\\w\\|\\s_\\)+\\)[^](']" e t)) (setq ms (match-string 1)) ;; A . is a \s_ char, so we must remove periods from -- 1.7.2.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 21 13:05:15 2011 Received: (at 7705-done) by debbugs.gnu.org; 21 Jan 2011 18:05:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PgLMJ-000749-4O for submit@debbugs.gnu.org; Fri, 21 Jan 2011 13:05:15 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PgLMG-00073w-Io for 7705-done@debbugs.gnu.org; Fri, 21 Jan 2011 13:05:12 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p0LID4SS024366; Fri, 21 Jan 2011 13:13:04 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id DCE2BB411E; Fri, 21 Jan 2011 13:13:03 -0500 (EST) From: Stefan Monnier To: Jari Aalto Subject: Re: bug#7705: [PATCH] lisp/emacs-lisp/checkdoc.el - Fix Lisp symbol `some-symbol' should appear in quotes Message-ID: References: <878vziw2e0.fsf@picasso.cante.net> Date: Fri, 21 Jan 2011 13:13:03 -0500 In-Reply-To: <878vziw2e0.fsf@picasso.cante.net> (Jari Aalto's message of "Wed, 22 Dec 2010 12:03:19 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3735=0 X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 7705-done Cc: 7705-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > 2010-12-22 Jari Aalto > * emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine): Fix > "Lisp symbol `some-symbol' should appear in quotes" by not matchig > strings that are immediately followed by "(", like manual page > refs some-page(1). Thank you, installed, Stefan From unknown Sat Aug 16 15:54:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 19 Feb 2011 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator