GNU bug report logs - #77046
31.0.50; Emacs sometimes crashes

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Pip Cet <pipcet <at> protonmail.com>
Cc: gerd.moellmann <at> gmail.com, 77046 <at> debbugs.gnu.org, triska <at> metalevel.at
Subject: bug#77046: 31.0.50; Emacs sometimes crashes
Date: Sat, 22 Mar 2025 18:47:11 +0200

> Date: Sat, 22 Mar 2025 16:25:01 +0000
> From: Pip Cet <pipcet <at> protonmail.com>
> Cc: triska <at> metalevel.at, gerd.moellmann <at> gmail.com, 77046 <at> debbugs.gnu.org
> 
> "Eli Zaretskii" <eliz <at> gnu.org> writes:
> 
> >> That line is:
> >>
> >>   if (!FRAME_TERMINAL (f)->defined_color_hook
> >>       (f, SSDATA (name), color, true, true))
> >>
> >> which looks very unsafe to me: the SSDATA pointer will become invalid
> >> when we compact strings, which we might do since tty_lookup_color calls
> >> into Lisp.  The color_name pointer is used after that point in
> >> tty_defined_color, possibly causing false negatives for the strcmp in
> >> lines 1157/1159.
> >>
> >> However, that doesn't really explain this crash, it's just another
> >> (possibly latent) SDATA bug.  At first glance, there seem to be more of
> >> hose in xfaces.c, though, so it's possible something further up the call
> >> chain results in a corrupt SDATA pointer.
> >
> > Does the below look OK?  I think it solves several SSDATA issues,
> 
> It does, yes!  I thought there were more issues, but that was apparently
> a mistake of mine.  Sorry about that.

Thanks, installed on master.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.