GNU bug report logs - #77019
[PATCH 0/1] machine: hetzner: Allow attaching existing public IPs.

Previous Next

Full log

Message #23 received at 77019 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Roman Scherer <roman.scherer <at> burningswell.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Sergey Trofimov <sarg <at> sarg.org.ru>, Roman Scherer <roman <at> burningswell.com>,
 77019 <at> debbugs.gnu.org
Subject: Re: bug#77019: [PATCH 0/1] machine: hetzner: Allow attaching
 existing public IPs.
Date: Sun, 20 Apr 2025 23:27:20 +0900

Hi,

Roman Scherer <roman.scherer <at> burningswell.com> writes:

> Hi Ludovic and Sergey,
>
> the patch looks good to me. Thanks for adding the tests.
>
> I would have expected #t, #f or a string as the value of
> hetzner-configuration-ipv4 and hetzner-configuration-ipv6.
>
> It's a pitty the null issue in guile-json has no comments yet.
>
> I would say, let's merge it. The default behaviour right now is to
> enable ipv4 and ipv6 and this patch does the same. Once the issue in
> guile-json has been fixed we gain the ability to disable via #f, right?

nitpick: If these fields are booleans, they should be suffixed by '?',
e.g. 'ipv6?' or 'ipv4?', for clarity.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.