Subject: Re: bug#77019: [PATCH 0/1] machine: hetzner: Allow attaching existing public IPs.

From: Maxim Cournoyer <[email-masked]>
Date: Sun, 20 Apr 2025 23:27:20 +0900

Hi,

Roman Scherer <[email-masked]> writes:

> Hi Ludovic and Sergey,
>
> the patch looks good to me. Thanks for adding the tests.
>
> I would have expected #t, #f or a string as the value of
> hetzner-configuration-ipv4 and hetzner-configuration-ipv6.
>
> It's a pitty the null issue in guile-json has no comments yet.
>
> I would say, let's merge it. The default behaviour right now is to
> enable ipv4 and ipv6 and this patch does the same. Once the issue in
> guile-json has been fixed we gain the ability to disable via #f, right?

nitpick: If these fields are booleans, they should be suffixed by '?',
e.g. 'ipv6?' or 'ipv4?', for clarity.

-- 
Thanks,
Maxim