GNU bug report logs - #77004
[PATCH] gnu: libvirt: Fix path to Linux modules

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#77004: closed ([PATCH] gnu: libvirt: Fix path to Linux modules)
Date: Sun, 16 Mar 2025 14:20:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 16 Mar 2025 23:19:17 +0900
with message-id <87plihys62.fsf <at> gmail.com>
and subject line Re: [bug#77004] [PATCH] gnu: libvirt: Fix path to Linux modules, [PATCH] gnu: libvirt: Fix path to Linux modules
has caused the debbugs.gnu.org bug report #77004,
regarding [PATCH] gnu: libvirt: Fix path to Linux modules
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
77004: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77004
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: nathan <nathan_mail <at> nborghese.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: libvirt: Fix path to Linux modules
Date: Fri, 14 Mar 2025 01:16:30 +0000

[Message part 3 (text/plain, inline)]

libvirt needs to load a file that is inside the modules folder.
Fix the path
Nix has a similar fix https://github.com/NixOS/nixpkgs/pull/286985

[0001-gnu-libvirt-Fix-path-to-Linux-modules.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: nathan <nathan_mail <at> nborghese.com>
Cc: 77004-done <at> debbugs.gnu.org
Subject: Re: [bug#77004] [PATCH] gnu: libvirt: Fix path to Linux modules,
 [PATCH] gnu: libvirt: Fix path to Linux modules
Date: Sun, 16 Mar 2025 23:19:17 +0900

Hi,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

[...]

>> @@ -508,11 +508,13 @@ (define (libvirt-shepherd-service config)
>>                       (list (string-append #$libvirt "/sbin/libvirtd")
>>                             "-f" #$config-file
>>                             #$@(if listen-tcp? '("--listen") '()))
>> -                     ;; For finding qemu and ip binaries.
>> +                     ;; For finding qemu, ip binaries, and kernel modules
>>                       #:environment-variables
>> -                     (list (string-append
>> -                            "PATH=/run/current-system/profile/bin:"
>> -                            "/run/current-system/profile/sbin"))))
>> +                     (list
>> +                      (string-append
>> +                       "PATH=/run/current-system/profile/bin:"
>> +                       "/run/current-system/profile/sbin")
>> +                      "LINUX_MODULE_DIRECTORY=/run/booted-system/kernel/lib/modules")))
>
> I suppose only modules from the booted kernel makes sense to be used,
> hence the /run/booted-system instead of /run/current-system as Nix uses?

I've kept /run/booted-system, made some light cosmetic changes including
in the GNU Changelog of the commit message (have a look in commit
856fa9a4e4), and pushed!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.