GNU bug report logs - #76982
30.1; url-generic-parse-url cannot parse Windows file paths

Previous Next

Full log

Message #22 received at 76982 <at> debbugs.gnu.org (full text, mbox):

From: Sebastián Monía <sebastian <at> sebasmonia.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 76982 <at> debbugs.gnu.org, morgan <at> ice9.digital
Subject: Re: bug#76982: 30.1; url-generic-parse-url cannot parse Windows
 file paths
Date: Mon, 07 Apr 2025 00:18:57 -0400

[Message part 1 (text/plain, inline)]

Hello,

Attached a new patch, with some tests and updated changelog.

Eli Zaretskii <eliz <at> gnu.org> writes:
> Ping!  Sebastián, would you like to submit an updated patch which
> addresses my comments?
>
>> > @@ -210,6 +215,13 @@ url-generic-parse-url
>> >  
>> >            (if (and host (string-match "%[0-9][0-9]" host))
>> >                (setq host (url-unhex-string host)))
>> > +
>> > +          ;; For file:// URIs, if the path "looks like" Windows/DOS, it
>> > +          ;; makes sense to strip the leading slash (bug#76982)
>> > +          (when (and (string= "file" scheme)
>> > +                     (string-match "^/[A-Za-z]:[/\\]" file))
>> > +            (setq file (substring file 1)))
>> > +
>> >            (url-parse-make-urlobj scheme user pass host port file
>> >  				 fragment nil full))))))
>> 
>> Isn't it cleaner to go one more character forward here:
>> 
>>           ;; 3.2. Authority
>>           (when (looking-at "//")
>>             (setq full t)
>>             (forward-char 2)  <<<<<<<<<<<<<<<<<<<<
>>             (setq save-pos (point))
>>             (skip-chars-forward "^/?#")
>> 
>> if the conditions for Windows-style absolute file name are fulfilled?

The URI could potentially have components before we get to the filename,
so the look head for "path starts with" isn't as clean.
In this patch I still do that check in the same place as in the
original.


Thank you,
Seb

[0001-Special-treatment-for-file-URIs-that-look-like-Windo.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Sebastián Monía
https://site.sebasmonia.com/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.