GNU bug report logs - #76955
30.1; php-ts-mode-php-executable default path may not match remote path

Previous Next

Full log

Message #56 received at 76955 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 76955 <at> debbugs.gnu.org, morgan <at> ice9.digital
Subject: Re: bug#76955: 30.1;
 php-ts-mode-php-executable default path may not match remote path
Date: Thu, 13 Mar 2025 18:47:42 +0200

> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Cc: morgan <at> ice9.digital, 76955 <at> debbugs.gnu.org
> Date: Thu, 13 Mar 2025 17:28:41 +0100
> 
> In data giovedì 13 marzo 2025 15:25:57 Ora standard dell’Europa centrale, Eli 
> Zaretskii ha scritto:
> > How about the following solution:
> > 
> >  . we replace references to php-ts-mode-php-executable with a call to
> >    a function
> >  . that function will do something like
> > 
> >    (let ((php-prog (if (file-remote-p default-directory)
> >                        (executable-find "php" t)
> > 		     php-ts-mode-php-executable)))
> >      php-prog)
> > 
> > WDYT?
> Yes, that's fine. Maybe we should also rename 'php-ts-mode-php-executable', 
> something like 'php-ts-mode-php-default-executable'. It seems to me that it 
> might not be clear that this value would not be used if the file was remote.

Yes, good idea.  Would you like to post a patch to that effect?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.