GNU bug report logs - #76955
30.1; php-ts-mode-php-executable default path may not match remote path

Previous Next

Full log

Message #53 received at 76955 <at> debbugs.gnu.org (full text, mbox):

From: Morgan Willcock <morgan <at> ice9.digital>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 76955 <at> debbugs.gnu.org
Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may
 not match remote path
Date: Thu, 13 Mar 2025 16:45:04 +0000

Vincenzo Pupillo <v.pupillo <at> gmail.com> writes:

> In data giovedì 13 marzo 2025 15:25:57 Ora standard dell’Europa centrale, Eli
> Zaretskii ha scritto:
>> > From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
>> > Cc: 76955 <at> debbugs.gnu.org
>> > Date: Thu, 13 Mar 2025 11:17:11 +0100
>> >
>> > Ciao,
>> >
>> > 'php-ts-mode-php-executable' it's used for 'php-ts-mode-flymake-php',
>> > 'run-php' and 'php-ts-mode-run-php-webserver'.
>>
>> Then please consider the solution proposed below.
>>
>> > @Morgan: Will setting the executable path to "php" work in your scenario?
>> > Of the functions listed above, which one do you usually use?
>>
>> Customizing the value is an okay solution, but we are discussing how
>> to solve this for users that don't customize.
>>
>> How about the following solution:
>>
>>  . we replace references to php-ts-mode-php-executable with a call to
>>    a function
>>  . that function will do something like
>>
>>    (let ((php-prog (if (file-remote-p default-directory)
>>                        (executable-find "php" t)
>> 		     php-ts-mode-php-executable)))
>>      php-prog)
>>
>> WDYT?
> Yes, that's fine. Maybe we should also rename 'php-ts-mode-php-executable',
> something like 'php-ts-mode-php-default-executable'. It seems to me that it
> might not be clear that this value would not be used if the file was remote.

Wouldn't this approach make it impossible to override the value for the
remote system if the wrong PHP binary is found by executable-find?

-- 
Morgan Willcock

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.