GNU bug report logs - #76955
30.1; php-ts-mode-php-executable default path may not match remote path

Previous Next

Full log

Message #143 received at 76955 <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76955 <at> debbugs.gnu.org, morgan <at> ice9.digital
Subject: Re: bug#76955: 30.1;
 php-ts-mode-php-executable default path may not match remote path
Date: Wed, 19 Mar 2025 18:14:23 +0100

[Message part 1 (text/plain, inline)]

Ciao Micheal, thank you. 
The new version of the patch is attached.

Thanks.

Vincenzo


In data mercoledì 19 marzo 2025 14:14:30 Ora standard dell’Europa centrale, 
Michael Albinus ha scritto:
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> Hi,
> 
> >>   (let ((php-prog
> >>   
> >>          (if (file-remote-p default-directory)
> >>          
> >>              (executable-find
> >>              
> >>               (or php-ts-mode-alternative-php-program-name "php") t)
> >>            
> >>            (if php-ts-mode-alternative-php-program-name
> >>            
> >>                (executable-find
> >>                
> >>                 php-ts-mode-alternative-php-program-name)
> >>              
> >>              php-ts-mode-php-default-executable))))
> >>     
> >>     php-prog))
> >> 
> >> WDYT?
> > 
> > I think this is okay, but let's also ask Michael (CC'ed).
> 
> The following should suffice:
> 
> --8<---------------cut here---------------start------------->8---
> (or (executable-find
>       (or php-ts-mode-alternative-php-program-name "php") t)
>     php-ts-mode-php-default-executable)
> --8<---------------cut here---------------end--------------->8---
> 
> executable-find works also on local default-directory with non-nil
> REMOTE. And you don't need the let-clause.
> 
> > Thanks.

[0001-PHP-should-be-in-the-PATH-either-locally-or-remotely.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.