GNU bug report logs - #76955
30.1; php-ts-mode-php-executable default path may not match remote path

Previous Next

Package: emacs;

Reported by: Morgan Willcock <morgan <at> ice9.digital>

Date: Tue, 11 Mar 2025 20:11:02 UTC

Severity: normal

Found in version 30.1

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Vincenzo Pupillo <v.pupillo <at> gmail.com>, 76955 <at> debbugs.gnu.org, morgan <at> ice9.digital
Subject: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path
Date: Wed, 19 Mar 2025 14:14:30 +0100
Eli Zaretskii <eliz <at> gnu.org> writes:

Hi,

>>   (let ((php-prog
>>          (if (file-remote-p default-directory)
>>              (executable-find
>>               (or php-ts-mode-alternative-php-program-name "php") t)
>>            (if php-ts-mode-alternative-php-program-name
>>                (executable-find
>>                 php-ts-mode-alternative-php-program-name)
>>              php-ts-mode-php-default-executable))))
>>     php-prog))
>>
>> WDYT?
>
> I think this is okay, but let's also ask Michael (CC'ed).

The following should suffice:

--8<---------------cut here---------------start------------->8---
(or (executable-find
      (or php-ts-mode-alternative-php-program-name "php") t)
    php-ts-mode-php-default-executable)
--8<---------------cut here---------------end--------------->8---

executable-find works also on local default-directory with non-nil
REMOTE. And you don't need the let-clause.

> Thanks.




This bug report was last modified 52 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.