GNU bug report logs - #76955
30.1; php-ts-mode-php-executable default path may not match remote path

Previous Next

Full log

Message #137 received at 76955 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>,
 Michael Albinus <michael.albinus <at> gmx.de>
Cc: 76955 <at> debbugs.gnu.org, morgan <at> ice9.digital
Subject: Re: bug#76955: 30.1;
 php-ts-mode-php-executable default path may not match remote path
Date: Wed, 19 Mar 2025 14:17:55 +0200

> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Cc: 76955 <at> debbugs.gnu.org
> Date: Tue, 18 Mar 2025 21:25:02 +0100
> 
> (defvar-local php-ts-mode-alternative-php-program-name nil
>   "An alternative to the usual `php' program name.
> In non-nil, `php-ts-mode--executable' try to find this executable.")
> 
> (defun php-ts-mode--executable ()
>   "Return the absolute filename of the `php' executable.
> If the `default-directory' is remote, search on a remote host, otherwise
> return `php-ts-mode-php-default-executable'.  If
> `php-ts-mode-alternative-php-program-name' is non-nil, finds this program
> instead of the usual `php'."
>   (let ((php-prog
>          (if (file-remote-p default-directory)
>              (executable-find
>               (or php-ts-mode-alternative-php-program-name "php") t)
>            (if php-ts-mode-alternative-php-program-name
>                (executable-find
>                 php-ts-mode-alternative-php-program-name)
>              php-ts-mode-php-default-executable))))
>     php-prog))
> 
> WDYT?

I think this is okay, but let's also ask Michael (CC'ed).

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.