GNU bug report logs - #76955
30.1; php-ts-mode-php-executable default path may not match remote path

Previous Next

Full log

View this message in rfc822 format

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 76955 <at> debbugs.gnu.org, morgan <at> ice9.digital
Subject: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path
Date: Mon, 17 Mar 2025 22:27:28 +0100

[Message part 1 (text/plain, inline)]

Ciao Eli, this is the new patch. 
I did not write anything to /etc/NEWS in this patch, there is no new 30.2 
section. Do I need to create one?

In data giovedì 13 marzo 2025 17:47:42 Ora standard dell’Europa centrale, Eli 
Zaretskii ha scritto:
> > From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> > Cc: morgan <at> ice9.digital, 76955 <at> debbugs.gnu.org
> > Date: Thu, 13 Mar 2025 17:28:41 +0100
> > 
> > In data giovedì 13 marzo 2025 15:25:57 Ora standard dell’Europa centrale,
> > Eli> 
> > Zaretskii ha scritto:
> > > How about the following solution:
> > >  . we replace references to php-ts-mode-php-executable with a call to
> > >  
> > >    a function
> > >  
> > >  . that function will do something like
> > >  
> > >    (let ((php-prog (if (file-remote-p default-directory)
> > >    
> > >                        (executable-find "php" t)
> > > 		     
> > > 		     php-ts-mode-php-executable)))
> > >      
> > >      php-prog)
> > > 
> > > WDYT?
> > 
> > Yes, that's fine. Maybe we should also rename
> > 'php-ts-mode-php-executable',
> > something like 'php-ts-mode-php-default-executable'. It seems to me that
> > it
> > might not be clear that this value would not be used if the file was
> > remote.
> Yes, good idea.  Would you like to post a patch to that effect?

[0001-PHP-should-be-in-the-PATH-either-locally-or-remotely.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.