From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 11 16:10:23 2025 Received: (at submit) by debbugs.gnu.org; 11 Mar 2025 20:10:23 +0000 Received: from localhost ([127.0.0.1]:45863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ts5vi-0002uR-EO for submit@debbugs.gnu.org; Tue, 11 Mar 2025 16:10:23 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42742) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ts5ve-0002ne-6Z for submit@debbugs.gnu.org; Tue, 11 Mar 2025 16:10:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ts5vI-0001CX-6B for bug-gnu-emacs@gnu.org; Tue, 11 Mar 2025 16:09:56 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ts5vE-0002Ob-I4 for bug-gnu-emacs@gnu.org; Tue, 11 Mar 2025 16:09:55 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 30E7844345 for ; Tue, 11 Mar 2025 20:09:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1741723786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=NDw56q8QkOVaych3SI/FiPwgKkWSnZqRUux5/BgMjzw=; b=WvYUSsjtumuzQzFpJF/oN+4Js7A20IZUiVo5JVzP4EBDRzcVshxI5xyeQWf6uM4oo3bLOx bfTpiVDSka7N2OsiuPuwnWJSrrGLKZlcyL9Bvvq+WukSsY3kLEI0jIFdiIHHzljDS/MgsV +NaHgboSnqgXwwnwkTrAhsO1rQUz4RjsH/lnIfj+WpK8rSIfdY+Ing8UUSDvvbulC6lPe/ /LMRVnAwa/jpKxfnz6Eed/NCA4O0nrweYvKpXdcaWOX7RdFW5p+1OlDlH6/QmYYcVc7PjS 3/oYs3eBufFhqiGnlsU54Lj7Lo6BbtxuTOUbBmThytEv+SC+H+6t8LQsXbXDjw== From: Morgan Willcock To: bug-gnu-emacs@gnu.org Subject: 30.1; php-ts-mode-php-executable default path may not match remote path X-Debbugs-Cc: Vincenzo Pupillo Date: Tue, 11 Mar 2025 20:09:37 +0000 Message-ID: <87frjj2uta.fsf@ice9.digital> MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: 0 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdefudehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecunecujfgurhephffvufffkfggtgesthdtredttddttdenucfhrhhomhepofhorhhgrghnucghihhllhgtohgtkhcuoehmohhrghgrnhesihgtvgelrdguihhgihhtrghlqeenucggtffrrghtthgvrhhnpedtleejffejheelkeekvdekleegvdeihfduueeludetueffudetgffhgfelteethfenucfkphepkedtrdeggedrvdeftddrkedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepkedtrdeggedrvdeftddrkedvpdhhvghlohepmhgrtghmihhnihdrnhhothhlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhorhhgrghnsehitggvledrughighhithgrlhdpnhgspghrtghpthhtohepuddprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhg X-GND-Sasl: morgan@ice9.digital Received-SPF: pass client-ip=217.70.183.197; envelope-from=morgan@ice9.digital; helo=relay5-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) The default value of php-ts-mode-php-executable is determined by searching for a php binary locally, but the found path may not work for TRAMP connections to a remote system: (defcustom php-ts-mode-php-executable (or (executable-find "php") "/usr/bin/php") Would it not be more portable to just set the executable path to "php" and then let a binary named "php" be located both locally and remotely? In particular, if connecting from a Windows system to a remote system, the probability of the binary location being the same on both systems is likely to be very low. In GNU Emacs 30.1 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.2, Xaw scroll bars) of 2025-03-02 built on macmini Windowing system distributor 'The X.Org Foundation', version 11.0.12101015 System Description: Debian GNU/Linux trixie/sid Configured using: 'configure --with-native-compilation --with-xml2 --with-x-toolkit=lucid --with-tree-sitter --disable-gc-mark-trace' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XPM LUCID ZLIB Important settings: value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: which-key-mode: t global-visual-wrap-prefix-mode: t display-time-mode: t savehist-mode: t repeat-mode: t recentf-mode: t minibuffer-electric-default-mode: t minibuffer-depth-indicate-mode: t midnight-mode: t ido-everywhere: t global-hl-line-mode: t editorconfig-mode: t global-display-fill-column-indicator-mode: t global-devil-mode: t devil-mode: t global-corfu-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-history-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t view-mode: t Load-path shadows: /home/mwillcock/.emacs.d/elpa/modus-themes-4.6.0/theme-loaddefs hides /usr/local/share/emacs/30.1/lisp/theme-loaddefs /home/mwillcock/.emacs.d/elpa/python-0.29/python hides /usr/local/share/emacs/30.1/lisp/progmodes/python /home/mwillcock/.emacs.d/elpa/eglot-1.18/eglot hides /usr/local/share/emacs/30.1/lisp/progmodes/eglot /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-css hides /usr/local/share/emacs/30.1/lisp/org/ob-css /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-version hides /usr/local/share/emacs/30.1/lisp/org/org-version /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-table hides /usr/local/share/emacs/30.1/lisp/org/ob-table /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-mobile hides /usr/local/share/emacs/30.1/lisp/org/org-mobile /home/mwillcock/.emacs.d/elpa/org-9.7.24/oc-basic hides /usr/local/share/emacs/30.1/lisp/org/oc-basic /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-lint hides /usr/local/share/emacs/30.1/lisp/org/org-lint /home/mwillcock/.emacs.d/elpa/org-9.7.24/oc-csl hides /usr/local/share/emacs/30.1/lisp/org/oc-csl /home/mwillcock/.emacs.d/elpa/org-9.7.24/oc-bibtex hides /usr/local/share/emacs/30.1/lisp/org/oc-bibtex /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-macs hides /usr/local/share/emacs/30.1/lisp/org/org-macs /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-protocol hides /usr/local/share/emacs/30.1/lisp/org/org-protocol /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-forth hides /usr/local/share/emacs/30.1/lisp/org/ob-forth /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-ditaa hides /usr/local/share/emacs/30.1/lisp/org/ob-ditaa /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-compat hides /usr/local/share/emacs/30.1/lisp/org/org-compat /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox hides /usr/local/share/emacs/30.1/lisp/org/ox /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-rmail hides /usr/local/share/emacs/30.1/lisp/org/ol-rmail /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-core hides /usr/local/share/emacs/30.1/lisp/org/ob-core /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-latex hides /usr/local/share/emacs/30.1/lisp/org/ob-latex /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-mouse hides /usr/local/share/emacs/30.1/lisp/org/org-mouse /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox-md hides /usr/local/share/emacs/30.1/lisp/org/ox-md /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-sql hides /usr/local/share/emacs/30.1/lisp/org/ob-sql /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-org hides /usr/local/share/emacs/30.1/lisp/org/ob-org /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-table hides /usr/local/share/emacs/30.1/lisp/org/org-table /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-ocaml hides /usr/local/share/emacs/30.1/lisp/org/ob-ocaml /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-clock hides /usr/local/share/emacs/30.1/lisp/org/org-clock /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-feed hides /usr/local/share/emacs/30.1/lisp/org/org-feed /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-refile hides /usr/local/share/emacs/30.1/lisp/org/org-refile /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox-ascii hides /usr/local/share/emacs/30.1/lisp/org/ox-ascii /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox-icalendar hides /usr/local/share/emacs/30.1/lisp/org/ox-icalendar /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-C hides /usr/local/share/emacs/30.1/lisp/org/ob-C /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-gnuplot hides /usr/local/share/emacs/30.1/lisp/org/ob-gnuplot /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-src hides /usr/local/share/emacs/30.1/lisp/org/org-src /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-clojure hides /usr/local/share/emacs/30.1/lisp/org/ob-clojure /home/mwillcock/.emacs.d/elpa/org-9.7.24/oc hides /usr/local/share/emacs/30.1/lisp/org/oc /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol hides /usr/local/share/emacs/30.1/lisp/org/ol /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-ctags hides /usr/local/share/emacs/30.1/lisp/org/org-ctags /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-perl hides /usr/local/share/emacs/30.1/lisp/org/ob-perl /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-processing hides /usr/local/share/emacs/30.1/lisp/org/ob-processing /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-bbdb hides /usr/local/share/emacs/30.1/lisp/org/ol-bbdb /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-eval hides /usr/local/share/emacs/30.1/lisp/org/ob-eval /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox-odt hides /usr/local/share/emacs/30.1/lisp/org/ox-odt /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-bibtex hides /usr/local/share/emacs/30.1/lisp/org/ol-bibtex /home/mwillcock/.emacs.d/elpa/org-9.7.24/oc-biblatex hides /usr/local/share/emacs/30.1/lisp/org/oc-biblatex /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-timer hides /usr/local/share/emacs/30.1/lisp/org/org-timer /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-attach hides /usr/local/share/emacs/30.1/lisp/org/org-attach /home/mwillcock/.emacs.d/elpa/org-9.7.24/org hides /usr/local/share/emacs/30.1/lisp/org/org /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-fold hides /usr/local/share/emacs/30.1/lisp/org/org-fold /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-comint hides /usr/local/share/emacs/30.1/lisp/org/ob-comint /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-pcomplete hides /usr/local/share/emacs/30.1/lisp/org/org-pcomplete /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-keys hides /usr/local/share/emacs/30.1/lisp/org/org-keys /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox-latex hides /usr/local/share/emacs/30.1/lisp/org/ox-latex /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-ruby hides /usr/local/share/emacs/30.1/lisp/org/ob-ruby /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-capture hides /usr/local/share/emacs/30.1/lisp/org/org-capture /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-gnus hides /usr/local/share/emacs/30.1/lisp/org/ol-gnus /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-eshell hides /usr/local/share/emacs/30.1/lisp/org/ob-eshell /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-tempo hides /usr/local/share/emacs/30.1/lisp/org/org-tempo /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-element-ast hides /usr/local/share/emacs/30.1/lisp/org/org-element-ast /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-man hides /usr/local/share/emacs/30.1/lisp/org/ol-man /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-js hides /usr/local/share/emacs/30.1/lisp/org/ob-js /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-plot hides /usr/local/share/emacs/30.1/lisp/org/org-plot /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-attach-git hides /usr/local/share/emacs/30.1/lisp/org/org-attach-git /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-lua hides /usr/local/share/emacs/30.1/lisp/org/ob-lua /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-eww hides /usr/local/share/emacs/30.1/lisp/org/ol-eww /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-fortran hides /usr/local/share/emacs/30.1/lisp/org/ob-fortran /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-screen hides /usr/local/share/emacs/30.1/lisp/org/ob-screen /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-footnote hides /usr/local/share/emacs/30.1/lisp/org/org-footnote /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-loaddefs hides /usr/local/share/emacs/30.1/lisp/org/org-loaddefs /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-julia hides /usr/local/share/emacs/30.1/lisp/org/ob-julia /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-awk hides /usr/local/share/emacs/30.1/lisp/org/ob-awk /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-dot hides /usr/local/share/emacs/30.1/lisp/org/ob-dot /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-emacs-lisp hides /usr/local/share/emacs/30.1/lisp/org/ob-emacs-lisp /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-doi hides /usr/local/share/emacs/30.1/lisp/org/ol-doi /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-faces hides /usr/local/share/emacs/30.1/lisp/org/org-faces /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-macro hides /usr/local/share/emacs/30.1/lisp/org/org-macro /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-fold-core hides /usr/local/share/emacs/30.1/lisp/org/org-fold-core /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-sed hides /usr/local/share/emacs/30.1/lisp/org/ob-sed /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox-koma-letter hides /usr/local/share/emacs/30.1/lisp/org/ox-koma-letter /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-entities hides /usr/local/share/emacs/30.1/lisp/org/org-entities /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-sass hides /usr/local/share/emacs/30.1/lisp/org/ob-sass /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-datetree hides /usr/local/share/emacs/30.1/lisp/org/org-datetree /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-haskell hides /usr/local/share/emacs/30.1/lisp/org/ob-haskell /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox-man hides /usr/local/share/emacs/30.1/lisp/org/ox-man /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-element hides /usr/local/share/emacs/30.1/lisp/org/org-element /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-lob hides /usr/local/share/emacs/30.1/lisp/org/ob-lob /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-id hides /usr/local/share/emacs/30.1/lisp/org/org-id /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-python hides /usr/local/share/emacs/30.1/lisp/org/ob-python /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-tangle hides /usr/local/share/emacs/30.1/lisp/org/ob-tangle /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-java hides /usr/local/share/emacs/30.1/lisp/org/ob-java /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-crypt hides /usr/local/share/emacs/30.1/lisp/org/org-crypt /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-cycle hides /usr/local/share/emacs/30.1/lisp/org/org-cycle /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-lisp hides /usr/local/share/emacs/30.1/lisp/org/ob-lisp /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-makefile hides /usr/local/share/emacs/30.1/lisp/org/ob-makefile /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-persist hides /usr/local/share/emacs/30.1/lisp/org/org-persist /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob hides /usr/local/share/emacs/30.1/lisp/org/ob /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-shell hides /usr/local/share/emacs/30.1/lisp/org/ob-shell /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-indent hides /usr/local/share/emacs/30.1/lisp/org/org-indent /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-colview hides /usr/local/share/emacs/30.1/lisp/org/org-colview /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-habit hides /usr/local/share/emacs/30.1/lisp/org/org-habit /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-irc hides /usr/local/share/emacs/30.1/lisp/org/ol-irc /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox-texinfo hides /usr/local/share/emacs/30.1/lisp/org/ox-texinfo /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-ref hides /usr/local/share/emacs/30.1/lisp/org/ob-ref /home/mwillcock/.emacs.d/elpa/org-9.7.24/oc-natbib hides /usr/local/share/emacs/30.1/lisp/org/oc-natbib /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox-beamer hides /usr/local/share/emacs/30.1/lisp/org/ox-beamer /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-w3m hides /usr/local/share/emacs/30.1/lisp/org/ol-w3m /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-agenda hides /usr/local/share/emacs/30.1/lisp/org/org-agenda /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-duration hides /usr/local/share/emacs/30.1/lisp/org/org-duration /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-octave hides /usr/local/share/emacs/30.1/lisp/org/ob-octave /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-matlab hides /usr/local/share/emacs/30.1/lisp/org/ob-matlab /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox-org hides /usr/local/share/emacs/30.1/lisp/org/ox-org /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-goto hides /usr/local/share/emacs/30.1/lisp/org/org-goto /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-plantuml hides /usr/local/share/emacs/30.1/lisp/org/ob-plantuml /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-eshell hides /usr/local/share/emacs/30.1/lisp/org/ol-eshell /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-maxima hides /usr/local/share/emacs/30.1/lisp/org/ob-maxima /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-inlinetask hides /usr/local/share/emacs/30.1/lisp/org/org-inlinetask /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox-publish hides /usr/local/share/emacs/30.1/lisp/org/ox-publish /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-num hides /usr/local/share/emacs/30.1/lisp/org/org-num /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-R hides /usr/local/share/emacs/30.1/lisp/org/ob-R /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-lilypond hides /usr/local/share/emacs/30.1/lisp/org/ob-lilypond /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-archive hides /usr/local/share/emacs/30.1/lisp/org/org-archive /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-info hides /usr/local/share/emacs/30.1/lisp/org/ol-info /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-sqlite hides /usr/local/share/emacs/30.1/lisp/org/ob-sqlite /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-docview hides /usr/local/share/emacs/30.1/lisp/org/ol-docview /home/mwillcock/.emacs.d/elpa/org-9.7.24/ox-html hides /usr/local/share/emacs/30.1/lisp/org/ox-html /home/mwillcock/.emacs.d/elpa/org-9.7.24/ol-mhe hides /usr/local/share/emacs/30.1/lisp/org/ol-mhe /home/mwillcock/.emacs.d/elpa/org-9.7.24/org-list hides /usr/local/share/emacs/30.1/lisp/org/org-list /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-groovy hides /usr/local/share/emacs/30.1/lisp/org/ob-groovy /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-exp hides /usr/local/share/emacs/30.1/lisp/org/ob-exp /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-calc hides /usr/local/share/emacs/30.1/lisp/org/ob-calc /home/mwillcock/.emacs.d/elpa/org-9.7.24/ob-scheme hides /usr/local/share/emacs/30.1/lisp/org/ob-scheme Features: (shadow sort ecomplete mail-extr gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range gnus-win gnus nnheader range emacsbug switchmail message yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils view compile text-property-search comp-run comp-common flyspell ispell goto-addr thingatpt init which-key visual-wrap time vc-git diff-mode track-changes vc-dispatcher shadowfile savehist repeat tramp-cache time-stamp tramp-sh tramp rx trampver tramp-integration files-x tramp-message tramp-compat xdg shell pcomplete comint ansi-osc ring parse-time iso8601 time-date format-spec ansi-color tramp-loaddefs recentf tree-widget wid-edit minibuf-eldef mb-depth midnight ido hl-line editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch display-fill-column-indicator devil use-package-diminish corfu compat modus-vivendi-theme modus-themes find-func edmacro kmacro pcase use-package-bind-key bind-key easy-mmode diminish cl-extra help-mode use-package-core ags-mode-autoloads corfu-autoloads devil-autoloads diminish-autoloads eglot-autoloads flymake-ansible-lint-autoloads indent-bars-autoloads inform-mode-autoloads jabber-autoloads fsm-autoloads kixtart-mode-autoloads lua-mode-autoloads markdown-mode-autoloads modus-themes-autoloads org-autoloads org-msg-autoloads htmlize-autoloads package-lint-autoloads php-mode-autoloads plantuml-mode-autoloads dash-autoloads powershell-autoloads python-autoloads rainbow-mode-autoloads renpy-autoloads info sly-autoloads srv-autoloads switchmail-autoloads wgrep-autoloads yaml-mode-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 313937 18266) (symbols 48 21736 0) (strings 32 67688 5193) (string-bytes 1 2162533) (vectors 16 30109) (vector-slots 8 378100 10177) (floats 8 357 2) (intervals 56 3317 6) (buffers 992 16)) From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 12 08:50:15 2025 Received: (at 76955) by debbugs.gnu.org; 12 Mar 2025 12:50:15 +0000 Received: from localhost ([127.0.0.1]:47798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsLXL-0005QL-4f for submit@debbugs.gnu.org; Wed, 12 Mar 2025 08:50:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54964) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsLXI-0005Po-8e for 76955@debbugs.gnu.org; Wed, 12 Mar 2025 08:50:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tsLXC-00057u-19; Wed, 12 Mar 2025 08:50:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=x7eCU/qvjQ6B7kn05pG8/nimmA2L3+PzXIeBwXt4tfQ=; b=RpCOH9yS+qxS pVu1lM2J5qZowXC5pA6/vSqla7BnvXXKphPk5xz9NJYEkUITavn2JdIynbDZOqs/TRa91RQan1JbN sGpSH280/Ti40eF56aKY3ic06S2veg+tGJDJj5Lw/5bm4f13RBmQbuKywSitqCiwK84Zl9roH8FBw b/glGeiX4cX6hJsnx/Qdyk/jOWD9WMXD2zoeMMsRm01doI+EaVLWjq/q8QEL7VitckN+yskVLgbLw hEHyqLU6QAcZirGO1eKMf4OMmD2zQphqMv89e4iiKZIJKJ7a+v/wJmLWm+MyOixmT2Q1M5g/HhfGP utXq4SU7UfK5CQBF1oJ8tA==; Date: Wed, 12 Mar 2025 14:50:03 +0200 Message-Id: <86ikoe76ro.fsf@gnu.org> From: Eli Zaretskii To: Morgan Willcock In-Reply-To: <87frjj2uta.fsf@ice9.digital> (message from Morgan Willcock on Tue, 11 Mar 2025 20:09:37 +0000) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Vincenzo Pupillo > From: Morgan Willcock > Date: Tue, 11 Mar 2025 20:09:37 +0000 > > > > The default value of php-ts-mode-php-executable is determined by > searching for a php binary locally, but the found path may not work for > TRAMP connections to a remote system: > > (defcustom php-ts-mode-php-executable (or (executable-find "php") "/usr/bin/php") > > Would it not be more portable to just set the executable path to "php" > and then let a binary named "php" be located both locally and remotely? Does it help to use this instead: (defcustom php-ts-mode-php-executable (or (executable-find "php" t) "/usr/bin/php") From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 12 14:25:26 2025 Received: (at 76955) by debbugs.gnu.org; 12 Mar 2025 18:25:26 +0000 Received: from localhost ([127.0.0.1]:51631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsQli-0005C6-08 for submit@debbugs.gnu.org; Wed, 12 Mar 2025 14:25:26 -0400 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]:59275) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsQlg-0005Bq-9a for 76955@debbugs.gnu.org; Wed, 12 Mar 2025 14:25:24 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 1D8A744341; Wed, 12 Mar 2025 18:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1741803917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4M6+5SJJFJX3IVdQYnxasHx3hnFNniHWM+sQcdoUdyI=; b=b1qomnwSMnO595Cplts6zQN8UsXMRcciCJEcpahkSpvDAfCvses8rprJ7zR3YM9eSn4F4V wbrYhhMtVT8BTsYJo0KMUyBcpwN0VNEgrnrV9NffyWzSgB3r00k6wLC0NCGgxRc0N/dr/f C8KgwZRcyrT9mCd2mE9AEzKY123QElqmu5stQlSiEOhzQHXeauJGaFe6vkM+FVpty8V5S3 fhpNhSmgnZG+7riSX+sEZtwx8j2Frc2KyNZZREL7jGV94zdlTS6wq/wjO6GEM43A0FsZHr kvDOMHvwkSOxUwzmVgTZgV+tE+GW0angWa8jJSZsz05g8MBjYT8ZH4Hz9hyTCg== From: Morgan Willcock To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <86ikoe76ro.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 Mar 2025 14:50:03 +0200") References: <87frjj2uta.fsf@ice9.digital> <86ikoe76ro.fsf@gnu.org> Date: Wed, 12 Mar 2025 18:25:16 +0000 Message-ID: <87ikoe9kdv.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdehjeekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefoohhrghgrnhcuhghilhhltghotghkuceomhhorhhgrghnsehitggvledrughighhithgrlheqnecuggftrfgrthhtvghrnhepueduvdeguefgvdeuudekleejhfethfekgeefveejffdvheffkeduvddugefgjeeinecukfhppeektddrgeegrddvfedtrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeektddrgeegrddvfedtrdekvddphhgvlhhopehmrggtmhhinhhirdhnohhtlhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmohhrghgrnhesihgtvgelrdguihhgihhtrghlpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepvhdrphhuphhilhhlohesghhmrghilhdrtghomhdprhgtphhtthhopeejieelheehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Does it help to use this instead: > > (defcustom php-ts-mode-php-executable > (or (executable-find "php" t) "/usr/bin/php") I don't think that would help. If the package is loaded while default-directory is local the value would be wrong on the remote system. If the package is loaded while default-directory is remote the value would be wrong on the local system. Neither the local or remote path is "/usr/bin/php". I was surprised that the default value was not "php". Is there some benefit in searching for the executable so early? -- Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 12 15:15:02 2025 Received: (at 76955) by debbugs.gnu.org; 12 Mar 2025 19:15:02 +0000 Received: from localhost ([127.0.0.1]:51730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsRXh-0007VN-UK for submit@debbugs.gnu.org; Wed, 12 Mar 2025 15:15:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37232) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsRXg-0007Uy-CY for 76955@debbugs.gnu.org; Wed, 12 Mar 2025 15:15:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tsRXZ-0000fd-VJ; Wed, 12 Mar 2025 15:14:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=prq2gUYSOznV0zq6onpAbSfxnSkDS6wAW0OKSbpY/sI=; b=EHT5rJuHF3DM 3G1VZHR0vpYEyVZSlOQVsmpqxAyI+mmn1Pox/en/9gl2iguHxjOHki6bCHc/0R5JYgU/Y20qN+U/B 0JHIOxvShLA8QLOA/ZIcBMNe4DXpWGYwhrGEskh0hM/CK1eWZA8/rrFHvLjozuBEka3Hzl7IeW4Rj 4zDk/XNIYk2S7aZpyWd0Nyv+sYm4syP5b5+lwD40qvblNUlglq847t/9rBRVFR65TsP6y8uWRo7VX 0CLt3I8VaXy96ACTaBcjfvu1eXRkIvfTdXpcjKFy2Ftf4wSFdJdEKFhmIJYwk8LUM5h5BU6EwcY3T 3s600Vh+Jj7USwsbb9lqpg==; Date: Wed, 12 Mar 2025 21:14:50 +0200 Message-Id: <86r0323vth.fsf@gnu.org> From: Eli Zaretskii To: Morgan Willcock In-Reply-To: <87ikoe9kdv.fsf@ice9.digital> (message from Morgan Willcock on Wed, 12 Mar 2025 18:25:16 +0000) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <86ikoe76ro.fsf@gnu.org> <87ikoe9kdv.fsf@ice9.digital> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Willcock > Cc: 76955@debbugs.gnu.org, v.pupillo@gmail.com > Date: Wed, 12 Mar 2025 18:25:16 +0000 > > Eli Zaretskii writes: > > > Does it help to use this instead: > > > > (defcustom php-ts-mode-php-executable > > (or (executable-find "php" t) "/usr/bin/php") > > I don't think that would help. > > If the package is loaded while default-directory is local the value > would be wrong on the remote system. So what is your scenario that it requires to have a php executable on the remote host? Can you describe your use case in detail? > I was surprised that the default value was not "php". Is there some > benefit in searching for the executable so early? Who said it must be on PATH? From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 12 15:47:47 2025 Received: (at 76955) by debbugs.gnu.org; 12 Mar 2025 19:47:47 +0000 Received: from localhost ([127.0.0.1]:51806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsS3P-0003l0-1Z for submit@debbugs.gnu.org; Wed, 12 Mar 2025 15:47:47 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:58215) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsS3L-0003kg-Gy for 76955@debbugs.gnu.org; Wed, 12 Mar 2025 15:47:45 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id B4645442D3; Wed, 12 Mar 2025 19:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1741808856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nTB41JYMb3O55KP7eaQ1/7NvOyJBK6pANR0CfTYHIGM=; b=nhdbaZtwZ1bFOyiYA321nsTM7IzjE1SyjMHDF8WcxJBatfo9R4NicKOmLPzyAW/FOTTB9X qYosiGgcOrfdkPCmwqgTzKFiMuBQ1xO/pgZsuGIHxJqJ7BMNorzuxpWVIQ2Zd6g1DGQhet ajKu2pviGfpNStVV7g+mn6rpwV8tc0cxnHo4FzyS5PyEWvUqSe/DTBkZLaCUM8vQb5zGA9 YiMdTahmf+3QRXakPWepTPFcn3N+t5+50i3v1ND8SY2u5lMJ5BRzLYFEB/tf0nQGbWYnVf BWqNaCVzEDQP5G4dnPy9ahS2wqmF1srOsszhnL8kzeHqYa1iRiLn4C8MkMxW8g== From: Morgan Willcock To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <86r0323vth.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 Mar 2025 21:14:50 +0200") References: <87frjj2uta.fsf@ice9.digital> <86ikoe76ro.fsf@gnu.org> <87ikoe9kdv.fsf@ice9.digital> <86r0323vth.fsf@gnu.org> Date: Wed, 12 Mar 2025 19:47:34 +0000 Message-ID: <874izyyqsp.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdehleehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefoohhrghgrnhcuhghilhhltghotghkuceomhhorhhgrghnsehitggvledrughighhithgrlheqnecuggftrfgrthhtvghrnhepueduvdeguefgvdeuudekleejhfethfekgeefveejffdvheffkeduvddugefgjeeinecukfhppeektddrgeegrddvfedtrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeektddrgeegrddvfedtrdekvddphhgvlhhopehmrggtmhhinhhirdhnohhtlhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmohhrghgrnhesihgtvgelrdguihhgihhtrghlpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepvhdrphhuphhilhhlohesghhmrghilhdrtghomhdprhgtphhtthhopeejieelheehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Morgan Willcock >> Cc: 76955@debbugs.gnu.org, v.pupillo@gmail.com >> Date: Wed, 12 Mar 2025 18:25:16 +0000 >> >> Eli Zaretskii writes: >> >> > Does it help to use this instead: >> > >> > (defcustom php-ts-mode-php-executable >> > (or (executable-find "php" t) "/usr/bin/php") >> >> I don't think that would help. >> >> If the package is loaded while default-directory is local the value >> would be wrong on the remote system. > > So what is your scenario that it requires to have a php executable on > the remote host? Can you describe your use case in detail? I am not doing anything complicated, just using the same major mode both locally and remotely. The local binary (on PATH) is "c:/Users/mwillcock/scoop/shims/php.exe". The remote binary (on PATH, but if it wasn't I imagine I could get it on PATH using connection-local-set-profiles - I am already doing that for an LSP server binary) is "/usr/pkg/bin/php". >> I was surprised that the default value was not "php". Is there some >> benefit in searching for the executable so early? > > Who said it must be on PATH? I think it is more likely to be on PATH than not, and if "/usr/bin/php" does exist I think that is also likely to be on PATH anyway. -- Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 00:30:05 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 04:30:05 +0000 Received: from localhost ([127.0.0.1]:52706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsaCq-0000yt-I6 for submit@debbugs.gnu.org; Thu, 13 Mar 2025 00:30:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52342) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsaCm-0000xa-Ua for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 00:30:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tsaCg-000568-RA; Thu, 13 Mar 2025 00:29:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=t/ySYt7huJ95gCCH32Ofv4XDvVfyRJi0h36EZhjMmno=; b=ofGr72EVyf7/ 9Hk57g39rtCfD3YXqitskYrUF5kSsLMq1jpq7JLaAoHCIi9MqNrCCe8u0c/y6DNlNEBF0FYVxVrWD dzMR/8QsMIgS01GROapevzp1j2kcuyV59bgWbu6oYm8jeBh1GEjg+KJdXxq7TlY8jwYAwDHIVJ4wl ZWP4JOVZnhGZWcEIRBtI38APDse+Q1szQDNDUDZ5FLUbvA5CDbXpkJsFcsg7R3PWUWFo7H4AJt+1R It9fDH2PdQ086Hgj58MVA9nlcvdzPcfxhLqH6MOtH3M0bHBwzxYrDgcFlDMRp02b3jSYURU4Ocu/x R6KyM1GZR7mP/XLgd6u1UA==; Date: Thu, 13 Mar 2025 06:29:51 +0200 Message-Id: <86o6y54kow.fsf@gnu.org> From: Eli Zaretskii To: Morgan Willcock In-Reply-To: <874izyyqsp.fsf@ice9.digital> (message from Morgan Willcock on Wed, 12 Mar 2025 19:47:34 +0000) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <86ikoe76ro.fsf@gnu.org> <87ikoe9kdv.fsf@ice9.digital> <86r0323vth.fsf@gnu.org> <874izyyqsp.fsf@ice9.digital> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Willcock > Cc: 76955@debbugs.gnu.org, v.pupillo@gmail.com > Date: Wed, 12 Mar 2025 19:47:34 +0000 > > Eli Zaretskii writes: > > >> From: Morgan Willcock > >> Cc: 76955@debbugs.gnu.org, v.pupillo@gmail.com > >> Date: Wed, 12 Mar 2025 18:25:16 +0000 > >> > >> Eli Zaretskii writes: > >> > >> > Does it help to use this instead: > >> > > >> > (defcustom php-ts-mode-php-executable > >> > (or (executable-find "php" t) "/usr/bin/php") > >> > >> I don't think that would help. > >> > >> If the package is loaded while default-directory is local the value > >> would be wrong on the remote system. > > > > So what is your scenario that it requires to have a php executable on > > the remote host? Can you describe your use case in detail? > > I am not doing anything complicated, just using the same major mode both > locally and remotely. > > The local binary (on PATH) is "c:/Users/mwillcock/scoop/shims/php.exe". > > The remote binary (on PATH, but if it wasn't I imagine I could get it on > PATH using connection-local-set-profiles - I am already doing that for > an LSP server binary) is "/usr/pkg/bin/php". What is the binary used for in this mode, and why can't whatever is done with it be always done locally? I'm asking because I don't use this mode and don't know why the executable is needed by it. > >> I was surprised that the default value was not "php". Is there some > >> benefit in searching for the executable so early? > > > > Who said it must be on PATH? > > I think it is more likely to be on PATH than not, and if "/usr/bin/php" > does exist I think that is also likely to be on PATH anyway. The defcustom exists so that you could customize it to anything, and exec-path is not identical to PATH. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 03:35:17 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 07:35:18 +0000 Received: from localhost ([127.0.0.1]:53273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsd65-00026U-KV for submit@debbugs.gnu.org; Thu, 13 Mar 2025 03:35:17 -0400 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:45566) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tsd62-00024q-Jf for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 03:35:15 -0400 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5e5e63162a0so918411a12.3 for <76955@debbugs.gnu.org>; Thu, 13 Mar 2025 00:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741851308; x=1742456108; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=ZiSsJCZEeYDgoVMRDwuvEb94F+Ljf9D7HCUsaI6lQSQ=; b=OENX6cWspq7DrxbosJQ3cpCP2HXFa91coLLQ5bpq4wHaMmzU4K4Mh50dNyl8eDvC9J 3bMUIvcIDkUGyvoSou+7s3XRI46BTX7lQaS5QLEGmGZ5zicNoggJnDedS7ctqscddQ3x c0fLy/cjYNi9AmwnyvpdcYRbClECnstHgAWPvX6FS0oa9lR9zGQqc0GVw22Yd0ZWJlRY c9cbfXt3GR+tTFAnriv3aYzXx3hOi332qljDWGKUQJY3z4nMp0SGpplwR2Km3Rsm8AcF rnS9AfYRMzjf1b1NL/+wUzvqtCQWGqFH5JDLJ5VDJ0atmO56ORy96CKU5u0qpBMGKrSz lnIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741851308; x=1742456108; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZiSsJCZEeYDgoVMRDwuvEb94F+Ljf9D7HCUsaI6lQSQ=; b=i8EekcMdrM0Cnrr/2nCgomFGk2oNUxhr0dRbESk6E1pIWmlbrajs19oMYebrauvw0v sRwtXDMCc239CK14m/oSP7PL3pfYjZ0Aneo1ODeeR1p5JiunMIgkfYHC7d/78zJEI2/o 3u9l6BPwi+gAXbMQkUcjT47x+rZNG1N04hUi7DUvYD04zcM0Y3yXY4J+3u55egYaUS5P AXY95iKaSeYCa3JZQ/StmNz5mPvetBoaG+vG/tTDf9d8gGozq6sAgGuyWOuj7gs4Mq6Y TEeKIwxCYdhegS0OSBOMxACmZyXXMzE0WDtxqJ4QJJeMG1ZefZ4BRGc20f9DeSIh1caz +9YA== X-Forwarded-Encrypted: i=1; AJvYcCVe6UFPeR44/U0pwziLBe07Y2Azim341B9nTUmEhypZOkrIfOvlz6rlHgNBmCP03uqeFd+mMQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywl1cU6ya7oIjMBsNWVsgz7TBkRWGOTiEa/pfrNvmMXEJIZwTlS j9XTNfKKqwkNYNKfH6o3QIyQzDEsRvWFjb2Lh3eu6skOykP/siAaXPKDysR1B/cNzJCCIlQHt0e ZTh709PKW1bH3uYEwdRXGUg+QvsXhQlTC X-Gm-Gg: ASbGnct+I3L1NdIqe5JLsUcrHwqHa2v2l5cd/zfkRL1UNvi6YKIY68C43MFXM0LYnRK kYfP9fzn/4eITinMqzXkXuw6Z5e0ZRmuQNZGci3UreSW4JI5MLYdRmcI1JJ+z9n6MOrd/8Gd2My VyxaCkKM3er1c8/gpe3z9RH4eCUw== X-Google-Smtp-Source: AGHT+IHILeiK7hZgsVKo5t+BheUCwfLEVQ5l2Z8X5TDgzWH0nmf4i55vDiKEIx0sCERTHLCrIcl0WLYbTMePBHJpg/Y= X-Received: by 2002:a05:6402:280f:b0:5e5:35d1:87d with SMTP id 4fb4d7f45d1cf-5e75f5a34cfmr15113057a12.20.1741851307965; Thu, 13 Mar 2025 00:35:07 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Mar 2025 00:35:06 -0700 From: Stefan Kangas In-Reply-To: <87frjj2uta.fsf@ice9.digital> References: <87frjj2uta.fsf@ice9.digital> MIME-Version: 1.0 Date: Thu, 13 Mar 2025 00:35:06 -0700 X-Gm-Features: AQ5f1Jo9qjhwP-08gEv-Tf4teylxo_qbscr34mxxYeMLrf5jwpv2mRaDYRxGScM Message-ID: Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path To: Morgan Willcock , 76955@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: Vincenzo Pupillo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Morgan Willcock writes: > (defcustom php-ts-mode-php-executable (or (executable-find "php") "/usr/bin/php") BTW, shouldn't this be called `php-ts-mode-php-command'? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 03:57:17 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 07:57:17 +0000 Received: from localhost ([127.0.0.1]:53358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsdRN-00037b-2c for submit@debbugs.gnu.org; Thu, 13 Mar 2025 03:57:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36542) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsdRL-00037O-4e for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 03:57:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tsdRE-00077q-EG; Thu, 13 Mar 2025 03:57:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yuV2mqKspHL7/pgxUe4b3MlRBXLfFHCNw9ymm8fVphg=; b=SmDM52UL5OCU bKGds353pungdXorSPjfxJDJbqsu8th9fhnZmA73B2pDhNZl5Q/xOYO7LJDbSZZ0Xcxmh3WjKdqVt 7MDeorM0LPELnwqUmzqmClHhPReQy0ISdP61cWLbxm1EC23APouZYbPz086tnLfd5L5mgfpG0WEnA sBv4Z/9sCypNabCQ/XxotptzC1gBB0ri0MGMQ2xqjzqv0zts7gDKHneqs1/WicgpFRJWhIxOZjXME pNx3JWaqiewFHc5TCud0q1mdkH5WUt8+vvOBqbvO80onxopS6/dh+3+gEbRCWpWafEESQpoxEIIkH DcapbWEFkN+ze5fh6w8OWw==; Date: Thu, 13 Mar 2025 09:57:05 +0200 Message-Id: <8634fh4b3i.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Thu, 13 Mar 2025 00:35:06 -0700) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Vincenzo Pupillo > From: Stefan Kangas > Date: Thu, 13 Mar 2025 00:35:06 -0700 > > Morgan Willcock writes: > > > (defcustom php-ts-mode-php-executable (or (executable-find "php") "/usr/bin/php") > > BTW, shouldn't this be called `php-ts-mode-php-command'? We are splitting hair, but "command" could be a shell command", whereas "executable" generally means a file name. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 04:01:00 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 08:01:00 +0000 Received: from localhost ([127.0.0.1]:53377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsdUy-0003Lk-7L for submit@debbugs.gnu.org; Thu, 13 Mar 2025 04:01:00 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:45466) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tsdUu-0003LU-KZ for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 04:00:57 -0400 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5e5e63162a0so948324a12.3 for <76955@debbugs.gnu.org>; Thu, 13 Mar 2025 01:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741852850; x=1742457650; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=tG6UqZsufyruinposYYRdg6OKs0xxroq2BtpgWHvyDM=; b=kMlzZaozjwMTVA6XB2c1D721f8S+bdS9wsOJ0RNfGSBNnMTDl8ZTmUR3YJS3vmmtjs FFJ8oLrIrVtThPIVrzbNp35qlQWrLL+vBDUhrngKmICw11jUEyK1ehesjuRR1IBzG30D GyDjPu6yq/9uGc42Egd41z7gpmcWL5Bdc/LcHKz3xExfKtfR4+gej4rJVnX21PppdFDG XRotYU0fIMefFX1C0TTkuDZhkVY4vHjrhq0ESV7Dsm/zmpK0IS13xl3VadfqbPBSggqy kcL/q/1eKgHTE9BDBgrnrJuyjuIq/hL4UJrX1vgmCDS5KR75f7zwSbf3zkGBQt7JrIdU 9bzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741852850; x=1742457650; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tG6UqZsufyruinposYYRdg6OKs0xxroq2BtpgWHvyDM=; b=iluZSBAHwlFOHGZ8lENpvF1P/+63NNYAUDrrTPnCxdDTG5OJ8rT8QsIGK5bMORUxV6 EfUHVKLo3iUlOUwfM07E/rgs7Y//XysDFNrjVi56uVP+2G6aFlA6eGbELaixVCfDR+wS I16LD/Uez90cFMivUJEoNaaVFhxlRO38qt7zmsmFVCgdmFhNs+KbpRzV6Tg3UGZGm3av ctjJ8LS+rsB+R4lns8QnlhS0cL7K6nfuUvdNdyE95nYMAYjFlLPboLljaVvls9oMvuP1 hUNMw4A1iulbNXgIlPXOFWvt0c5pPMlImQNkDTXPYxsANifEPfVYdvBkJ1h7g1epQwB1 VpSg== X-Forwarded-Encrypted: i=1; AJvYcCUlpGpfTnrQNQkCQVo6T2hxGSRXfx9EenO9zZPzLxi6YX59F/s0/JSVanGZps4j3QPLzwTgAw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxHfKLvScIFVIyBQcolTwjQWuOJyLQLDaY8pEtFpgKyKsHF5gRw 4QE8RUK+hRPJgIowP+A5TjPFVBSW12HzjxwYSiBUhVDFnNMxblSinyg8VESgZyYvadIGlByEkFr RVr3R0CDAVOKl42sAH2RchFVZT18= X-Gm-Gg: ASbGncuQkDulv9i+IHjyVYuiPxMK/HgK+uqii2s44BXtN7A08YRhtTq5sWXwMffFaHq hmXcOQ+WB9clTM/FgtXRsqdKX2WPuvMVQ9O5/HTtxf+rzKrfU8BAa9B1gApkglLeBePSw6dGWrk SKwax4myEWQcJFlj4Ph1W1ImUaUQ== X-Google-Smtp-Source: AGHT+IGXxcyQa12K4onYtmgItOlVWvp1MCLzAUcpaaqaGYQl2jAZA6lQvc6cJilzQF0+QzRDPEHlQzgVhyRkzwxyJ3A= X-Received: by 2002:a05:6402:234a:b0:5e7:c773:ae35 with SMTP id 4fb4d7f45d1cf-5e7c773aff6mr4860852a12.5.1741852849961; Thu, 13 Mar 2025 01:00:49 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Mar 2025 01:00:48 -0700 From: Stefan Kangas In-Reply-To: <8634fh4b3i.fsf@gnu.org> References: <87frjj2uta.fsf@ice9.digital> <8634fh4b3i.fsf@gnu.org> MIME-Version: 1.0 Date: Thu, 13 Mar 2025 01:00:48 -0700 X-Gm-Features: AQ5f1JomRbOxgxBLaOe6rACY14qC1-CUeeOTTdvFXlZNZKD0WUSEpIAmnQEnOGg Message-ID: Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Cc: Vincenzo Pupillo >> From: Stefan Kangas >> Date: Thu, 13 Mar 2025 00:35:06 -0700 >> >> Morgan Willcock writes: >> >> > (defcustom php-ts-mode-php-executable (or (executable-find "php") "/usr/bin/php") >> >> BTW, shouldn't this be called `php-ts-mode-php-command'? > > We are splitting hair, but "command" could be a shell command", > whereas "executable" generally means a file name. It's mostly for consistency; I find few hits for -executable$ but many for -command$ in our tree. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 06:17:22 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 10:17:22 +0000 Received: from localhost ([127.0.0.1]:53838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsfcv-0004QB-JU for submit@debbugs.gnu.org; Thu, 13 Mar 2025 06:17:21 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:54408) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tsfcs-0004Py-Pl for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 06:17:19 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-39133f709f5so458461f8f.0 for <76955@debbugs.gnu.org>; Thu, 13 Mar 2025 03:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741861032; x=1742465832; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7Le0lnv67ejAXqLCeivJV58dpmUH8wUY1YXPak+dimU=; b=IxnXyaUFMTgHFOjWlRHWsJimUgeqS9x86+k3yqRrtnldW1Rs8ONgXjI2BMEc/O/JSN bFGUeO98K7aJhkH1emhxDcP7dCZCMry2VKtZXHn57kj1WGw/4x4m2qibeMBe3hhP4ONP Kg+b795Ll7dkaUAfGN1ymWsKX78yYeDz1b4fKMFbiJ4k2Nq1Uc23UvCvMTgI8Tbszowb zZjKOroN2K2n2WTL02SSo601aTraLFgvEI/48rFszYuMoVLyIcCM+jxpdo7yIMl8eiXs rgRORt9ZrPJFee5w2ipNaP92n0Go1m2LVEnmKLCydLp/an/nvV7DHlQtOtvcycLW4B4y Jwig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741861032; x=1742465832; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7Le0lnv67ejAXqLCeivJV58dpmUH8wUY1YXPak+dimU=; b=XoL5sgtTeL6R6TCNrjw+iI9IrbvmqEGJo0eEOHlewh4cKxqtIMgnhOHNNWXCw/nOwR wOJIVoDjsZTl4F2i1KVf4EuuDGuHRwVCxF1RFipOcTsLeZMm+gneqj/LcOOZ31zD5IW9 UY2julfygALlqbVmRkLUfPEzia78Ow4f5wugrpwFSpmH36dt6PA8/wyrFojjTUWsj5qq jw76eh0ZuqdkgdgFxFfoRR1j+GVUoz3e19AP06pQPMzWKqaMJ+m1EKDvF/wW+lHtLdAb fQ848OCV5FXnfhkjfhV45D0RTHQs4P4/h4tbj26KxhiDXXkvxYy6DDHfeD555adfJ3xY AhqQ== X-Gm-Message-State: AOJu0YzwFlFcuQwdvI0KlbVbjqziJevy9LB7idAojFc/cNe7N/xJ2GsC UO+Bb/XFa0n/hDmJBy6qTKvwY9MQw7OmK1fm/NULtGl2K05QVIc9 X-Gm-Gg: ASbGncsS7O6pypA3qZwQisrQVh7gUJnHGO2YYZoWGRcNWwALcowHpgCcZrMe8SjNbos 0vCyQYYtselW0S3EsGmn1g1jmTU7fwdd99zkcxLpNRoXmkIWpExjS211KJIj4TunmNi/PUucFOn OrOU5nSA/MM1s7ZfttFGqxtU8ITI0ioVt6wWHjsIcGex6ORRn7LJZJEeJQJxjyk5y80c48ldtjb sLDUmAqcI+XVhyENAJTs2F0RoTqke5vOqXbKwUBoVd4DCOeZXDST/X4lJuWRGcPIewtfBz1Ox5N FKiuVTvJ4vr/0Spj8eVVRUGEMsZ+dPuyPhHA4Amm70NGreLH51lMogr87qE2t++BQIaDRCnjCA= = X-Google-Smtp-Source: AGHT+IG8BK+Z3/qCCx4WXfNceLVyB2xhE+ohVAMKh3kOJpzaeFsvRDC0zivWUxeGHmuVbkARuogLeA== X-Received: by 2002:a05:6000:402a:b0:391:2c0c:126b with SMTP id ffacd0b85a97d-39132d531c3mr20420956f8f.23.1741861032382; Thu, 13 Mar 2025 03:17:12 -0700 (PDT) Received: from 3-191.divsi.unimi.it (3-191.divsi.unimi.it. [159.149.3.191]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c83b6b43sm1646196f8f.35.2025.03.13.03.17.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 03:17:12 -0700 (PDT) From: Vincenzo Pupillo To: Morgan Willcock , Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path Date: Thu, 13 Mar 2025 11:17:11 +0100 Message-ID: <3517098.LZWGnKmheA@3-191.divsi.unimi.it> In-Reply-To: <86o6y54kow.fsf@gnu.org> References: <87frjj2uta.fsf@ice9.digital> <874izyyqsp.fsf@ice9.digital> <86o6y54kow.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ciao, =20 'php-ts-mode-php-executable' it's used for 'php-ts-mode-flymake-php',=20 'run-php' and 'php-ts-mode-run-php-webserver'. @Morgan: Will setting the executable path to "php" work in your scenario? Of the functions listed above, which one do you usually use? Thanks. Vincenzo In data gioved=C3=AC 13 marzo 2025 05:29:51 Ora standard dell=E2=80=99Europ= a centrale, Eli=20 Zaretskii ha scritto: > > From: Morgan Willcock > > Cc: 76955@debbugs.gnu.org, v.pupillo@gmail.com > > Date: Wed, 12 Mar 2025 19:47:34 +0000 > >=20 > > Eli Zaretskii writes: > > >> From: Morgan Willcock > > >> Cc: 76955@debbugs.gnu.org, v.pupillo@gmail.com > > >> Date: Wed, 12 Mar 2025 18:25:16 +0000 > > >>=20 > > >> Eli Zaretskii writes: > > >> > Does it help to use this instead: > > >> > (defcustom php-ts-mode-php-executable > > >> > =20 > > >> > (or (executable-find "php" t) "/usr/bin/php") > > >>=20 > > >> I don't think that would help. > > >>=20 > > >> If the package is loaded while default-directory is local the value > > >> would be wrong on the remote system. > > >=20 > > > So what is your scenario that it requires to have a php executable on > > > the remote host? Can you describe your use case in detail? > >=20 > > I am not doing anything complicated, just using the same major mode both > > locally and remotely. > >=20 > > The local binary (on PATH) is "c:/Users/mwillcock/scoop/shims/php.exe". > >=20 > > The remote binary (on PATH, but if it wasn't I imagine I could get it on > > PATH using connection-local-set-profiles - I am already doing that for > > an LSP server binary) is "/usr/pkg/bin/php". >=20 > What is the binary used for in this mode, and why can't whatever is > done with it be always done locally? I'm asking because I don't use > this mode and don't know why the executable is needed by it. >=20 > > >> I was surprised that the default value was not "php". Is there some > > >> benefit in searching for the executable so early? > > >=20 > > > Who said it must be on PATH? > >=20 > > I think it is more likely to be on PATH than not, and if "/usr/bin/php" > > does exist I think that is also likely to be on PATH anyway. >=20 > The defcustom exists so that you could customize it to anything, and > exec-path is not identical to PATH. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 07:26:18 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 11:26:18 +0000 Received: from localhost ([127.0.0.1]:53937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsghd-0007gq-RA for submit@debbugs.gnu.org; Thu, 13 Mar 2025 07:26:18 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:43299) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsghY-0007gU-Ge for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 07:26:15 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 82A9443233; Thu, 13 Mar 2025 11:26:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1741865164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FKVV8kEtKXJkBu8jvt3HZdIZ3TTAIv7MDQ1grZAEIYk=; b=UdGo0KXocJcXFXlp9Pc8kEe0OKKs6otIUf/XaBOz6VgraRKKLYJVIAGUig+4R9IfctIJlk 09EiruGkYJIQG038yJVPyjT6ts/KBM4+o7bAGy0UbVbNWY7jgrreNRAVQi6L0pLJu7a1A4 QtDqZSNljTuTFnLcxniG3PaKXjQi7uZYF7U/t5sPQ/G1s5x18ZOxwinKYOMAsz8+t+zLhU VFunOfnvidVY2d8l+isFYgBivtdN9zD5akaxoPlmm03h9o3Ksu6sg+sbkGDWMJHKZtdQnY TC6WmYzXDrljresXpdb5gA9t4VOgJ7dxRitaSAITjqN4yBzYzMIoniTbhAIBzQ== From: Morgan Willcock To: Vincenzo Pupillo Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <3517098.LZWGnKmheA@3-191.divsi.unimi.it> (Vincenzo Pupillo's message of "Thu, 13 Mar 2025 11:17:11 +0100") References: <87frjj2uta.fsf@ice9.digital> <874izyyqsp.fsf@ice9.digital> <86o6y54kow.fsf@gnu.org> <3517098.LZWGnKmheA@3-191.divsi.unimi.it> Date: Thu, 13 Mar 2025 11:26:03 +0000 Message-ID: <87a59pdvec.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdejkeefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefoohhrghgrnhcuhghilhhltghotghkuceomhhorhhgrghnsehitggvledrughighhithgrlheqnecuggftrfgrthhtvghrnhepueduvdeguefgvdeuudekleejhfethfekgeefveejffdvheffkeduvddugefgjeeinecukfhppeektddrgeegrddvfedtrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeektddrgeegrddvfedtrdekvddphhgvlhhopehmrggtmhhinhhirdhnohhtlhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmohhrghgrnhesihgtvgelrdguihhgihhtrghlpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepjeeileehheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehvrdhpuhhpihhllhhosehgmhgrihhlrdgtohhm X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: Eli Zaretskii , 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Vincenzo Pupillo writes: > 'php-ts-mode-php-executable' it's used for 'php-ts-mode-flymake-php', > 'run-php' and 'php-ts-mode-run-php-webserver'. It was calling run-php where I initially found the problem. > @Morgan: Will setting the executable path to "php" work in your scenario? > Of the functions listed above, which one do you usually use? Setting the value to "php" is how I use it, because that works everywhere I need it even though the local and remote setups have nothing in common. Just to be clear, the "bug" I am reporting here is that the current default value seems to assume that the local PHP setup will be identical to a remote PHP setup, and that falling back to using a full path like "/usr/bin/php" makes similar and platform specific assumptions. To work in more places without requiring customisation, I think the default value should be "php". I cannot see any benefit in calling executable-find to set the default value because this seems at odds with using the major mode with TRAMP connections. I see little benefit in "/usr/bin/php" as a default fallback value because it is very likely that the binary would have been automatically located in /usr/bin if that path exists. If someone could explain the reasoning behind how the default value is currently being set, and why that is better than just using the value "php", feel free to close this bug report. Thanks, Morgan -- Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 09:56:51 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 13:56:51 +0000 Received: from localhost ([127.0.0.1]:57518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsj3K-0001qm-PK for submit@debbugs.gnu.org; Thu, 13 Mar 2025 09:56:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54306) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsj3H-0001qa-M0 for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 09:56:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tsj3A-0004VJ-Sn; Thu, 13 Mar 2025 09:56:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zLBCxhAsRyaiuzuHF6GO8uUH7n3D7dGPqHtnAmcONNY=; b=iXlqrJoMJeIb qWvynzZtsl0xwbFK8IbZpbuX0F1eMhCAh3xMJeqgFNdNhw4di81UVCFV38aiO4E6JI6Z0VLOdyYlf Yk3y3A1HPLPPh6AqBqbwPl989W9xaX1VJIhMvj0tZJyLxYe7LUCsM96FZdEh8je9h0JZvi/C3Er8R d8Hr7GIsispWHETTXjZzcLQLBS7Y4uhp5Yv32MtNS/kX/FbDAdifDyJsm9dejkC/BHFWR9j8zKW92 QkdV8OJEVgxwq3xhihtNQ/qQJTuzQlTWXmWYGNNxCeruL2fIjTMv4bCDN+phCPFCArW4xcyX0VOcr t1lgwsOozL44BptEJdgmlg==; Date: Thu, 13 Mar 2025 15:56:37 +0200 Message-Id: <86h63x2fvu.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Thu, 13 Mar 2025 01:00:48 -0700) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <8634fh4b3i.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Thu, 13 Mar 2025 01:00:48 -0700 > Cc: morgan@ice9.digital, 76955@debbugs.gnu.org, v.pupillo@gmail.com > > Eli Zaretskii writes: > > >> Cc: Vincenzo Pupillo > >> From: Stefan Kangas > >> Date: Thu, 13 Mar 2025 00:35:06 -0700 > >> > >> Morgan Willcock writes: > >> > >> > (defcustom php-ts-mode-php-executable (or (executable-find "php") "/usr/bin/php") > >> > >> BTW, shouldn't this be called `php-ts-mode-php-command'? > > > > We are splitting hair, but "command" could be a shell command", > > whereas "executable" generally means a file name. > > It's mostly for consistency; I find few hits for -executable$ but many > for -command$ in our tree. I think we use "command" for strings that are shell commands, and "program" for strings that are file names of program executables. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 10:07:52 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 14:07:52 +0000 Received: from localhost ([127.0.0.1]:57531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsjDz-0002KO-TQ for submit@debbugs.gnu.org; Thu, 13 Mar 2025 10:07:52 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:47117) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tsjDx-0002K6-Iy for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 10:07:50 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-43cf848528aso9158955e9.2 for <76955@debbugs.gnu.org>; Thu, 13 Mar 2025 07:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741874863; x=1742479663; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B/BPbj1NojEUbXcvcjwg6o0W6nWCvK2tqkch7yaXFOw=; b=aD7gHNtwpZGcPYoLRN/y3SGTxgDzR4pOCip4lU4/s1Xr8UgCPApYvnI3HCqqdRFCuq yxyZFIJYq+v+2KwzXne+03InCFtAFh0BoNSX/y7AXxp4GJN3A6++uCj7qA3uRhhGprbn DyaWhFSFlib+54vz1/zqlEb3v+HcsWY/XXED+RyvVxaKNwpIcANcrVJqO97jUBbESbE7 WiUCRIJtA+Oq3btCzXGQVSUV5MnCYHaJe3VDEud3tOgfGZ+nNQEbQMZV6Dswp0z4gGCg Fsq/m/RM1r/akX6DioJ8zZPeEO0mRRcPzxx8qI/uwI+9+6y9xG3aVPPbbGyBzDn1i3kV o4mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741874863; x=1742479663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B/BPbj1NojEUbXcvcjwg6o0W6nWCvK2tqkch7yaXFOw=; b=k/XCaWWP74gCmZWVkBIeqqGbYhThmvdXLh0cvtc8tEb5lp0/Qw1fnZGYJ2yFMXIVUu nYdFt1TOH1HBW+WFxyA6dVI/r+pn1hfDx9ttW2RPJm83FzWXncI/a6L/xIHuxP6NMyBo 9QzIiIhr8n5Dh2uewOz8e/1bdQfXvxTq4+r9ShMgeW7uBKE3/LwlFRoaRlAvuYvE9dgz X8Jub2ZsWe80CvSgHap0eMlzRRnsabpwDHD44yl/5TNlf5wC4CMQiNJpT+9hMZXtbeEW CU2z1FQd2QbJvcNJHmsiVdyOk8jdWkfNSN1vq9zNZPpOHCqM0VQHO5HepJuEKTAOr/HR 8M+g== X-Forwarded-Encrypted: i=1; AJvYcCVNNaAT/K7nYY0wN9M6W8rwWNiTvoc99RR0qAlWJRs54C+D5M+V3yv5mkX0s0lwqAXSyhr7tQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzMiEonj7VHYJS0FZjhh30TZ2Jm5MuEKCTiioqd1/yDJlq39N8E apsDUaZ9kHZvzM8g+svKMw3Zy0zgySXCToeCEzYYuOGANpP1kmu8 X-Gm-Gg: ASbGncutQti6nzz2MelmJ7qVnDrd6H4NI77YyjidNZvqQtCtm9nrigIXm9DqeWJXbUw udNPs1LWpaB41vnZ1Y2m0g1vl4tFtkD/pHVNLsyTgIxtOXDj0EHJuLpmySLEaeeyETCNpaDsEln 0Qb6/86tmh1sfoKAd7OM6K2YySDgtCTgoMBkgGjeSYwaqIyTM57UqiNDd+KMSYoW8sgDQ/GgRni Xv6L5M5cc9MafovwUw77sO+YH47UoFE3g3a3xuBiXq2mg8enigIiu+ZCzb3wZ4OfknDKikKHZEu c1ByV/dllu3N6kXu8YTEHLULVGPt12dzsvETr/7ifv1PU6z5267GWoucA33DBBKQctUJf3ubMA= = X-Google-Smtp-Source: AGHT+IEruLhnwjwXtmu9/+3TZbo0z+5KgOcpgJtgC/kfUc0zPHRdNf3CGHOCf+gVWtbwpfpiZfZ3bA== X-Received: by 2002:a05:600c:198e:b0:43b:ce08:c382 with SMTP id 5b1f17b1804b1-43d01be6dfbmr129998685e9.16.1741874862969; Thu, 13 Mar 2025 07:07:42 -0700 (PDT) Received: from 3-191.divsi.unimi.it (3-191.divsi.unimi.it. [159.149.3.191]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d19541339sm18356485e9.21.2025.03.13.07.07.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 07:07:42 -0700 (PDT) From: Vincenzo Pupillo To: Morgan Willcock Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path Date: Thu, 13 Mar 2025 15:07:41 +0100 Message-ID: <7174905.9J7NaK4W3v@3-191.divsi.unimi.it> In-Reply-To: <87a59pdvec.fsf@ice9.digital> References: <87frjj2uta.fsf@ice9.digital> <3517098.LZWGnKmheA@3-191.divsi.unimi.it> <87a59pdvec.fsf@ice9.digital> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: Eli Zaretskii , 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) In data gioved=C3=AC 13 marzo 2025 12:26:03 Ora standard dell=E2=80=99Europ= a centrale,=20 Morgan Willcock ha scritto: > Vincenzo Pupillo writes: > > 'php-ts-mode-php-executable' it's used for 'php-ts-mode-flymake-php', > > 'run-php' and 'php-ts-mode-run-php-webserver'. >=20 > It was calling run-php where I initially found the problem. Ok. 'run-php' can be invoked with C-u M-x run-php and you can specify the p= ath=20 to php. Sometimes I am forced to use older versions of php, Remi's php=20 packages use a suffix to indicate the version, e.g. php54. >=20 > > @Morgan: Will setting the executable path to "php" work in your scenari= o? > > Of the functions listed above, which one do you usually use? >=20 > Setting the value to "php" is how I use it, because that works > everywhere I need it even though the local and remote setups have > nothing in common. >=20 > Just to be clear, the "bug" I am reporting here is that the current > default value seems to assume that the local PHP setup will be identical > to a remote PHP setup, and that falling back to using a full path like > "/usr/bin/php" makes similar and platform specific assumptions. >=20 > To work in more places without requiring customisation, I think the > default value should be "php". >=20 > I cannot see any benefit in calling executable-find to set the default > value because this seems at odds with using the major mode with TRAMP > connections. >=20 > I see little benefit in "/usr/bin/php" as a default fallback value > because it is very likely that the binary would have been automatically > located in /usr/bin if that path exists. >=20 > If someone could explain the reasoning behind how the default value is > currently being set, and why that is better than just using the value > "php", feel free to close this bug report. At first it was just 'php' then, since I don't know the details of how path= =20 resolution works on Windows or even Macs, I preferred to use 'executable- find'. as in python.el for example. So, since I have always used 'php-mode'= =20 and wanted users to feel "at home", I used exactly the same expression: '(o= r=20 (executable-find "php") "/usr/bin/php")'. Vincenzo >=20 > Thanks, > Morgan >=20 > -- > Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 10:26:09 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 14:26:09 +0000 Received: from localhost ([127.0.0.1]:57574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsjVh-0003Bs-58 for submit@debbugs.gnu.org; Thu, 13 Mar 2025 10:26:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39798) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsjVe-0003BK-2K for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 10:26:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tsjVX-0000ou-5V; Thu, 13 Mar 2025 10:25:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=E3YLq+0fQnOEh1yrX/gfN7XKsG2oAktTkyk1rSjoHqo=; b=FicpwWg7ptmT YjkrZDTgswj1vzXzM6VbWkhaoJPriGmswaZEcRjome5824Y6e9dhIeeygHezw69+IX7z4sA2xtx2w 3Z006YFiPE7KfpTH5fGs7LmDAA7Q28oOTrXb3OQM5s2PnkYA6solcGFaXLehvCOpdbsebiLjh5x+m LNPB4kZcoOOKILP1uJ5+Y0Vtd257O6hGz9sILqJ2cI5Kpfea+M9j1jnmQrox36vDf3vnNe/mQlVJk Vop8GBpKz5AWfc32Wd07NACw3y1FE3rL0t8R39Sm9DETuqQJXlrU0MdiH8DIC6Z9u7kzzwWp0uT7/ l5fm0VLJUEYGh6L7NMBL5Q==; Date: Thu, 13 Mar 2025 16:25:57 +0200 Message-Id: <867c4t2eiy.fsf@gnu.org> From: Eli Zaretskii To: Vincenzo Pupillo In-Reply-To: <3517098.LZWGnKmheA@3-191.divsi.unimi.it> (message from Vincenzo Pupillo on Thu, 13 Mar 2025 11:17:11 +0100) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <874izyyqsp.fsf@ice9.digital> <86o6y54kow.fsf@gnu.org> <3517098.LZWGnKmheA@3-191.divsi.unimi.it> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Vincenzo Pupillo > Cc: 76955@debbugs.gnu.org > Date: Thu, 13 Mar 2025 11:17:11 +0100 > > Ciao, > > 'php-ts-mode-php-executable' it's used for 'php-ts-mode-flymake-php', > 'run-php' and 'php-ts-mode-run-php-webserver'. Then please consider the solution proposed below. > @Morgan: Will setting the executable path to "php" work in your scenario? > Of the functions listed above, which one do you usually use? Customizing the value is an okay solution, but we are discussing how to solve this for users that don't customize. How about the following solution: . we replace references to php-ts-mode-php-executable with a call to a function . that function will do something like (let ((php-prog (if (file-remote-p default-directory) (executable-find "php" t) php-ts-mode-php-executable))) php-prog) WDYT? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 10:42:01 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 14:42:01 +0000 Received: from localhost ([127.0.0.1]:57622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsjl3-0003uW-5P for submit@debbugs.gnu.org; Thu, 13 Mar 2025 10:42:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37322) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsjl1-0003uG-3a for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 10:41:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tsjku-0003YR-7x; Thu, 13 Mar 2025 10:41:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EUuxZm+Rt2WO5gyFZP9gBr2uTmsE8inheoQgztsi7QQ=; b=FBaRHhJK9Gys tPRyLulfQcWVsMF5V6Phvhvmt+ys2FLLCNe1M+vunAc13KjQ9bbWpyQc6dKIbhJMy9vvK3V1XoFQa yorCpxAU5IpuNFNBAb3JadE+Ra6drm0MtYE990rUwKALJ4piQE9hUj7aOFvLMWtc3wEFXZ4HomGOE mGLrgPliJzETki6YViS+8HqHH365anjySEQSJwFPEeG4oPl0wOi1mwIR3os3qKDB/DahUU3/CaSW7 YFiywINwaEEEQzmFISDUu5RAryGKdgyjO/1iNWqbQVfxPAXxNiMSv2dawvKaw3fccEMk8b0g5IfL7 PeCVMOfa9SwzD6hmVNOZug==; Date: Thu, 13 Mar 2025 16:41:45 +0200 Message-Id: <861pv12dsm.fsf@gnu.org> From: Eli Zaretskii To: Morgan Willcock In-Reply-To: <87a59pdvec.fsf@ice9.digital> (message from Morgan Willcock on Thu, 13 Mar 2025 11:26:03 +0000) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <874izyyqsp.fsf@ice9.digital> <86o6y54kow.fsf@gnu.org> <3517098.LZWGnKmheA@3-191.divsi.unimi.it> <87a59pdvec.fsf@ice9.digital> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Willcock > Cc: Eli Zaretskii , 76955@debbugs.gnu.org > Date: Thu, 13 Mar 2025 11:26:03 +0000 > > I cannot see any benefit in calling executable-find to set the default > value because this seems at odds with using the major mode with TRAMP > connections. The main benefit is that invoking the program on local files will be faster. And I presume that most of these invocations are indeed on local files; remote files are much more rare. So speeding up the local case seems like a good optimization. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 12:28:52 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 16:28:52 +0000 Received: from localhost ([127.0.0.1]:57818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tslQS-0000mD-5v for submit@debbugs.gnu.org; Thu, 13 Mar 2025 12:28:52 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:47223) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tslQO-0000lt-Tk for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 12:28:50 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-43cf848528aso10944025e9.2 for <76955@debbugs.gnu.org>; Thu, 13 Mar 2025 09:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741883323; x=1742488123; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qaex04qvv4H9An/gOs/DMZoRPrD8bTQVmmWTHjTa6o4=; b=Fd1Tj2Ly15RkhRsloUBeNB56vLe1yTr1QjA55Rke1yREg9kZnTnrdzmW5nAVg7dmhb C1/5xSvD5yDTZJtyq4TeZIqGEoJ09JEqIIGSRhzQ4kMq/hSGuQdgNuL0aE7GRfeBiJdq v+o97EdzEKe+wkWmfpM9R5ckZo6lymNywnuik9dvBHtvglOrRn/Bck3dv6TluSxJv7L6 kCMz+6Bgc1zYh9SjjO46W2IsIpVqbRHlVpxQwy843lqxYE5EIA7ewCigeL7Gcj6kSVeJ OXYTTOYRaBSaNDPeBCkxCQefjSKpb3bZkVXV/6IuiJbqtH6FDRUB4L9j2GSz8W5Fesy+ F59g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741883323; x=1742488123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qaex04qvv4H9An/gOs/DMZoRPrD8bTQVmmWTHjTa6o4=; b=uZbeliH70QKUZkeYonNmsxoclIomssg1uZM59pd64nWkccicyRG+BCFNZU9dk6AP5E 3dS9v/AB+ZXyskLOKc7ThFmTrxkC3QvxrmZiZTlgJV2DFkTpMlyjsO85lrv1pmhYlmRy IQQMoB0zXSX6DCbfqglyUGHgnHbVKVzJPPSJNc4Y9Biu91F66nKuWRvjzcJm77LcIg5N qqTR6f2nw8DngT9rnfEL6r5BW89ArFUiP+f3QmkJWPzXk9/vofn7F0r5PFE1MSi1kwu0 DZjUnxQegtrQsY8/PIXvFdOeKnmFhEuOynXzTxx+2I6ZdLvxzLuPWMegCXh0K2bVsyNe SK1A== X-Forwarded-Encrypted: i=1; AJvYcCWsi58AzqBZUsGEwmC48TpoK8gXzy4sZ1H746Z1ZlxsFEOu5a57ZJqisAr/+AnD+bRwME2tmA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyevJcom8IMci2GUOZdQ69in5P3Y8NgEPUYWW+3CeurDqMLUIUE dR3lB2aMh1ZHzROcA/rTaLpLwsKrGz5B49KG83R2HqxhzIK2nxGS X-Gm-Gg: ASbGncvClpP0oc0k3f78pxwxM020s5D4QPUZooNauDC3lQVSWP5b1Y947ROOWOKGEla xwwkRACgvBC/Iykxhr5RRxzxf535DUVRNKVH+iYXwCtEch7ZPkT18Qr97mCE+bdaZjrpG1o70jk KiHZGojl48OCGQcN8mPu0y243BAK25jGORmrJJMVcYTa4lzMrr2YQRerDcPD0MdIgMUH5uH9NGs Ejoy79Laq7bzkD1apK5bo//gkSF25ypq12kRnN+CmCGci/p9Oj7eU2KbmPXR3uLszH14UjKO9pL 5QK79Cc3SJWE60SbJIUzJ+4wIV84HF6ymLDprbfqNDJrrffpM0je0zEsfseOsVRcXJYBoanz/w= = X-Google-Smtp-Source: AGHT+IG5MGl7sb8pyIEVk+LeWI68NqKIrj6FfWaIi74+hJcHBIBONG9GO0DCQWhYJVfb6jaFz2ttSg== X-Received: by 2002:a05:6000:154d:b0:38f:6287:6474 with SMTP id ffacd0b85a97d-392641bfee6mr12664352f8f.15.1741883322594; Thu, 13 Mar 2025 09:28:42 -0700 (PDT) Received: from 3-191.divsi.unimi.it (3-191.divsi.unimi.it. [159.149.3.191]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c83b7656sm2558140f8f.40.2025.03.13.09.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 09:28:42 -0700 (PDT) From: Vincenzo Pupillo To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path Date: Thu, 13 Mar 2025 17:28:41 +0100 Message-ID: <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> In-Reply-To: <867c4t2eiy.fsf@gnu.org> References: <87frjj2uta.fsf@ice9.digital> <3517098.LZWGnKmheA@3-191.divsi.unimi.it> <867c4t2eiy.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) In data gioved=C3=AC 13 marzo 2025 15:25:57 Ora standard dell=E2=80=99Europ= a centrale, Eli=20 Zaretskii ha scritto: > > From: Vincenzo Pupillo > > Cc: 76955@debbugs.gnu.org > > Date: Thu, 13 Mar 2025 11:17:11 +0100 > >=20 > > Ciao, > >=20 > > 'php-ts-mode-php-executable' it's used for 'php-ts-mode-flymake-php', > > 'run-php' and 'php-ts-mode-run-php-webserver'. >=20 > Then please consider the solution proposed below. >=20 > > @Morgan: Will setting the executable path to "php" work in your scenari= o? > > Of the functions listed above, which one do you usually use? >=20 > Customizing the value is an okay solution, but we are discussing how > to solve this for users that don't customize. >=20 > How about the following solution: >=20 > . we replace references to php-ts-mode-php-executable with a call to > a function > . that function will do something like >=20 > (let ((php-prog (if (file-remote-p default-directory) > (executable-find "php" t) > php-ts-mode-php-executable))) > php-prog) >=20 > WDYT? Yes, that's fine. Maybe we should also rename 'php-ts-mode-php-executable',= =20 something like 'php-ts-mode-php-default-executable'. It seems to me that it= =20 might not be clear that this value would not be used if the file was remote. Vincenzo From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 12:45:16 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 16:45:16 +0000 Received: from localhost ([127.0.0.1]:57835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tslgJ-0001fl-Il for submit@debbugs.gnu.org; Thu, 13 Mar 2025 12:45:15 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:46577) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tslgG-0001bB-Ey for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 12:45:13 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 5037744289; Thu, 13 Mar 2025 16:45:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1741884305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1VH7luqn8VMjHiEM1pAfrCfEIWOEHg4G+zT3wAmKlmY=; b=Qxf2Bt7beE7PU/wq87ww9Z8auwmUeqRcaLZw8NpyRr0ap0D8dWxfr8IFQEPYVz8hgzbGPG VwjXJBCxlsRhGgn6tQR3Wg/qySpheKq907IJlmXE8CYXRR2eTShbYVsmLRckQazMrMfhWL cn53H2tRvT7hsrSbFWXGrG9h+HMU4mKTouONQLlt2OEhVJXGZDJynmSIgx7qwyCLn+yx2S kKoqbLuwv9V9bVaBfU9ieMdzgQSfYsJBl/oRkOp2mn0WMY75+RCkDL39A3wxvVkTQeLI0P PE9qBOA2Vq1sUADXOIKnCbl795skAdfgWJHS+U6NZ/3rizogamZpR0crNTpn3A== From: Morgan Willcock To: Vincenzo Pupillo Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> (Vincenzo Pupillo's message of "Thu, 13 Mar 2025 17:28:41 +0100") References: <87frjj2uta.fsf@ice9.digital> <3517098.LZWGnKmheA@3-191.divsi.unimi.it> <867c4t2eiy.fsf@gnu.org> <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> Date: Thu, 13 Mar 2025 16:45:04 +0000 Message-ID: <87wmcsdgmn.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdekgeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepofhorhhgrghnucghihhllhgtohgtkhcuoehmohhrghgrnhesihgtvgelrdguihhgihhtrghlqeenucggtffrrghtthgvrhhnpedugeduhfdvleefheefgffgueelfeehueejleevudekuedutdduiefggeefveejieenucfkphepkedtrdeggedrvdeftddrkedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepkedtrdeggedrvdeftddrkedvpdhhvghlohepmhgrtghmihhnihdrnhhothhlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhorhhgrghnsehitggvledrughighhithgrlhdpnhgspghrtghpthhtohepfedprhgtphhtthhopeejieelheehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepvhdrphhuphhilhhlohesghhmrghilhdrtghomh X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: Eli Zaretskii , 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Vincenzo Pupillo writes: > In data gioved=C3=AC 13 marzo 2025 15:25:57 Ora standard dell=E2=80=99Eur= opa centrale, Eli > Zaretskii ha scritto: >> > From: Vincenzo Pupillo >> > Cc: 76955@debbugs.gnu.org >> > Date: Thu, 13 Mar 2025 11:17:11 +0100 >> > >> > Ciao, >> > >> > 'php-ts-mode-php-executable' it's used for 'php-ts-mode-flymake-php', >> > 'run-php' and 'php-ts-mode-run-php-webserver'. >> >> Then please consider the solution proposed below. >> >> > @Morgan: Will setting the executable path to "php" work in your scenar= io? >> > Of the functions listed above, which one do you usually use? >> >> Customizing the value is an okay solution, but we are discussing how >> to solve this for users that don't customize. >> >> How about the following solution: >> >> . we replace references to php-ts-mode-php-executable with a call to >> a function >> . that function will do something like >> >> (let ((php-prog (if (file-remote-p default-directory) >> (executable-find "php" t) >> php-ts-mode-php-executable))) >> php-prog) >> >> WDYT? > Yes, that's fine. Maybe we should also rename 'php-ts-mode-php-executable= ', > something like 'php-ts-mode-php-default-executable'. It seems to me that = it > might not be clear that this value would not be used if the file was remo= te. Wouldn't this approach make it impossible to override the value for the remote system if the wrong PHP binary is found by executable-find? --=20 Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 12:47:53 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 16:47:53 +0000 Received: from localhost ([127.0.0.1]:57854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tslir-0001nR-Bm for submit@debbugs.gnu.org; Thu, 13 Mar 2025 12:47:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38504) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tslio-0001n7-7W for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 12:47:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tslii-0008Se-SB; Thu, 13 Mar 2025 12:47:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=jdU4EV62nEe8kITvih4SAxthOMiirJzOtOgP79zoFUw=; b=nshzUcJSvlis251id4sh YvgHM5Vum16B6F0NovoVnN3vT3P4f1USGUFE6zWi5/o7KRYd7NGAc0sW7m2fgm60ylsZKI/xNeBoW OwjVHpnRlDjQOzTr2h58EhRw9jm3jfSNFc+A6MuShBMTPJI13M3/N0VEt2S2NZ9kMJ5UUIIuW2TGh Dw4PdBJ9S3m6OioMpRKXCJoHofzapXcmF5LH9TesrANgb8U90K1NhlLKOnLYtSAJ/9l4t81MZ+5rX Cr2BnBcm7Ghd4xhws10RmOEoiKtFEBzSbuEYO0oYYbAjreQofVQqPNU1qE5RZkQA1c4FYJwWtD3wN Wm+Hc63P20vIvA==; Date: Thu, 13 Mar 2025 18:47:42 +0200 Message-Id: <86seng27yp.fsf@gnu.org> From: Eli Zaretskii To: Vincenzo Pupillo In-Reply-To: <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> (message from Vincenzo Pupillo on Thu, 13 Mar 2025 17:28:41 +0100) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <3517098.LZWGnKmheA@3-191.divsi.unimi.it> <867c4t2eiy.fsf@gnu.org> <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Vincenzo Pupillo > Cc: morgan@ice9.digital, 76955@debbugs.gnu.org > Date: Thu, 13 Mar 2025 17:28:41 +0100 > > In data giovedì 13 marzo 2025 15:25:57 Ora standard dell’Europa centrale, Eli > Zaretskii ha scritto: > > How about the following solution: > > > > . we replace references to php-ts-mode-php-executable with a call to > > a function > > . that function will do something like > > > > (let ((php-prog (if (file-remote-p default-directory) > > (executable-find "php" t) > > php-ts-mode-php-executable))) > > php-prog) > > > > WDYT? > Yes, that's fine. Maybe we should also rename 'php-ts-mode-php-executable', > something like 'php-ts-mode-php-default-executable'. It seems to me that it > might not be clear that this value would not be used if the file was remote. Yes, good idea. Would you like to post a patch to that effect? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 12:59:11 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 16:59:11 +0000 Received: from localhost ([127.0.0.1]:57881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsltn-0002PV-Er for submit@debbugs.gnu.org; Thu, 13 Mar 2025 12:59:11 -0400 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]:53251) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsltl-0002P0-13 for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 12:59:09 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id D107A4424D; Thu, 13 Mar 2025 16:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1741885142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IZVAHl0zOXzCX4diWyUaJNoMRq7lPsVf9nWmhX6i0ws=; b=ZUN4mAWg+wVTgPMrOrJx7GH3pzdpuOhC13bEARLqzuYIpO81Sc4Q5/ltmDxVmABZajWa6X HvisDVx5R+IEeucXXap+S28JSoaxg/GbLrUCJ+Wpv1yFKRv38hUUTN04ny8wk1bjatcFdV Qdgtuq4BlRIyUKJpNslPpaAnNunxsLHwc8jASReNmm7YUaO+lMeWpdqDdCZD1KCRUyHCiN vwESAtlJVt8JR/Ul+MyWJH0rrAVX1DUGLRB3IBwiqkys9kWDnWp2J2M1VQCEEnBsQamuHT Xv2yPvE0pu4Wq2f72ODAqs13ssQ0iM9xh96Xd3XsUECKB2d5UrjlJWdghBjv4Q== From: Morgan Willcock To: Vincenzo Pupillo Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <7174905.9J7NaK4W3v@3-191.divsi.unimi.it> (Vincenzo Pupillo's message of "Thu, 13 Mar 2025 15:07:41 +0100") References: <87frjj2uta.fsf@ice9.digital> <3517098.LZWGnKmheA@3-191.divsi.unimi.it> <87a59pdvec.fsf@ice9.digital> <7174905.9J7NaK4W3v@3-191.divsi.unimi.it> Date: Thu, 13 Mar 2025 16:59:00 +0000 Message-ID: <87plikdfzf.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdekgeelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefoohhrghgrnhcuhghilhhltghotghkuceomhhorhhgrghnsehitggvledrughighhithgrlheqnecuggftrfgrthhtvghrnhepueduvdeguefgvdeuudekleejhfethfekgeefveejffdvheffkeduvddugefgjeeinecukfhppeektddrgeegrddvfedtrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeektddrgeegrddvfedtrdekvddphhgvlhhopehmrggtmhhinhhirdhnohhtlhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmohhrghgrnhesihgtvgelrdguihhgihhtrghlpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepjeeileehheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehvrdhpuhhpihhllhhosehgmhgrihhlrdgtohhm X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: Eli Zaretskii , 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Vincenzo Pupillo writes: >> If someone could explain the reasoning behind how the default value is >> currently being set, and why that is better than just using the value >> "php", feel free to close this bug report. > > At first it was just 'php' then, since I don't know the details of how path > resolution works on Windows or even Macs, I preferred to use 'executable- > find'. as in python.el for example. I think the critical difference is, python.el is not using the path to the binary as the default value, it takes the successful search as a signal of which python executable name to be searching for: (defcustom python-interpreter (cond ((executable-find "python") "python") (t "python3")) > So, since I have always used 'php-mode' and wanted users to feel "at > home", I used exactly the same expression: '(or (executable-find "php") > "/usr/bin/php")'. I don't think php-mode has a feature like run-php, so your original default value of "php" makes much more sense to me. I don't think you need to do anything special for Windows of macOS. -- Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 13:17:38 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 17:17:38 +0000 Received: from localhost ([127.0.0.1]:57924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsmBd-0003T7-Nd for submit@debbugs.gnu.org; Thu, 13 Mar 2025 13:17:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50606) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsmBa-0003Sj-B9 for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 13:17:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tsmBU-0007YZ-2n; Thu, 13 Mar 2025 13:17:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=bqtvb8cMR4LUzl2lDw6V8NqQe0I6rkFLnFLkILGGaaw=; b=mudw2ZRuJxt6CDgBEHje NC/K+XgbwvJ/0dp0XfsdQbnUBx8pIHL42+Mq7xiR3sPkN9VOr6BbtzjMEba99a4tdikaVaq1LB+EG vbrr5/ZR+lSgmiQpgpy5taZqjZr/4Xbx4vqRKo7ZafNkdZbqhBxXdW/Q2O+4PIH6myT2s+qqoxxeu 6v04RXQg3yPDGSUIz2Pf78LfiOe5U+tOE90E7TetxrHziZKXRiJ/Fa3iixRAQmXGvG4j44p5MF4tY InT+WC+Hi3+mSyD2eKQRDhsmqYkkNJyk0jQanyPG0xW0J9jrzyjd7ImLn7kF7oR/GFyANdZRyjOUY l+dJzauXl9r6BA==; Date: Thu, 13 Mar 2025 19:17:24 +0200 Message-Id: <86plik26l7.fsf@gnu.org> From: Eli Zaretskii To: Morgan Willcock In-Reply-To: <87wmcsdgmn.fsf@ice9.digital> (message from Morgan Willcock on Thu, 13 Mar 2025 16:45:04 +0000) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <3517098.LZWGnKmheA@3-191.divsi.unimi.it> <867c4t2eiy.fsf@gnu.org> <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> <87wmcsdgmn.fsf@ice9.digital> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Willcock > Cc: Eli Zaretskii , 76955@debbugs.gnu.org > Date: Thu, 13 Mar 2025 16:45:04 +0000 > > Vincenzo Pupillo writes: > > > In data giovedì 13 marzo 2025 15:25:57 Ora standard dell’Europa centrale, Eli > > Zaretskii ha scritto: > >> > From: Vincenzo Pupillo > >> > Cc: 76955@debbugs.gnu.org > >> > Date: Thu, 13 Mar 2025 11:17:11 +0100 > >> > > >> > Ciao, > >> > > >> > 'php-ts-mode-php-executable' it's used for 'php-ts-mode-flymake-php', > >> > 'run-php' and 'php-ts-mode-run-php-webserver'. > >> > >> Then please consider the solution proposed below. > >> > >> > @Morgan: Will setting the executable path to "php" work in your scenario? > >> > Of the functions listed above, which one do you usually use? > >> > >> Customizing the value is an okay solution, but we are discussing how > >> to solve this for users that don't customize. > >> > >> How about the following solution: > >> > >> . we replace references to php-ts-mode-php-executable with a call to > >> a function > >> . that function will do something like > >> > >> (let ((php-prog (if (file-remote-p default-directory) > >> (executable-find "php" t) > >> php-ts-mode-php-executable))) > >> php-prog) > >> > >> WDYT? > > Yes, that's fine. Maybe we should also rename 'php-ts-mode-php-executable', > > something like 'php-ts-mode-php-default-executable'. It seems to me that it > > might not be clear that this value would not be used if the file was remote. > > Wouldn't this approach make it impossible to override the value for the > remote system if the wrong PHP binary is found by executable-find? If executable-find fails to find the PHP binary on the remote host, how can using "php" which you suggested do any better? But if we want to allow customization of remote PHP executable, we could introduce another defcustom. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 13:43:22 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 17:43:22 +0000 Received: from localhost ([127.0.0.1]:57973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsmaX-0004ql-HD for submit@debbugs.gnu.org; Thu, 13 Mar 2025 13:43:21 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:53835) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsmaU-0004qQ-SZ for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 13:43:19 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 4F3D544342; Thu, 13 Mar 2025 17:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1741887792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gpPQ8h+lmxjB1FtIAWRE42Hg3NMk7U8xsZ2yue/mmRs=; b=A64rxVjg+HXPzNMbnvwvtxqzYZh8RfGt4dukj5rwbreVVLrJT8zTIsXQDNuQCGkY6t1MfB SejugpwaLMhSgoOAdyon6/mqN7sJOTS1kVRZ/lDqT4tOMHrVpTc5FTddEb/YB8rWL8gft0 DJQns/bT3fp2L18pv97n05kJ2UPHUBn9ehePc9aX1KtdUWzGzJkCwYOsEBvB4JN/0+53p0 BZEQFyaTxYDU5IrXyuCeXN0MHWkwynTH4UUKjEjZLKFVY9Fbf7DDtHOlA6qCdj+UJhHx5G U7hW78gYiegXptAQk49hqHlTww8vHtmrUwN/U/7w2cUMIhGU7WxnD6Ro4peLnQ== From: Morgan Willcock To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <86plik26l7.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Mar 2025 19:17:24 +0200") References: <87frjj2uta.fsf@ice9.digital> <3517098.LZWGnKmheA@3-191.divsi.unimi.it> <867c4t2eiy.fsf@gnu.org> <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> <87wmcsdgmn.fsf@ice9.digital> <86plik26l7.fsf@gnu.org> Date: Thu, 13 Mar 2025 17:43:11 +0000 Message-ID: <87ldt8ddxs.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdekheekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepofhorhhgrghnucghihhllhgtohgtkhcuoehmohhrghgrnhesihgtvgelrdguihhgihhtrghlqeenucggtffrrghtthgvrhhnpedugeduhfdvleefheefgffgueelfeehueejleevudekuedutdduiefggeefveejieenucfkphepkedtrdeggedrvdeftddrkedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepkedtrdeggedrvdeftddrkedvpdhhvghlohepmhgrtghmihhnihdrnhhothhlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhorhhgrghnsehitggvledrughighhithgrlhdpnhgspghrtghpthhtohepfedprhgtphhtthhopeejieelheehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvhdrphhuphhilhhlohesghhmrghilhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Morgan Willcock >> Cc: Eli Zaretskii , 76955@debbugs.gnu.org >> Date: Thu, 13 Mar 2025 16:45:04 +0000 >>=20 >> Vincenzo Pupillo writes: >>=20 >> > In data gioved=C3=AC 13 marzo 2025 15:25:57 Ora standard dell=E2=80=99= Europa centrale, Eli >> > Zaretskii ha scritto: >> >> > From: Vincenzo Pupillo >> >> > Cc: 76955@debbugs.gnu.org >> >> > Date: Thu, 13 Mar 2025 11:17:11 +0100 >> >> > >> >> > Ciao, >> >> > >> >> > 'php-ts-mode-php-executable' it's used for 'php-ts-mode-flymake-php= ', >> >> > 'run-php' and 'php-ts-mode-run-php-webserver'. >> >> >> >> Then please consider the solution proposed below. >> >> >> >> > @Morgan: Will setting the executable path to "php" work in your sce= nario? >> >> > Of the functions listed above, which one do you usually use? >> >> >> >> Customizing the value is an okay solution, but we are discussing how >> >> to solve this for users that don't customize. >> >> >> >> How about the following solution: >> >> >> >> . we replace references to php-ts-mode-php-executable with a call to >> >> a function >> >> . that function will do something like >> >> >> >> (let ((php-prog (if (file-remote-p default-directory) >> >> (executable-find "php" t) >> >> php-ts-mode-php-executable))) >> >> php-prog) >> >> >> >> WDYT? >> > Yes, that's fine. Maybe we should also rename 'php-ts-mode-php-executa= ble', >> > something like 'php-ts-mode-php-default-executable'. It seems to me th= at it >> > might not be clear that this value would not be used if the file was r= emote. >>=20 >> Wouldn't this approach make it impossible to override the value for the >> remote system if the wrong PHP binary is found by executable-find? > > If executable-find fails to find the PHP binary on the remote host, > how can using "php" which you suggested do any better? Because in that case I can modify either search path or the value of the variable to match where the (correct) PHP binary is. I think that using the value "php" would work the in majority of cases for the majority of people, and working around issues is already covered by existing Emacs functionality. > But if we want to allow customization of remote PHP executable, we > could introduce another defcustom. This will have the same problems if connecting to two remote system which are configured differently. --=20 Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 13:53:48 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 17:53:48 +0000 Received: from localhost ([127.0.0.1]:57991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsmke-0005MX-4j for submit@debbugs.gnu.org; Thu, 13 Mar 2025 13:53:48 -0400 Received: from mout.gmx.net ([212.227.15.15]:42875) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsmka-0005M4-SG for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 13:53:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1741888418; x=1742493218; i=michael.albinus@gmx.de; bh=iC5da0fRjWCB/9swJuQaZ5fsEdCvVSi2c5swQtBnviM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=cn0I/IufGAYYHW+4fUPSuG6N7yjELTyL+dsohOK8sI4+q+pSv/vrpaw8vByhgzhz 0sbUsi0+01m1vKzHpokUAowoziyMH0MWsL861Ra4N2jXHiJOTLay+4ab7xNwYBw8c vZxD0PmpUCHFAzuQ0pxfhP6tGo8UB/zCCfYquLGBgizLMBPl3RgYq+kVOfNXLOsgR ys0fC+X4Eih8nhASfIQxeGC5bublvSTGdlFgznU89rDrtVRsu3X1S+VxAyMDYL1CS 9V693HpHGxqvVKeMvG7rv6mZnGrRAbD4SGMG7VMqWDKAuYRmLX5+TkUKpgAxYXDRm qv2jRUG3CzGxp7OrTg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.37.59]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MD9T1-1u1LJz1cIr-00GY9S; Thu, 13 Mar 2025 18:53:38 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <86plik26l7.fsf@gnu.org> References: <87frjj2uta.fsf@ice9.digital> <3517098.LZWGnKmheA@3-191.divsi.unimi.it> <867c4t2eiy.fsf@gnu.org> <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> <87wmcsdgmn.fsf@ice9.digital> <86plik26l7.fsf@gnu.org> Date: Thu, 13 Mar 2025 18:53:36 +0100 Message-ID: <874izwyfz3.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:h/vSfA6DY0/KSPgmSAQ1th9/BLZ6Oiz/mIVJAHWevL8vgS0k+JT JybLq7KjA12+uoFjui7P9kmA20mAXAmoa3vNMlT7O4I6VZer4ldx8V9Wa3eyI7Iv6Af5cfn Zmqzr0GLarMT/qG2g0EvKXXvbqARgjCelgZ/DXBlzwozawmchboHOCr3YIohEpOVZqN8Rv7 8yqpKWPGUx4T9I30vP75A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:T/4in2wSEnY=;ZRZOA9VtKYGJHb2LfbrmxYqn7zg /ZaMSvdhzSnEp3bQN8JooKqoBl19jJzUxgBwHbaMiDG/az/Nn8MoPL2B/zcghbMR/d5N3Xnuc 6kcKvGOc8+f9yRY5orlJ4dAmS5eA97eobub+SVuCmJRavgY7cBB1tOZh/59V48F4z7HDxUXLP lhMtlbmKUMWqV223xR4NccWeNcroR7XzwFQ/Q2P9tPOpCPPrhwZgHwnUD53OpDm22RSp6c/Ld ucp8D5EK7RXmWQrQlie90eNG3/dFCwNc5YRG+X18dfPn8y1VBlsFvV2oyC5vfDju9vGdFVZrQ lYXLOkGD8OGajs+rhKka9LplUmZd01mcrid6xHZHvWWgoMouObEy44XyUT8uh3XSG2J71oPHr T9JUKenBX3WJGuNy0YOjpXmZNgxoIlGeQobnHk0HFk7xn489G0UaCfIL0ZBjA9xFPWBIv3Tas 21FpCVUSiBFgWZNRDX1X1R9TKVYmcqMJgAvlwdVyQRxjp1qcTKoIyeE7csuUDa/t7CBq/dCLV 572t7JyvkhzX8JnWKXBO/CPa6wKjwJCPnwzGBtJ83wsm1nCUYhz2X5iIXex2Kj0qSf0zgv6YM HGysxGXyiV+uTrUt44zbEkRCTXtsV5UrFTL0R3J6WptNPfe1y/deyRV/z2Vx0HfOJVqo3J5mW o0bbME6xjt1trIfi4wuFR4qWlTo3jLlpSa4I+wxd4T/J0JN6Rbwb+NJDg7bCpe92sc13L/EWl Hms7BZE+Au9uhRkZMcS7dNuZUJJfY/ywcaHXNo1keeZJW1eSKAZcBobfy+5koY2nxmIfJwTlP f6+b2WJayC3BnZRbG+JudS/3NoM4eueCfVb8UYw9qlijaMu4kYaFY85b5i9q7IHF958n9GaTR gEbU48mkOcdTfl2ZNCYbhJV0pIpLmKtVD0JqZe6uQTYUp6VsnSnicGcGB03UpqiBc7MS8xIXq InY91BUTuBWAhDj9zb4iufaQ7XRMbN8X5vdpE/8LGWScEI/oNimu6ugPlMoS23ew/6AJ3E84f FZhb5wg7yLfCSQk7fzd8i8+JO1S2xW+6QsRXTXEkBSWZFN8JdJa4rW0lfXmiHMQl+UZd290pd bLJncjy5/jg44mrWUQ7QEbApqhrpQcWeOVREiLhj2iJRqFSj1LS8sgokoy7irCuSgasrsVgl2 /CMs62BvwCVOuHVFCjAVory3VQzWTD5I3liD9eSin/Rfj5EQNeMszkv5zRTR5LY6KrVw8T1k8 DW176nSpSghHuxuLh4tvJUPDUDaJtYnvN35h2WcCdNiaTgO9QPPzIzw41GR0Z41nH6G8+flFM pVxnBzbQPs+uDOvfVP55SABOH0PXue2h1PfAE2V8DDG3vu3c+gSMzcvSFgKRZdzFyFKg/+dwe NnjtUb+ui9kCRzhvBDfF+9IoxJZ2kLl9+wvMgaCcQ0MuZpQIwMjeObfQYMDyRw+uDZ9HrsP8i aa79h1AvdkpVYqgmskBR5fd3h6LPqNsZVg2fH/gBJRp7jzZri X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org, Morgan Willcock X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi Eli, > If executable-find fails to find the PHP binary on the remote host, > how can using "php" which you suggested do any better? Because the PATH you set in your remote .profile isn't expanded by default into tramp-remote-path. You must arrange for it, for example by adding symbol tramp-own-remote-path into that list. (info "(tramp) Remote programs") Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 15:28:49 2025 Received: (at 76955) by debbugs.gnu.org; 13 Mar 2025 19:28:49 +0000 Received: from localhost ([127.0.0.1]:58223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsoEb-00089x-2G for submit@debbugs.gnu.org; Thu, 13 Mar 2025 15:28:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49282) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tsoEY-00089i-Ge for 76955@debbugs.gnu.org; Thu, 13 Mar 2025 15:28:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tsoES-0001W3-4K; Thu, 13 Mar 2025 15:28:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=sebHzlHPyMU7U0gp0LuhjbgFBpWzC6tFuBmpvkmp3/0=; b=P+hXW+cz22neD5cyPqy5 jaG9+KgW+1onedFT95et8yeI/yhLMML0S9383xZASZuMzbqScHzsvbU7CBGL+BCHQoP8L/DyOrsKV +abvJSRpQBXANV/18+WGt8uG4XPrtOgWUt0NwCOaAptUth1pc25bs15pX6eQYH2aGTprTj/zZgXFI Wernhm4a+tpJOkRCC7StVDixRVTx+jhhxAX0/afwGG8sRSlJpNp1x7bfNDhMWnRnnggQwAc/C23MR CghoZyIwLWgdNtP+swo/DE9glM2GX6AK0zaVuiRmDA5HwANBsZPeghYEPPK1rCNHIlud3HeNqDUgV QlOcAnbyotjPJw==; Date: Thu, 13 Mar 2025 21:28:14 +0200 Message-Id: <86ikoc20j5.fsf@gnu.org> From: Eli Zaretskii To: Morgan Willcock In-Reply-To: <87ldt8ddxs.fsf@ice9.digital> (message from Morgan Willcock on Thu, 13 Mar 2025 17:43:11 +0000) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <3517098.LZWGnKmheA@3-191.divsi.unimi.it> <867c4t2eiy.fsf@gnu.org> <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> <87wmcsdgmn.fsf@ice9.digital> <86plik26l7.fsf@gnu.org> <87ldt8ddxs.fsf@ice9.digital> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Willcock > Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org > Date: Thu, 13 Mar 2025 17:43:11 +0000 > > Eli Zaretskii writes: > > >> From: Morgan Willcock > >> Cc: Eli Zaretskii , 76955@debbugs.gnu.org > >> Date: Thu, 13 Mar 2025 16:45:04 +0000 > >> > >> Vincenzo Pupillo writes: > >> > >> > In data giovedì 13 marzo 2025 15:25:57 Ora standard dell’Europa centrale, Eli > >> > Zaretskii ha scritto: > >> >> > From: Vincenzo Pupillo > >> >> > Cc: 76955@debbugs.gnu.org > >> >> > Date: Thu, 13 Mar 2025 11:17:11 +0100 > >> >> > > >> >> > Ciao, > >> >> > > >> >> > 'php-ts-mode-php-executable' it's used for 'php-ts-mode-flymake-php', > >> >> > 'run-php' and 'php-ts-mode-run-php-webserver'. > >> >> > >> >> Then please consider the solution proposed below. > >> >> > >> >> > @Morgan: Will setting the executable path to "php" work in your scenario? > >> >> > Of the functions listed above, which one do you usually use? > >> >> > >> >> Customizing the value is an okay solution, but we are discussing how > >> >> to solve this for users that don't customize. > >> >> > >> >> How about the following solution: > >> >> > >> >> . we replace references to php-ts-mode-php-executable with a call to > >> >> a function > >> >> . that function will do something like > >> >> > >> >> (let ((php-prog (if (file-remote-p default-directory) > >> >> (executable-find "php" t) > >> >> php-ts-mode-php-executable))) > >> >> php-prog) > >> >> > >> >> WDYT? > >> > Yes, that's fine. Maybe we should also rename 'php-ts-mode-php-executable', > >> > something like 'php-ts-mode-php-default-executable'. It seems to me that it > >> > might not be clear that this value would not be used if the file was remote. > >> > >> Wouldn't this approach make it impossible to override the value for the > >> remote system if the wrong PHP binary is found by executable-find? > > > > If executable-find fails to find the PHP binary on the remote host, > > how can using "php" which you suggested do any better? > > Because in that case I can modify either search path or the value of the > variable to match where the (correct) PHP binary is. > > I think that using the value "php" would work the in majority of cases > for the majority of people, and working around issues is already covered > by existing Emacs functionality. > > > But if we want to allow customization of remote PHP executable, we > > could introduce another defcustom. > > This will have the same problems if connecting to two remote system > which are configured differently. So I conclude that expecting "php" to be on PATH on remote systems is a requirement, since nothing else will work reliably enough, and let's close this discussion at that. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 14 16:29:32 2025 Received: (at 76955) by debbugs.gnu.org; 14 Mar 2025 20:29:32 +0000 Received: from localhost ([127.0.0.1]:36417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttBeu-0004DN-23 for submit@debbugs.gnu.org; Fri, 14 Mar 2025 16:29:32 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:57728) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ttBeq-0004D6-JR for 76955@debbugs.gnu.org; Fri, 14 Mar 2025 16:29:29 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-43d04dc73b7so998555e9.3 for <76955@debbugs.gnu.org>; Fri, 14 Mar 2025 13:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741984162; x=1742588962; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G42QroECU2zf2htgHeBoNcHye4vxCf8grpof0kCIutA=; b=CfbbNVgcrne1vv0R8S5Y45DGbLaljAOR4ufX34zyPIghi0d2hDXy21+YiooaXZPQQw ALE5cFzh7FQloRJ5ywO8Gui/NmxEsj016iDufWQtYY63BKI/iH7Ga4o4IYnC7pHpLZT4 er+rKrDLnYhgjaxExUI/g67VIugyf7nS7eqxSKmsXzZCCEJOYsuiV178XmgrepEnzR+q dfIPQMqDMqEKbg5uBMYGFQgY+/ZA1tKA5OXBcBkJYJ8lRcIYhku4aGjx4WglJ7tJftdP pOghqFxx0G0c2Db5u/PvjpB7TNpsTFiLYFIBFXR1ENCUZ+Dtz4xRcyZD5CuOFfelw/vY nbIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741984162; x=1742588962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G42QroECU2zf2htgHeBoNcHye4vxCf8grpof0kCIutA=; b=RzFANpKZvIG3o9Bx6fy2c3hMpzNhu/O4qS+H3hr9R8M9dOvE4sSno08TBCwvpAG0uL LYERZ7ji7iGiBrcHI04AZZKt5r2otXlLZeX204DyChyJr7nEZWDVZ3DxfCwQOFRK1Rb6 o37hzlp55EC3LVr47zgx9Gen7LDlfckzcSjrASAsC/pxaai62qJcQC8v+doH0opizFcK npLq4S1H+nwaU4Q3NQw8sLDM974J34qcYvorTDwcZTAi4BDO3L+awdjxhxlTbZo0teTQ AO2sLgtPOjfMmlDBkrsiG+UMMM1Loz4QBFW02V/DhcpLOIBeP9v7mXfimS+RGDgHFV9t /fXQ== X-Gm-Message-State: AOJu0YxczJu+2J24bqPZYi1elu7iOpm2j60+cIsoxr0APgYq7aHroch0 caaXnwrvZ7JbuAtakewW43ksv81vFKzS6X4KBr7N5kPyDTkwEKzG X-Gm-Gg: ASbGncuMULwLYjVfXH52gwJoFKDssXv88BpQdWg6ox2y4arH0BrPDv5JvR3WkDMHDhK QTvcp2Nnhs14k9H5/klcOxr2fnWquhejcjVTm5N2GyG/xMh/AQMCAQM+L/CK8Ghb9GD+fUC0Z0z Fl/wpmEOvk3/wMDH9c7kEiaV2Jdo/P1xYaDgi5nSpRyT6Vwm/YebRvPN7wsSaIWFmTB89Vvau8s JUD8hQvL9Z8hsMvVJcBRkJMCBJptGECkTW8vDOevA/mKxXp0spk/Y5iv+Sil5n197J7rHJkUeZA 4aPCKPTNYaZdEYnCwgTnTTqmqap3SfpGhdx0yYg5VX1kIjGqgShYi88wbfrQVthsm93I5rFWXdL OssaQoTXM X-Google-Smtp-Source: AGHT+IHeksT4oMpBU29x7vQfzXxn/LAPTwg2IGIsTWC1efLEDy5OhixlPv8ZnCxnfPBfVrtq+8HVpw== X-Received: by 2002:a05:6000:1541:b0:391:9b2:f49a with SMTP id ffacd0b85a97d-397200acb11mr5230666f8f.55.1741984162119; Fri, 14 Mar 2025 13:29:22 -0700 (PDT) Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c7df339asm6513576f8f.3.2025.03.14.13.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Mar 2025 13:29:21 -0700 (PDT) From: Vincenzo Pupillo To: Morgan Willcock , Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path Date: Fri, 14 Mar 2025 21:29:20 +0100 Message-ID: <26898875.1r3eYUQgxm@fedora> In-Reply-To: <86ikoc20j5.fsf@gnu.org> References: <87frjj2uta.fsf@ice9.digital> <87ldt8ddxs.fsf@ice9.digital> <86ikoc20j5.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart2388191.vFx2qVVIhK" Content-Transfer-Encoding: 7Bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --nextPart2388191.vFx2qVVIhK Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Ciao Eli, the patch is attached. Thanks Vincenzo In data gioved=C3=AC 13 marzo 2025 20:28:14 Ora standard dell=E2=80=99Europ= a centrale, Eli=20 Zaretskii ha scritto: > > From: Morgan Willcock > > Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org > > Date: Thu, 13 Mar 2025 17:43:11 +0000 > >=20 > > Eli Zaretskii writes: > > >> From: Morgan Willcock > > >> Cc: Eli Zaretskii , 76955@debbugs.gnu.org > > >> Date: Thu, 13 Mar 2025 16:45:04 +0000 > > >>=20 > > >> Vincenzo Pupillo writes: > > >> > In data gioved=C3=AC 13 marzo 2025 15:25:57 Ora standard dell=E2= =80=99Europa > > >> > centrale, Eli> >> >=20 > > >> > Zaretskii ha scritto: > > >> >> > From: Vincenzo Pupillo > > >> >> > Cc: 76955@debbugs.gnu.org > > >> >> > Date: Thu, 13 Mar 2025 11:17:11 +0100 > > >> >> >=20 > > >> >> > Ciao, > > >> >> >=20 > > >> >> > 'php-ts-mode-php-executable' it's used for > > >> >> > 'php-ts-mode-flymake-php', > > >> >> > 'run-php' and 'php-ts-mode-run-php-webserver'. > > >> >>=20 > > >> >> Then please consider the solution proposed below. > > >> >>=20 > > >> >> > @Morgan: Will setting the executable path to "php" work in your > > >> >> > scenario? > > >> >> > Of the functions listed above, which one do you usually use? > > >> >>=20 > > >> >> Customizing the value is an okay solution, but we are discussing = how > > >> >> to solve this for users that don't customize. > > >> >>=20 > > >> >> How about the following solution: > > >> >> . we replace references to php-ts-mode-php-executable with a call > > >> >> to > > >> >> =20 > > >> >> a function > > >> >> =20 > > >> >> . that function will do something like > > >> >> =20 > > >> >> (let ((php-prog (if (file-remote-p default-directory) > > >> >> =20 > > >> >> (executable-find "php" t) > > >> >> =20 > > >> >> php-ts-mode-php-executable))) > > >> >> =20 > > >> >> php-prog) > > >> >>=20 > > >> >> WDYT? > > >> >=20 > > >> > Yes, that's fine. Maybe we should also rename > > >> > 'php-ts-mode-php-executable', > > >> > something like 'php-ts-mode-php-default-executable'. It seems to me > > >> > that it > > >> > might not be clear that this value would not be used if the file w= as > > >> > remote.> >>=20 > > >> Wouldn't this approach make it impossible to override the value for = the > > >> remote system if the wrong PHP binary is found by executable-find? > > >=20 > > > If executable-find fails to find the PHP binary on the remote host, > > > how can using "php" which you suggested do any better? > >=20 > > Because in that case I can modify either search path or the value of the > > variable to match where the (correct) PHP binary is. > >=20 > > I think that using the value "php" would work the in majority of cases > > for the majority of people, and working around issues is already covered > > by existing Emacs functionality. > >=20 > > > But if we want to allow customization of remote PHP executable, we > > > could introduce another defcustom. > >=20 > > This will have the same problems if connecting to two remote system > > which are configured differently. >=20 > So I conclude that expecting "php" to be on PATH on remote systems is > a requirement, since nothing else will work reliably enough, and let's > close this discussion at that. --nextPart2388191.vFx2qVVIhK Content-Disposition: attachment; filename="0001-PHP-has-to-be-in-the-PATH-bug-76242.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0001-PHP-has-to-be-in-the-PATH-bug-76242.patch" >From 3f5b7c7667021784a20d6090c52dedfffa1c12d0 Mon Sep 17 00:00:00 2001 From: Vincenzo Pupillo Date: Fri, 14 Mar 2025 21:11:22 +0100 Subject: [PATCH] PHP has to be in the PATH (bug#76242) * lisp/progmodes/php-ts-mode.el (php-ts-mode-php-executable): Now the value is the executable name. --- lisp/progmodes/php-ts-mode.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/php-ts-mode.el b/lisp/progmodes/php-ts-mode.el index 56c15dad36f..eb53df21b97 100644 --- a/lisp/progmodes/php-ts-mode.el +++ b/lisp/progmodes/php-ts-mode.el @@ -134,8 +134,8 @@ php-ts-mode-css-fontify-colors :type 'boolean :safe 'booleanp) -(defcustom php-ts-mode-php-executable (or (executable-find "php") "/usr/bin/php") - "The location of PHP executable." +(defcustom php-ts-mode-php-executable "php" + "The PHP executable." :tag "PHP Executable" :version "30.1" :type 'file) -- 2.48.1 --nextPart2388191.vFx2qVVIhK-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 15 04:59:13 2025 Received: (at 76955) by debbugs.gnu.org; 15 Mar 2025 08:59:13 +0000 Received: from localhost ([127.0.0.1]:38778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttNMO-0007AH-Uu for submit@debbugs.gnu.org; Sat, 15 Mar 2025 04:59:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38966) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ttNMM-0007A4-N6 for 76955@debbugs.gnu.org; Sat, 15 Mar 2025 04:59:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ttNMG-0005Ph-7s; Sat, 15 Mar 2025 04:59:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=P5eHKwm1ylt4Zp6KZR/Wro3ljCYCcfO84KjoKW+Ztl4=; b=ZtBii0iu7VGS rOkkL8v049JsZfeUV/cVjy/AWP+vKZM8l6EZlHw6CC5q5D5scTdMloQlEdyef1ed6BDKWMv25TTNK 4gi7Qh0rUF1TtI1EFeVBGximuY1vU97vULTORpnycUVT6VjaF747p5JFRMR4+oGAuqYyaluc96gi/ M1DVvgIX3ziCCJEHmCugkJkYybMpHRiZbbKnjdc0cMdiWFBM6WzTi0hGHtItpGFuayGm756SGMWlV IuueAfUVrIbkYeRYBQpOdVwCiV8WKH2ry6absUrW5uJVPqCxCy5MXApYig+pqZzmdumN5GaW1uTpV IKszzkxn69pkxAmQW4SYoQ==; Date: Sat, 15 Mar 2025 10:58:58 +0200 Message-Id: <86tt7uy8j1.fsf@gnu.org> From: Eli Zaretskii To: Vincenzo Pupillo In-Reply-To: <26898875.1r3eYUQgxm@fedora> (message from Vincenzo Pupillo on Fri, 14 Mar 2025 21:29:20 +0100) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <87ldt8ddxs.fsf@ice9.digital> <86ikoc20j5.fsf@gnu.org> <26898875.1r3eYUQgxm@fedora> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Vincenzo Pupillo > Cc: 76955@debbugs.gnu.org > Date: Fri, 14 Mar 2025 21:29:20 +0100 > > Ciao Eli, the patch is attached. Thanks, but this is IMO worse than what I suggested, which was to call executable-find every time the program is invoked for remote systems. The idea is that the users can customize php-ts-mode-php-executable for their local setup, without affect the remote setup in any way. The change you posted doesn't allow that: users will have to make sure the same value is valid on both local and all of the remote systems, which is not always possible. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 15 07:03:56 2025 Received: (at 76955) by debbugs.gnu.org; 15 Mar 2025 11:03:56 +0000 Received: from localhost ([127.0.0.1]:39071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttPJ5-0000tp-V1 for submit@debbugs.gnu.org; Sat, 15 Mar 2025 07:03:56 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34125) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ttPIz-0000tO-WC for 76955@debbugs.gnu.org; Sat, 15 Mar 2025 07:03:54 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 064944421A; Sat, 15 Mar 2025 11:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1742036622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eZdagGXyCB5YAzvqIZxc2bmKLKVTQFSZzrla0bCg5bs=; b=Xytk2ZigNuH4f4VntP7rV6NGypt2539N0Glaj9MuBQCKSJXJ8p5kAj7GAKjjH3LgTghN3i n6XbiA91oFlOHoPb/y0hyxqS+9KoNwNgesTsjPBxyqPzO39wVxn5oiB8EdQA4G3aNSL5Tz 1pcf248cYSD/0ne5+kNx4NIZWpk/w/cVSZD1JkEnun8EVTt19JPkv7L6fTml814MaY0tWL FZDneuLu4dwoGYdQ9fTZwjVcl5Pa6aNhoOtRiP96o6RPtKR9E77JgxDA6Gvv2GiTzYOvwG nNFMTLXGPlAVWwPruebNslS+GfxyjUYhkAcx7jQPFjjA3xygllVnPxxx/HwHdQ== From: Morgan Willcock To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <86tt7uy8j1.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Mar 2025 10:58:58 +0200") References: <87frjj2uta.fsf@ice9.digital> <87ldt8ddxs.fsf@ice9.digital> <86ikoc20j5.fsf@gnu.org> <26898875.1r3eYUQgxm@fedora> <86tt7uy8j1.fsf@gnu.org> Date: Sat, 15 Mar 2025 11:03:40 +0000 Message-ID: <87a59mh7xv.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddufeefheehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefoohhrghgrnhcuhghilhhltghotghkuceomhhorhhgrghnsehitggvledrughighhithgrlheqnecuggftrfgrthhtvghrnhepueduvdeguefgvdeuudekleejhfethfekgeefveejffdvheffkeduvddugefgjeeinecukfhppeektddrgeegrddvfedtrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeektddrgeegrddvfedtrdekvddphhgvlhhopegshedtrdhnohhtlhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmohhrghgrnhesihgtvgelrdguihhgihhtrghlpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepjeeileehheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehvrdhpuhhpihhllhhosehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: Vincenzo Pupillo , 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> Ciao Eli, the patch is attached. > > Thanks, but this is IMO worse than what I suggested, which was to call > executable-find every time the program is invoked for remote systems. > The idea is that the users can customize php-ts-mode-php-executable > for their local setup, without affect the remote setup in any way. > The change you posted doesn't allow that: users will have to make sure > the same value is valid on both local and all of the remote systems, > which is not always possible. I don't think any other modes provide a separate value for remote binary paths, and TRAMP provides multiple ways to modify where the search for the remote binary would be done. I think in the extreme case where TRAMP does not provide what is required, someone could always just set a buffer local value to the required path based on their own criteria. But to fix the bug that I reported, I feel the patch is correct, since in the majority of cases the correct binary would be located by default by using the value "php". The same would apply for other remote binaries like diff, find, grep, and xargs - if you resolve the path to the binary locally you may break calling it remotely. What problem is introduced by not calling executable-find? You pointed out it is faster to resolve the binary path once rather than multiple times, but I don't think that it can be considered a good optimisation when it breaks calling the binary on remotes systems. > So I conclude that expecting "php" to be on PATH on remote systems is > a requirement, since nothing else will work reliably enough, and let's > close this discussion at that. I am not sure what you mean by "reliably", but being on PATH is not a requirement to use it. It will very likely be on PATH, but with some additional configuration of the TRAMP connection it doesn't need to be. -- Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 15 08:26:46 2025 Received: (at 76955) by debbugs.gnu.org; 15 Mar 2025 12:26:47 +0000 Received: from localhost ([127.0.0.1]:39614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttQbG-0004J7-FX for submit@debbugs.gnu.org; Sat, 15 Mar 2025 08:26:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41668) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ttQbE-0004In-A6 for 76955@debbugs.gnu.org; Sat, 15 Mar 2025 08:26:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ttQb8-0007cs-0O; Sat, 15 Mar 2025 08:26:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=M6O9QNBrT/379QCYmq5Jgfu2qfz/eZCTxBYbmuorOV8=; b=P5uj618560UI yMzOl4XqhzryCJXEsEDFTLEdg2lTO+SBGqA8XF06oOg8pACieByeolCCoxwoeZK5gxylR0LdTUExc e3y4wbqxFC37jQ4nylHBI6I8C/vHGsrRuyo/wbcZUeZonCMdWX4jeA+Vdbr3mcjAJtdiL+iETsmMS Yb7jlDOLxnlFkJY0PZm7FkIwsi/7Wa3zWKvti/Q7Jo25pyRpOj7OSNn9ikCwywmls2ovcly0VeGSn J3ESGmybDEN+ODi+efVWofw8KdWw9qAz8M+mmJ4XK7lCdP9D9nZHdWNZS0W7t4fZOOrL2b5lEQLhf sE4+u3XzICVwBweWeqPU1Q==; Date: Sat, 15 Mar 2025 14:26:21 +0200 Message-Id: <86msdmwkcy.fsf@gnu.org> From: Eli Zaretskii To: Morgan Willcock In-Reply-To: <87a59mh7xv.fsf@ice9.digital> (message from Morgan Willcock on Sat, 15 Mar 2025 11:03:40 +0000) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <87ldt8ddxs.fsf@ice9.digital> <86ikoc20j5.fsf@gnu.org> <26898875.1r3eYUQgxm@fedora> <86tt7uy8j1.fsf@gnu.org> <87a59mh7xv.fsf@ice9.digital> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Willcock > Cc: Vincenzo Pupillo , 76955@debbugs.gnu.org > Date: Sat, 15 Mar 2025 11:03:40 +0000 > > Eli Zaretskii writes: > > > So I conclude that expecting "php" to be on PATH on remote systems is > > a requirement, since nothing else will work reliably enough, and let's > > close this discussion at that. > > I am not sure what you mean by "reliably", but being on PATH is not a > requirement to use it. It will very likely be on PATH, but with some > additional configuration of the TRAMP connection it doesn't need to be. I mean that we should use executable-find for remote directories, thus assuming that the program is on PATH on remote systems, and let users customize the local value via the user option. IOW, the user option should not have effect on remote invocations. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 15 09:05:33 2025 Received: (at 76955) by debbugs.gnu.org; 15 Mar 2025 13:05:33 +0000 Received: from localhost ([127.0.0.1]:39754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttRCm-00019Y-ST for submit@debbugs.gnu.org; Sat, 15 Mar 2025 09:05:33 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:47195) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ttRCk-00019I-VF for 76955@debbugs.gnu.org; Sat, 15 Mar 2025 09:05:31 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-43cf848528aso5031285e9.2 for <76955@debbugs.gnu.org>; Sat, 15 Mar 2025 06:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742043925; x=1742648725; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V9uEKmbwNeS9X69gM0K+Qph4q09PL1yAH3BNR/k6L4o=; b=jd0iFuHirnfoUaoTFPbRknECpN8t/qJlxrgRFr6KZg9V8yCupUAd05Eqscom5ESpOy n/zRu5MjrjxSPooOcQdd+N4FK9goeRayM19sp2OjTVNCp7WXUqVVT07wFiIPKI/yzsAN OliNxmoS2euUI2VxZZCqLmTOuLIIBtFHGz6uj2isFpvyvXAHGZdtjcv9kMbc3/XMD6MW uuA8OXTeXaoAztVbZ1q1XalWvTled84VWyv2ugSb2gD9YWkv8GW5fkWYAXsD9Jftn+tY KYTfTI9Ev3WV70TsnKSeF2lUjUO1LPzNPxgt/OmMwcvYFJUb+38qp2RPueOY0VmHWgr4 uZtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742043925; x=1742648725; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V9uEKmbwNeS9X69gM0K+Qph4q09PL1yAH3BNR/k6L4o=; b=YhBIO2woBr4sWBtTGinPyN+U27Ypfs+wC5QcJZFDtbxkW9vwjoz+dNGxvEkuXf/z1y MmVvfGUnIWRwETN+PzAgB7gOm8zPm6NyuXM4sTZzBIhNWeVGKhHcYY/eURFC5o2nq5gq gl+IXRaGNyYbpbm+qEUhO3DnaxfGw6H/9fup2ZM5438kaZKDeMxBbhxts0qGDQqukjGg UgzsFQIfcE6VR4nJ9sqnizYc+DVb0uKYiq4ko4CpBN4SVYXZuArmJf/0+9sZjz2KR6bp iSuHkfv0E9W2HCxbJXxT6tbdJouGOa1xMMoU/cG3u/d1s8nZficCEm6sv1mwRrcCQ/gg 6qLw== X-Forwarded-Encrypted: i=1; AJvYcCV20hE988fk1v+Gc8HZpZX07kF6NiAsh+tY2mMH9foN6fb2oeplhEmhNLh9nxA3CNXXjfw7Jg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw2Tspt3MwlqYrZbjfpxD/pi7vyOCPrmKr7jHBbrAs/VILGkVTU vSx/FKu6//S6tyN85okSKKL/Lno39kTVuaNvx7ugKaWmBXhUVcs0 X-Gm-Gg: ASbGnctlOXxJIypY6TE2VjpLcAFdhpD0v1HYE+WvubEUjqkk9MFoudKxsnvdEjVm2iu hIUTu6EVij36wRexmXjm7D64zRIlxh2iKfwWFk26KnSFQlAfxXB38v+I3o+nb8LWGsZNl6JjIYI EfViVPkGFM4Me1mQNPd0MH45IQddnQc0ZyGUTEl6iudoXrhpLpNs+oq9cEbmzd4InBdpQcezaL1 xRZ2qy96Isl+TOcJkz6Xy/pec4bcgoLAwXlmJRy8SXNEvxOag2fPPVQRRg1FZYNip+r+1K9TTwO t6biZfBM+jujsuIIN8WIkUcsiBvCk5VBzVhGX0Qcm5BhZP+CUqp4QLYGsOhFXxvKpdjvob070zY bYyzVOvnv X-Google-Smtp-Source: AGHT+IGQzffzy4DCTbOPVpZM49HcwOQrow4dX2Wtw0MEIyAatUV8IiGntGmDgyikwmzMjjdK11+RDw== X-Received: by 2002:a05:600c:3b9f:b0:43d:fa:1f9a with SMTP id 5b1f17b1804b1-43d1ece134cmr82601375e9.30.1742043924507; Sat, 15 Mar 2025 06:05:24 -0700 (PDT) Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d1fe292dbsm49508465e9.19.2025.03.15.06.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Mar 2025 06:05:24 -0700 (PDT) From: Vincenzo Pupillo To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path Date: Sat, 15 Mar 2025 14:05:23 +0100 Message-ID: <4777348.vXUDI8C0e8@fedora> In-Reply-To: <86tt7uy8j1.fsf@gnu.org> References: <87frjj2uta.fsf@ice9.digital> <26898875.1r3eYUQgxm@fedora> <86tt7uy8j1.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) In data sabato 15 marzo 2025 09:58:58 Ora standard dell=E2=80=99Europa cent= rale, Eli=20 Zaretskii ha scritto: > > From: Vincenzo Pupillo > > Cc: 76955@debbugs.gnu.org > > Date: Fri, 14 Mar 2025 21:29:20 +0100 > >=20 > > Ciao Eli, the patch is attached. >=20 > Thanks, but this is IMO worse than what I suggested, which was to call > executable-find every time the program is invoked for remote systems. > The idea is that the users can customize php-ts-mode-php-executable > for their local setup, without affect the remote setup in any way. > The change you posted doesn't allow that: users will have to make sure > the same value is valid on both local and all of the remote systems, > which is not always possible. Sorry I misinterpreted what you wrote: >So I conclude that expecting =E2=80=9Cphp=E2=80=9D to be on PATH on remote= systems is > a requirement, since nothing else will work reliably enough, and let's > close this discussion at that. Vincenzo From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 15 09:08:06 2025 Received: (at 76955) by debbugs.gnu.org; 15 Mar 2025 13:08:07 +0000 Received: from localhost ([127.0.0.1]:39777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttRFG-0001ND-FA for submit@debbugs.gnu.org; Sat, 15 Mar 2025 09:08:06 -0400 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]:54645) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ttRFE-0001Le-6Q for 76955@debbugs.gnu.org; Sat, 15 Mar 2025 09:08:05 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id EC53B42DF9; Sat, 15 Mar 2025 13:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1742044076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z1PnAFkCdhJ4eRw3TN95oQOQi+y1m8U/PsaHLyLDoR8=; b=QJrEiJ+847r/UNcQzZNUAPEG8xjiiWXgHGoluXQQ+n4kOlyq9kWXUIeGBEgP6SEjtU0ucN EF8AAkYF0+3MBN635ovc7peWv/y5gGeNoLxX2rCQkRgQb6q0ydjMqoWVlrmmSHPvcoOp9c uIknazoFoN/+Yq3vxjqcpzYqmLjybxYMK7U2GJwj+gU9T17W0AN3JlGOf159uhfB2dtppb S9nRusWXPuBzdBY8v/mwo2RcmCRceOlpaa20baG269UMMjw/Nrs3xpBtI+GyobPtiHPB2M RNLGRYJkpTSuN4a7cQfZ/sX4V7tunZ70tt0Lz8tQQgVOZq7ky0JrNuUEika0EA== From: Morgan Willcock To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <86msdmwkcy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Mar 2025 14:26:21 +0200") References: <87frjj2uta.fsf@ice9.digital> <87ldt8ddxs.fsf@ice9.digital> <86ikoc20j5.fsf@gnu.org> <26898875.1r3eYUQgxm@fedora> <86tt7uy8j1.fsf@gnu.org> <87a59mh7xv.fsf@ice9.digital> <86msdmwkcy.fsf@gnu.org> Date: Sat, 15 Mar 2025 13:07:54 +0000 Message-ID: <878qp6phlh.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddufeefkedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefoohhrghgrnhcuhghilhhltghotghkuceomhhorhhgrghnsehitggvledrughighhithgrlheqnecuggftrfgrthhtvghrnhepueduvdeguefgvdeuudekleejhfethfekgeefveejffdvheffkeduvddugefgjeeinecukfhppeektddrgeegrddvfedtrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeektddrgeegrddvfedtrdekvddphhgvlhhopegshedtrdhnohhtlhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmohhrghgrnhesihgtvgelrdguihhgihhtrghlpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepjeeileehheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehvrdhpuhhpihhllhhosehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Morgan Willcock >> Cc: Vincenzo Pupillo , 76955@debbugs.gnu.org >> Date: Sat, 15 Mar 2025 11:03:40 +0000 >> >> Eli Zaretskii writes: >> >> > So I conclude that expecting "php" to be on PATH on remote systems is >> > a requirement, since nothing else will work reliably enough, and let's >> > close this discussion at that. >> >> I am not sure what you mean by "reliably", but being on PATH is not a >> requirement to use it. It will very likely be on PATH, but with some >> additional configuration of the TRAMP connection it doesn't need to be. > > I mean that we should use executable-find for remote directories, > thus assuming that the program is on PATH on remote systems, and let > users customize the local value via the user option. I think this introduces an additional complication if executable-find finds a binary which is not the one that should be used. > IOW, the user option should not have effect on remote invocations. >From my perspective as a user of mode, just setting the value to "php" introduces no additional complexity, works in more places by default than the current value, and doesn't deviate from how other modes (and associated executable paths) are managed. I feel we should probably get input from TRAMP maintainers at this point - I don't think I can add much more context beyond what I've already written and I don't want to keep repeating the same points. -- Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 15 09:18:42 2025 Received: (at 76955) by debbugs.gnu.org; 15 Mar 2025 13:18:42 +0000 Received: from localhost ([127.0.0.1]:39844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttRPV-0001ud-6G for submit@debbugs.gnu.org; Sat, 15 Mar 2025 09:18:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59520) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ttRPN-0001u9-CX for 76955@debbugs.gnu.org; Sat, 15 Mar 2025 09:18:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ttRPH-0004j9-2r; Sat, 15 Mar 2025 09:18:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rapNVGUlm/FoJ4KLVS2yhHn8esvFdKp1uWBMhjtPELw=; b=XiGPlUlRepxl +rMIg3+JUJNKVBK6107fL1ZF7GmOfs82NPbM0DZAEiK3IrAnzCF7EKk+/vxRqg37A9f48VsrIZEub IdcfmwNx4mBf3W3ttcIxZGgEtpu0F6d6IO83wB1FuSltjXGK/B15gW+OijI+RS6ezPtZVBfizKFRb XTQTTkg9WBvma/kbkyOjA2O3Q5tdvY5Mxg9MGNw0B9zFUWLXCKfcKMvZu7ExQ/6sr+5PVfuWbaAYl 46y8byHWtgHu4lV4KqxUtqoIzYSTlbYmb8B5v6rKI8afJ5FADNKvt2bEf9HpWyZ2jUnqn2PKFjaMH a/mCcfeFMzNrxPUl0pjfvQ==; Date: Sat, 15 Mar 2025 15:18:25 +0200 Message-Id: <86a59mwhy6.fsf@gnu.org> From: Eli Zaretskii To: Morgan Willcock In-Reply-To: <878qp6phlh.fsf@ice9.digital> (message from Morgan Willcock on Sat, 15 Mar 2025 13:07:54 +0000) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <87ldt8ddxs.fsf@ice9.digital> <86ikoc20j5.fsf@gnu.org> <26898875.1r3eYUQgxm@fedora> <86tt7uy8j1.fsf@gnu.org> <87a59mh7xv.fsf@ice9.digital> <86msdmwkcy.fsf@gnu.org> <878qp6phlh.fsf@ice9.digital> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Willcock > Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org > Date: Sat, 15 Mar 2025 13:07:54 +0000 > > Eli Zaretskii writes: > > >> From: Morgan Willcock > >> Cc: Vincenzo Pupillo , 76955@debbugs.gnu.org > >> Date: Sat, 15 Mar 2025 11:03:40 +0000 > >> > >> Eli Zaretskii writes: > >> > >> > So I conclude that expecting "php" to be on PATH on remote systems is > >> > a requirement, since nothing else will work reliably enough, and let's > >> > close this discussion at that. > >> > >> I am not sure what you mean by "reliably", but being on PATH is not a > >> requirement to use it. It will very likely be on PATH, but with some > >> additional configuration of the TRAMP connection it doesn't need to be. > > > > I mean that we should use executable-find for remote directories, > > thus assuming that the program is on PATH on remote systems, and let > > users customize the local value via the user option. > > I think this introduces an additional complication if executable-find > finds a binary which is not the one that should be used. > > > IOW, the user option should not have effect on remote invocations. > > >From my perspective as a user of mode, just setting the value to "php" > introduces no additional complexity, works in more places by default > than the current value, and doesn't deviate from how other modes (and > associated executable paths) are managed. My suggestion will still work in your case, no? The advantage is that it will also work in other cases, when the user option is customized to name a local version of the php executable. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 15 11:04:13 2025 Received: (at 76955) by debbugs.gnu.org; 15 Mar 2025 15:04:14 +0000 Received: from localhost ([127.0.0.1]:43104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttT3d-0005Os-As for submit@debbugs.gnu.org; Sat, 15 Mar 2025 11:04:13 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:43999) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ttT3Y-0005OE-Ak for 76955@debbugs.gnu.org; Sat, 15 Mar 2025 11:04:10 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 92B9120454; Sat, 15 Mar 2025 15:03:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1742051041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4i6X39rMoIXg+VUNIjcMgzsnwM3d2Ci2OCpMWxsXHKs=; b=ZdFniLnXuAr4Dtoo3z8xGTeFSAxvsyl+Q9ByVW4cn5S0oRprGE2S3XUroc8x/06qTB2hPB BoSQ9r4UTuYDO5K+2UKVoL428hus7bC81jaY+8NNg2EOeJJvETkwqGPB67P7EitN0nSl8+ LYUUVuMKwrmPV/ZFjX/glK2cAsEYQnI3WKARMQKnm20Brei65v91Lg/f5hZmccGKFegLfH Q2LunMSohIi33vUJltt3WNP2sPWWLdkoZYSIqQLthPa7D4BirabbRJtguHYY1NO1jZQUVh /cnq4MljpT2NN5kdBA4etZNFc3Xi33qPlELo3PiGSWVXbByebgEKAJZB0uF58w== From: Morgan Willcock To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <86a59mwhy6.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Mar 2025 15:18:25 +0200") References: <87frjj2uta.fsf@ice9.digital> <87ldt8ddxs.fsf@ice9.digital> <86ikoc20j5.fsf@gnu.org> <26898875.1r3eYUQgxm@fedora> <86tt7uy8j1.fsf@gnu.org> <87a59mh7xv.fsf@ice9.digital> <86msdmwkcy.fsf@gnu.org> <878qp6phlh.fsf@ice9.digital> <86a59mwhy6.fsf@gnu.org> Date: Sat, 15 Mar 2025 15:03:57 +0000 Message-ID: <874izupc82.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddufeegtdefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefoohhrghgrnhcuhghilhhltghotghkuceomhhorhhgrghnsehitggvledrughighhithgrlheqnecuggftrfgrthhtvghrnhepueduvdeguefgvdeuudekleejhfethfekgeefveejffdvheffkeduvddugefgjeeinecukfhppeektddrgeegrddvfedtrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeektddrgeegrddvfedtrdekvddphhgvlhhopegshedtrdhnohhtlhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmohhrghgrnhesihgtvgelrdguihhgihhtrghlpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepjeeileehheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehvrdhpuhhpihhllhhosehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Morgan Willcock >> Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org >> Date: Sat, 15 Mar 2025 13:07:54 +0000 >> >> Eli Zaretskii writes: >> >> >> From: Morgan Willcock >> >> Cc: Vincenzo Pupillo , 76955@debbugs.gnu.org >> >> Date: Sat, 15 Mar 2025 11:03:40 +0000 >> >> >> >> Eli Zaretskii writes: >> >> >> >> > So I conclude that expecting "php" to be on PATH on remote systems is >> >> > a requirement, since nothing else will work reliably enough, and let's >> >> > close this discussion at that. >> >> >> >> I am not sure what you mean by "reliably", but being on PATH is not a >> >> requirement to use it. It will very likely be on PATH, but with some >> >> additional configuration of the TRAMP connection it doesn't need to be. >> > >> > I mean that we should use executable-find for remote directories, >> > thus assuming that the program is on PATH on remote systems, and let >> > users customize the local value via the user option. >> >> I think this introduces an additional complication if executable-find >> finds a binary which is not the one that should be used. >> >> > IOW, the user option should not have effect on remote invocations. >> >> >From my perspective as a user of mode, just setting the value to "php" >> introduces no additional complexity, works in more places by default >> than the current value, and doesn't deviate from how other modes (and >> associated executable paths) are managed. > > My suggestion will still work in your case, no? It would work in my particular case, but it also means that someone who installed their own executable at "~/bin/php" on both the local and remote systems, and then customised the value to "~/bin/php", would now have a new class of problem on the remote system. > The advantage is that it will also work in other cases, when the user > option is customized to name a local version of the php executable. These same issues exist with LSP server binaries for Eglot and linter executables for Flymake; the defaults assume they are on PATH, but there is also the possibility that someone has had to get the required binary themselves, without installing it system-wide, and the TRAMP settings for the connection are what allows the search to be steered to the correct place. I don't think it is feasible to begin a precedent that any code which attempts to run an executable should now explicitly check whether the system is remote and assume that it knows better than the user's configuration. I don't know the codebase well enough to declare that there are no other instances of this happening, but I can show a similar problem: (setq find-program "c:/ezwinports/bin/find.exe") Having set this value, I have now broken the ability to use find on any remote system where this path doesn't exist. When it breaks the remote usage I know exactly why and I know that I need to manage things differently, taking into account the local environment and the environment provided by the TRAMP connection. I would not assume that all code referencing find-program needs to start overriding its value if default-directory is classed as being remote. (I appreciate that "-program" may signal that this value is intended to be the executable name rather than a complete path, but the semantics of the problem are the same.) That said, I do not claim to be TRAMP expert, I just use it. A TRAMP maintainer is probably better positioned to clarify the preferable way to configure paths to executables so they work locally and remotely. -- Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 15 12:09:23 2025 Received: (at 76955) by debbugs.gnu.org; 15 Mar 2025 16:09:23 +0000 Received: from localhost ([127.0.0.1]:43275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttU4g-00050g-WB for submit@debbugs.gnu.org; Sat, 15 Mar 2025 12:09:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53012) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ttU4f-00050L-2s for 76955@debbugs.gnu.org; Sat, 15 Mar 2025 12:09:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ttU4X-0007xn-LQ; Sat, 15 Mar 2025 12:09:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6BInt32L65gJQjoP+RK4BqJ7dcvzbclGz1+1362HOJ0=; b=Va44Akyah7Ue HdK9COPpc0K9F0kZP7wus+cCT0Qc26VjD8VghRjcg0HViRxRyehUlI1D16yuO9lbPt02SNXNfjfUg IqsAxawunjhz/VEf0QnkkOK3gZQY88TsXaRbv9+fMCkoS2FbEWprc/deoxoDKmGHGshg2c6N8guJD rH2sc+Nw8ic1GDR6eyLWEo3ngLy5YfxdnA0+laulL8U1sIzCf5RxZfjyYHnADqa7R/+XWCSdKsZpH aAlBmvBOLUcYpfVzRxjgU0Dg2iYhqE/b8NeEY3aGsq/tIfCyE7cZ0VT/PKJFKVTlLwgAgsE86S6Gq kI2B7CyPkanbMW7kRVjEVg==; Date: Sat, 15 Mar 2025 18:09:10 +0200 Message-Id: <86zfhmuvh5.fsf@gnu.org> From: Eli Zaretskii To: Morgan Willcock In-Reply-To: <874izupc82.fsf@ice9.digital> (message from Morgan Willcock on Sat, 15 Mar 2025 15:03:57 +0000) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <87ldt8ddxs.fsf@ice9.digital> <86ikoc20j5.fsf@gnu.org> <26898875.1r3eYUQgxm@fedora> <86tt7uy8j1.fsf@gnu.org> <87a59mh7xv.fsf@ice9.digital> <86msdmwkcy.fsf@gnu.org> <878qp6phlh.fsf@ice9.digital> <86a59mwhy6.fsf@gnu.org> <874izupc82.fsf@ice9.digital> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Willcock > Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org > Date: Sat, 15 Mar 2025 15:03:57 +0000 > > Eli Zaretskii writes: > > >> >From my perspective as a user of mode, just setting the value to "php" > >> introduces no additional complexity, works in more places by default > >> than the current value, and doesn't deviate from how other modes (and > >> associated executable paths) are managed. > > > > My suggestion will still work in your case, no? > > It would work in my particular case, but it also means that someone who > installed their own executable at "~/bin/php" on both the local and > remote systems, and then customised the value to "~/bin/php", would now > have a new class of problem on the remote system. Customizing the variable to "~/bin/php" will only work if it is correct for _all_ the remote systems, as you yourself pointed out. Which is unlikely to happen. And adding "~/bin" to PATH to fix this particular case is a no-brainer. So I still insist that my proposal is better than just changing the default value to "php". > I don't think it is feasible to begin a precedent that any code which > attempts to run an executable should now explicitly check whether the > system is remote and assume that it knows better than the user's > configuration. I don't know the codebase well enough to declare that > there are no other instances of this happening, but I can show a similar > problem: > > (setq find-program "c:/ezwinports/bin/find.exe") If you do that, you are using those ports contrary to my suggestions, which is to have a Posix-style tree with bin/, share/, etc. subdirectories, add the bin/ subdirectory to PATH, and unzip all the ports into the same tree. That way, everything works seamlessly and without problems. > Having set this value, I have now broken the ability to use find on any > remote system where this path doesn't exist. The difference between Find and "php" is that the former is used by several Emacs packages, and is a general-purpose program that should be easily found on any system. By contrast, "php" is used only by this mode, and so the possibility for it to be not on PATH is higher. But if it _is_ on PATH, then customizing the value to just "php" will get users what they will have if we change the default to just "php". > That said, I do not claim to be TRAMP expert, I just use it. A TRAMP > maintainer is probably better positioned to clarify the preferable way > to configure paths to executables so they work locally and remotely. Then let's stop arguing and install the change. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 15 12:51:27 2025 Received: (at 76955) by debbugs.gnu.org; 15 Mar 2025 16:51:27 +0000 Received: from localhost ([127.0.0.1]:43344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttUjP-00032p-36 for submit@debbugs.gnu.org; Sat, 15 Mar 2025 12:51:27 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:41005) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ttUjM-00032R-35 for 76955@debbugs.gnu.org; Sat, 15 Mar 2025 12:51:24 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 41E6B432E9; Sat, 15 Mar 2025 16:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1742057477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tm9zMNS+/jK3FXhNQxlCQ26I2P1PGtngYrJWUTK0ohA=; b=QGM32Nnvkdx1ttCgjeolZb5Zf7TrVoornGflBfeetcRLcFULhgT6aaV13Qbzz0R8JM7Np3 roP3Lz5IjHJYc+D0Qd6UUfxGRE8DiRM9yyT8s4HbamEWcpKfXdhij48MUFUT/21nK1GEln 9NNh69unw5z576G6QptSpc3kd5JFoXUz4ULQIazcOSDoEf8JeY4c7R1XQiU8tARVR87r0y GoHpZHGDUEHKNhmW91Hs3mSWm4DMvohofaG699mXKlh2P+F4doiz5vmMlS21wQFv7rx1jE h7/Jv80tbr1KefPBCHclBf65qAs3cgbb7l5CsurbES6tXF5PR/8p79ADuBHS/A== From: Morgan Willcock To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <86zfhmuvh5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Mar 2025 18:09:10 +0200") References: <87frjj2uta.fsf@ice9.digital> <87ldt8ddxs.fsf@ice9.digital> <86ikoc20j5.fsf@gnu.org> <26898875.1r3eYUQgxm@fedora> <86tt7uy8j1.fsf@gnu.org> <87a59mh7xv.fsf@ice9.digital> <86msdmwkcy.fsf@gnu.org> <878qp6phlh.fsf@ice9.digital> <86a59mwhy6.fsf@gnu.org> <874izupc82.fsf@ice9.digital> <86zfhmuvh5.fsf@gnu.org> Date: Sat, 15 Mar 2025 16:51:15 +0000 Message-ID: <87tt7unsos.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddufeegvdehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefoohhrghgrnhcuhghilhhltghotghkuceomhhorhhgrghnsehitggvledrughighhithgrlheqnecuggftrfgrthhtvghrnhepueduvdeguefgvdeuudekleejhfethfekgeefveejffdvheffkeduvddugefgjeeinecukfhppeektddrgeegrddvfedtrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeektddrgeegrddvfedtrdekvddphhgvlhhopegshedtrdhnohhtlhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmohhrghgrnhesihgtvgelrdguihhgihhtrghlpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepjeeileehheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehvrdhpuhhpihhllhhosehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> > My suggestion will still work in your case, no? >> >> It would work in my particular case, but it also means that someone who >> installed their own executable at "~/bin/php" on both the local and >> remote systems, and then customised the value to "~/bin/php", would now >> have a new class of problem on the remote system. > > Customizing the variable to "~/bin/php" will only work if it is > correct for _all_ the remote systems, as you yourself pointed out. > Which is unlikely to happen. I am pointing out an example of user controlled paths which have been specifically configured to match, which is not the original problem that I was pointing out. > And adding "~/bin" to PATH to fix this particular case is a > no-brainer. It is not necessarily easy to add "~/bin" to PATH for the remote connection. > So I still insist that my proposal is better than just changing the > default value to "php". > Then let's stop arguing and install the change. I'm happy to leave the conversation at this point. -- Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 16 04:34:27 2025 Received: (at 76955) by debbugs.gnu.org; 16 Mar 2025 08:34:27 +0000 Received: from localhost ([127.0.0.1]:45309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttjRx-00008s-25 for submit@debbugs.gnu.org; Sun, 16 Mar 2025 04:34:27 -0400 Received: from mout.gmx.net ([212.227.15.18]:45037) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ttjRr-00007C-Tu for 76955@debbugs.gnu.org; Sun, 16 Mar 2025 04:34:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1742114052; x=1742718852; i=michael.albinus@gmx.de; bh=3Astbdp5hlCWnFK7UNhbiefaUuSvP/NGlnsxt9enuAw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=DBfBtpGrbTNLbVd/FCsnh1hT5i+96VktExdMVkl3H2BR2Ru0sAIe3bKviLiqmaEc rCbCt+BOwLuCs/7CnzoZBijxbLIqNlVdktbulc96omv48heBWARHh0llBaKe+GdXi BTnoLq58AMn0qMdZ+4SkB3pqYvir71aGZWQILmhnrbq7C81TXex8CtOprekAb9VoW HbPxncRKjukxrnWsNXuMqvB6u9n+FKsXt/9UO9esvRLujT3GMjSmyARsondeee7iY sR1lhvMHG/Bz+1XN3hCGNJlCAllYrxNCfP03ufDJBqyFXz/iGIJuqT5ti7If0JSkC oFA+TiSFEzMw08OrzQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.37.59]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M6Db0-1trXau17Sy-001NoA; Sun, 16 Mar 2025 09:34:12 +0100 From: Michael Albinus To: Morgan Willcock Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <874izupc82.fsf@ice9.digital> References: <87frjj2uta.fsf@ice9.digital> <87ldt8ddxs.fsf@ice9.digital> <86ikoc20j5.fsf@gnu.org> <26898875.1r3eYUQgxm@fedora> <86tt7uy8j1.fsf@gnu.org> <87a59mh7xv.fsf@ice9.digital> <86msdmwkcy.fsf@gnu.org> <878qp6phlh.fsf@ice9.digital> <86a59mwhy6.fsf@gnu.org> <874izupc82.fsf@ice9.digital> Date: Sun, 16 Mar 2025 09:34:09 +0100 Message-ID: <871puxwf0e.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:EHt/JRrP7JF/eEMzF4uEkYfH1EneZst2/BIItxsPw/9kCHpQjBk 0EqFoeBDNgRGjb7RR9sthtnTOYY2Q+L6vn128jBF+wZRwbEVXCHfQh1ZfskOGYrCE41til5 3O6GMiLccwEtJzZAG9wtPQ0IA719iWFjLYZjOOqU6zVI1OT0xrumw+2GpOs3z3CyHj8Wc6E AAVTWCBR6WhVPVjS81bIQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:MZCURR5GtjY=;Tmf14B7AMTGrBbGCJYaYpOo/E34 9hcCiIUZQ4765UPhWyPM4OlNEIMnewaJfxG7AczZM9xKlPxJgRApsUVxNyUBqXS14lTX3Xiv0 s22cBVNu9fj3ORqFkAo3e4vyKDLVO3lL70/cGUGYYc9K4aLUKhgcxrQBsAzfkodqQj94BT88r 81Ci/OADiT2kt7Gu+5oAgSJRgs5tHX4O3LCoHFNl6xR4/nHpREpmv6eYlh0l4aMN8QBhOQkgZ rb9vIgMdMPEnM2W1aOV61GLXowfVDKnwWT6vzr3mv2xPLMGN99Lkyou/qWt0TOLp2x12NwUXb FTAua6iuAwY48vBHPE1sJkS0zBfY58mX8cBCerj0l3Q8S+fNd5FDl33ZeNGhWMz5HPhjxnUL3 pPAMObXq9GMN3XHlCbi0d5stj3n8yYine1HX6ruN3mV8c5mn9QzsIyP6z59QdRUXCNxXtIe8/ +sf0TllEQEhPw6I5SbJNOY49lsX2lP/kNKoadpmE/e8pRFx7pJJdyll6cP9QZ6Xi77tTU1cPj CqOjC/UX5AD1ovx4dJxbpVoDDzk4EtUxRqLQt9D6WVpe/pof/cutbf1pYNCbQ8tYctfgdToRx 4sqSsPe+5M+7sNmPEMTq7QTtxcooG1U124fKjNT1mhxmfCkZEzTR+RQSdMDa9WQkcNilF28Hf vyOgz48wNVL9lvlAPvlOo4Bj5mnm32leqdRQiGS6rF7pPiHXWx4fnLsxjBBh8e7DPsOZdbfWN yxq8btCWEv55rlv4rCG6cu4LX4P0X4WYhNRSND1EoA/nCy/mB5aZwqoprNBPqb+F1vKwGII3Y 9GZsfAIPO4FwtHE76554QCaSAo4uv9i7fBHy/mMwp5FNMXkKLuqRo1/zyq5P7YfpL7Qyn6HM+ wGntvKI3yTidpeURG0dM8fOgUq53opS/b/TYiwCruEHTjrFBGkb298ZzU/eGnrtPbvYjfhays MVNFm67LfhQmkfcoIkCcKth5adkDHTUnXWU9FDxPWErsru830gisPCBCQl1j09vfqvCfmvuHS bCIT5VqIYJyW9fo2IsSs+An8bXurB25eUg4tRIA1mQpCZQcG/PLaBWtwUn62UubXZFFhYFEk0 5/2uOLljimgBy5uPuhalgPxjq/KVLpSe0IGP3pvRb7D+IN7odHQ8Ztlg9Bou2eQt0IPYLf8RD 3lM/dLFUSrEo0136Bazm29miHCVvP38JdReGbN16FTPsUSsnbBq1CG3Hb1kGn6e26tlKDG7fG ApdtSojMFu67btD4/zwyis+mZ8t5B7OcLmYV/Z7Fah18lYWOxYRSnsTVsHKu8KiKPiQ/Z45Ra WeO6FRiHSFMQ3Vw6ec18tVFVVsxdaRwt++CFqtp30z2fEe00iUzncOlp2zxpBSkhi2aMO5uAP Q3P+ZCbhJrZBOUmvdHsYiRxNN5mRj837wzOumYxYMA+Q8p0RObASyCrnGZPksWZxhC/XRpPvW 57P6smg1SolexfO+DlaA+GuIlTSYmMskMy1UdBODzuym8r6Ax X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: Eli Zaretskii , v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Morgan Willcock writes: Hi, > That said, I do not claim to be TRAMP expert, I just use it. A TRAMP > maintainer is probably better positioned to clarify the preferable way > to configure paths to executables so they work locally and remotely. Tramp recommends to use (executable-find "php" 'remote) . This requires to set a proper PATH on the remote side. Experience tells, that likely, you will run into further problems if you haven't set the remote (and local) PATH accordingly. Users might apply hard-coded values, like "/exotic/path/php" or "php". This is what connection-local variables are good for. But a package should offer the proper way of setting. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 16 18:02:13 2025 Received: (at 76955) by debbugs.gnu.org; 16 Mar 2025 22:02:13 +0000 Received: from localhost ([127.0.0.1]:51085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ttw3g-0002F3-70 for submit@debbugs.gnu.org; Sun, 16 Mar 2025 18:02:13 -0400 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:56778) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ttw3c-0002DM-UJ for 76955@debbugs.gnu.org; Sun, 16 Mar 2025 18:02:10 -0400 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5e5dce099f4so4966115a12.1 for <76955@debbugs.gnu.org>; Sun, 16 Mar 2025 15:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742162522; x=1742767322; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=doejzcCBt7/FbNiQvMMQsm4HFAwBNyFGumRqkN4Dwx4=; b=S1426LJb8J+clPT/MHYDbQIgVe/w3ePyjbINwFA9U0RYPOijpHZqV/nZpuFS+Nl/Ii z+lb5+82RUINMYWau98BukcC0e4VFcmmhKORJNEFC6r8weo5Jepi4IzJ6thM0Z3I/xhM LiF+pgx5fA173qlJ6FQIhmJ2PxFw0IJpNT93G5ShXYji4xbecrxsVXf/3qZvV3qG2NnQ 4L45TbEg//cT0EDDD2XgT6EeQa1zcRHSxI+WffnXfUOU8kHxtxm4jjEgVbBVol9TMpuT 2qvgAlPQI3IIr+GrKZuM8Pmyc15MxCISmIGD3/6w84+qxz+1OI1rCbBwgngj1Deua5NI JMcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742162522; x=1742767322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=doejzcCBt7/FbNiQvMMQsm4HFAwBNyFGumRqkN4Dwx4=; b=BNKRp1ljmPgQBpJI4v1Ejguwu0LFiOpT/5oaHWwhFjSel2pQJ0jdNjLvb7cKZ9HwoZ d29U7XhgxvUr68ulzb61FOGGxpRdmRNNa9FCgF2YT9SlZHXOy1KUcQcPpbKZBADe1840 rMVHbU4LVVuZml7cBuR2Ag9xhZKFnuckPA2nb64vQsXA5cEU9HD2PQKIdha05TTmy6Zd 17K6kqITLILeAh1IVmrX9H2YlQnerNUD5/PT/ydd4bywOVemi5Nrr2mFCNnypY1cFKTG dO9LLzdsASLClZ9ar3OHnPXbsthz+FmRzHUD8PBlo/mxcGB4E32kDr5Q5SxlGx9AYFOQ UtqQ== X-Forwarded-Encrypted: i=1; AJvYcCXRjVJTdqM/ty1UEGzkcdcCfMQV7hVbmRH5CW+Pn7DgWeuDHlmns9vZ1bGWgWt5cBhamAts+w==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzh90jTfCvw57jEA0w0GsRJh1J2n+MXobaKef3GQ9V17pGXmBJM fFIjfd3TE48m8drts7Wy8VnQSIsQ50AxXhAWBXaNmfScvp85Q492 X-Gm-Gg: ASbGncuKVdlHUKNoSOg8ulOzEa2nLuLgBf5cTt/SUpttqK5vKgKskEBDgtdMzsM1iv5 0Fg9eC5KUIKQ8pImhA7GNiLWfzggV7jrcjYy5YQ+oo4VRNxgvmPnPOmP5HhatVxk0rS1nd0w/54 rY4qPIUa9CzUsUhdCLxgEJ8qO/WoqL6I6qKpt8dn9GnhWm3k/fMpJp79Nteuygge9E2X50MoICT qqJ2LitAaeoBrPObKW6oqcTD6PD1mgNoARe6DQVPd4DLMd70WKaafb64jnVydxpXVXMxRzYddF7 fDLWCRsFLoERNCg4Gc8xOZRkrouXqYnzAGEvjaziobtaTGv/v3qoRJ6tS7g4yE9oFhXaY5inL8N qegTMk9Qf X-Google-Smtp-Source: AGHT+IGy8fwc/t5ydLx9gBMtD02O3VC4Rg6ydGcrL2ZhDgs7eJA2uGaJQydVAtS/zoFSm0t2kN9zQA== X-Received: by 2002:a05:6402:518d:b0:5e5:bdfe:6c00 with SMTP id 4fb4d7f45d1cf-5e89fa52e16mr10009323a12.19.1742162521766; Sun, 16 Mar 2025 15:02:01 -0700 (PDT) Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e816974740sm4877671a12.26.2025.03.16.15.02.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Mar 2025 15:02:01 -0700 (PDT) From: Vincenzo Pupillo To: Morgan Willcock , Michael Albinus Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path Date: Sun, 16 Mar 2025 23:01:59 +0100 Message-ID: <2785973.lGaqSPkdTl@fedora> In-Reply-To: <871puxwf0e.fsf@gmx.de> References: <87frjj2uta.fsf@ice9.digital> <874izupc82.fsf@ice9.digital> <871puxwf0e.fsf@gmx.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: Eli Zaretskii , 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ciao Micheal,=20 I wrote this function based on what you wrote in your last email and what I= =20 read in the TRAMP documentation: (defun php-ts-mode--executable-find () (let ((php-prog (if (file-remote-p default-directory) (let* ((remote-path (when (boundp 'tramp-remote-path)=20 tramp-remote-path)) (own-path (when (boundp 'tramp-own-remote-path)=20 tramp-own-remote-path)) (exec-path (delete-dups=20 (append remote-path own-path exec-path)))) (executable-find "php" t)) php-ts-mode-php-executable))) php-prog)) Does this function make any sense? Vincenzo In data domenica 16 marzo 2025 09:34:09 Ora standard dell=E2=80=99Europa ce= ntrale,=20 Michael Albinus ha scritto: > Morgan Willcock writes: >=20 > Hi, >=20 > > That said, I do not claim to be TRAMP expert, I just use it. A TRAMP > > maintainer is probably better positioned to clarify the preferable way > > to configure paths to executables so they work locally and remotely. >=20 > Tramp recommends to use (executable-find "php" 'remote) . This requires > to set a proper PATH on the remote side. Experience tells, that likely, > you will run into further problems if you haven't set the remote (and > local) PATH accordingly. >=20 > Users might apply hard-coded values, like "/exotic/path/php" or > "php". This is what connection-local variables are good for. >=20 > But a package should offer the proper way of setting. >=20 > Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 17 04:06:57 2025 Received: (at 76955) by debbugs.gnu.org; 17 Mar 2025 08:06:58 +0000 Received: from localhost ([127.0.0.1]:54907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tu5Uv-0003k9-Iv for submit@debbugs.gnu.org; Mon, 17 Mar 2025 04:06:57 -0400 Received: from mout.gmx.net ([212.227.17.20]:37419) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tu5Ut-0003j3-45 for 76955@debbugs.gnu.org; Mon, 17 Mar 2025 04:06:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1742198802; x=1742803602; i=michael.albinus@gmx.de; bh=KLRRMRiqju/pfPRJRkGc1WFVpmnbGZaRydhM5ljCR4U=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=eFRwGvvVAMRJ62G6N27PY4LacTdgAXvTUMT0658jBNvlw1KioTOQe/IzoynWhA5F afpY5pCN9lz8Y4w1kES0XuhTvj9/T0ffHRjRHxiAUx+7yRe6XVIrh32gpoHi5kIts C/aC3BnRN6lWDIn1a6cNoXZjhxKkIZvDMZq5FPD65yz2EeYRpSaXPQNIssn5Z0k6j rjmb0/ZvSOHN43epS5qt7lX4lvfGSuaWCaIrKcd6ej3jvQ47qXjD8yCnp+Hl7bqLv sua0Uq/eQEVMN1Qe9Wmruufpoqs/4+Ca0cRmbegu9PSOPioqsyiYjA7LVX7BCSV1+ /H4zvxsot6Cb3aCfKQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.37.59]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M5wPb-1tr2YT0WN9-00Et16; Mon, 17 Mar 2025 09:06:42 +0100 From: Michael Albinus To: Vincenzo Pupillo Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <2785973.lGaqSPkdTl@fedora> References: <87frjj2uta.fsf@ice9.digital> <874izupc82.fsf@ice9.digital> <871puxwf0e.fsf@gmx.de> <2785973.lGaqSPkdTl@fedora> Date: Mon, 17 Mar 2025 09:06:40 +0100 Message-ID: <87jz8oulm7.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:wTgpRPdrP35fni3F9aKNLYz/oUgDRSZenooS3C/IgGX4dxY96GV MQUHpP/P6BQoRY909Gsb3aaA/N/eduux9l5TzATLVWaT2JfnDCOBv29CMyl2Te9HKkpl1fl A84tsiVkzvvd2ubudfOnJjns+I5eRYG121Ve2EaL03mP2RS8sJQkKkl7Sf0ycDyar2v/Qrh zyUTPMnoeQCFWTUO3oo+Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ocS6KgjCzxI=;ZRv89Z5WV144AH09QeJ+B8jmy5w iYnqqbrONO85WIiy8BMXye/2rM+CnfCM6oFzGhKW77t0yKhredTlga3TAsxeZEINtXBHre2si GFgAsIBFcTXBQfAvNlfhc80EP+6V8/OxV2j+vEyFRj8UNmP2FTOixWK9lkUNUHJ2JY6zBh1NW kU3WJ/FFOoGI6MnrKJzbORvnAK8kFjXTZIF3OsLUeb4tL8OROVn/6tGVrQ3RjEmJWIhr1GVim v5PHMct0i5t8Th2FO82ijJAF+fDMsgZzxAt++kwR3zjDpLUlV1s7BR623bx5ZvoLJDeD/sy55 6RTz9GLrKIFI7xOZQ4yi/wQVvb8pgDvpEDF8e08EAsKgeUXQNVgfD91gHWrzfto3QTx2OvEXw V+wtHm/TtRho+RHfpe398hGYaubcAlZvb6YU/KhfBiP435AZ9+g1pAHf/I1TqGs4T1OTpjS4W b5mrxOsqkS04ObcZ/vlf6IobO9Mc3d/ovGKA2nHEXi9w/lZ9zVWeKeUSeho2M9PuaAriDkJGU Y8ok6rpftPEQonua7G/zuahXD94xbhWBUYwXOgD9njs2NFvyKVqyniC9unxWpPmB9wbSQnl07 KiVZvIp2K/AQf+6PFQ7OQ5+Q3I7Ze+KqqWLICDyAPD341P0pEYmrypM2PRCfzVelzp3MjUbUr fq8KIyvAXr+uBraP5Sz+hE6YcedtR9orM5uBrES/dpS4wdFlTDaDsRGwMxHwILowfezS6fv9W f52668ichjBp4skMLD7b4xXnoh7sI8nm3oFDpDo3tzcN1SOuOmw31q+gE82sjQlYFKIkix+Fu xVCCwOB0nMZx1sVO+zS38XYDBQlnqbBMSjAq0WZbtzUZzQTnH5VaJ4KU9ya9hbTSU+DrKD/xB FcXCUntrP4WAeZCK5hZ5PWYw7P1ur4ehN6sfkv/ITxOR1wDk7CHnUR24klTkYb/xOrgflJGod 1hNqd9TqvfNtVmMUpZ23XHkFfWeJ75g8/LH/9xAOBW8B7WpM3jFVXRtZZEsFqr/9+TMj9uDhU v0IjbveNtLWOEbBTpfpeUMAXN3hzbgNxq6iylh5XJ36AfcgHs2Uw4uvhj1E251QY17Szh/mB3 UGQlzE/wXAcfe+oMTIZza8CCvqj6gnoXddFpegTbUgJsNBoIHD3ViEKfvNiI2pXJHJRD5t1Y4 0RKNH7yaJzcBhsYXdpxMJKUXs4L/31vymY391I0H+2UNfHa3FUhwsk3Gwk91IlHfssXnzIHmt IXSKWrhdsR2xYi+rUoMq5ANq/giCHtgAuXDpiDBAzvDWWPoJ6F7ZKCPtx4JHdDncYj7Mlc+fm pl770K9YuwO3KZTEUyg9jt1si0Ep2FhculwF8ZJRi3xdaqmLGuG/j2U0PPU+qo41o96kw19kF gVBNEXYLqR5dmm6qRj/w/dN2LnoUJjd3E4VQOdYosQ+qm2osIrAFpzj3wbFzFlPKK8zMnfbcr 2o6Ka08t9+D7j/YAp06SJ3/Yj1tM= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: Eli Zaretskii , 76955@debbugs.gnu.org, Morgan Willcock X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Vincenzo Pupillo writes: > Ciao Micheal, Hi Vincenzo, > I wrote this function based on what you wrote in your last email and wha= t I > read in the TRAMP documentation: > > (defun php-ts-mode--executable-find () > (let ((php-prog > (if (file-remote-p default-directory) > (let* ((remote-path (when (boundp 'tramp-remote-path) > tramp-remote-path)) > (own-path (when (boundp 'tramp-own-remote-path) > tramp-own-remote-path)) > (exec-path (delete-dups > (append remote-path own-path exec-path)))) > (executable-find "php" t)) > php-ts-mode-php-executable))) > php-prog)) > > Does this function make any sense? No. Tramp doesn't use exec-path when it runs executable-find remotely. tramp-own-remote-path is just a symbol, it doesn't carry any value. Changes in remote path must be applied prior establishing a remote connection. Etc pp ... Pls call just (executable-find "php" t) in your package, this works properly also for local default directory. Arranging for a proper (remote) PATH is the duty of the user. > Vincenzo Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 17 05:25:48 2025 Received: (at 76955) by debbugs.gnu.org; 17 Mar 2025 09:25:48 +0000 Received: from localhost ([127.0.0.1]:55542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tu6jD-0001dq-O4 for submit@debbugs.gnu.org; Mon, 17 Mar 2025 05:25:48 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:47596) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tu6j9-0001c6-OB for 76955@debbugs.gnu.org; Mon, 17 Mar 2025 05:25:45 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-43cf034d4abso21196795e9.3 for <76955@debbugs.gnu.org>; Mon, 17 Mar 2025 02:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742203537; x=1742808337; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=17VS+ZfMipVrOdcJrBxpKLL9Nn+CjcGnF3nPaahhDbQ=; b=TE23GesmTo5e+FxX6yiZYBQLf7PmbEDYI0bzcoUrczqxdEpFUbLIkLY3P49ILXImyx T5K5UbBvDKKZka7BnsyiiN6BYbkUe8JXIa6SsRTTe69gIFhiLl6Es+0AnBIEHjr7CBHZ +/pMUpM+dIAo97QsqID+znHgTy5g7uf/vrLFHvJLG31vpNfNjkb/J/Ixo5oaY/0HPz8l 5IDT6J61Su5HpG92/ZhR2hxc4wgzfXtsAXG/m/T+AhBLUXoWNPZFLBH1lyjWOqGqnAzC Bm2j1If0w9kMnoxGUAZQTUvUST862tdkLC0jS4hE59yJ74hEyMr1deuSEEgI5txRif2w DVeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742203537; x=1742808337; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=17VS+ZfMipVrOdcJrBxpKLL9Nn+CjcGnF3nPaahhDbQ=; b=ptzPwRwQp1Pe5+AVcAHaC9BZ5BIjATCPRJ8sACRvb9y5Fm0D4vKGxUUfAZPuWyccIP jB4VsEEV04OtzCzfK/q7mWPP2yo99Wp1DVaN2OqyunjuWwxrsdHZrTpQytwPuqsr6bUn PQDxgyhupfG7EjsC7rbOFzQIPjux9phJyDOoVcdIN46mS5c4cUnE5b6fgq7MQM2J+47Q igm/+neb2BSdTHtBbBqHzbQ2Lr6o0ATMAZSqTCzL4T+pIFpinKDC6BHmEFxcBioAaH4U IfcBXAnaWOWpCgEIapTZ1TbV16QgYyvklK1kqht2PSuYRmiw6PIWDzZpugQ/z4HaoNLA Z8MQ== X-Forwarded-Encrypted: i=1; AJvYcCUR4RjkHtwoUcX/34pRQOQc5eSCDxkzR2HyFjRW9dX/U8r6LaHZMaw+4ZCdvyAopPmcJ/fTxA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyyPQ2K6WfIIEqT37I1BldbLkwPfzzUYuWGYDyoJpZqH/jzx3am EcVFXUUd5sri/qpJBVOH/y0c07Q61LggnmefKuGhZY6NXMelHFcP X-Gm-Gg: ASbGncv1tJMxTnpBDE0SGa62sbfoFaOuHV4lmVgYSVyfj77dY2ik2av8lt4zVikEGoQ sv6h+U0YzY8auvOEyjxxPgGLJ6icXU0/tefyjfZmQ728hFIaTdB6MQdMNU+XAcAjAhNvzD+2j08 5uNOyaR3f+XHVh8VN4F1whlYqYdS18W4LRyfz2+r5zpG5mkD9G3k7G6ETRe65eEN3FCVhcNBGQ+ hoFvvveCpxYEcrSfdvYpBb1WNsG1OXlTuHdt1qt8LfmmEeIT7W/FzKYFzf0XbOrhbY6pCGByZFw TH/TZoJyTzRhDnOCWq0lh2SpqMdfRUo20Uhub33qVg4ZVR17PSVXiTqH+0TusqBWg3f47k/c8w= = X-Google-Smtp-Source: AGHT+IHpt7962j2mfdYp99KDS8IKtzOByVxYePlW0+mZhPs3jF1SQCCM2mp/2pErLGBV5/tpCm5vVw== X-Received: by 2002:a05:600c:46d1:b0:43c:eec7:eab7 with SMTP id 5b1f17b1804b1-43d1ec81224mr134439115e9.11.1742203537165; Mon, 17 Mar 2025 02:25:37 -0700 (PDT) Received: from 3-191.divsi.unimi.it (3-191.divsi.unimi.it. [159.149.3.191]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d33f5771dsm10851045e9.38.2025.03.17.02.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 02:25:36 -0700 (PDT) From: Vincenzo Pupillo To: Michael Albinus Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path Date: Mon, 17 Mar 2025 10:25:36 +0100 Message-ID: <4786210.vXUDI8C0e8@3-191.divsi.unimi.it> In-Reply-To: <87jz8oulm7.fsf@gmx.de> References: <87frjj2uta.fsf@ice9.digital> <2785973.lGaqSPkdTl@fedora> <87jz8oulm7.fsf@gmx.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: Eli Zaretskii , 76955@debbugs.gnu.org, Morgan Willcock X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ok, thank you Michael. V. In data luned=C3=AC 17 marzo 2025 09:06:40 Ora standard dell=E2=80=99Europa= centrale,=20 Michael Albinus ha scritto: > Vincenzo Pupillo writes: > > Ciao Micheal, >=20 > Hi Vincenzo, >=20 > > I wrote this function based on what you wrote in your last email and wh= at > > I > > read in the TRAMP documentation: > >=20 > > (defun php-ts-mode--executable-find () > >=20 > > (let ((php-prog > > =20 > > (if (file-remote-p default-directory) > > =20 > > (let* ((remote-path (when (boundp 'tramp-remote-path) > > =09 > > tramp-remote-path)) > > =09 > > (own-path (when (boundp 'tramp-own-remote-path) > > =09 > > tramp-own-remote-path)) > > =09 > > (exec-path (delete-dups > > =09 > > (append remote-path own-path exec-path)))) > > =09 > > (executable-find "php" t)) > > =20 > > php-ts-mode-php-executable))) > > =20 > > php-prog)) > >=20 > > Does this function make any sense? >=20 > No. Tramp doesn't use exec-path when it runs executable-find > remotely. tramp-own-remote-path is just a symbol, it doesn't carry any > value. Changes in remote path must be applied prior establishing a > remote connection. Etc pp ... >=20 > Pls call just (executable-find "php" t) in your package, this works > properly also for local default directory. Arranging for a proper > (remote) PATH is the duty of the user. >=20 > > Vincenzo >=20 > Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 17 17:27:49 2025 Received: (at 76955) by debbugs.gnu.org; 17 Mar 2025 21:27:49 +0000 Received: from localhost ([127.0.0.1]:33051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tuHzu-0004Zv-Sd for submit@debbugs.gnu.org; Mon, 17 Mar 2025 17:27:48 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:42176) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tuHzl-0004YZ-LW for 76955@debbugs.gnu.org; Mon, 17 Mar 2025 17:27:42 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-43d0359b1fcso17170425e9.0 for <76955@debbugs.gnu.org>; Mon, 17 Mar 2025 14:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742246851; x=1742851651; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JF2sb1Ztzk3EjUUSzNp0lM3meMQcHiM0WvniwKJXPcg=; b=c6cPUvlOHkSTplILrFMk4zLCax+Yz7VOtJwFyZ7Uq0rPNuGwVgmdDxNcnfX4CIzDAa Kkmb7C3gCDi2Fpe8BbpKWFXuyqkfaXrJvtVHX5wezpRAPPFgSMvzCqFeryOnaTkO1IBC iddMn72rU9A2EiOs7PkAC3y9kgsFP46R5Iv8NUCKW04i5A2J7jJjIuv30hi06MCBIIo5 opA+FE3V+02uZLHrxzXBmhNEE8jQn1rVZIZ+9lp1HTp/AMWJSe6N8kymsaUdmW1nsT0g jrUxzUQEPns6LHNJbtLAzOKhnMXO/xJiKq6e06Dg2KU3z+DMG89LsCBDdb6ODfkMPoJK 5phQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742246851; x=1742851651; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JF2sb1Ztzk3EjUUSzNp0lM3meMQcHiM0WvniwKJXPcg=; b=FCmQNOKwm1q3CzKhMxn8MIw+RwlKiM2L73xzjI5ol9hY10rLtR+wQxFZgo1vh4/Tq0 4VAkcHEQF6Nc6MBCkQ9Gh+O/TBL9IeAuWG80G2Wke41i4cuO8R6mCjNotLfL+m4S+IyP fq/utjrxKMZKiW3Tuz4n4pu2+xgkVttCNz3maaRQqPHkuBMviYLDGogTFMhNI0amIarp pJzcLwS3v6JeTT2SrBoXvdvXhGdYSBxiSvTI1mLDGbzCiiqdFAnwtFnsXD3KJDHrukYo Zsvyj696W0JACe0ibJMWdrFM7pJuFg4EA0WpYFsngijQQ5YW+VlHSJnC5GHMfz6S85PV Y8sw== X-Forwarded-Encrypted: i=1; AJvYcCUvevbB9xa+exhNFOaP1y3RK89mb4wqWr5JTs7temPNCGzq2oeLDybWEccFStJcaBJOjknAfg==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx6/FHR9Z1SUCi5MNssRJes4BoRQWD4YgLdmQpi350x5yPKSb5F 7TuFPlGo/c4Jdhc48SZaatcfHtrx5tjpFMbdtJz6ozH/OgCENuOkjuE+b27z X-Gm-Gg: ASbGncsv+8qhCM5mmg+T1TIYGMGZwV52STc9qhI8OrPe4p+K+kGKXQUyTxtZeRN+mRH TB0jJ/d0RQ5ePLrXPiydRstkJs+BZW2z1RVtryOrzwaysBKbQmwR6xm8MuVTQcLTGSTljXSv9y2 EnGrJzmCmq+5/f2vGHlYhhyePSU234eZ65qgZ0HF377A8pc0xE0Ce1VXXzC+oj4TeXvtDyZuccy /RVT5Sh69mUxtQvdq19ChgO+b9rjSthMKm2+w9+MUt7yGEbHTZVKBDfnOnptYQ+fKIn72JBKPmf EI2T8n4N+Hy3n25Zm4kstxkLqEw5prpy3RT62LTZ6WrSuXsp7EA/0y8RxMzGr2opeESH3mmvcHi fy3AWqlqIbVRVtItfXRA= X-Google-Smtp-Source: AGHT+IGT+I3eKCXYWcQquExq9I5te3j6jXwVwGZUyLHOa2Fcyjc6YFLB9ykoQZTiwA0ZZssOUkIdqg== X-Received: by 2002:a05:600c:4e0a:b0:43c:f3e1:a729 with SMTP id 5b1f17b1804b1-43d39385308mr6497255e9.12.1742246850945; Mon, 17 Mar 2025 14:27:30 -0700 (PDT) Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d28565b17sm80888615e9.37.2025.03.17.14.27.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 14:27:30 -0700 (PDT) From: Vincenzo Pupillo To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path Date: Mon, 17 Mar 2025 22:27:28 +0100 Message-ID: <2755270.vuYhMxLoTh@fedora> In-Reply-To: <86seng27yp.fsf@gnu.org> References: <87frjj2uta.fsf@ice9.digital> <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> <86seng27yp.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart4960019.OV4Wx5bFTl" Content-Transfer-Encoding: 7Bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --nextPart4960019.OV4Wx5bFTl Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Ciao Eli, this is the new patch.=20 I did not write anything to /etc/NEWS in this patch, there is no new 30.2=20 section. Do I need to create one? In data gioved=C3=AC 13 marzo 2025 17:47:42 Ora standard dell=E2=80=99Europ= a centrale, Eli=20 Zaretskii ha scritto: > > From: Vincenzo Pupillo > > Cc: morgan@ice9.digital, 76955@debbugs.gnu.org > > Date: Thu, 13 Mar 2025 17:28:41 +0100 > >=20 > > In data gioved=C3=AC 13 marzo 2025 15:25:57 Ora standard dell=E2=80=99E= uropa centrale, > > Eli>=20 > > Zaretskii ha scritto: > > > How about the following solution: > > > . we replace references to php-ts-mode-php-executable with a call to > > > =20 > > > a function > > > =20 > > > . that function will do something like > > > =20 > > > (let ((php-prog (if (file-remote-p default-directory) > > > =20 > > > (executable-find "php" t) > > > =20 > > > php-ts-mode-php-executable))) > > > =20 > > > php-prog) > > >=20 > > > WDYT? > >=20 > > Yes, that's fine. Maybe we should also rename > > 'php-ts-mode-php-executable', > > something like 'php-ts-mode-php-default-executable'. It seems to me that > > it > > might not be clear that this value would not be used if the file was > > remote. > Yes, good idea. Would you like to post a patch to that effect? --nextPart4960019.OV4Wx5bFTl Content-Disposition: attachment; filename="0001-PHP-should-be-in-the-PATH-either-locally-or-remotely.patch" Content-Transfer-Encoding: quoted-printable Content-Type: text/x-patch; charset="UTF-8"; name="0001-PHP-should-be-in-the-PATH-either-locally-or-remotely.patch" =46rom 4232862c660215dc27e729a32c42e260bc7936aa Mon Sep 17 00:00:00 2001 =46rom: Vincenzo Pupillo Date: Fri, 14 Mar 2025 21:11:22 +0100 Subject: [PATCH] PHP should be in the PATH, either locally or remotely. (bug#76242). MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * lisp/progmodes/php-ts-mode.el (php-ts-mode-php-default-executable): Renamed from 'php-ts-mode-php-executable'. (php-ts-mode--executable): New function that returns the absolute filename of the PHP executable, local or remote, based on 'default-directory'. (php-ts-mode--anchor-prev-sibling): Replaced 'when-let' with =E2=80=9Cwhen-let*.=E2=80=9D (php-ts-mode--indent-defun): Replaced 'when-let' with 'when-let*'. (php-ts-mode-run-php-webserver): Use the new function (php-ts-mode-php-default-executable). (run-php): Use the new function (php-ts-mode-php-default-executable). =2D-- lisp/progmodes/php-ts-mode.el | 43 ++++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/lisp/progmodes/php-ts-mode.el b/lisp/progmodes/php-ts-mode.el index 56c15dad36f..2ba04b09f06 100644 =2D-- a/lisp/progmodes/php-ts-mode.el +++ b/lisp/progmodes/php-ts-mode.el @@ -134,8 +134,8 @@ php-ts-mode-css-fontify-colors :type 'boolean :safe 'booleanp) =20 =2D(defcustom php-ts-mode-php-executable (or (executable-find "php") "/usr/= bin/php") =2D "The location of PHP executable." +(defcustom php-ts-mode-php-default-executable (or (executable-find "php") = "/usr/bin/php") + "The default PHP executable." :tag "PHP Executable" :version "30.1" :type 'file) @@ -270,7 +270,7 @@ php-ts-mode-flymake-php :noquery t :connection-type 'pipe :buffer (generate-new-buffer " *php-ts-mode-flymake*") =2D :command `(,php-ts-mode-php-executable + :command `(,(php-ts-mode--executable) "-l" "-d" "display_errors=3D0") :sentinel (lambda (proc _event) @@ -306,6 +306,16 @@ php-ts-mode-flymake-php =0C ;;; Utils =20 +(defun php-ts-mode--executable () + "Return the absolute filename of the php executable. +If the `default-directory' is remote, search on a remote host, +otherwise return `php-ts-mode-php-default-executable'." + (let ((php-prog + (if (file-remote-p default-directory) + (executable-find "php" t) + php-ts-mode-php-default-executable))) + php-prog)) + (defun php-ts-mode--get-indent-style () "Helper function to set indentation style. MODE can be `psr2', `pear', `drupal', `wordpress', `symfony', `zend'." @@ -595,7 +605,7 @@ php-ts-mode--anchor-prev-sibling =20 PARENT is NODE's parent, BOL is the beginning of non-whitespace characters of the current line." =2D (when-let ((prev-sibling + (when-let* ((prev-sibling (or (treesit-node-prev-sibling node t) (treesit-node-prev-sibling (treesit-node-first-child-for-pos parent bol) t) @@ -1236,7 +1246,7 @@ php-ts-mode--indent-defun "Indent the current top-level declaration syntactically. `treesit-defun-type-regexp' defines what constructs to indent." (interactive "*") =2D (when-let ((orig-point (point-marker)) + (when-let* ((orig-point (point-marker)) (node (treesit-defun-at-point))) (indent-region (treesit-node-start node) (treesit-node-end node)) @@ -1613,7 +1623,7 @@ php-ts-mode-run-php-webserver (message "Run PHP built-in web server with args %s into buffer %s" (string-join args " ") buf-name) =2D (apply #'make-comint name php-ts-mode-php-executable nil args)) + (apply #'make-comint name (php-ts-mode--executable) nil args)) (funcall (if (called-interactively-p 'interactive) #'display-buffer #'get-buff= er) buf-name))) @@ -1677,18 +1687,19 @@ run-php Optional CONFIG, if supplied, is the php.ini file to use." (interactive (when current-prefix-arg (list =2D (read-string "Run PHP: " php-ts-mode-php-executable) + (read-string "Run PHP: " (php-ts-mode--executable)) (expand-file-name (read-file-name "With config: " php-ts-mode-php-config)= )))) =2D (let ((buffer (get-buffer-create php-ts-mode-inferior-php-buffer)) =2D (cmd (or =2D cmd =2D php-ts-mode-php-executable =2D (read-string "Run PHP: " php-ts-mode-php-executable))) =2D (config (or =2D config =2D (and php-ts-mode-php-config =2D (expand-file-name php-ts-mode-php-config))))) + (let* ((php-prog (php-ts-mode--executable)) + (buffer (get-buffer-create php-ts-mode-inferior-php-buffer)) + (cmd (or + cmd + php-prog + (read-string "Run PHP: " php-prog))) + (config (or + config + (and php-ts-mode-php-config + (expand-file-name php-ts-mode-php-config))))) (unless (comint-check-proc buffer) (with-current-buffer buffer (inferior-php-ts-mode-startup cmd config) =2D-=20 2.48.1 --nextPart4960019.OV4Wx5bFTl-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 17 18:30:20 2025 Received: (at 76955) by debbugs.gnu.org; 17 Mar 2025 22:30:20 +0000 Received: from localhost ([127.0.0.1]:33171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tuIyQ-0003w2-2M for submit@debbugs.gnu.org; Mon, 17 Mar 2025 18:30:20 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:60527) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tuIyK-0003t0-9j for 76955@debbugs.gnu.org; Mon, 17 Mar 2025 18:30:14 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id CC70543420; Mon, 17 Mar 2025 22:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1742250605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4acxeJCa8GfhKhLnZSRvBM8sdtT/w+Qcadpc9EvWoKc=; b=iqWSg6QcSlkf2Yo6M1TmLlL0AITtx2ta2nr6E3MAa9rWm31QEoBjxKHW1Zf97eh3k7A8Uj SclKv5zM//Us289mo6uqVkimzhW0hI2KCmgJfd8sUtLFl8k1qZlaIQ3PLV48cxTgjNftDR Jb8dc5IG9VCCZcwIthp66WCMMUc3rAak34T0VPSfSiQAA+fcSJpZOne8syt0qATsxxPuP7 17CSEWIBw2EgByH+KLVORBP98b1a6odcvR2UXz3a1sThe3WTBdTD5JUMVZaqRorjB0vrK6 ioVGmXm72w4BhIzyrwTTlS2lglk33bn0XysSDLPTwGmTeu4nnLNFT77ylBMiDw== From: Morgan Willcock To: Vincenzo Pupillo Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <2755270.vuYhMxLoTh@fedora> (Vincenzo Pupillo's message of "Mon, 17 Mar 2025 22:27:28 +0100") References: <87frjj2uta.fsf@ice9.digital> <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> <86seng27yp.fsf@gnu.org> <2755270.vuYhMxLoTh@fedora> Date: Mon, 17 Mar 2025 22:30:03 +0000 Message-ID: <87tt7rqoic.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddugedtjeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefoohhrghgrnhcuhghilhhltghotghkuceomhhorhhgrghnsehitggvledrughighhithgrlheqnecuggftrfgrthhtvghrnhepueduvdeguefgvdeuudekleejhfethfekgeefveejffdvheffkeduvddugefgjeeinecukfhppeektddrgeegrddvfedtrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeektddrgeegrddvfedtrdekvddphhgvlhhopegshedtrdhnohhtlhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmohhrghgrnhesihgtvgelrdguihhgihhtrghlpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepjeeileehheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehvrdhpuhhpihhllhhosehgmhgrihhlrdgtohhm X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: Eli Zaretskii , 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Vincenzo Pupillo writes: > Ciao Eli, this is the new patch. Hi Vincenzo, The php binaries which I use are installed with pkgsrc, which supports installing multiple versions of PHP, installed as bin/php${PHP_VERSION}. One of those versions would be available as bin/php. If I have two remote versions installed, and one of them is found by executable-find searching for "php", I cannot see how I would select the other version once the patch is applied. Shouldn't the search name "php" be configurable to allow the name to be overridden? Something like this: (executable-find php-program t) where php-program defaults to being "php". Thanks, Morgan -- Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 18 08:46:29 2025 Received: (at 76955) by debbugs.gnu.org; 18 Mar 2025 12:46:29 +0000 Received: from localhost ([127.0.0.1]:38344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tuWKy-0007hS-02 for submit@debbugs.gnu.org; Tue, 18 Mar 2025 08:46:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35564) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tuWKu-0007gE-Iz for 76955@debbugs.gnu.org; Tue, 18 Mar 2025 08:46:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuWKl-0003aL-Eu; Tue, 18 Mar 2025 08:46:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WeFNd9KRJmxHpTZz3Eem4L/Y0qXdVXwbowaleK+jY6g=; b=qhTL3NQFsV3Q P8O7AIhga9ZLeiHcXO3xdoErEzMgx7bPQZ27a6NcK4ZtRIxvejUCe2Zqb0qktIEHL9bFXB2qalkdn 2q8prB/9Z9mVwJpW5iPB/1NcBZ/dLm3hb1kW0zRmeQeML9nC6RRjTGfhe2RvUi0C9QoZBzviKIw1P GgNco1P0egIrUS3Mp7CnZugUft4IcTvr70c6tQNwsquYBcACma9/LMhs+/Y5KpQF/jmC2vB++9KNC yGVvjKrczzwWrVBWbjJrprWlzGMTXdqG9J/ZJ0+k8c+31FCRmcbjZ6oxaMYFXIVnMcv74X5ZxJ4Su FLU/PrabhTiMcwMUadkEeg==; Date: Tue, 18 Mar 2025 14:46:05 +0200 Message-Id: <86msdiqzg2.fsf@gnu.org> From: Eli Zaretskii To: Morgan Willcock In-Reply-To: <87tt7rqoic.fsf@ice9.digital> (message from Morgan Willcock on Mon, 17 Mar 2025 22:30:03 +0000) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> <86seng27yp.fsf@gnu.org> <2755270.vuYhMxLoTh@fedora> <87tt7rqoic.fsf@ice9.digital> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Willcock > Cc: Eli Zaretskii , 76955@debbugs.gnu.org > Date: Mon, 17 Mar 2025 22:30:03 +0000 > > Vincenzo Pupillo writes: > > > Ciao Eli, this is the new patch. > > Hi Vincenzo, > > The php binaries which I use are installed with pkgsrc, which supports > installing multiple versions of PHP, installed as bin/php${PHP_VERSION}. > One of those versions would be available as bin/php. > > If I have two remote versions installed, and one of them is found by > executable-find searching for "php", I cannot see how I would select the > other version once the patch is applied. How do you do this with the current version of php-ts-mode? > Shouldn't the search name "php" be configurable to allow the name to be > overridden? Something like this: > > (executable-find php-program t) > > where php-program defaults to being "php". It's possible to add this, but it would be a separate feature. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 18 12:01:13 2025 Received: (at 76955) by debbugs.gnu.org; 18 Mar 2025 16:01:13 +0000 Received: from localhost ([127.0.0.1]:42567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tuZNR-0000w4-50 for submit@debbugs.gnu.org; Tue, 18 Mar 2025 12:01:13 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:52383) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tuZNJ-0000tO-Mj for 76955@debbugs.gnu.org; Tue, 18 Mar 2025 12:01:10 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 2424F44414; Tue, 18 Mar 2025 16:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1742313659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8XqNySPy2lh+CBbsxq2pKA4dlhgNcAP8ufYI6H8hsd0=; b=hE0KA+ahi1PiBiQpSvz7K5iWwGN79a/E6dhcnJEW/Bc2OYOOGOmXzp4NMclLBDSWB4+0Hr niveX1lRTnwecN6eJ/5CvwSDZ+eYscf7waT52aMcLYnMJLUL+ViYGHBtr5fI7LD9BipRY1 wzVjL/KV3JyWZkwepOmv7Kxx1izxLwfOnIiJddekQ5oJNobLDppLhqZQ1MDrUfRlHuNGy+ D1LdP5BnONWxKtFilc6Xn+cJyEDwM4GsVmKYiQq/dspGoCAAPnG1PN61cHb8BzFkotkIEY tXGJPIA00ZZRFH009W4pdpxiHaGyLNLtfXWr6FAZ5/ENEQLOL4V45SPEKRM2qQ== From: Morgan Willcock To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <86msdiqzg2.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 18 Mar 2025 14:46:05 +0200") References: <87frjj2uta.fsf@ice9.digital> <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> <86seng27yp.fsf@gnu.org> <2755270.vuYhMxLoTh@fedora> <87tt7rqoic.fsf@ice9.digital> <86msdiqzg2.fsf@gnu.org> Date: Tue, 18 Mar 2025 16:00:57 +0000 Message-ID: <87bjtyba6e.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddugedvkeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefoohhrghgrnhcuhghilhhltghotghkuceomhhorhhgrghnsehitggvledrughighhithgrlheqnecuggftrfgrthhtvghrnhepueduvdeguefgvdeuudekleejhfethfekgeefveejffdvheffkeduvddugefgjeeinecukfhppeektddrgeegrddvfedtrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeektddrgeegrddvfedtrdekvddphhgvlhhopehmrggtmhhinhhirdhnohhtlhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmohhrghgrnhesihgtvgelrdguihhgihhtrghlpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepjeeileehheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehvrdhpuhhpihhllhhosehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Morgan Willcock >> Cc: Eli Zaretskii , 76955@debbugs.gnu.org >> Date: Mon, 17 Mar 2025 22:30:03 +0000 >> >> Vincenzo Pupillo writes: >> >> > Ciao Eli, this is the new patch. >> >> Hi Vincenzo, >> >> The php binaries which I use are installed with pkgsrc, which supports >> installing multiple versions of PHP, installed as bin/php${PHP_VERSION}. >> One of those versions would be available as bin/php. >> >> If I have two remote versions installed, and one of them is found by >> executable-find searching for "php", I cannot see how I would select the >> other version once the patch is applied. > > How do you do this with the current version of php-ts-mode? Since the value of php-ts-mode-php-executable is used locally and remotely, I just set the buffer local value to the correct name. (connection-local-set-profile-variables 'with-php84 '((php-ts-mode-php-executable . "php84"))) (connection-local-set-profiles '(:application tramp :machine "remotename") 'with-php84) >> Shouldn't the search name "php" be configurable to allow the name to be >> overridden? Something like this: >> >> (executable-find php-program t) >> >> where php-program defaults to being "php". > > It's possible to add this, but it would be a separate feature. The variable php-ts-mode-php-executable is effectively already providing this feature, but the suggested change appears to remove it. -- Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 18 12:59:00 2025 Received: (at 76955) by debbugs.gnu.org; 18 Mar 2025 16:59:00 +0000 Received: from localhost ([127.0.0.1]:42830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tuaHL-0000Tq-Mn for submit@debbugs.gnu.org; Tue, 18 Mar 2025 12:59:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57018) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tuaHI-0000Sb-5g for 76955@debbugs.gnu.org; Tue, 18 Mar 2025 12:58:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuaHC-0002wG-5T; Tue, 18 Mar 2025 12:58:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PWRG5UQytpRK1vnA9Ztj1krBZAWh14tFAv8nLKT+4KQ=; b=hPbXNzsdt78b PtbdOMD22GwA4xcT70rtNpQ9HV4xLDaBsBX4PHoT/3GWc03yM37Rys19+xDXQRlSPT9sxNbr2QFK8 GMd9BtD85T3plVLGrtq9jMIfJS/GO5PQryd8pJzpe+++qbve0kFSthECKMrsl0WszPyCLZOfp+o5J M/Y9kBxlEDkgu4AbYQxtVMFWSfsLv1F7z8CXD4r7aS/5QRKbPEvT42CTyrFrp6nsKzyzl0i6+u8bA RA+7xGVQRjHC+wpaJ+C7y5/1IxaAv+o44ehC7k6hu61lICdljzFUBCAjZa9VueiAiuFB4rMPXv6LN A6uNS0osbdE6JifNiUuN6A==; Date: Tue, 18 Mar 2025 18:58:18 +0200 Message-Id: <865xk6qnrp.fsf@gnu.org> From: Eli Zaretskii To: Morgan Willcock In-Reply-To: <87bjtyba6e.fsf@ice9.digital> (message from Morgan Willcock on Tue, 18 Mar 2025 16:00:57 +0000) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> <86seng27yp.fsf@gnu.org> <2755270.vuYhMxLoTh@fedora> <87tt7rqoic.fsf@ice9.digital> <86msdiqzg2.fsf@gnu.org> <87bjtyba6e.fsf@ice9.digital> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Willcock > Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org > Date: Tue, 18 Mar 2025 16:00:57 +0000 > > Eli Zaretskii writes: > > >> If I have two remote versions installed, and one of them is found by > >> executable-find searching for "php", I cannot see how I would select the > >> other version once the patch is applied. > > > > How do you do this with the current version of php-ts-mode? > > Since the value of php-ts-mode-php-executable is used locally and > remotely, I just set the buffer local value to the correct name. So each time you have a connection to a new host, you do this setting anew? > >> (executable-find php-program t) > >> > >> where php-program defaults to being "php". > > > > It's possible to add this, but it would be a separate feature. > > The variable php-ts-mode-php-executable is effectively already providing > this feature, but the suggested change appears to remove it. Yes, because this feature is not really provided, not in the general case, and we already agreed to stop arguing about it. So let's install the latest change, and then let's add the php-program option, which will make the support cleaner and more reliable. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 18 13:40:30 2025 Received: (at 76955) by debbugs.gnu.org; 18 Mar 2025 17:40:30 +0000 Received: from localhost ([127.0.0.1]:43031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tuavT-000660-Jk for submit@debbugs.gnu.org; Tue, 18 Mar 2025 13:40:29 -0400 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]:49389) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tuavN-00061q-UL for 76955@debbugs.gnu.org; Tue, 18 Mar 2025 13:40:24 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id BB621432FA; Tue, 18 Mar 2025 17:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1742319615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f/QC4pHQD8ss8bSS/Qev5Mn4GKucLBj9sy+5cJob8y8=; b=MWCeaUCvMuunZ8uTtpFqXlKQcLgu478FzShZTSE43ATHNryyvi/h/OtAHElJR5A4qcBFQR 0y3c9ijVgOcAeXS9FPIWBC12WyyRy6NRuLMx67yIInvmU3kd+F7Tt4HSzQdHjUBAed659B SZxvrDgpLvQ66RDCunbfDIVyvDCzxwzDA1FNtbVQHOw+BVDcJ8Jrq2YnUrvgOiNn5BWypJ uQgYs/jnm84/9t8C/6wwtwQmauN9QOlLoXLRdK2BqADdnlS5jy0PtkfrRQs0I60mV1gzMN uPIwdkxIAcTAoAOkmUoHYQAES4ZoZTMGBNraSwaeVVoxxQW/A5kpOrBgPvGRHQ== From: Morgan Willcock To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <865xk6qnrp.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 18 Mar 2025 18:58:18 +0200") References: <87frjj2uta.fsf@ice9.digital> <2022384.7Z3S40VBb9@3-191.divsi.unimi.it> <86seng27yp.fsf@gnu.org> <2755270.vuYhMxLoTh@fedora> <87tt7rqoic.fsf@ice9.digital> <86msdiqzg2.fsf@gnu.org> <87bjtyba6e.fsf@ice9.digital> <865xk6qnrp.fsf@gnu.org> Date: Tue, 18 Mar 2025 17:40:13 +0000 Message-ID: <87plie2q6a.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddugeeftdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefoohhrghgrnhcuhghilhhltghotghkuceomhhorhhgrghnsehitggvledrughighhithgrlheqnecuggftrfgrthhtvghrnhepueduvdeguefgvdeuudekleejhfethfekgeefveejffdvheffkeduvddugefgjeeinecukfhppeektddrgeegrddvfedtrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeektddrgeegrddvfedtrdekvddphhgvlhhopehmrggtmhhinhhirdhnohhtlhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmohhrghgrnhesihgtvgelrdguihhgihhtrghlpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepjeeileehheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehvrdhpuhhpihhllhhosehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Morgan Willcock >> Cc: v.pupillo@gmail.com, 76955@debbugs.gnu.org >> Date: Tue, 18 Mar 2025 16:00:57 +0000 >> >> Eli Zaretskii writes: >> >> >> If I have two remote versions installed, and one of them is found by >> >> executable-find searching for "php", I cannot see how I would select the >> >> other version once the patch is applied. >> > >> > How do you do this with the current version of php-ts-mode? >> >> Since the value of php-ts-mode-php-executable is used locally and >> remotely, I just set the buffer local value to the correct name. > > So each time you have a connection to a new host, you do this setting > anew? Yes, if it is a development host and I want the setting to persist. For this same environment, I have to configure the connection anyway to modify the value of tramp-remote-path, because the LSP server binary that I use is self-installed and will not be on PATH with the default TRAMP settings. I also use local PHP and LSP server binaries, which is why I don't just set the global value to what works remotely. -- Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 18 16:25:16 2025 Received: (at 76955) by debbugs.gnu.org; 18 Mar 2025 20:25:16 +0000 Received: from localhost ([127.0.0.1]:43476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tudUx-0007Ei-N0 for submit@debbugs.gnu.org; Tue, 18 Mar 2025 16:25:16 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:46516) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tudUt-00079P-QQ for 76955@debbugs.gnu.org; Tue, 18 Mar 2025 16:25:12 -0400 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5e5b6f3025dso8898462a12.1 for <76955@debbugs.gnu.org>; Tue, 18 Mar 2025 13:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742329505; x=1742934305; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zRup880tvtUxEUm8NQW31fnMrGAOsv9oi9q2VnN/kic=; b=YnEZhxht+jBmL7XRKfl5lzBu3iarPo9z5LmeuH2qjEjYkQrA4dPe3igPFACmEnjind NR6PHz0DN9a3wA5cUsT2kx6TLEOzQd9N6XN5ZX7wGoXLVeStoFJ8I32njw3MttF2uPJh z+2mjYzkwzWXK3JL0NoEOYi+eZ223dBIv/bqm+Md68UOPPkAu6g2xwAF2UfZBzZTIaTO +z4qnK/AHVx37LvtWvDI0UZDmSOGEa2Cqk8uHt23UmIPuVll5oEFRVcIlCf/LXWdHV/1 Je0NG/RTsuPrxFJVGbn9HpJ3e2RzXhKQghTNbi1KNsVs5O0SSBtSs3HTdHTzsJY+2fS8 0sWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742329505; x=1742934305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zRup880tvtUxEUm8NQW31fnMrGAOsv9oi9q2VnN/kic=; b=dWsCQbYHuv5kTogKlw6c9o5CnQ9E/kRZHmEjnG9ITnRkjcEALGb9U+CY8XUVsbbFk4 cD+8e3mA/sxeKHrDxUsVzC3mP+ypp/P/73Nsr3HDueX5UH0yVd1aWTMgZkNr02Lg1DZy Zad951STLJeFpsXubwqBlwT43e+kxSdwT8ztuHwfRhD3aR8/oneXbgGCzzRLo8nAxrZN sQnjArdJEt2Nm7/49ZUgElSYNRBJSGhUBp/UsLIlf83ETutqVJM5zgg0949oWgz1O+TD dlfq/hWcI6eiGGFiFsNaYJfcpfEF6aAGU9Z+lBxsr8FhsUkEdEXMnbr1SORSXsAzhgi+ bx7g== X-Gm-Message-State: AOJu0YxCCYmSluV+GHkPucw9VlqRTuR24ketDERo34oBspHP98RyPlRO zDv7RSDUXEvbM9YxGLF3MCQCUhl+Io2qKIPOvjzKBxd3NymD2yvm X-Gm-Gg: ASbGncvjS98xotOwMeSuQUsmF5BQxfHrXhAkjR60rDqSSFf+NOoD9UPPmvcZBK/hi5m 8GuBqBgvwrhmhIIndOPYwgydKFW56A8DhSlk9w+s67eNyFhJ9gQJFaehtiNQpstq5TT8WgG3qqk vzkI3URYBjew085gnXyrFhePssYf3ME7BdAAKAH9BN30FJdPaal9KlUW3iY9LTnqvBGCSWWPCdG 9bgG99S/rtZxbE0lxehlLTlKiuTl3HUHjO4XeSr9FhuZl6oN1wxzzthQo2B4EwjAkQ++ZYwC23T XpMMaABif5knMZmKPmnvC0oaP2WfVQM9WGDBzPYtZXvjL7waom+5t2LxpQUl2DvOOzXT6QLyLce h9WgvsQOx X-Google-Smtp-Source: AGHT+IGHqjqtZr1vvHvxlEd6Tr5sdPsD6lUdB/LouPtRygHdWfv88d3X7IHbYEc1Or56rgfTTZHVkg== X-Received: by 2002:a05:6402:1ed2:b0:5e7:97d1:e371 with SMTP id 4fb4d7f45d1cf-5eb80d199edmr90558a12.13.1742329505004; Tue, 18 Mar 2025 13:25:05 -0700 (PDT) Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e816ad3d1asm8063643a12.55.2025.03.18.13.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 13:25:04 -0700 (PDT) From: Vincenzo Pupillo To: Morgan Willcock , Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path Date: Tue, 18 Mar 2025 21:25:02 +0100 Message-ID: <26832585.1r3eYUQgxm@fedora> In-Reply-To: <86msdiqzg2.fsf@gnu.org> References: <87frjj2uta.fsf@ice9.digital> <87tt7rqoic.fsf@ice9.digital> <86msdiqzg2.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) In data marted=C3=AC 18 marzo 2025 13:46:05 Ora standard dell=E2=80=99Europ= a centrale, Eli=20 Zaretskii ha scritto: > > From: Morgan Willcock > > Cc: Eli Zaretskii , 76955@debbugs.gnu.org > > Date: Mon, 17 Mar 2025 22:30:03 +0000 > >=20 > > Vincenzo Pupillo writes: > > > Ciao Eli, this is the new patch. > >=20 > > Hi Vincenzo, > >=20 > > The php binaries which I use are installed with pkgsrc, which supports > > installing multiple versions of PHP, installed as bin/php${PHP_VERSION}. > > One of those versions would be available as bin/php. > >=20 > > If I have two remote versions installed, and one of them is found by > > executable-find searching for "php", I cannot see how I would select the > > other version once the patch is applied. >=20 > How do you do this with the current version of php-ts-mode? >=20 > > Shouldn't the search name "php" be configurable to allow the name to be > >=20 > > overridden? Something like this: > > (executable-find php-program t) > >=20 > > where php-program defaults to being "php". >=20 > It's possible to add this, but it would be a separate feature. My proposal is this: (defvar-local php-ts-mode-alternative-php-program-name nil "An alternative to the usual `php' program name. In non-nil, `php-ts-mode--executable' try to find this executable.") (defun php-ts-mode--executable () "Return the absolute filename of the `php' executable. If the `default-directory' is remote, search on a remote host, otherwise return `php-ts-mode-php-default-executable'. If `php-ts-mode-alternative-php-program-name' is non-nil, finds this program instead of the usual `php'." (let ((php-prog (if (file-remote-p default-directory) (executable-find (or php-ts-mode-alternative-php-program-name "php") t) (if php-ts-mode-alternative-php-program-name (executable-find php-ts-mode-alternative-php-program-name) php-ts-mode-php-default-executable)))) php-prog)) WDYT? Vincenzo From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 19 08:18:12 2025 Received: (at 76955) by debbugs.gnu.org; 19 Mar 2025 12:18:12 +0000 Received: from localhost ([127.0.0.1]:49200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tusNA-0001Ak-CS for submit@debbugs.gnu.org; Wed, 19 Mar 2025 08:18:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57174) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tusN6-0001AT-Vv for 76955@debbugs.gnu.org; Wed, 19 Mar 2025 08:18:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tusN0-0000pR-76; Wed, 19 Mar 2025 08:18:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uvE65LgzNBhO6i8lm3fPdOTKNFg+ERCqvULQ1N610Sw=; b=TpDIHVk+Oq1k uDGBZTeNkYpBrRpEE7H2VJPoteuMp+MOk4F1X1XOD5Ib5yDBDlXRQnCH9I7tsqKN1ncdXGHQz34NK Q/syNVQtyvEjR28QIdWXAH8TaEpXYzcIpoULO66eNyed1qDj9qypPN5ovBI3I+Vj5v+tehwh865Bq TWmyEhSckZns1QEc0vw2E7M8TFpPknJtay2DiKXFUAyASLueUayytwnIQjksyH5XwzFDfYUAxs5IU NQoVzgDil19prxYc+3SWVkS902omXqVMcSTtUFHZxI+OwZIZ4A0P4JHgtban05LPXDa/RyhjmuX/G w+rde6maZ5KvayfBXr74CQ==; Date: Wed, 19 Mar 2025 14:17:55 +0200 Message-Id: <86tt7pp630.fsf@gnu.org> From: Eli Zaretskii To: Vincenzo Pupillo , Michael Albinus In-Reply-To: <26832585.1r3eYUQgxm@fedora> (message from Vincenzo Pupillo on Tue, 18 Mar 2025 21:25:02 +0100) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <87tt7rqoic.fsf@ice9.digital> <86msdiqzg2.fsf@gnu.org> <26832585.1r3eYUQgxm@fedora> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955 Cc: 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Vincenzo Pupillo > Cc: 76955@debbugs.gnu.org > Date: Tue, 18 Mar 2025 21:25:02 +0100 > > (defvar-local php-ts-mode-alternative-php-program-name nil > "An alternative to the usual `php' program name. > In non-nil, `php-ts-mode--executable' try to find this executable.") > > (defun php-ts-mode--executable () > "Return the absolute filename of the `php' executable. > If the `default-directory' is remote, search on a remote host, otherwise > return `php-ts-mode-php-default-executable'. If > `php-ts-mode-alternative-php-program-name' is non-nil, finds this program > instead of the usual `php'." > (let ((php-prog > (if (file-remote-p default-directory) > (executable-find > (or php-ts-mode-alternative-php-program-name "php") t) > (if php-ts-mode-alternative-php-program-name > (executable-find > php-ts-mode-alternative-php-program-name) > php-ts-mode-php-default-executable)))) > php-prog)) > > WDYT? I think this is okay, but let's also ask Michael (CC'ed). Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 19 09:14:42 2025 Received: (at 76955) by debbugs.gnu.org; 19 Mar 2025 13:14:42 +0000 Received: from localhost ([127.0.0.1]:49504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tutFq-0006DL-6p for submit@debbugs.gnu.org; Wed, 19 Mar 2025 09:14:42 -0400 Received: from mout.gmx.net ([212.227.15.18]:53287) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tutFn-0006D5-1C for 76955@debbugs.gnu.org; Wed, 19 Mar 2025 09:14:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1742390071; x=1742994871; i=michael.albinus@gmx.de; bh=J/fpNKtYn1vBO0FfPdsW87+jdX/K1hveAoJhEAIfVDY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=opJQyLyxHwYr+j9tVEDp8v0NQ/wojc9cdnX78zo4lEM07sTrlj7PR9+/T975V0EW VajIGpVjGTY9sU8rDZL9NRWI4D9hR4Jy/Qr7UIavlOa9RQvl7fl6zv/dwyc0jlzks Y96MejDvzzxTinUh6jc54pgrUMM97W9eHfLqv4pKj0CwoB1zCZlYCRRKZvhZHXrV4 YJPm/1mfkS1PtHlHimjHsvTn/0RJh2iftsgvno5dn4rBvd5bPsP5YYUsTdrV/AjOg MGaTo3rv+IJ4eC4sWjnX3rraIqW6TdwZmjZbBwtWmk4dVT7B39dMFjndEulNGTzLh SwCiFC5r2VL5RiLI1Q== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.37.59]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MPXhA-1tYHvJ10QE-00Lp67; Wed, 19 Mar 2025 14:14:31 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <86tt7pp630.fsf@gnu.org> References: <87frjj2uta.fsf@ice9.digital> <87tt7rqoic.fsf@ice9.digital> <86msdiqzg2.fsf@gnu.org> <26832585.1r3eYUQgxm@fedora> <86tt7pp630.fsf@gnu.org> Date: Wed, 19 Mar 2025 14:14:30 +0100 Message-ID: <878qp188nd.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:jj9wHIZoAV99Cem4/K7bO0fbOM456G9Ecfeyidt7R/SaJwuKzxw Sj7YERuLHSFjG9Hv1A4Iw/T02yQcUtqH2xUbjnx1mRPGvlK+Z8I1bKyUgcmrRi8qenhqSum xhVdTXglTHcFcE2WAAFPNS+sbowCAUKbapn65HEMw6TetXmTl2mxMpCqy0TRqy3OctsheyA SOivtlkQA++cybMNDUqPQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:irtt7xo+qiU=;oI+WgkI89ivTP1ASzptyeUGwnYA 7Fy89pf68wf0xCzbjYMN9c8tpGt7SYVqjFU+35+p8kcfj+zhvSyoBQwZuhMYezTfluv3mY5RL U/ver0frsmZFdA/SF0IWpcGqpCtg6wyj/2J0W2bIDWYv+nTtPFkzJuX4rrnCn6Ko5kIs7gCrY /2qqQOIR67P6kQLP6yjFvYa6yGLDOj/U3kvmssBs2JTOzyg0dQhumppdTyrlKlXTiUzlaZ4fP 4DW3xBbpfhJSrvHrBUu5HWzdbsUBdEDPSiJF3JOMktYeIVTcZKFBf+Fw+uYe+oXh/KinEVCkX 6KntCEAobAE4DO/XzYb6jEr5FWc7W8F3t12DkuHICPx8OTSdEJi5UGgznPWP6EfBHzGsfbq/B KS+az6Fp+ew628jogtZxxdkqmT8UVF5BHr5v1RT6r63pN19CnZXvQb3AibZlDObUvJNjWBs92 AA9E65WeEHg9CeCsuxZ6/yRA1dYq3G2y332QsDwSdr2JFx1/0iYBR220Jx2hVTIpyDxRfThS+ BYLkQq8NnrJW4H7Geoxe14EW86Sp481GAsTWI8WjFmJeXUsUAmLpWRJZiyTu8Ikk+D//cxU5d 4JTTvD0GTyHfeYGMnVN7pvJQJMn2IAQGdMx+fNLSaK4ZwsadAUvP1oj3QUcml/1KDPwVFTLGl IylWxony4IEWO7P+lvC2nfaZUgd/79gZEtvqLO+17WWKYyLdgAcK/GhzFGIuxeKU6GVho0Z8y 3fNRS5Oynscd0cGb0wzqIQWcOYLBqwdOofRNViGahbXfPbZKND/xcoKgUFsAH6+0WkW8cMWge FUas5fsj3pPL/bYcI5M3HA+pGHOcztjMSSXD1JzC5si5X+duTMXXeQDVcp/NJoyyLKYef4wtK UuijkSrlITMH73KboSLq1rlhPV0PJ2lH7g2MPS6nq0GyjPSKmfV6LBrOLAWGIo3C7Eo6Zwvcj iseEVHnIaKfDeriGMA32ab1U6sbYbM3M6ATWLTCf6IL4TuZFcJzzBFZsasj1Pz0hUaJqXeW0b 2REuTXS5iXVMtEq0V6D5m2jjMerCqDfqgLjD1YlfQBbGkSKeTo3jjt+HFBFDL4OjhBy0iRIb7 BZ5iCqsAaL6viaT1cSxRa3YnYlbLFkNla4oraYeyqD6i+uokYgvpZ0zbS7R5ZBGoIwCyfN0wO WnJERlVmWklvG1fAJ8zIICIO9H3xtfVOXf9INbbMoy7xEajZeHYDxCpZxb6+OQ4a/gC9UcU2w Ai98/3aup0AYw7xbn00f6C11mXMGIAGhtDtkPJimvvmKOKudH89J3c+QXXY/GlO8nzTw3XYZ6 qqpfGfQ9f0PKVBqaSqcEDmb03kIbLZ5TwSJb6aPEGFTp6TA1wxxXpn3HHjtHMFxJsPANaaSGl BDhZ2W5uBeoK3AEcfDLMc/1pq/6qJKaGR6ctwftg2889lcwb+aQsJ9klbGfx2md7EL1v7Z/0g 0nvlTTwBwMXilWJrVdThF4jyLs5lwRQHus/sSBEsxAfjsElmr Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: Vincenzo Pupillo , 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi, >> (let ((php-prog >> (if (file-remote-p default-directory) >> (executable-find >> (or php-ts-mode-alternative-php-program-name "php") t) >> (if php-ts-mode-alternative-php-program-name >> (executable-find >> php-ts-mode-alternative-php-program-name) >> php-ts-mode-php-default-executable)))) >> php-prog)) >> >> WDYT? > > I think this is okay, but let's also ask Michael (CC'ed). The following should suffice: =2D-8<---------------cut here---------------start------------->8--- (or (executable-find (or php-ts-mode-alternative-php-program-name "php") t) php-ts-mode-php-default-executable) =2D-8<---------------cut here---------------end--------------->8--- executable-find works also on local default-directory with non-nil REMOTE. And you don't need the let-clause. > Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 19 13:14:34 2025 Received: (at 76955) by debbugs.gnu.org; 19 Mar 2025 17:14:34 +0000 Received: from localhost ([127.0.0.1]:52929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tuwzx-0006Gk-UI for submit@debbugs.gnu.org; Wed, 19 Mar 2025 13:14:34 -0400 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:57446) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tuwzv-0006GT-Fa for 76955@debbugs.gnu.org; Wed, 19 Mar 2025 13:14:32 -0400 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5e677f59438so11098459a12.2 for <76955@debbugs.gnu.org>; Wed, 19 Mar 2025 10:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742404465; x=1743009265; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gsk9z//Q4Qc6jKs3iOA09KLCCkBdwJGTKPLlS3jmiQI=; b=cXEbrbuQUCjuBY7wDQeqx+bI6wSZgwPcvr2yhDFchp2eiYX0zDhAb+1irwxBrxCywX 9p+9w3J3TLrOEF/CcIqrTI91n8sErOYp/SkENyJ9khJsXbJh2vgb1fR1O/QHVHHwqVNI r01SHCZ343XjxtBxudepgEWuCoTwhM+TdCSIJiX0/7cmFIydW2TTe0E+Kq3iDJhXQDDe /cIqlIrl1/aBlF0bxvaScSw6QqN+4wAAIZllXI1BorApl6eqjOOqHu4IKERiQ/hMCjlZ VX0tXC8bv2v7cCMSYf0c1S8BXhWyfkFB3bB3Mq9QgJTVjo4ZTim9lgvv93fibV5KC3ML MNQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742404465; x=1743009265; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gsk9z//Q4Qc6jKs3iOA09KLCCkBdwJGTKPLlS3jmiQI=; b=L/rt1iGdvwR5TjWmRXiczAV0mSawixwXBox4upW/h+EWYRDBzF4XftFqb9kI9XijuU Jdvn7N9KpWuxKvehuYIjVg5TTp9ErGqho/frMtB8mnS2x7j2rpANOwiYCvBolBjTAJdg 5ELBX1jHCvSP4jkUnKtinBptfvKzcTAOVw8LNiS2+NahCVHCg4XHfbZQEfdMfcdhdTO2 lrOYAD+jEb/DUPM3YZI1+L5w7lHiBd6QgQdhtJM/+LzwkNjXuts24E5Xtj6yuBSxbGRA OS/tTx2mLApbQNcMEJk+L/hZHN19XGkAhIjtWnmeuyqukoUlDTNNaxBoenHeBq3mh+A2 uFhA== X-Forwarded-Encrypted: i=1; AJvYcCX0V0D/PdH6Cf+WfEIPtf677QFtSPr7CJcojuxT0inf5A35S2OICf4M5oFi96GN8FscL5pO7g==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwWD495Vm2+Ws2pesnHOuWifLS4gSG3EIMdhze25NfQc3Taiw/x fQyME0JyFg6IzS6OtAvO54s23aMDH46XBfskHhl9XKKQ1SbMwHkJ X-Gm-Gg: ASbGncvE+zd//k0XTd0l+F/J3Ws3ZOllLA/1UPK5oysO0t6ka5rx47fv+le2M76vxJN fUJafuAv/9Elmx6VhSBMAPc2DtdecYwZaFl/TvrDumCs9+uyslp8M1LWIyvO1193f/MTTD2u05y i1A9ArbGhQQ9fuUA1IkhO6X3Sq6A86UqNE1qcifVAcv3gK4/RloRtS0KZFFdPlh2sq6OW8jyMG/ xAY8aAlI8qYDvldOZEi7YgZCIzcM7k9LGEK8FJ3Hru5NWiXjEsL2lP5p1TuFYwuHBjXTTIZ+zZY WCalgPIFrkLfkj1c3H+li+oSPrK/6ERaPn9DA2FeIlSI162kBgpel9lERWwrV+ylbM1t7LesLiT N7bhDTtCo X-Google-Smtp-Source: AGHT+IFW+RRbWo+3H4PLSETQX0f0kDlX/i80+2VQDLIV8yDzj7qP72ZTRMmrxWYHfvkhE+hTodTLyA== X-Received: by 2002:a05:6402:5244:b0:5e6:bc68:8a34 with SMTP id 4fb4d7f45d1cf-5eb9f1d1cd7mr98243a12.7.1742404464925; Wed, 19 Mar 2025 10:14:24 -0700 (PDT) Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e8169b04dasm9642955a12.37.2025.03.19.10.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Mar 2025 10:14:24 -0700 (PDT) From: Vincenzo Pupillo To: Eli Zaretskii , Michael Albinus Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path Date: Wed, 19 Mar 2025 18:14:23 +0100 Message-ID: <26846524.1r3eYUQgxm@fedora> In-Reply-To: <878qp188nd.fsf@gmx.de> References: <87frjj2uta.fsf@ice9.digital> <86tt7pp630.fsf@gnu.org> <878qp188nd.fsf@gmx.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart2329926.vFx2qVVIhK" Content-Transfer-Encoding: 7Bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --nextPart2329926.vFx2qVVIhK Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Ciao Micheal, thank you.=20 The new version of the patch is attached. Thanks. Vincenzo In data mercoled=C3=AC 19 marzo 2025 14:14:30 Ora standard dell=E2=80=99Eur= opa centrale,=20 Michael Albinus ha scritto: > Eli Zaretskii writes: >=20 > Hi, >=20 > >> (let ((php-prog > >> =20 > >> (if (file-remote-p default-directory) > >> =20 > >> (executable-find > >> =20 > >> (or php-ts-mode-alternative-php-program-name "php") t) > >> =20 > >> (if php-ts-mode-alternative-php-program-name > >> =20 > >> (executable-find > >> =20 > >> php-ts-mode-alternative-php-program-name) > >> =20 > >> php-ts-mode-php-default-executable)))) > >> =20 > >> php-prog)) > >>=20 > >> WDYT? > >=20 > > I think this is okay, but let's also ask Michael (CC'ed). >=20 > The following should suffice: >=20 > --8<---------------cut here---------------start------------->8--- > (or (executable-find > (or php-ts-mode-alternative-php-program-name "php") t) > php-ts-mode-php-default-executable) > --8<---------------cut here---------------end--------------->8--- >=20 > executable-find works also on local default-directory with non-nil > REMOTE. And you don't need the let-clause. >=20 > > Thanks. --nextPart2329926.vFx2qVVIhK Content-Disposition: attachment; filename="0001-PHP-should-be-in-the-PATH-either-locally-or-remotely.patch" Content-Transfer-Encoding: quoted-printable Content-Type: text/x-patch; charset="UTF-8"; name="0001-PHP-should-be-in-the-PATH-either-locally-or-remotely.patch" =46rom faccf82242f53a497a59e4f4dedf930dcc4b25a3 Mon Sep 17 00:00:00 2001 =46rom: Vincenzo Pupillo Date: Fri, 14 Mar 2025 21:11:22 +0100 Subject: [PATCH] PHP should be in the PATH, either locally or remotely. (bug#76242). MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * lisp/progmodes/php-ts-mode.el (php-ts-mode-php-default-executable): Renamed from 'php-ts-mode-php-executable'. (php-ts-mode--executable): New function that returns the absolute filename of the PHP executable, local or remote, based on 'default-directory'. (php-ts-mode--anchor-prev-sibling): Replaced 'when-let' with =E2=80=9Cwhen-let*.=E2=80=9D (php-ts-mode--indent-defun): Replaced 'when-let' with 'when-let*'. (php-ts-mode-run-php-webserver): Use the new function (php-ts-mode-php-default-executable). (run-php): Use the new function (php-ts-mode-php-default-executable). =2D-- lisp/progmodes/php-ts-mode.el | 47 +++++++++++++++++++++++------------ 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/lisp/progmodes/php-ts-mode.el b/lisp/progmodes/php-ts-mode.el index 56c15dad36f..98c631488a5 100644 =2D-- a/lisp/progmodes/php-ts-mode.el +++ b/lisp/progmodes/php-ts-mode.el @@ -134,12 +134,16 @@ php-ts-mode-css-fontify-colors :type 'boolean :safe 'booleanp) =20 =2D(defcustom php-ts-mode-php-executable (or (executable-find "php") "/usr/= bin/php") =2D "The location of PHP executable." +(defcustom php-ts-mode-php-default-executable (or (executable-find "php") = "/usr/bin/php") + "The default PHP executable." :tag "PHP Executable" :version "30.1" :type 'file) =20 +(defvar-local php-ts-mode-alternative-php-program-name nil + "An alternative to the usual `php' program name. +In non-nil, `php-ts-mode--executable' try to find this executable.") + (defcustom php-ts-mode-php-config nil "The location of php.ini file. If nil the default one is used to run the embedded webserver or @@ -270,7 +274,7 @@ php-ts-mode-flymake-php :noquery t :connection-type 'pipe :buffer (generate-new-buffer " *php-ts-mode-flymake*") =2D :command `(,php-ts-mode-php-executable + :command `(,(php-ts-mode--executable) "-l" "-d" "display_errors=3D0") :sentinel (lambda (proc _event) @@ -306,6 +310,16 @@ php-ts-mode-flymake-php =0C ;;; Utils =20 +(defun php-ts-mode--executable () + "Return the absolute filename of the php executable. +If the `default-directory' is remote, search on a remote host, otherwise +return `php-ts-mode-php-default-executable'. If +`php-ts-mode-alternative-php-program-name' is non-nil, finds this program +instead of the usual `php'." + (or (executable-find + (or php-ts-mode-alternative-php-program-name "php") t) + php-ts-mode-php-default-executable)) + (defun php-ts-mode--get-indent-style () "Helper function to set indentation style. MODE can be `psr2', `pear', `drupal', `wordpress', `symfony', `zend'." @@ -595,7 +609,7 @@ php-ts-mode--anchor-prev-sibling =20 PARENT is NODE's parent, BOL is the beginning of non-whitespace characters of the current line." =2D (when-let ((prev-sibling + (when-let* ((prev-sibling (or (treesit-node-prev-sibling node t) (treesit-node-prev-sibling (treesit-node-first-child-for-pos parent bol) t) @@ -1236,7 +1250,7 @@ php-ts-mode--indent-defun "Indent the current top-level declaration syntactically. `treesit-defun-type-regexp' defines what constructs to indent." (interactive "*") =2D (when-let ((orig-point (point-marker)) + (when-let* ((orig-point (point-marker)) (node (treesit-defun-at-point))) (indent-region (treesit-node-start node) (treesit-node-end node)) @@ -1613,7 +1627,7 @@ php-ts-mode-run-php-webserver (message "Run PHP built-in web server with args %s into buffer %s" (string-join args " ") buf-name) =2D (apply #'make-comint name php-ts-mode-php-executable nil args)) + (apply #'make-comint name (php-ts-mode--executable) nil args)) (funcall (if (called-interactively-p 'interactive) #'display-buffer #'get-buff= er) buf-name))) @@ -1677,18 +1691,19 @@ run-php Optional CONFIG, if supplied, is the php.ini file to use." (interactive (when current-prefix-arg (list =2D (read-string "Run PHP: " php-ts-mode-php-executable) + (read-string "Run PHP: " (php-ts-mode--executable)) (expand-file-name (read-file-name "With config: " php-ts-mode-php-config)= )))) =2D (let ((buffer (get-buffer-create php-ts-mode-inferior-php-buffer)) =2D (cmd (or =2D cmd =2D php-ts-mode-php-executable =2D (read-string "Run PHP: " php-ts-mode-php-executable))) =2D (config (or =2D config =2D (and php-ts-mode-php-config =2D (expand-file-name php-ts-mode-php-config))))) + (let* ((php-prog (php-ts-mode--executable)) + (buffer (get-buffer-create php-ts-mode-inferior-php-buffer)) + (cmd (or + cmd + php-prog + (read-string "Run PHP: " php-prog))) + (config (or + config + (and php-ts-mode-php-config + (expand-file-name php-ts-mode-php-config))))) (unless (comint-check-proc buffer) (with-current-buffer buffer (inferior-php-ts-mode-startup cmd config) =2D-=20 2.48.1 --nextPart2329926.vFx2qVVIhK-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 19 13:30:43 2025 Received: (at 76955) by debbugs.gnu.org; 19 Mar 2025 17:30:43 +0000 Received: from localhost ([127.0.0.1]:52975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tuxFa-0007A8-Hu for submit@debbugs.gnu.org; Wed, 19 Mar 2025 13:30:42 -0400 Received: from mout.gmx.net ([212.227.17.22]:33351) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tuxFX-00079p-Mi for 76955@debbugs.gnu.org; Wed, 19 Mar 2025 13:30:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1742405427; x=1743010227; i=michael.albinus@gmx.de; bh=xgQ3uY2GEPqmJqAs++6bu6pIhC2N0bWmYET5L0hpIjw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=O50ircnt/ltax3t9dsvHIuH8Vm1H+LBvnQ2Cnl3v1wyb0lJl3HXui1VhDHut6JKN D3nmayCnDT+smfR17p5TQUTHHdo2BS1W7E7yiU42hB2JiTybTxPix9bN9CQKauFJn 4g6WANlxSnnun45dmPAHT1E8e6Y/9xo1igl0HsVgRBmVRupykPCBe4VyUCI3bXVci gxzp7YiDt1K1USx2KiORZ0W+fDU6/jBc701JQNKEYkdBSNsyfwHtrpC2SI8zcO9D1 SGI3dlSPRUDyljsK2LIro4leuXKYvk6bJQF0S+6jMlR61DrcsuBOhxhU6q/gr2Hhk gLFim19d1IkLmCqZug== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.37.59]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MLi8m-1tdHs2475E-00U6Un; Wed, 19 Mar 2025 18:30:27 +0100 From: Michael Albinus To: Vincenzo Pupillo Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <26846524.1r3eYUQgxm@fedora> References: <87frjj2uta.fsf@ice9.digital> <86tt7pp630.fsf@gnu.org> <878qp188nd.fsf@gmx.de> <26846524.1r3eYUQgxm@fedora> Date: Wed, 19 Mar 2025 18:30:23 +0100 Message-ID: <87plid6i8g.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:cVap13tu8yUlQii0/ABKt+Nc2Jby5xIddYt4Oi8E3UxtVbPtkLW iwLwmG7VqokOLQRfmJDjVHktlw4zddXggz8BWSykkDxZnH1vn8ePFaJ/Un1jTclFaogohAH nDWKDJBtdXvXLROVCti3RFzT5grMEAxYRG7810UhwJUL8/PkMaMcsvkjICB0WMi1OuokV3b YUpzyWzq/d2rnmTIKY0pg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:G2/3qDVS2ew=;Nx5hTxkWohhXD06ZLnAPrSY2I/P LjEB8UHHZI6Kkk7dD9lBnJZYA+gbF8mG3ym5sJmoxBAI14aq/oAnSehPfF+bal6Gyto6Jpifu x36B6AFq4OwMaMJ/Op9RN4umXLVRM/T7Zd03ULgeshJXM8IdgLkWQkNF2mYf6vTuJy+TvF05P 0Tez8SEdkeWxai9pbgRVY85KFKs20OtEgahBOir6xJKslExUmsO+2HnTGieVcQh+HQVj1zwIF 18Zh44pXn/ezIl4z84a5q7Ty58DM8+Ff/3PcgVAYGtrzS7NOvpZW5uP+2FqQl3PUrIG7CX5Uw QLxaAivdrgnuFJegezV2edsqIqvFccI+xITI5VzGHtCUbHuZNEJxINssXIoWAjuRKQbaBrSht zSYN0BHjOvbt7OuBn9Csqg0kBqaAIQE9jCLhLt5e0hgCHp1bB8AMM4OaSbQbbPkTivcYXoNYH Cpl3Pdtws4xZ+exQXG4848MdNVwRmdgityaMLD/OyJzRmb3ipL4Ejhvya3CqRJ0y/YmkmPEYw IXdd7d6WZxvBhQ2FTzuoqLpRoBrQoiDg7WevifROLpHT+ZjiM6v4aoVqUY57oQpYAnTctWj1N erXiM7qNYQC3BUGJgPpAdkHWBm2F60AE4a5nXmhnK7S/1Ok1NStD1yi6rUpPZZggQDgOXMiF0 fIXkOq1417gLh5y2Asd9h7pR+z6aoJbm/mmbbbHP9v7EWzhiTXpXN9Yt62yCqBoQdj+bdXDgi vssrQWnZHYLBSPq3PG9LJh2RHlZsb6LU2SlTCVBDmjJlMCCj1bDJLdTVBliD4GHqIH+2yIyTe DgpKn/Mj28evxJoXq7qLzi3UaYc0Ww+dsKFW5BA1bHpsaDrSKZEFjs6+kiUTJaEg/GUJV0DM0 SdP7HZmI/JsHaqk+P5u7G2O1x2X2A8br9n0DFj6f5gQIQ3u0g/w6iqkslxUk/bda6v4DRXzDL Rmmt5JyjHCZUF9m4iGWi/gaLOYcedsCgbwa4HZRiyOYx54KQc+PupNABa06TPD2ADyysePDUT zdh7Cj1FxdrbOESV3ONWVOY6G7FHNT3wKLUz8lVNwrC69kzWGWZBGS2w38+/jqz+a6QwOeAnM Yjis36f/w9p2BvPsBN/QQ6DrWN3SNaA9ZcQ/v/McjBg2A1quqaCz/gpB22Y6nMTa441IBZHDC Gtv9b9qEqM8Xncuah7Qr4I5qrPEMTrU6YtNKaUnTq3ieUy1pJ4Kalclx/bhbBmOaeqwx5rEuA RSqHbwViAveRCzqh9klSAt5dWsmV4tpjUOqC7LQkjQOdCA21CvKhMeRRpDpKXJAF6a3V0INoQ QWTL7R8Bq8nC6wEzQeTGtmAPkTHxJalriS9ZXRTb83zPBm57vPcWvaBwLCxN7uUjOqa7fNqPm KHSIeTtOzSqYNc+pcdBaEz7r0v/ecASQmHYy6xHAwACUhUXlpDyU73eObEhXeS3cgAomzuxd5 NzzDIlmI9Qo6bRFFIKNVLS7B1z+cvxzi8xz9Pqnkewo8lEZOI Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: Eli Zaretskii , 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Vincenzo Pupillo writes: > Ciao Micheal, thank you. Hi Vincenzo, > The new version of the patch is attached. I guess the docstring of php-ts-mode--executable must be adapted to the recent affair. > Thanks. > > Vincenzo Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 19 14:25:30 2025 Received: (at 76955) by debbugs.gnu.org; 19 Mar 2025 18:25:30 +0000 Received: from localhost ([127.0.0.1]:53061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tuy6b-0001Q5-II for submit@debbugs.gnu.org; Wed, 19 Mar 2025 14:25:30 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:49268) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tuy6Y-0001Ph-O6 for 76955@debbugs.gnu.org; Wed, 19 Mar 2025 14:25:27 -0400 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-aaecf50578eso158596866b.2 for <76955@debbugs.gnu.org>; Wed, 19 Mar 2025 11:25:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742408721; x=1743013521; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uiwi8kT4BEiND/1EShMTk898odjIXhpPUd+pmzOrfQ8=; b=MGbgjph62tJ9dzDbZHheWs/f0JYIzTU+VLIO5DQ6lw2vzxvumXfck3a24x6qSLbD7U uZvCGT6nn6iuQKjtBkjzW8hrhzLSHEs78nbf7s0JzR2I4yMUphubHrl6eNIK06lBdNw0 PzFT7WAmXzSnhFhfmoG9OpViimRtG0lrFucvxLgnXmuQI5cjrqCLkYO8nFwBfN5pNK+y QdzUk+OXj7OqCZQ8rMi00SOUbo564CwV9U5oy8ghemppDrmHqPmo0xme0MaIza06aUIz A0/ukq40D8ohCvy6lT7nJlzi6a4WBl5wqgAJHvNC1QmWwnd+Ss6ZrI/JNiOOs9HX8yc1 eF+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742408721; x=1743013521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uiwi8kT4BEiND/1EShMTk898odjIXhpPUd+pmzOrfQ8=; b=GAHkZrzIJoFs/OegD82tGvPaH073qrBvkPFILy5THx35cjjDJe2EJJ+Rf97rZZsvBg t4eSOTWjNfTOZAhGVykUS7772mThPXVBaa9Lfd+SWkPgJeecBak7pkImMfvIPel62hSE R8orOhe9afkw61KegX7AlrZocE4jIBPD4AzfrgibVkT/M0lOxvNw4GcyiXE495sJV72c GehtfpF95ih+G6e7rv56CWa9sM4RXCkYhpxj0i4nBQUU96XLMmwMkQOR2tkE5q3z1mfi fiiqJhJazFyiIFBB90iDaFcs+M8uKLKnBHLpxL9GObP7FecgGM1S1JTS7iHfW9VuUwCb iP6g== X-Forwarded-Encrypted: i=1; AJvYcCW1amB/cuhroIDVTpQs/nJeq1iwaaUkDJ9HYevDB3QkjUjtjq5zJUxbBa1Gr61rZ4qHabzGNA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzk0BlP3sthsT4MSHc3OF48KTgs5Qfxy8k8MUJGjBlM6MHnenLD IygqwK6EaRVS+fyOSsfmxJoR2ZlzfDZ/GuGnY1UtnxF06npbPyEG X-Gm-Gg: ASbGncttnl7Who5WL7PrFw7+6nSb0nriXIBGJ9INNpsZc+6eKrsqBuDJKF//v7RE0UG hZJXKpAjn0/n/2P+ewobuS8LHo9ShzO0Wu9fNIdXQcGLjkJDqsjkU7PeEFYD0gVFviRNBHiI7cu xHgk3qdK2zVZl7pNCtIUcwX7PF4TXz/ULsRKJhXWerZwkffPh6/Gvs670+v4smfQFVDhMd9eNU9 ZV0K5SjseccDihIQziVKASCh8deB6sV/jpZr7lrLP22+b4KDlhpMakgtJSmpXOrdCFhAUGNiiUf taAErWJVGrMU6nJWnsbcLckZ9lecj2mYxHnnAsrGW4oABbpg+GvwjHwq2K52BL889nXMwHGsz1v l2pnDP+Ze X-Google-Smtp-Source: AGHT+IF0uWoj5RHedFcbc+MiBmfbZUYeTzxpvbgLWOcsnBIhKF+lSuyyqvIJ7lrae+t7dRG18OXEKQ== X-Received: by 2002:a17:907:84a:b0:abf:750b:93b8 with SMTP id a640c23a62f3a-ac3b7d8492bmr397945366b.22.1742408720334; Wed, 19 Mar 2025 11:25:20 -0700 (PDT) Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it. [2.230.139.124]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3149d0bfbsm1069356966b.95.2025.03.19.11.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Mar 2025 11:25:19 -0700 (PDT) From: Vincenzo Pupillo To: Michael Albinus Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path Date: Wed, 19 Mar 2025 19:25:18 +0100 Message-ID: <2288293.9o76ZdvQCi@fedora> In-Reply-To: <87plid6i8g.fsf@gmx.de> References: <87frjj2uta.fsf@ice9.digital> <26846524.1r3eYUQgxm@fedora> <87plid6i8g.fsf@gmx.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart2854859.vuYhMxLoTh" Content-Transfer-Encoding: 7Bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76955 Cc: Eli Zaretskii , 76955@debbugs.gnu.org, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --nextPart2854859.vuYhMxLoTh Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In data mercoled=C3=AC 19 marzo 2025 18:30:23 Ora standard dell=E2=80=99Eur= opa centrale,=20 Michael Albinus ha scritto: > Vincenzo Pupillo writes: > > Ciao Micheal, thank you. >=20 > Hi Vincenzo, >=20 > > The new version of the patch is attached. >=20 > I guess the docstring of php-ts-mode--executable must be adapted to the > recent affair. Done >=20 > > Thanks. > >=20 > > Vincenzo >=20 > Best regards, Michael. Thanks! Vincenzo --nextPart2854859.vuYhMxLoTh Content-Disposition: attachment; filename="0001-PHP-should-be-in-the-PATH-either-locally-or-remotely.patch" Content-Transfer-Encoding: quoted-printable Content-Type: text/x-patch; charset="UTF-8"; name="0001-PHP-should-be-in-the-PATH-either-locally-or-remotely.patch" =46rom 5c9edc087efcb6e9d7c80cf52cacd6df46e45df3 Mon Sep 17 00:00:00 2001 =46rom: Vincenzo Pupillo Date: Fri, 14 Mar 2025 21:11:22 +0100 Subject: [PATCH] PHP should be in the PATH, either locally or remotely. (bug#76242). MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * lisp/progmodes/php-ts-mode.el (php-ts-mode-php-default-executable): Renamed from 'php-ts-mode-php-executable'. (php-ts-mode--executable): New function that returns the absolute filename of the PHP executable, local or remote, based on 'default-directory'. (php-ts-mode--anchor-prev-sibling): Replaced 'when-let' with =E2=80=9Cwhen-let*.=E2=80=9D (php-ts-mode--indent-defun): Replaced 'when-let' with 'when-let*'. (php-ts-mode-run-php-webserver): Use the new function (php-ts-mode-php-default-executable). (run-php): Use the new function (php-ts-mode-php-default-executable). =2D-- lisp/progmodes/php-ts-mode.el | 47 +++++++++++++++++++++++------------ 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/lisp/progmodes/php-ts-mode.el b/lisp/progmodes/php-ts-mode.el index 56c15dad36f..b626a19a0de 100644 =2D-- a/lisp/progmodes/php-ts-mode.el +++ b/lisp/progmodes/php-ts-mode.el @@ -134,12 +134,16 @@ php-ts-mode-css-fontify-colors :type 'boolean :safe 'booleanp) =20 =2D(defcustom php-ts-mode-php-executable (or (executable-find "php") "/usr/= bin/php") =2D "The location of PHP executable." +(defcustom php-ts-mode-php-default-executable (or (executable-find "php") = "/usr/bin/php") + "The default PHP executable." :tag "PHP Executable" :version "30.1" :type 'file) =20 +(defvar-local php-ts-mode-alternative-php-program-name nil + "An alternative to the usual `php' program name. +In non-nil, `php-ts-mode--executable' try to find this executable.") + (defcustom php-ts-mode-php-config nil "The location of php.ini file. If nil the default one is used to run the embedded webserver or @@ -270,7 +274,7 @@ php-ts-mode-flymake-php :noquery t :connection-type 'pipe :buffer (generate-new-buffer " *php-ts-mode-flymake*") =2D :command `(,php-ts-mode-php-executable + :command `(,(php-ts-mode--executable) "-l" "-d" "display_errors=3D0") :sentinel (lambda (proc _event) @@ -306,6 +310,16 @@ php-ts-mode-flymake-php =0C ;;; Utils =20 +(defun php-ts-mode--executable () + "Return the absolute filename of the php executable. +If the `default-directory' is remote, search on a remote host, otherwise +it searches locally. If `php-ts-mode-alternative-php-program-name' is +non-zero, it searches for this program instead of the usual `php'. +If the search fails, it returns `php-ts-mode-php-default-executable'." + (or (executable-find + (or php-ts-mode-alternative-php-program-name "php") t) + php-ts-mode-php-default-executable)) + (defun php-ts-mode--get-indent-style () "Helper function to set indentation style. MODE can be `psr2', `pear', `drupal', `wordpress', `symfony', `zend'." @@ -595,7 +609,7 @@ php-ts-mode--anchor-prev-sibling =20 PARENT is NODE's parent, BOL is the beginning of non-whitespace characters of the current line." =2D (when-let ((prev-sibling + (when-let* ((prev-sibling (or (treesit-node-prev-sibling node t) (treesit-node-prev-sibling (treesit-node-first-child-for-pos parent bol) t) @@ -1236,7 +1250,7 @@ php-ts-mode--indent-defun "Indent the current top-level declaration syntactically. `treesit-defun-type-regexp' defines what constructs to indent." (interactive "*") =2D (when-let ((orig-point (point-marker)) + (when-let* ((orig-point (point-marker)) (node (treesit-defun-at-point))) (indent-region (treesit-node-start node) (treesit-node-end node)) @@ -1613,7 +1627,7 @@ php-ts-mode-run-php-webserver (message "Run PHP built-in web server with args %s into buffer %s" (string-join args " ") buf-name) =2D (apply #'make-comint name php-ts-mode-php-executable nil args)) + (apply #'make-comint name (php-ts-mode--executable) nil args)) (funcall (if (called-interactively-p 'interactive) #'display-buffer #'get-buff= er) buf-name))) @@ -1677,18 +1691,19 @@ run-php Optional CONFIG, if supplied, is the php.ini file to use." (interactive (when current-prefix-arg (list =2D (read-string "Run PHP: " php-ts-mode-php-executable) + (read-string "Run PHP: " (php-ts-mode--executable)) (expand-file-name (read-file-name "With config: " php-ts-mode-php-config)= )))) =2D (let ((buffer (get-buffer-create php-ts-mode-inferior-php-buffer)) =2D (cmd (or =2D cmd =2D php-ts-mode-php-executable =2D (read-string "Run PHP: " php-ts-mode-php-executable))) =2D (config (or =2D config =2D (and php-ts-mode-php-config =2D (expand-file-name php-ts-mode-php-config))))) + (let* ((php-prog (php-ts-mode--executable)) + (buffer (get-buffer-create php-ts-mode-inferior-php-buffer)) + (cmd (or + cmd + php-prog + (read-string "Run PHP: " php-prog))) + (config (or + config + (and php-ts-mode-php-config + (expand-file-name php-ts-mode-php-config))))) (unless (comint-check-proc buffer) (with-current-buffer buffer (inferior-php-ts-mode-startup cmd config) =2D-=20 2.48.1 --nextPart2854859.vuYhMxLoTh-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 21 12:31:17 2025 Received: (at 76955) by debbugs.gnu.org; 21 Mar 2025 16:31:17 +0000 Received: from localhost ([127.0.0.1]:39174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tvfHA-0005sP-3E for submit@debbugs.gnu.org; Fri, 21 Mar 2025 12:31:17 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:33843) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tvfH7-0005re-4L for 76955@debbugs.gnu.org; Fri, 21 Mar 2025 12:31:14 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 2D744442F7; Fri, 21 Mar 2025 16:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1742574665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SU1Br1ZpQiI5sE/c3C5MtDyUt9GwMIxCTSfG6q1C+dg=; b=aNl92Q053a9JQ+bgEYdjogO/R3mWK77EdGN83g1EViugaL3j6eO9cAx8KDTQYTBjNS1Dcy 6ciiu3AUP0LwsxgnuCSi1XS3PKjDPNZiaQi9jn22sETlcycIivIEw0CQk8jpspyb4gMihP iXZMLfXr/RmJ/Lbevty1Zayb0mPSttJ0/dmaJsoNVNK2YtB352QPvocSUWVUAQ8s4LdSix YfCO4ip1q3S2EQY8TiuAuW7UyHzA7+RUcrGRCk45KKluipDvljKAXkEu/qKDZaEjel23ua ZH/ftF6+jb9Rj31zR5BEgd0Mq0CI1FBSQBDgZwQ3mOKQ3wbCYPm2Y8gl/YMRYw== From: Morgan Willcock To: Vincenzo Pupillo Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path In-Reply-To: <2288293.9o76ZdvQCi@fedora> (Vincenzo Pupillo's message of "Wed, 19 Mar 2025 19:25:18 +0100") References: <87frjj2uta.fsf@ice9.digital> <26846524.1r3eYUQgxm@fedora> <87plid6i8g.fsf@gmx.de> <2288293.9o76ZdvQCi@fedora> Date: Fri, 21 Mar 2025 16:31:03 +0000 Message-ID: <86h63m9whk.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduheduheejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefoohhrghgrnhcuhghilhhltghotghkuceomhhorhhgrghnsehitggvledrughighhithgrlheqnecuggftrfgrthhtvghrnhepueduvdeguefgvdeuudekleejhfethfekgeefveejffdvheffkeduvddugefgjeeinecukfhppeektddrgeegrddvfedtrdekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeektddrgeegrddvfedtrdekvddphhgvlhhopehthhhinhhkphgrugdrnhhothhlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhorhhgrghnsehitggvledrughighhithgrlhdpnhgspghrtghpthhtohepgedprhgtphhtthhopeejieelheehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhhitghhrggvlhdrrghlsghinhhushesghhmgidruggvpdhrtghpthhtohepvhdrphhuphhilhhlohesghhmrghilhdrtghomh X-GND-Sasl: morgan@ice9.digital X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76955 Cc: Eli Zaretskii , Michael Albinus , 76955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Vincenzo Pupillo writes: >> > The new version of the patch is attached. >> >> I guess the docstring of php-ts-mode--executable must be adapted to the >> recent affair. I guess that the intention is described in the title of the patch ("PHP should be in the PATH, either locally or remotely"), but the current setup with php-ts-mode-php-executable allows an explicit path to be set which is not on PATH, and it can be set both locally and remotely. I just want to check that removing this feature is completely intentional, since someone may be using it. Thanks, Morgan -- Morgan Willcock From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 07:34:01 2025 Received: (at 76955-done) by debbugs.gnu.org; 29 Mar 2025 11:34:02 +0000 Received: from localhost ([127.0.0.1]:57294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyURt-0005tm-Cf for submit@debbugs.gnu.org; Sat, 29 Mar 2025 07:34:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43016) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyURq-0005tO-V0 for 76955-done@debbugs.gnu.org; Sat, 29 Mar 2025 07:34:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyURk-0005Z1-Lh; Sat, 29 Mar 2025 07:33:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=KYPHBq0hvJnvSKuAkudC8Om+vVxnHEWUNMb6thB68A0=; b=ZWY7ieq+CtuLpsxINXL9 QOAlw/p+97SoSmt+hoBZWy4arIW+cmn4KrberxOIUOd3n6lIKcm4KweZk3pqQ1S+G8G7+P57SZK7G qmo2RJKENSBtiW0GOkeZ3y+qRteOxuzhR5A3htqD8NndCqKWd0rmhg4x+DAaE6YWXM6aLTfqb+koz 8Sk6Tw3NHjzPyTSjixy97zrn+7zsuzZOKvGzE0Oj0IKUnIrNO7L4AF9oK2TY3rCCcqPwhii36EW18 j2n4fwzlFTPYmuXV8+EwGAX3TTAqMdPxcA0EURXKt3nTRwJkSvpYJ0ZkPsJjA06woU18Sk6UUatR0 MrxN0HO4M3mc0g==; Date: Sat, 29 Mar 2025 14:33:51 +0300 Message-Id: <86pli06pgg.fsf@gnu.org> From: Eli Zaretskii To: Vincenzo Pupillo In-Reply-To: <2288293.9o76ZdvQCi@fedora> (message from Vincenzo Pupillo on Wed, 19 Mar 2025 19:25:18 +0100) Subject: Re: bug#76955: 30.1; php-ts-mode-php-executable default path may not match remote path References: <87frjj2uta.fsf@ice9.digital> <26846524.1r3eYUQgxm@fedora> <87plid6i8g.fsf@gmx.de> <2288293.9o76ZdvQCi@fedora> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76955-done Cc: 76955-done@debbugs.gnu.org, michael.albinus@gmx.de, morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Vincenzo Pupillo > Cc: Eli Zaretskii , morgan@ice9.digital, 76955@debbugs.gnu.org > Date: Wed, 19 Mar 2025 19:25:18 +0100 > > In data mercoledì 19 marzo 2025 18:30:23 Ora standard dell’Europa centrale, > Michael Albinus ha scritto: > > Vincenzo Pupillo writes: > > > Ciao Micheal, thank you. > > > > Hi Vincenzo, > > > > > The new version of the patch is attached. > > > > I guess the docstring of php-ts-mode--executable must be adapted to the > > recent affair. > > Done > > > > > > Thanks. > > > > > > Vincenzo > > > > Best regards, Michael. > > Thanks! Thanks, now installed on the emacs-30 branch, and closing the bug. From unknown Sun Jun 22 00:52:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 27 Apr 2025 11:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator