GNU bug report logs - #76945
[PATCH] etags: character classes and intervals not working in --regex

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76945 in the body.
You can then email your comments to 76945 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Gorsunov <gorsunov <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] etags: character classes and intervals not working in --regex
Date: Tue, 11 Mar 2025 14:28:45 +0200

[Message part 1 (text/plain, inline)]

  Before commit d904cc83 regex syntax flags used in etags were

  RE_CHAR_CLASSES | RE_INTERVALS | RE_SHY_GROUPS | RE_FRUGAL

  that got changed to 0. Including a patch that restores
  RE_CHAR_CLASSES and RE_INTERVALS and adds check for these features
  to the test. As far I can understand from the bug 74861, the
  absence of shy groups and non-greedy matching won't be fixed
  until Gnulib supports them

[0001-etags-restore-some-regex-features-that-used-to-work-.patch (text/x-patch, attachment)]

Message #8 received at 76945 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vladimir Gorsunov <gorsunov <at> gmail.com>,
 Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 76945 <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Tue, 11 Mar 2025 19:41:15 +0200

> Date: Tue, 11 Mar 2025 14:28:45 +0200
> From: Vladimir Gorsunov <gorsunov <at> gmail.com>
> 
>    Before commit d904cc83 regex syntax flags used in etags were
> 
>    RE_CHAR_CLASSES | RE_INTERVALS | RE_SHY_GROUPS | RE_FRUGAL
> 
>    that got changed to 0. Including a patch that restores
>    RE_CHAR_CLASSES and RE_INTERVALS and adds check for these features
>    to the test. As far I can understand from the bug 74861, the
>    absence of shy groups and non-greedy matching won't be fixed
>    until Gnulib supports them

Thanks.

Paul, any comments?

Message #11 received at 76945 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Vladimir Gorsunov <gorsunov <at> gmail.com>, Richard Stallman <rms <at> gnu.org>,
 76945 <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Tue, 11 Mar 2025 10:58:58 -0700

On 2025-03-11 10:41, Eli Zaretskii wrote:
>> Date: Tue, 11 Mar 2025 14:28:45 +0200
>> From: Vladimir Gorsunov <gorsunov <at> gmail.com>
>>
>>     Before commit d904cc83 regex syntax flags used in etags were
>>
>>     RE_CHAR_CLASSES | RE_INTERVALS | RE_SHY_GROUPS | RE_FRUGAL
>>
>>     that got changed to 0. Including a patch that restores
>>     RE_CHAR_CLASSES and RE_INTERVALS and adds check for these features
>>     to the test. As far I can understand from the bug 74861, the
>>     absence of shy groups and non-greedy matching won't be fixed
>>     until Gnulib supports them
> 
> Thanks.
> 
> Paul, any comments?

As I understand it the original design for glibc regex was that Emacs 
was the default, so a flags value of zero meant Emacs. This is why 
RE_SYNTAX_EMACS is 0.

Evidently that design goal no longer holds, so it makes sense to adjust 
Emacs's use of glibc flags to match the behavior of Emacs's only 
regular-expression implementation in emacs/src/regex-emacs.c as best we can.

However, surely this adjustment should be made in Gnulib, not in 
etags.c. That is, gnulib/lib/regex.h (aka emacs/lib/regex.h) should 
#define RE_SYNTAX_EMACS to equal RE_CHAR_CLASSES | RE_INTERVALS, not 
zero. And eventually this change should be migrated back to glibc.

I'll cc this to rms in case he has further comments about this.

Message #14 received at 76945 <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Gorsunov <gorsunov <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Richard Stallman <rms <at> gnu.org>,
 76945 <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Wed, 12 Mar 2025 00:30:45 +0200

[Message part 1 (text/plain, inline)]

Excuse me but I have a question. If Gnulib is a collection of utility code
to be used by all projects, why is carrying something Emacs specific? Is
RE_SYNTAX_EMACS used by other projects?

On Tue, Mar 11, 2025 at 7:58 PM Paul Eggert <eggert <at> cs.ucla.edu> wrote:

> On 2025-03-11 10:41, Eli Zaretskii wrote:
> >> Date: Tue, 11 Mar 2025 14:28:45 +0200
> >> From: Vladimir Gorsunov <gorsunov <at> gmail.com>
> >>
> >>     Before commit d904cc83 regex syntax flags used in etags were
> >>
> >>     RE_CHAR_CLASSES | RE_INTERVALS | RE_SHY_GROUPS | RE_FRUGAL
> >>
> >>     that got changed to 0. Including a patch that restores
> >>     RE_CHAR_CLASSES and RE_INTERVALS and adds check for these features
> >>     to the test. As far I can understand from the bug 74861, the
> >>     absence of shy groups and non-greedy matching won't be fixed
> >>     until Gnulib supports them
> >
> > Thanks.
> >
> > Paul, any comments?
>
> As I understand it the original design for glibc regex was that Emacs
> was the default, so a flags value of zero meant Emacs. This is why
> RE_SYNTAX_EMACS is 0.
>
> Evidently that design goal no longer holds, so it makes sense to adjust
> Emacs's use of glibc flags to match the behavior of Emacs's only
> regular-expression implementation in emacs/src/regex-emacs.c as best we
> can.
>
> However, surely this adjustment should be made in Gnulib, not in
> etags.c. That is, gnulib/lib/regex.h (aka emacs/lib/regex.h) should
> #define RE_SYNTAX_EMACS to equal RE_CHAR_CLASSES | RE_INTERVALS, not
> zero. And eventually this change should be migrated back to glibc.
>
> I'll cc this to rms in case he has further comments about this.
>


-- 
Mit Respekt, Vladimir Gorsunov

[Message part 2 (text/html, inline)]

Message #17 received at 76945 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Vladimir Gorsunov <gorsunov <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Richard Stallman <rms <at> gnu.org>,
 76945 <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Tue, 11 Mar 2025 16:57:13 -0700

On 3/11/25 15:30, Vladimir Gorsunov wrote:
> If Gnulib is a collection of utility code
> to be used by all projects, why is carrying something Emacs specific? Is
> RE_SYNTAX_EMACS used by other projects?

Zile (an Emacs clone) uses it, and it's used in higher-level libraries 
that front for the GNU C library, e.g., [1].

[1]: https://github.com/jddurand/re-engine-GNU

Message #20 received at 76945 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>, rms <at> gnu.org
Cc: gorsunov <at> gmail.com, 76945 <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Sat, 29 Mar 2025 14:14:07 +0300

Ping!  Can we make some progress in resolving this?

Richard, do you have any comments?

> Date: Tue, 11 Mar 2025 10:58:58 -0700
> Cc: 76945 <at> debbugs.gnu.org, Richard Stallman <rms <at> gnu.org>,
>  Vladimir Gorsunov <gorsunov <at> gmail.com>
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> 
> On 2025-03-11 10:41, Eli Zaretskii wrote:
> >> Date: Tue, 11 Mar 2025 14:28:45 +0200
> >> From: Vladimir Gorsunov <gorsunov <at> gmail.com>
> >>
> >>     Before commit d904cc83 regex syntax flags used in etags were
> >>
> >>     RE_CHAR_CLASSES | RE_INTERVALS | RE_SHY_GROUPS | RE_FRUGAL
> >>
> >>     that got changed to 0. Including a patch that restores
> >>     RE_CHAR_CLASSES and RE_INTERVALS and adds check for these features
> >>     to the test. As far I can understand from the bug 74861, the
> >>     absence of shy groups and non-greedy matching won't be fixed
> >>     until Gnulib supports them
> > 
> > Thanks.
> > 
> > Paul, any comments?
> 
> As I understand it the original design for glibc regex was that Emacs 
> was the default, so a flags value of zero meant Emacs. This is why 
> RE_SYNTAX_EMACS is 0.
> 
> Evidently that design goal no longer holds, so it makes sense to adjust 
> Emacs's use of glibc flags to match the behavior of Emacs's only 
> regular-expression implementation in emacs/src/regex-emacs.c as best we can.
> 
> However, surely this adjustment should be made in Gnulib, not in 
> etags.c. That is, gnulib/lib/regex.h (aka emacs/lib/regex.h) should 
> #define RE_SYNTAX_EMACS to equal RE_CHAR_CLASSES | RE_INTERVALS, not 
> zero. And eventually this change should be migrated back to glibc.
> 
> I'll cc this to rms in case he has further comments about this.
> 

Message #23 received at 76945 <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Gorsunov <gorsunov <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Paul Eggert <eggert <at> cs.ucla.edu>, rms <at> gnu.org
Cc: 76945 <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Fri, 11 Apr 2025 19:55:01 +0300

Made a patch to gnulib 
https://lists.gnu.org/archive/html/bug-gnulib/2025-04/msg00064.html as 
Paul suggested

On 3/29/25 13:14, Eli Zaretskii wrote:
> Ping!  Can we make some progress in resolving this?
>
> Richard, do you have any comments?
>
>> Date: Tue, 11 Mar 2025 10:58:58 -0700
>> Cc: 76945 <at> debbugs.gnu.org, Richard Stallman <rms <at> gnu.org>,
>>   Vladimir Gorsunov <gorsunov <at> gmail.com>
>> From: Paul Eggert <eggert <at> cs.ucla.edu>
>>
>> On 2025-03-11 10:41, Eli Zaretskii wrote:
>>>> Date: Tue, 11 Mar 2025 14:28:45 +0200
>>>> From: Vladimir Gorsunov <gorsunov <at> gmail.com>
>>>>
>>>>      Before commit d904cc83 regex syntax flags used in etags were
>>>>
>>>>      RE_CHAR_CLASSES | RE_INTERVALS | RE_SHY_GROUPS | RE_FRUGAL
>>>>
>>>>      that got changed to 0. Including a patch that restores
>>>>      RE_CHAR_CLASSES and RE_INTERVALS and adds check for these features
>>>>      to the test. As far I can understand from the bug 74861, the
>>>>      absence of shy groups and non-greedy matching won't be fixed
>>>>      until Gnulib supports them
>>> Thanks.
>>>
>>> Paul, any comments?
>> As I understand it the original design for glibc regex was that Emacs
>> was the default, so a flags value of zero meant Emacs. This is why
>> RE_SYNTAX_EMACS is 0.
>>
>> Evidently that design goal no longer holds, so it makes sense to adjust
>> Emacs's use of glibc flags to match the behavior of Emacs's only
>> regular-expression implementation in emacs/src/regex-emacs.c as best we can.
>>
>> However, surely this adjustment should be made in Gnulib, not in
>> etags.c. That is, gnulib/lib/regex.h (aka emacs/lib/regex.h) should
>> #define RE_SYNTAX_EMACS to equal RE_CHAR_CLASSES | RE_INTERVALS, not
>> zero. And eventually this change should be migrated back to glibc.
>>
>> I'll cc this to rms in case he has further comments about this.
>>

Message #26 received at 76945 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vladimir Gorsunov <gorsunov <at> gmail.com>
Cc: eggert <at> cs.ucla.edu, rms <at> gnu.org, 76945 <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Sun, 13 Apr 2025 12:55:38 +0300

> Date: Fri, 11 Apr 2025 19:55:01 +0300
> Cc: 76945 <at> debbugs.gnu.org
> From: Vladimir Gorsunov <gorsunov <at> gmail.com>
> 
> Made a patch to gnulib 
> https://lists.gnu.org/archive/html/bug-gnulib/2025-04/msg00064.html as 
> Paul suggested

Thanks.  I guess we can now close this bug, as the issue will be
resolved in Gnulib?

Message #29 received at 76945 <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Gorsunov <gorsunov <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: eggert <at> cs.ucla.edu, rms <at> gnu.org, 76945 <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Sun, 13 Apr 2025 14:08:06 +0300

[Message part 1 (text/plain, inline)]

Seems strange to me to close before we make sure the software does, in
fact, behave as expected. But if that's how it is usually done in this
project, then of course!

On Sun, Apr 13, 2025 at 12:55 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Date: Fri, 11 Apr 2025 19:55:01 +0300
> > Cc: 76945 <at> debbugs.gnu.org
> > From: Vladimir Gorsunov <gorsunov <at> gmail.com>
> >
> > Made a patch to gnulib
> > https://lists.gnu.org/archive/html/bug-gnulib/2025-04/msg00064.html as
> > Paul suggested
>
> Thanks.  I guess we can now close this bug, as the issue will be
> resolved in Gnulib?
>


-- 
Mit Respekt, Vladimir Gorsunov

[Message part 2 (text/html, inline)]

Message #32 received at 76945 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vladimir Gorsunov <gorsunov <at> gmail.com>
Cc: eggert <at> cs.ucla.edu, rms <at> gnu.org, 76945 <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Sun, 13 Apr 2025 14:29:01 +0300

> From: Vladimir Gorsunov <gorsunov <at> gmail.com>
> Date: Sun, 13 Apr 2025 14:08:06 +0300
> Cc: eggert <at> cs.ucla.edu, rms <at> gnu.org, 76945 <at> debbugs.gnu.org
> 
> Seems strange to me to close before we make sure the software does, in fact, behave as expected. But if
> that's how it is usually done in this project, then of course!

We could wait until Gnulib folks resolve this on their end, but
someone will need to tell us when that happens, because I don't
normally read the Gnulib list.

Message #35 received at 76945 <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Gorsunov <gorsunov <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: eggert <at> cs.ucla.edu, rms <at> gnu.org, 76945 <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Sun, 13 Apr 2025 14:33:02 +0300

[Message part 1 (text/plain, inline)]

I'll tell you

On Sun, Apr 13, 2025 at 2:29 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Vladimir Gorsunov <gorsunov <at> gmail.com>
> > Date: Sun, 13 Apr 2025 14:08:06 +0300
> > Cc: eggert <at> cs.ucla.edu, rms <at> gnu.org, 76945 <at> debbugs.gnu.org
> >
> > Seems strange to me to close before we make sure the software does, in
> fact, behave as expected. But if
> > that's how it is usually done in this project, then of course!
>
> We could wait until Gnulib folks resolve this on their end, but
> someone will need to tell us when that happens, because I don't
> normally read the Gnulib list.
>


-- 
Mit Respekt, Vladimir Gorsunov

[Message part 2 (text/html, inline)]

Message #38 received at 76945 <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Gorsunov <gorsunov <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: eggert <at> cs.ucla.edu, rms <at> gnu.org, 76945 <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Mon, 14 Apr 2025 15:11:43 +0300

[Message part 1 (text/plain, inline)]

Well, gnulib did fix the value. Thanks Paul. When I rebuilt etags after
running merge-gnulib, it worked as expected. Don't know if that warrants
criteria for closing. Of course someone still needs to commit updated
gnulib here for it to be fixed for everyone

On Sun, Apr 13, 2025 at 2:33 PM Vladimir Gorsunov <gorsunov <at> gmail.com>
wrote:

> I'll tell you
>
> On Sun, Apr 13, 2025 at 2:29 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>> > From: Vladimir Gorsunov <gorsunov <at> gmail.com>
>> > Date: Sun, 13 Apr 2025 14:08:06 +0300
>> > Cc: eggert <at> cs.ucla.edu, rms <at> gnu.org, 76945 <at> debbugs.gnu.org
>> >
>> > Seems strange to me to close before we make sure the software does, in
>> fact, behave as expected. But if
>> > that's how it is usually done in this project, then of course!
>>
>> We could wait until Gnulib folks resolve this on their end, but
>> someone will need to tell us when that happens, because I don't
>> normally read the Gnulib list.
>>
>
>
> --
> Mit Respekt, Vladimir Gorsunov
>


-- 
Mit Respekt, Vladimir Gorsunov

[Message part 2 (text/html, inline)]

Message #41 received at 76945 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vladimir Gorsunov <gorsunov <at> gmail.com>
Cc: eggert <at> cs.ucla.edu, rms <at> gnu.org, 76945 <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Mon, 14 Apr 2025 16:39:38 +0300

> From: Vladimir Gorsunov <gorsunov <at> gmail.com>
> Date: Mon, 14 Apr 2025 15:11:43 +0300
> Cc: eggert <at> cs.ucla.edu, rms <at> gnu.org, 76945 <at> debbugs.gnu.org
> 
> Well, gnulib did fix the value. Thanks Paul. When I rebuilt etags after running merge-gnulib, it worked as
> expected. Don't know if that warrants criteria for closing. Of course someone still needs to commit updated
> gnulib here for it to be fixed for everyone

Thanks.  I think we will close this bug when Gnulib is updated in our
repository.

Message #46 received at 76945-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Vladimir Gorsunov <gorsunov <at> gmail.com>, rms <at> gnu.org,
 76945-done <at> debbugs.gnu.org
Subject: Re: bug#76945: [PATCH] etags: character classes and intervals not
 working in --regex
Date: Sat, 19 Apr 2025 22:42:27 -0700

On 2025-04-14 06:39, Eli Zaretskii wrote:
> I think we will close this bug when Gnulib is updated in our
> repository.

I did that and am closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.