GNU bug report logs - #76936
[PATCH] gnu: supertuxkart: Keep 'supertuxkart.desktop' file.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76936 in the body.
You can then email your comments to 76936 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nigko Yerden <nigko.yerden <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Nigko Yerden <nigko.yerden <at> gmail.com>
Subject: [PATCH] gnu: supertuxkart: Keep 'supertuxkart.desktop' file.
Date: Tue, 11 Mar 2025 14:22:59 +0500

* gnu/packages/games.scm (supertuxkart)[arguments]: Fix regexp in
'disable-data-install' phase so that the line in CMakeList.txt that installs
'supertuxkart.desktop' file is not commented out.

Change-Id: I408cdfeb9425c39228d38df4c15aee326e19dc34
---
 gnu/packages/games.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index fd22b0243f..89e06a3a81 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -4845,7 +4845,7 @@ (define-public supertuxkart
                (add-before 'configure 'disable-data-install
                  (lambda _
                    (substitute* "CMakeLists.txt"
-                     (("^install\\(.*STK_DATA_DIR" &)
+                     (("^install\\(DIRECTORY.*STK_DATA_DIR" &)
                       (string-append "# " &))))))))
     (inputs
      (list curl

base-commit: f70ad6267bf2bbafbf5eb0a1d04e2d624af796c5
-- 
2.48.1

Message #8 received at 76936 <at> debbugs.gnu.org (full text, mbox):

From: Nigko Yerden <nigko.yerden <at> gmail.com>
To: 76936 <at> debbugs.gnu.org, bavier <at> posteo.net
Subject: [PATCH] gnu: supertuxkart: Keep 'supertuxkart.desktop' file.
Date: Wed, 12 Mar 2025 21:33:04 +0500

Hello Eric Bavier,

I am very appreciate for your commit [1] that splits data from supertuxkart
package. Indeed, it was very annoying to download more than 700MB on almost
every upgrade. However, it seems that I found a minor bug in your nice patch:
supertuxkart has lost its .desktop file. Certainly, not everyone needs
.desktop file, but I think it would be better to keep it:)
 
Here [2] I suggest a one-line bug-fix. I checked that the supertuxkart
package is successfully built and works with this patch applied.

What do you think?

Thank you for your work!

Regards,
Nigko

[1] https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b33214d80e3e07421626449415e14bf120d93c9
[2] https://issues.guix.gnu.org/76936

Message #13 received at 76936-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <bavier <at> posteo.net>
To: Nigko Yerden <nigko.yerden <at> gmail.com>, 76936-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: supertuxkart: Keep 'supertuxkart.desktop' file.
Date: Fri, 14 Mar 2025 02:48:04 +0000

Hi Nigko,

I'm glad someone appreciates my improvement also.  Good catch, and 
thanks for the patch!  It looks good to me.  I've applied it in commit 
92124591eedf27e988c84f75acd4b4d99ff43122.

`~Eric

On 3/12/25 11:33, Nigko Yerden wrote:
> Hello Eric Bavier,
>
> I am very appreciate for your commit [1] that splits data from 
> supertuxkart
> package. Indeed, it was very annoying to download more than 700MB on 
> almost
> every upgrade. However, it seems that I found a minor bug in your nice 
> patch:
> supertuxkart has lost its .desktop file. Certainly, not everyone needs
> .desktop file, but I think it would be better to keep it:)
>
> Here [2] I suggest a one-line bug-fix. I checked that the supertuxkart
> package is successfully built and works with this patch applied.
>
> What do you think?
>
> Thank you for your work!
>
> Regards,
> Nigko
>
> [1] 
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b33214d80e3e07421626449415e14bf120d93c9
> [2] https://issues.guix.gnu.org/76936

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.