GNU bug report logs - #76917
[PATCH] gnu: python-numba: Disable tests that are not reproducible.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76917 in the body.
You can then email your comments to 76917 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: python-numba: Disable tests that are not reproducible.
Date: Mon, 10 Mar 2025 12:54:32 +0100

* gnu/packages/python-xyz.scm (python-numba):[arguments]: Adjust the
'disable-failing-tests phase to skip some additional tests that can fail
depending on current CPU.

Change-Id: I67f3a100f5863f6d946a8d07428e802178bd7391
---
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9f2829c4a8..4cb7c72a82 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29988,6 +29988,29 @@ (define-public python-numba
              (substitute* "numba/tests/test_import.py"
                (("def test_no_accidental_warnings")
                 "def disabled_test_no_accidental_warnings"))
+             ;; These tests fail due to result rounding depending on CPU.
+             (substitute* "numba/tests/test_looplifting.py"
+               (("def test_lift_objectmode_issue_4223")
+                "def disabled_test_lift_objectmode_issue_4223"))
+             (substitute* "numba/tests/test_extending.py"
+               (("def test_series_ufunc")
+                "def disabled_test_series_ufunc")
+               (("def test_index_ufunc")
+                "def disabled_test_index_ufunc"))
+             (substitute* "numba/tests/test_array_exprs.py"
+               (("def test_explicit_output")
+                "def disabled_test_explicit_output"))
+             (substitute* "numba/tests/test_target_extension.py"
+               (("def test_basic_offload")
+                "def disabled_test_basic_offload"))
+             (substitute* "numba/tests/test_np_functions.py"
+               (("def test_windowing")
+                "def disabled_test_windowing"))
+             ;; This fails nondeterministically, possibly depending on CPU.
+             ;; https://github.com/numba/numba/issues/8282.
+             (substitute* "numba/tests/test_function_type.py"
+               (("def test_wrapper_address_protocol_libm")
+                "def disabled_test_wrapper_address_protocol_libm"))
              ;; Some tests timeout or crash on some architectures.
              ,@(cond
                 ((target-aarch64?)

base-commit: 1548403fa70609a2efd47d1a802587799dc022d6
-- 
2.48.1

Message #8 received at 76917 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, 76917 <at> debbugs.gnu.org,
 Lars-Dominik Braun <lars <at> 6xq.net>, jgart <jgart <at> dismail.de>,
 Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: Re: [bug#76917] [PATCH] gnu: python-numba: Disable tests that are not
 reproducible.
Date: Mon, 10 Mar 2025 12:29:03 -0400

On Mon, Mar 10, 2025 at 10:23 AM Jelle Licht <jlicht <at> fsfe.org> wrote:
>
> * gnu/packages/python-xyz.scm (python-numba):[arguments]: Adjust the
> 'disable-failing-tests phase to skip some additional tests that can fail
> depending on current CPU.
>
> Change-Id: I67f3a100f5863f6d946a8d07428e802178bd7391
> ---
>  gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 9f2829c4a8..4cb7c72a82 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -29988,6 +29988,29 @@ (define-public python-numba
>               (substitute* "numba/tests/test_import.py"
>                 (("def test_no_accidental_warnings")
>                  "def disabled_test_no_accidental_warnings"))
> +             ;; These tests fail due to result rounding depending on CPU.
> +             (substitute* "numba/tests/test_looplifting.py"
> +               (("def test_lift_objectmode_issue_4223")
> +                "def disabled_test_lift_objectmode_issue_4223"))
> +             (substitute* "numba/tests/test_extending.py"
> +               (("def test_series_ufunc")
> +                "def disabled_test_series_ufunc")
> +               (("def test_index_ufunc")
> +                "def disabled_test_index_ufunc"))
> +             (substitute* "numba/tests/test_array_exprs.py"
> +               (("def test_explicit_output")
> +                "def disabled_test_explicit_output"))
> +             (substitute* "numba/tests/test_target_extension.py"
> +               (("def test_basic_offload")
> +                "def disabled_test_basic_offload"))
> +             (substitute* "numba/tests/test_np_functions.py"
> +               (("def test_windowing")
> +                "def disabled_test_windowing"))
> +             ;; This fails nondeterministically, possibly depending on CPU.
> +             ;; https://github.com/numba/numba/issues/8282.
> +             (substitute* "numba/tests/test_function_type.py"
> +               (("def test_wrapper_address_protocol_libm")
> +                "def disabled_test_wrapper_address_protocol_libm"))
>               ;; Some tests timeout or crash on some architectures.
>               ,@(cond
>                  ((target-aarch64?)
>
> base-commit: 1548403fa70609a2efd47d1a802587799dc022d6
> --
> 2.48.1

I think that I have been seeing both sets of errors disabled by this
patch, and I am now able to build python-numba again.

Reviewed-by: Greg Hogan <code <at> greghogan.com>

Message #11 received at 76917 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 76917 <at> debbugs.gnu.org
Subject: [PATCH] gnu: python-numba: Disable tests that are not reproducible.
Date: Mon, 10 Mar 2025 19:12:26 +0000

[Message part 1 (text/plain, inline)]

Hi,

It looks like Numba is CPU specific as I could build it all the time on
AMD Ryzen 7 3800X 8-Core Processor, but it fails to pass tests on
ci.guix.gnu.org on other user's machines.

It supports Pytest as test runner (PR #4781: WIP/runtest cf pytest)[1] I
might refactor the package to skip tests in #:tests-flags instead
altering tests files.

Meanwhile reviewing patch and build python-numba after apply.

1. https://github.com/numba/numba/blob/05b4cad9e10132c6c0166e76d80b034a18bce33a/docs/source/release-notes.rst#L3198

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 76917-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 76917-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: python-numba: Disable tests that are not reproducible.
Date: Mon, 10 Mar 2025 22:46:06 +0000

[Message part 1 (text/plain, inline)]

Hi,

Tests passed on my machine:
--8<---------------cut here---------------start------------->8---
Ran 10491 tests in 1336.846s
<...>
> grep -m1 "model name" /proc/cpuinfo
model name      : AMD Ryzen 7 3800X 8-Core Processor
--8<---------------cut here---------------end--------------->8---

Pushed to master as 42773718d5d5d42137ac84826850256fd6bed606.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.