From unknown Fri Jun 20 07:18:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#76892 <76892@debbugs.gnu.org> To: bug#76892 <76892@debbugs.gnu.org> Subject: Status: [PATCH v1] gnu: ntp: Fix crash. Reply-To: bug#76892 <76892@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:18:44 +0000 retitle 76892 [PATCH v1] gnu: ntp: Fix crash. reassign 76892 guix-patches submitter 76892 Jakob Kirsch severity 76892 normal tag 76892 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 09 11:20:11 2025 Received: (at submit) by debbugs.gnu.org; 9 Mar 2025 15:20:11 +0000 Received: from localhost ([127.0.0.1]:33854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trIRm-0000FL-T8 for submit@debbugs.gnu.org; Sun, 09 Mar 2025 11:20:11 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38900) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1trIRk-00009b-My for submit@debbugs.gnu.org; Sun, 09 Mar 2025 11:20:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trIRe-00071o-7L for guix-patches@gnu.org; Sun, 09 Mar 2025 11:20:02 -0400 Received: from mout.web.de ([212.227.15.3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trIRb-0001mZ-8r for guix-patches@gnu.org; Sun, 09 Mar 2025 11:20:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1741533593; x=1742138393; i=jakob.kirsch@web.de; bh=Df0N113wBi5lBDXfLeL00eDVNlzFfS8z41TbXOiaL04=; h=X-UI-Sender-Class:Date:From:To:Subject:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=AdPNh7xIVtkY+zRzOJsncAp2udhP2ZZJQT3bQxrd/0i5+YLLHTGk8wgOd4dEheIE Cbz+rqEjgIOBVL6Bkmd0rAAzsftBokl9gaAPzBryqExyUZlhSZ/fQEEaTfyFv1O2H XAS1DkGhe+K97KExZB9hY3q30VSfBjWz08OdCFCMt+54SekEBmsndqSvbrUBqk5PT MjicKdmmyhUEhgqShMb0YZ1/RcBVCv/Mi/BqcKc+TtVNjyJdW0TgiQSfEnnOh42NB 98KnSwpgL/fFRhVXKo59yoFVg1OrjbpKUPLj61pTbCWs8boNn1w+zbVOrPdFlMz3r SuPA8OwmzU/24WwBwQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from kernelpanicroom ([134.19.28.36]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M3Ez3-1tnjXR48fV-008IwU for ; Sun, 09 Mar 2025 16:19:53 +0100 Date: Sun, 9 Mar 2025 16:19:51 +0100 From: Jakob Kirsch To: guix-patches@gnu.org Subject: [PATCH v1] gnu: ntp: Fix crash. Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="5USq4ZLW3fYSoUNr" Content-Disposition: inline X-Provags-ID: V03:K1:SJYG9Vb2YIBp6oH+zvPrMLDs4LH+hJYXQs5mglUhWOCiBd8LAw0 gUEWSUv3cXefcKgUDJtxlYBBDBXlvDH6wdQGNgdGFF96U24wBAxpza8SMVfsxWiNsQo4/e2 7eUXP7PUU7mFKL4Lcvy8QtjvzztD/xfh0RXPQZYXLGJSHcypWLs8Bv/+Jm9FKD3JhbV7qaz cNVwcctOkrSk7bwZ39lIQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:6HqSdRS/0Rw=;EBZ9RxWVMk5SF3wQPTQPh2lVcqZ /B9UrCZ0sHGU8vlYGgOh9a1FzpJYUWEPg4KwfpIgIMlRSroEC/PEG5/ILWuVwnCm0Imp/V9y7 AtKiKa0OLjIdOwwC16yphL06osx51aRGV0LK0HqJFI3F5fuy+I3xEF33q9Ogz7jIWKU6SXt9X xqvlgSTBq59C0YMzC+RuioUQMmqz0TgaDIlcz+bepRfTqf0sxhnvvDM1JftchA2n05otxIVVA qUNZ0uHVxeObNZsV7wbgXdMrdgww20WXZx/GkeuixHQyfBsxSzrWfw9xcH/cXVVdgPj+W/74K ZXyQ+WTqhByDZG2mragAOgFAmzuGXgwT7J2YC+MP/FA+Q9EjJgD0DAcYxqZ86X2g0enW7oh5d BJQVSa2yfiMa2vvZdfoCl+2UwAvBm2HzdkD4UfRlyg61qVTSuHV273gA0t6pn7raoMCYbyE5A imz8ab7R7NCA2q32CJmd4ObuXd8ECS7D2ZZ64Rt6FWk6RcihDFrSgnFgjFg4NFq77ye9CCj2+ eMD+ZBgSePxQ6TR/tByMO70/ASLAQEfegz2WzCP71TzLAU5Afju6KPvXYPGGcUgb4lL+MkPaQ H+UCzPmJOVEsNa5L8GinrVlNhFLy5Uoh9ryRR1ssnVGH8PZP9rPhHQOzqxXzXmeRgs2nFA32/ 9ujxJw066EB9zIKK7VWrvD7Cz3kNu81YMENmxyX4i1vxCT7CKBgCnvnW/Hx+B68rWQ54OJ90S a0W1x9idmuEnkTtFI/YU+5ffDvZMJP+e6P8vaOzF0lHHR8sXvrdoPwDIevluh9NCgaww+7iju Pf2tvtynI3yeCt0UEzZCUwiI5JAd+ves/gMTsTL9pf1l5l84WgS9+iu1CJeUo8K258G9f1MJ5 7tVWVTduc4T2/6L6p77jwz0rAoJqZurMbNz5us2JtMkb4mpAhZIJCmS2ZCNFdXNKQx6dbAhjl CieWIIy9SQD3Tq1UqB9Oj1QmU1eJ8jBp89InNgMw/GB6p4dboO7CXOY/dzDaL+L1rtGbuI1Ln kJcc2DVYEojQGxR+qLcAO9ddodgvbmErheq33sqsWJt4BZ2wbOscQRqa/rNL5/dAnn9oln0mk +f8eCXnrUnLX1shNrgUab8j3JcsGeRsRPwSBXVI4mQPPXDC4udMFUjvSyBsnHCksE+bCbku7C Jokxzd+cNC/mX5NPpf/0DB6iF66a6tIzzp9xSSB/wAZPFcgVOPF9nfcOzW+8dihJF6b0UB2ka e0rxAzHABCwS5vx5COPBATQp0UR+hIL1zgqpX5Vs1r0wrl3DFQwBkRFsY8IdGWHGpa7JULpin V5s1mHN88jePrByXsFxurHaxMT/dGQZcderN7T+xtIrvYRoxWWR2nXt3sNfPzGj0bHXIjMnhY +mzEftFvFDgr2NuADDWjvfNA1QzsWM5oDxbP3FRS0mU6tHvPNnyar4uddQ Received-SPF: pass client-ip=212.227.15.3; envelope-from=jakob.kirsch@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --5USq4ZLW3fYSoUNr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ntpd segfaults at boot so here is a patch to fix that. --5USq4ZLW3fYSoUNr Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="v1-0001-gnu-ntp-Fix-crash.patch" Content-Transfer-Encoding: quoted-printable =46rom 3ebd9d493240978d5f2b14e55ed63754c43151c3 Mon Sep 17 00:00:00 2001 Message-ID: <3ebd9d493240978d5f2b14e55ed63754c43151c3.1741533506.git.jakob= .kirsch@web.de> From: Jakob Kirsch Date: Sun, 9 Mar 2025 16:16:43 +0100 Subject: [PATCH v1] gnu: ntp: Fix crash. * gnu/packages/ntp.scm (ntp): Add patch. * gnu/packages/patches/ntp-fix-dereferencing-the-wrong-variable.patch: Add= patch. * gnu/local.mk (dist_patch_DATA): Register patch. Change-Id: Ib3524c13fb2a1e6c70f8733cac3faeb427d00296 =2D-- gnu/local.mk | 1 + gnu/packages/ntp.scm | 94 +++++++++---------- ...fix-dereferencing-the-wrong-variable.patch | 45 +++++++++ 3 files changed, 92 insertions(+), 48 deletions(-) create mode 100644 gnu/packages/patches/ntp-fix-dereferencing-the-wrong-v= ariable.patch diff --git a/gnu/local.mk b/gnu/local.mk index 9082ed04bf..9658a7fd08 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -1908,6 +1908,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/nss-getcwd-nonnull.patch \ %D%/packages/patches/nss-increase-test-timeout.patch \ %D%/packages/patches/nss-3.56-pkgconfig.patch \ + %D%/packages/patches/ntp-fix-dereferencing-the-wrong-variable.patch \ %D%/packages/patches/nvi-assume-preserve-path.patch \ %D%/packages/patches/nvi-dbpagesize-binpower.patch \ %D%/packages/patches/nvi-db4.patch \ diff --git a/gnu/packages/ntp.scm b/gnu/packages/ntp.scm index 33ea790c9a..0b01f339d5 100644 =2D-- a/gnu/packages/ntp.scm +++ b/gnu/packages/ntp.scm @@ -132,62 +132,60 @@ (define-public chrony (define-public ntp (package - (name "ntp") - (version "4.2.8p18") - (source + (name "ntp") + (version "4.2.8p18") + (source (origin (method url-fetch) (uri (list (string-append "https://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-" - (version-major+minor version) - "/ntp-" version ".tar.gz") - (string-append - "http://archive.ntp.org/ntp4/ntp-" - (version-major+minor version) - "/ntp-" version ".tar.gz"))) + (version-major+minor version) "/ntp-" version ".tar.gz= ") + (string-append "http://archive.ntp.org/ntp4/ntp-" + (version-major+minor version) "/ntp-" ve= rsion + ".tar.gz"))) (sha256 (base32 "1rb8yksqxjcsjvww9kwnw1242qzszwixh916jj254a8szgrwb16g")) + (patches (search-patches + "ntp-fix-dereferencing-the-wrong-variable.patch")) (modules '((guix build utils))) - (snippet - '(begin - ;; Remove the bundled copy of libevent, but we must keep - ;; sntp/libevent/build-aux since configure.ac contains - ;; AC_CONFIG_AUX_DIR([sntp/libevent/build-aux]) - (rename-file "sntp/libevent/build-aux" - "sntp/libevent:build-aux") - (delete-file-recursively "sntp/libevent") - (mkdir "sntp/libevent") - (rename-file "sntp/libevent:build-aux" - "sntp/libevent/build-aux"))))) - (native-inputs (list which pkg-config)) - (inputs - (cons* openssl - libevent - ;; Build with POSIX capabilities support on GNU/Linux. This a= llows - ;; 'ntpd' to run as non-root (when invoked with '-u'.) - (if (target-linux?) - (list libcap) - '()))) - (arguments - (list - ;; Pass "--with-yielding-select=3Dyes" so that 'configure' knows whe= ther - ;; 'select' yields when using pthreads in a cross-compilation contex= t. - #:configure-flags - #~(list "--with-yielding-select=3Dyes") - #:phases - #~(modify-phases %standard-phases - (add-after 'unpack 'disable-network-test - (lambda _ - (substitute* "tests/libntp/Makefile.in" - (("test-decodenetnum\\$\\(EXEEXT\\) ") ""))))))) - (build-system gnu-build-system) - (synopsis "Real time clock synchronization system") - (description "NTP is a system designed to synchronize the clocks of + (snippet '(begin + ;; Remove the bundled copy of libevent, but we must ke= ep + ;; sntp/libevent/build-aux since configure.ac contains + ;; AC_CONFIG_AUX_DIR([sntp/libevent/build-aux]) + (rename-file "sntp/libevent/build-aux" + "sntp/libevent:build-aux") + (delete-file-recursively "sntp/libevent") + (mkdir "sntp/libevent") + (rename-file "sntp/libevent:build-aux" + "sntp/libevent/build-aux"))))) + (native-inputs (list which pkg-config)) + (inputs (cons* openssl libevent + ;; Build with POSIX capabilities support on GNU/Linux.= This allows + ;; 'ntpd' to run as non-root (when invoked with '-u'.) + (if (target-linux?) + (list libcap) + '()))) + (arguments + (list + ;; Pass "--with-yielding-select=3Dyes" so that 'configure' knows wh= ether + ;; 'select' yields when using pthreads in a cross-compilation conte= xt. + #:configure-flags + #~(list "--with-yielding-select=3Dyes") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'disable-network-test + (lambda _ + (substitute* "tests/libntp/Makefile.in" + (("test-decodenetnum\\$\\(EXEEXT\\) ") + ""))))))) + (build-system gnu-build-system) + (synopsis "Real time clock synchronization system") + (description "NTP is a system designed to synchronize the clocks of computers over a network.") - (license (l:x11-style - "https://www.eecis.udel.edu/~mills/ntp/html/copyright.html" - "A non-copyleft free licence from the University of Delaware= ")) - (home-page "https://www.ntp.org"))) + (license (l:x11-style + "https://www.eecis.udel.edu/~mills/ntp/html/copyright.html" + "A non-copyleft free licence from the University of Delawar= e")) + (home-page "https://www.ntp.org"))) (define-public openntpd (package diff --git a/gnu/packages/patches/ntp-fix-dereferencing-the-wrong-variable= .patch b/gnu/packages/patches/ntp-fix-dereferencing-the-wrong-variable.pat= ch new file mode 100644 index 0000000000..96108d2d83 =2D-- /dev/null +++ b/gnu/packages/patches/ntp-fix-dereferencing-the-wrong-variable.patch @@ -0,0 +1,45 @@ +Subject: [PATCH] Fix dereferencing the wrong variable + +In line 1911 in ntp_io.c, the code calls `create_interface(port, ep2)` an= d saves +the return value in the variable `ep`, which is then checked to not be `N= ULL` in +the next line. In case `ep` is `NULL`, the code starting in line 1923 is +executed. Keep in mind that `ep` is `NULL` in this branch. The error is l= ogged +in line 1928 and the address inside `ep` is converted using `stoa` by cal= ling +`stoa(&ep->sin)`. This would normally be fine since `socktoa` catches a `= NULL` +pointer in line 43 in socktoa.c but `&ep->sin` isn't `NULL` but 0x24 as t= he +field isn't the first one in the `endpt` struct. + +This then causes a segmentation fault by dereferencing the pointer `0x24`= in +line 46 as the code tries to get the address family using `AF(sock)`. + +This only happens when ntpd cannot create an interface which seems to hap= pen at +boot time leading to 6 crashes on my machine on average. + +The issue is that someone accidentally typed `ep` instead of the correct = `ep2`. + +This bug is being tracked as 3968 and 3928 upstream. +--- + ntpd/ntp_io.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/ntpd/ntp_io.c b/ntpd/ntp_io.c +index 9d79fe4..0e761ff 100644 +--- a/ntpd/ntp_io.c ++++ b/ntpd/ntp_io.c +@@ -1921,11 +1921,11 @@ update_interfaces( + } + else { + DPRINT_INTERFACE(3, +- (ep, "updating ", " new - FAILED")); ++ (ep2, "updating ", " new - FAILED")); + + msyslog(LOG_ERR, + "cannot bind address %s", +- stoa(&ep->sin)); ++ stoa(&ep2->sin)); + } + free(ep2); + } +-- +2.48.1 + base-commit: c4f297a664869a18126b66eb5209de1fcceb42d8 =2D- 2.48.1 --5USq4ZLW3fYSoUNr-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 09 17:36:29 2025 Received: (at submit) by debbugs.gnu.org; 9 Mar 2025 21:36:29 +0000 Received: from localhost ([127.0.0.1]:34589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trOJw-00048p-Sk for submit@debbugs.gnu.org; Sun, 09 Mar 2025 17:36:29 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34244) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1trOJt-00048N-Os for submit@debbugs.gnu.org; Sun, 09 Mar 2025 17:36:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trOJn-0002yZ-K2 for guix-patches@gnu.org; Sun, 09 Mar 2025 17:36:19 -0400 Received: from fhigh-b4-smtp.messagingengine.com ([202.12.124.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trOJl-0002xz-UY for guix-patches@gnu.org; Sun, 09 Mar 2025 17:36:19 -0400 Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfhigh.stl.internal (Postfix) with ESMTP id EF7992540088; Sun, 9 Mar 2025 17:36:16 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Sun, 09 Mar 2025 17:36:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mesmtp; t=1741556176; x= 1741642576; bh=Us8scZjgYOzswT/zq01UpMR/TwOt77WXwk/5l68eI5M=; b=z 0edt260qB6zETLquxP6bn3nhB975rCo0ctUnAEV1i2Z1mmfw69n0Hd+XLXyIxVWv QW4hYnzyoasm2O1//MeBjC1G7/vDHrKlTUWr+xeMY2dTIv8S3RktHabWgnbSWM25 48ADYnxH9grLwdJLnz2geCsWf3lI8YUuZ1nNAZKz7w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1741556176; x=1741642576; bh=Us8scZjgYOzswT/zq01UpMR/TwOt77WXwk/ 5l68eI5M=; b=T6C2Hb82SpG2Q5oVGcAquyC+3Jswx96oJGzUHHuFz/4rlV6ppmZ iHU23hEjSaGf3FfYTB4UIDbaznk3oGROQLrWy41nQv350Q0juSKt9tlONfgKUlsW BFEDIfm15Tn4qaa2maxUTChRmTmrJiatW11vz00twXQyKy6Gfp7WzZ1kcRukYb2H q9Pi4F9yHj68Ld1qmN0peTsdadRGhBrCWEkWr0pm3arTh+mML+xlI8n24CNpS0Ve 2ry7l9YLa/Dk0QJWY/JIIg2yDpPj3BuRg9VujCGY4zLlffA1dFehsXSXFiQ+NRvV 8GGkbbfdSBGJXs3RVM9QdXNutlVcAisx/Ig== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduudejheegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtredttddt vdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhird hnrghmvgeqnecuggftrfgrthhtvghrnhepieetudehfeekueefleegudfhjefgleehfeel uefhfeffgfeuudelhedvjeelieetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvgdpnhgspghrtghp thhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepghhuihigqdhprghttg hhvghssehgnhhurdhorhhgpdhrtghpthhtohepjeeikeelvdesuggvsggsuhhgshdrghhn uhdrohhrgh X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 Mar 2025 17:36:15 -0400 (EDT) Date: Sun, 9 Mar 2025 17:36:14 -0400 From: Leo Famulari To: Jakob Kirsch via Guix-patches via Subject: Re: [bug#76892] [PATCH v1] gnu: ntp: Fix crash. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=202.12.124.155; envelope-from=leo@famulari.name; helo=fhigh-b4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: 76892@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) On Sun, Mar 09, 2025 at 04:19:51PM +0100, Jakob Kirsch via Guix-patches via wrote: > ntpd segfaults at boot so here is a patch to fix that. > From 3ebd9d493240978d5f2b14e55ed63754c43151c3 Mon Sep 17 00:00:00 2001 > Message-ID: <3ebd9d493240978d5f2b14e55ed63754c43151c3.1741533506.git.jakob.kirsch@web.de> > From: Jakob Kirsch > Date: Sun, 9 Mar 2025 16:16:43 +0100 > Subject: [PATCH v1] gnu: ntp: Fix crash. > > * gnu/packages/ntp.scm (ntp): Add patch. > * gnu/packages/patches/ntp-fix-dereferencing-the-wrong-variable.patch: Add patch. > * gnu/local.mk (dist_patch_DATA): Register patch. Is the only change in this patch that we build ntp with the new patch file? And the rest of it is changes to indentation? Or are there other changes too? From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 09 17:52:28 2025 Received: (at 76892) by debbugs.gnu.org; 9 Mar 2025 21:52:29 +0000 Received: from localhost ([127.0.0.1]:34643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trOZQ-0004sz-MQ for submit@debbugs.gnu.org; Sun, 09 Mar 2025 17:52:28 -0400 Received: from mout.web.de ([212.227.15.4]:48303) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1trOZO-0004sj-Cu for 76892@debbugs.gnu.org; Sun, 09 Mar 2025 17:52:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1741557139; x=1742161939; i=jakob.kirsch@web.de; bh=MhkOOb/U2RguPmjF0Uihg/FevWgl4F0wUhbM8iVM8lU=; h=X-UI-Sender-Class:Date:From:To:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=py/xt9I7ljLUITehmAiZM9+zCUr85y+v+mARZAw+eBtlXEXOpM7laECn+59e/8Hv VnwoFzZNEZJSci9iK9HmusMtDxf44M6arcfvpw9ZKjcmZmGu7WA3rLrRz2fBUrf0x F1fy2CZ5QbN7tqggSDhP71JTUlbK7pP1sGozES/gF1rwAYOozhRRsCLZt6+GB9vMN CWJULMSj26KtbUGOMMqTeWptvKE2IwTIcXmyu0fnumoq58fDw3YFY/mZwywyT3a1O 9ll8XvpB4Rs16C6/mLFhOg8+InyMM0S1noGpJ8G98vy2/+oP3I8KQKjfz2ng2AFm/ IkP4Z0zPw7dmgY+Kjg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from kernelpanicroom ([134.19.28.36]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MpCqh-1tRzyu32eV-00lRRW for <76892@debbugs.gnu.org>; Sun, 09 Mar 2025 22:52:19 +0100 Date: Sun, 9 Mar 2025 22:52:17 +0100 From: Jakob Kirsch To: 76892@debbugs.gnu.org Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Provags-ID: V03:K1:iZ8Xr5MrHgio3S72CVGkXEbCkniyTony4TreW3GuwjJvFW+so1U B+QvK35iVI5sWpeqSkr6kTmgqmJQ0E16wnsq8rJST2j2nwQty+e5Wi6Xkq4LG3rjRXpfCiZ ffEvZ5W1rffzN8o1RP+w8XXM/Lh1jlGw/952QmY6c9lUZ1HohKQey3vOnOPqDp51iUkvqOs TeZ10lnr0FQlno5GNFpaA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:6Fz66+2hgM4=;9+LNiS0lny01vjraPk9Eas4IJEi GnDIAFseba8QpYzCLwvqG/ofw4oqwlcAnWD9LXLf+ixASyWAP0/4Xx7Gb/5Q87BryY/m0tT9i JNyl+HQfuGc/ipo4Y1UPg0pFw67o4344ZPqiZfFzZew98Qd+FeriuiMApB5G0B1wmtsEu46Dh FYAqpvIrr3RjJ7ThRhhpjaxFzrGhZM8ppFIxB55PhHwH69xv+RGsG/aysr51SIZ/cmlTXq8O/ g+D1WfGIPnXh+FixFxXm0xSAWOTF5hB43+i0WS04QDbG7hIMZeYPCbUwe38IRsIDrQnWnccOW IQQBI6data1LBZWmueRL5ld5U4fSU8yu0eKgRZIPThCofwX2KIVqNtKLYIgSLZc6aPcMcXiyq L0tt4Z+PsF0/MbhoA4c/87h/TcjiJOaX16TakWXL+hXWUiLIs1FFL5zTUh1KTZDDIO6qvzfkV AyLheiOnBCrVapeS2mYtqvRdS1dszmT1r5uldh+uLerdmB+76jDNNDrrpVishA+33ux3AodOe Ed1FFdfPyxXOc0x9D/ujCC9AI+1F7/RLi2TvDRnRX+i4Yg9t1EKmOISL9OiFOaKPDT3K7u6ha NMTu0D+FA8AeAsfxjsYpM0TI8pRJk3jou64dUiv2+8XGFDIOIB4fDMCaMocj8GbdAD37ZKOym pA7e8cBQsj/2m87ONC6Ypwz/ggGWyvBKz7YNlFYn1DzP9c11zmvZ5TrBA7fjV2zJeI6gdQspo FbFfYBd7m9u5Zz/CCVLElXogTAGdj7P906Q0H1LZKEvRKiXvB8VLFbPaxg7fJ8bk3c7oshh/F lGMyhvNM1SJWJpzvWb7uk/4Fu90TdTH7Oqq2DnIgcSAIDe3HFWSjy16DHfYCPKBG9m2lHsN+L 4OJQF1i+6xCwZ0I/mU1tYcuxwusa1bd5brGaO9l/kekVvR5pvcKBaT1/SFf8Hq/f6jQWhun64 KWfZkmyUttF6/BHnH2l00R7kU8eP6UgNmLU2SBxHHdsvb5kESYGqzBLCzyO7/3WppZWOb2bNz j422c0/iapQ8nq7eR8aCf1gGoy4j4GGYptrbSJ/V2QKzyIxznQkyEU8x9ObIUaLhy0FzzWE9d 15Q2Z2C4bBFO6UBSoqgqFjZq7uTTuxlS/8IKKnPoEm53GtnOyZPWi6gGZt2FUeua88ltFqH4d 0J/zn5Qrphujey+1tzOF6KbAvGNf4Y2RSaBanJgZCxV4xmjd5oLWMzweUrETJxpdD8oRXbeTr Zhqf4sEAbk32G4mWo/y38XoZSKIFiTggi+wwIXZK0uZ+JQ7Xl1MaWaOvi9Eu2XtSeD4KsMS9W pIN5QAOrjT3p+lciMxdh8xHzIKSO+sg5VgZLMyQQ8nZHNC8bVFnUdL05Tn7o9nmA2ic25rBkx UAE0mko2TKpA16lM8DBOaINvdVAQmQNgIeHGpw61/dyG9Cv3UbSR2MzawQ X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Yes I only added the patch to fix the crash (it's a typo where ep should be ep2) and ran `guix style ntp` on it. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.4 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.15.4 listed in bl.score.senderscore.com] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.4 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.4 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (jakob.kirsch[at]web.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: 76892 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Yes I only added the patch to fix the crash (it's a typo where ep should be ep2) and ran `guix style ntp` on it. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 10 00:48:26 2025 Received: (at 76892) by debbugs.gnu.org; 10 Mar 2025 04:48:26 +0000 Received: from localhost ([127.0.0.1]:35809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trV3y-0008R3-CK for submit@debbugs.gnu.org; Mon, 10 Mar 2025 00:48:26 -0400 Received: from fout-b8-smtp.messagingengine.com ([202.12.124.151]:51361) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1trV3u-0008Qn-TL for 76892@debbugs.gnu.org; Mon, 10 Mar 2025 00:48:24 -0400 Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id 20D381140159; Mon, 10 Mar 2025 00:48:17 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Mon, 10 Mar 2025 00:48:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm3; t=1741582096; x=1741668496; bh=a7 ZxnqmMcRJOS0trbw4RHEES5FpefycoXbZz0W+h7Rs=; b=VH0aKfNRB/rwHz3BTe JbXhwn3PwRD7rseGlPgfhOfNHlowXujZqW29BIFIvqlQHyCaBLvIu0t6zLIJk5jl ulbxNw/WtUdgGFyPEETUjReQQTvZEL6PYK3lwbv07W5HzappLtWQwpt4YHImx1s3 VJDkyAaDTV4xTzPpRIxDsfr3BUfYzvf70GmGlbgwNQFBxZZaBI54P2/9y9XraYC2 DLW1kX9gEozYShvufxyULTCAq3Le95VFI1y2TPFBDv4mKuuf0ISXpSFFOtLlPTme /FoGHLnwcBRmgkmBmiuMESN/muC98xqXYhhpu6hnPyqGHh1WWZ1/aiF45lmqi/Vh 3WVw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1741582096; x=1741668496; bh=a7ZxnqmMcRJOS0trbw4RHEES5Fpe fycoXbZz0W+h7Rs=; b=mnRAT3ujiNiuStgKrj5P4XMPl5Bn2TZ0jkL9iOanGCuS 4NQpvmC9O90xWwwxPhx/Dg6xtSmbe9e0Rh/OPPAQMff5/sCZmmQ1HcqF1JeBokWU V7xzJBuHZNA+eCDsRRX21traNQSWkHtQLS6MgJOy5znDkwqwr53XFeU8U61zPuBH 04DHHrqJsofCexX22xtaaBsooLiAIwO9Jn1mBekEHE+PTCvZmjQlSKdOCDvY0DiS hDMpa5NAe872pvYGveqRcAPVnft+TLZ/e+1ZysYm9RaPtqcDT8y/64db/AnCOZbJ DnSR8KvMHJn0JSp/BbAKlD/vZKQ2BmHw4oCxDhsJsQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduudekgedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvf evufgffffkgggtgfesthhqredttderjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgr nhesrhgvthhrohhsphgvtgdrthhvqeenucggtffrrghtthgvrhhnpefhteekteettefgud ejteeltdefhfekheelleehvddvfeegheffteeghfekudehveenucffohhmrghinhepnhht phdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehirghnsehrvghtrhhoshhpvggtrdhtvhdpnhgspghrtghpthhtohepvddpmhhouggv pehsmhhtphhouhhtpdhrtghpthhtohepjeeikeelvdesuggvsggsuhhgshdrghhnuhdroh hrghdprhgtphhtthhopehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Mar 2025 00:48:16 -0400 (EDT) From: Ian Eure To: Leo Famulari Subject: Re: [bug#76892] [PATCH v1] gnu: ntp: Fix crash. User-Agent: mu4e 1.12.9; emacs 29.4 Date: Sun, 09 Mar 2025 21:48:10 -0700 Message-ID: <871pv5cwz9.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76892 Cc: 76892@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Jakob, Leo, Leo Famulari writes: > On Sun, Mar 09, 2025 at 04:19:51PM +0100, Jakob Kirsch via=20 > Guix-patches via wrote: >> ntpd segfaults at boot so here is a patch to fix that. > >> From 3ebd9d493240978d5f2b14e55ed63754c43151c3 Mon Sep 17=20 >> 00:00:00 2001 >> Message-ID:=20 >> <3ebd9d493240978d5f2b14e55ed63754c43151c3.1741533506.git.jakob.kirsch@we= b.de> >> From: Jakob Kirsch >> Date: Sun, 9 Mar 2025 16:16:43 +0100 >> Subject: [PATCH v1] gnu: ntp: Fix crash. >>=20 >> * gnu/packages/ntp.scm (ntp): Add patch. >> *=20 >> gnu/packages/patches/ntp-fix-dereferencing-the-wrong-variable.patch:=20 >> Add patch. >> * gnu/local.mk (dist_patch_DATA): Register patch. > > Is the only change in this patch that we build ntp with the new=20 > patch > file? And the rest of it is changes to indentation? Or are there=20 > other > changes too? Here=E2=80=99s the upstream bug(s):=20 https://bugs.ntp.org/show_bug.cgi?id=3D3928=20 https://bugs.ntp.org/show_bug.cgi?id=3D3968 I think this patch is fine, we might also consider rolling back to=20 4.2.8p17. -- Ian From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 19 06:24:47 2025 Received: (at 76892-done) by debbugs.gnu.org; 19 Mar 2025 10:24:47 +0000 Received: from localhost ([127.0.0.1]:48539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tuqbP-00019i-Eq for submit@debbugs.gnu.org; Wed, 19 Mar 2025 06:24:47 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:59752) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tuqbK-00019I-UG; Wed, 19 Mar 2025 06:24:44 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id D8D4050E; Wed, 19 Mar 2025 11:24:34 +0100 (CET) Authentication-Results: hera.aquilenet.fr; none X-Virus-Scanned: Debian amavis at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavis, port 10024) with ESMTP id UZB0R1rkUUsr; Wed, 19 Mar 2025 11:24:34 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id E37EA42C; Wed, 19 Mar 2025 11:24:33 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Ian Eure Subject: Re: bug#76892: [PATCH v1] gnu: ntp: Fix crash. In-Reply-To: <871pv5cwz9.fsf@retrospec.tv> (Ian Eure's message of "Sun, 09 Mar 2025 21:48:10 -0700") References: <871pv5cwz9.fsf@retrospec.tv> Date: Wed, 19 Mar 2025 11:24:33 +0100 Message-ID: <874izpgvxa.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D8D4050E X-Spamd-Result: default: False [-6.01 / 15.00]; BAYES_HAM(-2.97)[99.86%]; NEURAL_HAM(-2.94)[-0.979]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; FREEMAIL_ENVRCPT(0.00)[web.de]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; URIBL_BLOCKED(0.00)[gnu.org:url,localhost:rdns,localhost:helo,retrospec.tv:email,ntp.org:url]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[famulari.name,debbugs.gnu.org,web.de] X-Rspamd-Action: no action X-Spamd-Bar: ------ X-Rspamd-Server: hera X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 76892-done Cc: Jakob Kirsch , 76401-done@debbugs.gnu.org, 76892-done@debbugs.gnu.org, Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Ian Eure skribis: > Here=E2=80=99s the upstream bug(s): https://bugs.ntp.org/show_bug.cgi?id= =3D3928 > https://bugs.ntp.org/show_bug.cgi?id=3D3968 > > I think this patch is fine, we might also consider rolling back to > 4.2.8p17. Applied, with a reference to too. Thanks, Ludo'. From unknown Fri Jun 20 07:18:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 16 Apr 2025 11:24:24 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator