GNU bug report logs - #76870
31.0.50; server-start with non-nil arg LEAVE-DEAD can write confusing warnings

Previous Next

Full log

Message #32 received at 76870 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
Cc: 76870 <at> debbugs.gnu.org
Subject: Re: bug#76870: 31.0.50; server-start with non-nil arg LEAVE-DEAD can
 write confusing warnings
Date: Sun, 16 Mar 2025 09:34:15 +0200

> Date: Sat, 15 Mar 2025 19:25:47 +0100
> Cc: 76870 <at> debbugs.gnu.org
> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
> 
> On 2025-03-15  12:50, Eli Zaretskii wrote:
> 
> > Would you like submitting a patch with that nit taken care of?
> 
> Yes, but please let me clarify another nit first.  With your
> proposal we would have error messages like this [comments and
> empty lines by me]:
> 
> - For the stop-then-restart case:
> 
>   [message unchanged comapared to master]
> 
>   ⛔ Warning (server): Unable to start the Emacs server.
> 
>   [the next line is actually generated from the caught error as `(cadr err)':]
>   There is an existing Emacs server, named "server"
>   To start the server in this Emacs process, stop the existing server or call M-x server-force-delete to forcibly disconnect it.
> 
> - For the stop-only case:
> 
>   ⛔ Warning (server): Unable to stop the server.
> 
>   [but "your" next line I cannot generate as `(cadr err)':]
>   The existing Emacs server, called "server", could not be stopped.
>   (Perhaps it was run from a different Emacs session?)
>   You can try stopping the server forcibly by calling M-x server-force-delete.
> 
> However, I like "your" second line better than the existing one, to be
> honest, and it would also fit the existing stop-then-restart case well.
> 
> So would you mind if I also changed function `server-stop' to always
> signal according to your proposal:
> 
>   (signal 'server-running-external
>           (list (format "The existing Emacs server, called \"%s\", could not be stopped."
>                         server-name))))
> 
> and then use the `(cadr err)' for both cases?

Yes, that'd be good.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.