Subject: Re: bug#76870: 31.0.50; server-start with non-nil arg LEAVE-DEAD can write confusing warnings

From: Eli Zaretskii <[email-masked]>
Date: Sat, 15 Mar 2025 13:50:36 +0200

> Date: Sun, 9 Mar 2025 22:18:08 +0100
> Cc: [email-masked]
> From: Jens Schmidt <[email-masked]>
> 
> On 2025-03-09  20:54, Eli Zaretskii wrote:
> 
> > How do you know it is an "external" server process?
> 
> Because 
> 
> a) the only condition handled by the condition-case
>    in `server-start´ (with and without my patch) is
>    named `server-running-external';
> 
> b) the only body form of the condition-case that
>    could signal something seems to be the call to
>    `server-stop´;
> 
> c) `server-stop' only seems to signal one "explicit"
>    signal, namely `server-running-external';
> 
> d) and that only if there is actually an external
>    server process running.
> 
> Wouldn't that justify to tailor the error messages also
> only to the "cannot stop external server" case?

Maybe, but I still prefer not to second guess what exactly happens,
but just tell what we know.

Would you like submitting a patch with that nit taken care of?