GNU bug report logs - #76864
[PATCH] services: Integrate gnome-keyring service in gnome-desktop service.

Previous Next

Full log

Message #19 received at 76864-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Vivien Kraus <vivien <at> planete-kraus.eu>,
 Ludovic Courtès <ludo <at> gnu.org>, 76864-done <at> debbugs.gnu.org
Subject: Re: [bug#76864] [PATCH] services: Integrate gnome-keyring service
 in gnome-desktop service.
Date: Sun, 09 Mar 2025 16:17:42 +0900

Hi,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

[...]

>> While I agree the naming is a mouthful, I find it necessary to have
>> it descriptive enough that it conveys the odd situation where we are
>> embedding a configuration object in another configuration :-).
>> 
>> So I'd keep it as is, knowing it probably will be seldom typed in a
>> user operating system config file anyway.
> For the field name adding -configuration is fine, but the accessor
> should really be shorter.  Compare slim-configuration-xorg or 
> gdm-configuration-xorg :)

OK, these existing precedents are enough to sway my opinion.  Renamed to
just '-keyring' and pushed!

Thanks for the review.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.