From unknown Sun Jun 22 00:11:34 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#76863] [PATCH] gnu: guile-libyaml: Improve packaging. Resent-From: Evgeny Pisemsky Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 08 Mar 2025 11:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 76863 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 76863@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.174143239215519 (code B ref -1); Sat, 08 Mar 2025 11:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Mar 2025 11:13:12 +0000 Received: from localhost ([127.0.0.1]:53109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqs7D-00042F-TJ for submit@debbugs.gnu.org; Sat, 08 Mar 2025 06:13:12 -0500 Received: from lists.gnu.org ([2001:470:142::17]:39448) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqs7C-00041o-6O for submit@debbugs.gnu.org; Sat, 08 Mar 2025 06:13:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqs74-0002cI-0R for guix-patches@gnu.org; Sat, 08 Mar 2025 06:13:02 -0500 Received: from pisemsky.site ([103.54.19.55]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqs71-0002sc-SB for guix-patches@gnu.org; Sat, 08 Mar 2025 06:13:01 -0500 Received: from localhost.localdomain ( [212.233.86.238]) by pisemsky.site (OpenSMTPD) with ESMTPSA id 36523d0c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sat, 8 Mar 2025 11:12:44 +0000 (UTC) From: Evgeny Pisemsky Date: Sat, 8 Mar 2025 14:12:24 +0300 Message-ID: X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=103.54.19.55; envelope-from=mail@pisemsky.site; helo=pisemsky.site X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_PBL=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/guile-xyz.scm (guile-libyaml): Run guix style. [version]: Specify semantic version. [source]: Use version tag, add deletion snippet. [build-system]: Use guile-build-system. [arguments]: Use gexps, clean up phases, disable auto compile. [native-inputs]: Add gcc, guile-3.0, nyacc. [inputs]: Remove guile-3.0. Change-Id: Id064f0cde60606a8f2bad8c903e840a9fa50376d --- gnu/packages/guile-xyz.scm | 88 ++++++++++++++++---------------------- 1 file changed, 37 insertions(+), 51 deletions(-) diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index e220f897ad..cc74591604 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -88,6 +88,7 @@ (define-module (gnu packages guile-xyz) #:use-module (gnu packages emacs) #:use-module (gnu packages emacs-xyz) #:use-module (gnu packages gawk) + #:use-module (gnu packages gcc) #:use-module (gnu packages gettext) #:use-module (gnu packages gl) #:use-module (gnu packages glib) @@ -6218,57 +6219,42 @@ (define-public guile-drmaa (license license:gpl3+))) (define-public guile-libyaml - (let ((commit "2bdacb72a65ab63264b2edc9dac9692df7ec9b3e") - (revision "2")) - (package - (name "guile-libyaml") - (version (git-version "0" revision commit)) - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/mwette/guile-libyaml") - (commit commit))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "1bssby1ri1vjll2rvi8b33xr2ghwjyxsd4yc15najj3h8n2ss87i")))) - (build-system gnu-build-system) - (arguments - `(#:modules (((guix build guile-build-system) - #:prefix guile:) - ,@%default-gnu-modules) - #:imported-modules ((guix build guile-build-system) - ,@%default-gnu-imported-modules) - #:tests? #false ; there are none - #:phases - (modify-phases %standard-phases - (delete 'configure) - (add-after 'unpack 'remove-unused-files - (lambda* (#:key inputs #:allow-other-keys) - (for-each delete-file '("guix.scm" "demo1.yml" "demo1.scm")))) - (add-before 'build 'build-ffi - (lambda* (#:key inputs #:allow-other-keys) - (invoke "guild" "compile-ffi" - "--no-exec" ; allow us to patch the generated file - "yaml/libyaml.ffi") - (substitute* "yaml/libyaml.scm" - (("dynamic-link \"libyaml\"") - (format #false "dynamic-link \"~a/lib/libyaml\"" - (assoc-ref inputs "libyaml")))))) - (replace 'build - (assoc-ref guile:%standard-phases 'build)) - (delete 'install)))) - (inputs - (list guile-3.0 libyaml)) - (propagated-inputs - (list guile-bytestructures nyacc)) - (home-page "https://github.com/mwette/guile-libyaml") - (synopsis "Guile wrapper for libyaml") - (description - "This package provides a simple yaml module for Guile using the -ffi-helper from nyacc.") - (license license:lgpl3+)))) + (package + (name "guile-libyaml") + (version "1.0.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/mwette/guile-libyaml") + (commit (string-append "V" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1bssby1ri1vjll2rvi8b33xr2ghwjyxsd4yc15najj3h8n2ss87i")) + (snippet #~(for-each delete-file + '("guix.scm" "demo1.yml" "demo1.scm"))))) + (build-system guile-build-system) + (arguments + (list + #:phases + #~(modify-phases %standard-phases + (add-before 'build 'build-ffi + (lambda* (#:key inputs #:allow-other-keys) + (setenv "GUILE_AUTO_COMPILE" "0") + (invoke "guild" "compile-ffi" "--no-exec" "yaml/libyaml.ffi") + (substitute* "yaml/libyaml.scm" + (("dynamic-link \"libyaml\"") + (format #f "dynamic-link \"~a/lib/libyaml\"" + (assoc-ref inputs "libyaml"))))))))) + (native-inputs (list gcc guile-3.0 nyacc)) + (inputs (list libyaml)) + (propagated-inputs (list guile-bytestructures nyacc)) + (home-page "https://github.com/mwette/guile-libyaml") + (synopsis "Guile wrapper for libyaml") + (description + "This package provides a simple yaml module for Guile using the ffi-helper from +nyacc.") + (license license:lgpl3+))) (define-public schmutz (let ((commit "f8043e6c258d2e29d153bc37cb17b130fee0579f") base-commit: 42bc94adbd1114771ef14a8e19563829ae355e87 -- 2.48.1 From unknown Sun Jun 22 00:11:34 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Evgeny Pisemsky Subject: bug#76863: closed (Re: [bug#76863] [PATCH] gnu: guile-libyaml: Improve packaging.) Message-ID: References: <87r035q43g.fsf@gnu.org> X-Gnu-PR-Message: they-closed 76863 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 76863@debbugs.gnu.org Date: Sun, 09 Mar 2025 21:37:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1741556224-16017-1" This is a multi-part message in MIME format... ------------=_1741556224-16017-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #76863: [PATCH] gnu: guile-libyaml: Improve packaging. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 76863@debbugs.gnu.org. --=20 76863: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76863 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1741556224-16017-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 76863-done) by debbugs.gnu.org; 9 Mar 2025 21:36:17 +0000 Received: from localhost ([127.0.0.1]:34581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trOJk-000488-S6 for submit@debbugs.gnu.org; Sun, 09 Mar 2025 17:36:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57786) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1trOJh-00047r-TA for 76863-done@debbugs.gnu.org; Sun, 09 Mar 2025 17:36:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trOJb-0002xG-VN; Sun, 09 Mar 2025 17:36:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=zX325LixV5xXflesDlnzwGVl6IV2OQOCtkPSQCSo828=; b=b799iGCv6mgsdo0DOF7E 0hrmTopv62qQ5fnjTUwDwUj959zbUvir27Rnoee6u+x4j0rveo30X79oufUPvB06HRF2O9LJef5ue CQ2BhA6AlPCOhic0iytu3IqbaTSB8Yr8iCbDpY7dJXgJVrROqndKyIus6ImiQiMZrxv6sRFsf6y09 QTyzAnuaZZMMQVhYSoBdnH2+zpg+aL0gc+x0jZG1t3HJi4Ft48iOKGFJvVSEQotGt7La+NuyHTHSo HaG5RubkfiT4inoXTWhJnlB9+owKMNhRUbiUMZGOGDH9/F5b+oY8/U3K4zjFk6d5LEuaLob+zaF8H 1R+g5msYz/fw2A==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Evgeny Pisemsky Subject: Re: [bug#76863] [PATCH] gnu: guile-libyaml: Improve packaging. In-Reply-To: (Evgeny Pisemsky's message of "Sat, 8 Mar 2025 14:12:24 +0300") References: Date: Sun, 09 Mar 2025 22:36:03 +0100 Message-ID: <87r035q43g.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76863-done Cc: 76863-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Evgeny Pisemsky skribis: > * gnu/packages/guile-xyz.scm (guile-libyaml): Run guix style. > [version]: Specify semantic version. > [source]: Use version tag, add deletion snippet. > [build-system]: Use guile-build-system. > [arguments]: Use gexps, clean up phases, disable auto compile. > [native-inputs]: Add gcc, guile-3.0, nyacc. > [inputs]: Remove guile-3.0. > > Change-Id: Id064f0cde60606a8f2bad8c903e840a9fa50376d Applied, thanks! ------------=_1741556224-16017-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Mar 2025 11:13:12 +0000 Received: from localhost ([127.0.0.1]:53109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqs7D-00042F-TJ for submit@debbugs.gnu.org; Sat, 08 Mar 2025 06:13:12 -0500 Received: from lists.gnu.org ([2001:470:142::17]:39448) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqs7C-00041o-6O for submit@debbugs.gnu.org; Sat, 08 Mar 2025 06:13:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqs74-0002cI-0R for guix-patches@gnu.org; Sat, 08 Mar 2025 06:13:02 -0500 Received: from pisemsky.site ([103.54.19.55]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqs71-0002sc-SB for guix-patches@gnu.org; Sat, 08 Mar 2025 06:13:01 -0500 Received: from localhost.localdomain ( [212.233.86.238]) by pisemsky.site (OpenSMTPD) with ESMTPSA id 36523d0c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sat, 8 Mar 2025 11:12:44 +0000 (UTC) From: Evgeny Pisemsky To: guix-patches@gnu.org Subject: [PATCH] gnu: guile-libyaml: Improve packaging. Date: Sat, 8 Mar 2025 14:12:24 +0300 Message-ID: X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=103.54.19.55; envelope-from=mail@pisemsky.site; helo=pisemsky.site X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_PBL=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/guile-xyz.scm (guile-libyaml): Run guix style. [version]: Specify semantic version. [source]: Use version tag, add deletion snippet. [build-system]: Use guile-build-system. [arguments]: Use gexps, clean up phases, disable auto compile. [native-inputs]: Add gcc, guile-3.0, nyacc. [inputs]: Remove guile-3.0. Change-Id: Id064f0cde60606a8f2bad8c903e840a9fa50376d --- gnu/packages/guile-xyz.scm | 88 ++++++++++++++++---------------------- 1 file changed, 37 insertions(+), 51 deletions(-) diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm index e220f897ad..cc74591604 100644 --- a/gnu/packages/guile-xyz.scm +++ b/gnu/packages/guile-xyz.scm @@ -88,6 +88,7 @@ (define-module (gnu packages guile-xyz) #:use-module (gnu packages emacs) #:use-module (gnu packages emacs-xyz) #:use-module (gnu packages gawk) + #:use-module (gnu packages gcc) #:use-module (gnu packages gettext) #:use-module (gnu packages gl) #:use-module (gnu packages glib) @@ -6218,57 +6219,42 @@ (define-public guile-drmaa (license license:gpl3+))) (define-public guile-libyaml - (let ((commit "2bdacb72a65ab63264b2edc9dac9692df7ec9b3e") - (revision "2")) - (package - (name "guile-libyaml") - (version (git-version "0" revision commit)) - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/mwette/guile-libyaml") - (commit commit))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "1bssby1ri1vjll2rvi8b33xr2ghwjyxsd4yc15najj3h8n2ss87i")))) - (build-system gnu-build-system) - (arguments - `(#:modules (((guix build guile-build-system) - #:prefix guile:) - ,@%default-gnu-modules) - #:imported-modules ((guix build guile-build-system) - ,@%default-gnu-imported-modules) - #:tests? #false ; there are none - #:phases - (modify-phases %standard-phases - (delete 'configure) - (add-after 'unpack 'remove-unused-files - (lambda* (#:key inputs #:allow-other-keys) - (for-each delete-file '("guix.scm" "demo1.yml" "demo1.scm")))) - (add-before 'build 'build-ffi - (lambda* (#:key inputs #:allow-other-keys) - (invoke "guild" "compile-ffi" - "--no-exec" ; allow us to patch the generated file - "yaml/libyaml.ffi") - (substitute* "yaml/libyaml.scm" - (("dynamic-link \"libyaml\"") - (format #false "dynamic-link \"~a/lib/libyaml\"" - (assoc-ref inputs "libyaml")))))) - (replace 'build - (assoc-ref guile:%standard-phases 'build)) - (delete 'install)))) - (inputs - (list guile-3.0 libyaml)) - (propagated-inputs - (list guile-bytestructures nyacc)) - (home-page "https://github.com/mwette/guile-libyaml") - (synopsis "Guile wrapper for libyaml") - (description - "This package provides a simple yaml module for Guile using the -ffi-helper from nyacc.") - (license license:lgpl3+)))) + (package + (name "guile-libyaml") + (version "1.0.0") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/mwette/guile-libyaml") + (commit (string-append "V" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1bssby1ri1vjll2rvi8b33xr2ghwjyxsd4yc15najj3h8n2ss87i")) + (snippet #~(for-each delete-file + '("guix.scm" "demo1.yml" "demo1.scm"))))) + (build-system guile-build-system) + (arguments + (list + #:phases + #~(modify-phases %standard-phases + (add-before 'build 'build-ffi + (lambda* (#:key inputs #:allow-other-keys) + (setenv "GUILE_AUTO_COMPILE" "0") + (invoke "guild" "compile-ffi" "--no-exec" "yaml/libyaml.ffi") + (substitute* "yaml/libyaml.scm" + (("dynamic-link \"libyaml\"") + (format #f "dynamic-link \"~a/lib/libyaml\"" + (assoc-ref inputs "libyaml"))))))))) + (native-inputs (list gcc guile-3.0 nyacc)) + (inputs (list libyaml)) + (propagated-inputs (list guile-bytestructures nyacc)) + (home-page "https://github.com/mwette/guile-libyaml") + (synopsis "Guile wrapper for libyaml") + (description + "This package provides a simple yaml module for Guile using the ffi-helper from +nyacc.") + (license license:lgpl3+))) (define-public schmutz (let ((commit "f8043e6c258d2e29d153bc37cb17b130fee0579f") base-commit: 42bc94adbd1114771ef14a8e19563829ae355e87 -- 2.48.1 ------------=_1741556224-16017-1--