From unknown Wed Jun 18 23:10:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#76858 <76858@debbugs.gnu.org> To: bug#76858 <76858@debbugs.gnu.org> Subject: Status: [PATCH] window-tool-bar: Use `static-if' from Compat 30 Reply-To: bug#76858 <76858@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:10:16 +0000 retitle 76858 [PATCH] window-tool-bar: Use `static-if' from Compat 30 reassign 76858 emacs submitter 76858 Daniel Mendler severity 76858 wishlist tag 76858 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 08 03:27:30 2025 Received: (at submit) by debbugs.gnu.org; 8 Mar 2025 08:27:30 +0000 Received: from localhost ([127.0.0.1]:52689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqpWs-0003Gx-DO for submit@debbugs.gnu.org; Sat, 08 Mar 2025 03:27:30 -0500 Received: from lists.gnu.org ([2001:470:142::17]:39766) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqpWp-0003Gg-9n for submit@debbugs.gnu.org; Sat, 08 Mar 2025 03:27:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqpWj-0003fH-P7 for bug-gnu-emacs@gnu.org; Sat, 08 Mar 2025 03:27:21 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqpWh-0007YR-GU for bug-gnu-emacs@gnu.org; Sat, 08 Mar 2025 03:27:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DRBv+vaNAm4nYCwdN9Xu0wv2ov5zfjnOCgGE51JKqYs=; b=TfQSsmJd69hwb04Q+QHamzS23j fOmcAJFwjA4oPc95oeVZMlnLkRDan9aCBhWy0aE7kn0RFmUD5O+nHvUEh82ku3n626gEVZUhqQxdB NwsGo931jt7+PtIgLbotMtESTyPYrjQMOSltUvZnfAl7VX4LltSL0ZepGgLtYsatIMBA=; From: Daniel Mendler To: bug-gnu-emacs@gnu.org Subject: [PATCH] window-tool-bar: Use `static-if' from Compat 30 Date: Sat, 08 Mar 2025 09:26:57 +0100 Message-ID: <87zfhwq65q.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Jared Finder X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch Compat 30 is available on ELPA and provides `static-if'. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-window-tool-bar-Use-static-if-from-Compat-30.patch >From e2a734e891112756ec047bc02801091036f7085c Mon Sep 17 00:00:00 2001 From: Daniel Mendler Date: Sat, 8 Mar 2025 09:23:53 +0100 Subject: [PATCH] window-tool-bar: Use `static-if' from Compat 30 * lisp/window-tool-bar.el (window-tool-bar--static-if): Remove (window-tool-bar--ignored-event-types): Use `static-if' from Compat instead. --- lisp/window-tool-bar.el | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/lisp/window-tool-bar.el b/lisp/window-tool-bar.el index 96726960fea..08f8e41f6c2 100644 --- a/lisp/window-tool-bar.el +++ b/lisp/window-tool-bar.el @@ -7,7 +7,7 @@ ;; Version: 0.3 ;; Keywords: mouse ;; URL: http://github.com/chaosemer/window-tool-bar -;; Package-Requires: ((emacs "27.1") (compat "29.1")) +;; Package-Requires: ((emacs "27.1") (compat "30")) ;; This is a GNU ELPA :core package. Avoid adding functionality that ;; is not available in the version of Emacs recorded above or any of @@ -385,26 +385,13 @@ window-tool-bar--ignore (interactive) nil) -;; static-if was added in Emacs 30, but this packages supports earlier -;; versions. -(defmacro window-tool-bar--static-if (condition then-form &rest else-forms) - "A conditional compilation macro. -Evaluate CONDITION at macro-expansion time. If it is non-nil, -expand the macro to THEN-FORM. Otherwise expand it to ELSE-FORMS -enclosed in a `progn' form. ELSE-FORMS may be empty." - (declare (indent 2) - (debug (sexp sexp &rest sexp))) - (if (eval condition lexical-binding) - then-form - (cons 'progn else-forms))) - (defvar window-tool-bar--ignored-event-types (let ((list (append '(mouse-movement pinch wheel-down wheel-up wheel-left wheel-right) ;; Prior to emacs 30, wheel events could also surface as ;; mouse- buttons. - (window-tool-bar--static-if (version< emacs-version "30") + (static-if (< emacs-major-version 30) (list mouse-wheel-down-event mouse-wheel-up-event mouse-wheel-left-event mouse-wheel-right-event -- 2.47.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 08 10:37:03 2025 Received: (at submit) by debbugs.gnu.org; 8 Mar 2025 15:37:03 +0000 Received: from localhost ([127.0.0.1]:56185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqwEY-0004a3-TA for submit@debbugs.gnu.org; Sat, 08 Mar 2025 10:37:03 -0500 Received: from lists.gnu.org ([2001:470:142::17]:37912) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqwEV-0004ZH-NI for submit@debbugs.gnu.org; Sat, 08 Mar 2025 10:37:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqwEP-0006Bw-HT for bug-gnu-emacs@gnu.org; Sat, 08 Mar 2025 10:36:54 -0500 Received: from greenhill.hpalace.com ([192.155.80.58]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqwEN-0004Hl-Si for bug-gnu-emacs@gnu.org; Sat, 08 Mar 2025 10:36:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1741448207; bh=hRgyEWrH/DRy4gK77E1LkVoPvzSJ8/lZQXPZp28uJL4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EgOkKwHHAvQj+E02I9BhT9aRzwiJ+sWEkud/usjHe7YVOoIzj65HJgaHsCQoHhIuW yylW9v0LzeoITTvw3giEDg9yWsLDpnHQLXPnGMYOvOoqslJxh0+mLXUEsFzXnsLGEX dvrHrwGkfHkof0OWMjlZsj4z9nAv1i/dW9WQPAFg9nWj2y7bgh+xc560GSM/w/YYUZ 9xfDtkWq645nXZWnb6p9HU17snKg8Yx0eHWUAU5DKYeCsB53GQBVzFfo3/9fYHrs+F RCAYIXZFheTjjguAiDN4QeiKQrDW1dN6G6vZne+bLcVofDtbQDQ0OUGv10Su3kH3kq TARUB6x6b7DSA== Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 37DB71F4B; Sat, 8 Mar 2025 15:36:47 +0000 (UTC) MIME-Version: 1.0 Date: Sat, 08 Mar 2025 07:36:47 -0800 From: Jared Finder To: Daniel Mendler Subject: Re: [PATCH] window-tool-bar: Use `static-if' from Compat 30 In-Reply-To: <87zfhwq65q.fsf@daniel-mendler.de> References: <87zfhwq65q.fsf@daniel-mendler.de> Message-ID: <7f005d5f711081b11e5f27ad1bd094c3@finder.org> X-Sender: jared@finder.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=192.155.80.58; envelope-from=jared@finder.org; helo=greenhill.hpalace.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) On 2025-03-08 00:26, Daniel Mendler wrote: > Tags: patch > > Compat 30 is available on ELPA and provides `static-if'. I see this created Bug#76858. (apologies if a new bug is created here) > -;; Package-Requires: ((emacs "27.1") (compat "29.1")) > +;; Package-Requires: ((emacs "27.1") (compat "30")) I think this also needs (eval-when-compile (require 'compat)) since static-if is a macro. But I could be wrong here, I'm always a bit confused about Emacs Lisp's eval-when forms. -- MJF From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 08 10:43:48 2025 Received: (at submit) by debbugs.gnu.org; 8 Mar 2025 15:43:49 +0000 Received: from localhost ([127.0.0.1]:56212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqwL6-0004tp-KZ for submit@debbugs.gnu.org; Sat, 08 Mar 2025 10:43:48 -0500 Received: from lists.gnu.org ([2001:470:142::17]:42352) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqwL3-0004ta-Jp for submit@debbugs.gnu.org; Sat, 08 Mar 2025 10:43:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqwKy-0008Ug-84 for bug-gnu-emacs@gnu.org; Sat, 08 Mar 2025 10:43:40 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqwKw-0007TF-7s for bug-gnu-emacs@gnu.org; Sat, 08 Mar 2025 10:43:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=G8I3aSarDGKv1EsPNfk7A+Dhtlla+PtKB5n5YLJejsg=; b=kqkkQPToUKk0B1+4DEFVUZAual qNiTZwWRoWkF2Fklf9jKb4+PolYe01mxK4AoO53H/8H0oKUA+j8iNbZ6qF/ZQLwINSzX7a02lho+4 4DWZSWHE+uZNqpw7JNUf7I1iI2P0LCZ/K/o6Z6fiZmWOZgw4R1CAB0zg6HQ4gIyB/2Mg=; From: Daniel Mendler To: Jared Finder Subject: Re: [PATCH] window-tool-bar: Use `static-if' from Compat 30 In-Reply-To: <7f005d5f711081b11e5f27ad1bd094c3@finder.org> (Jared Finder's message of "Sat, 08 Mar 2025 07:36:47 -0800") References: <87zfhwq65q.fsf@daniel-mendler.de> <7f005d5f711081b11e5f27ad1bd094c3@finder.org> Date: Sat, 08 Mar 2025 16:43:32 +0100 Message-ID: <87h643cyu3.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Jared Finder writes: > On 2025-03-08 00:26, Daniel Mendler wrote: >> Tags: patch >> Compat 30 is available on ELPA and provides `static-if'. > > I see this created Bug#76858. (apologies if a new bug is created here) > >> -;; Package-Requires: ((emacs "27.1") (compat "29.1")) >> +;; Package-Requires: ((emacs "27.1") (compat "30")) > > I think this also needs (eval-when-compile (require 'compat)) since static-if is > a macro. But I could be wrong here, I'm always a bit confused about Emacs Lisp's > eval-when forms. No, (require 'compat) is sufficient. > -- MJF From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 08 23:52:42 2025 Received: (at submit) by debbugs.gnu.org; 9 Mar 2025 04:52:42 +0000 Received: from localhost ([127.0.0.1]:57635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tr8eY-000229-7B for submit@debbugs.gnu.org; Sat, 08 Mar 2025 23:52:42 -0500 Received: from lists.gnu.org ([2001:470:142::17]:56014) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tr8eW-00021t-3Y for submit@debbugs.gnu.org; Sat, 08 Mar 2025 23:52:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tr8eQ-00023K-JZ for bug-gnu-emacs@gnu.org; Sat, 08 Mar 2025 23:52:34 -0500 Received: from greenhill.hpalace.com ([192.155.80.58]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tr8eO-00015E-Sv for bug-gnu-emacs@gnu.org; Sat, 08 Mar 2025 23:52:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=finder.org; s=2018; t=1741495950; bh=zsA5JiXuJ3Vx+JbFt/E8/UvXzhH9gbeZLHvozLTQgFg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f0qjzpvM75FoilniHW2JUMpbuHYiMp87zi2NxaFNdVkx2ag+PhCuINuxrS8ZtPZx5 0y6qbgoshXbOuKbepel/pYv41oJN9c05kWFVfx50IJd8a9SZedWBQrTeQN4XKe75Hd X41L39tXsNwlFhmwg/p11CCoidCpntlt5dGiGsFIo9PkZi9wNoNldRkJqZHK0yCx25 K72dYMk/uHDJkL4LCZrc/qt5cye0ScoQPriAC5jKFLjmgdAiWkMsGAJvPX5JF3A0Kg NSptgE0I/H678z5rSrK3S6aPjLJ4tsqHuBzqhrTp6Ffrsc6SLQuSgCzOMTvoItYMfW zITqvKP3Lg6pw== Received: from mail.finder.org (unknown [192.155.80.58]) by greenhill.hpalace.com (Postfix) with ESMTPSA id 27CFB18EF; Sun, 9 Mar 2025 04:52:30 +0000 (UTC) MIME-Version: 1.0 Date: Sat, 08 Mar 2025 20:52:30 -0800 From: Jared Finder To: Daniel Mendler Subject: Re: [PATCH] window-tool-bar: Use `static-if' from Compat 30 In-Reply-To: <87h643cyu3.fsf@daniel-mendler.de> References: <87zfhwq65q.fsf@daniel-mendler.de> <7f005d5f711081b11e5f27ad1bd094c3@finder.org> <87h643cyu3.fsf@daniel-mendler.de> Message-ID: <33f37cdc30a4aea3dd40f80590618546@finder.org> X-Sender: jared@finder.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=192.155.80.58; envelope-from=jared@finder.org; helo=greenhill.hpalace.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) On 2025-03-08 07:43, Daniel Mendler wrote: > Jared Finder writes: > >> On 2025-03-08 00:26, Daniel Mendler wrote: >>> Tags: patch >>> Compat 30 is available on ELPA and provides `static-if'. >> >> I see this created Bug#76858. (apologies if a new bug is created here) >> >>> -;; Package-Requires: ((emacs "27.1") (compat "29.1")) >>> +;; Package-Requires: ((emacs "27.1") (compat "30")) >> >> I think this also needs (eval-when-compile (require 'compat)) since >> static-if is >> a macro. But I could be wrong here, I'm always a bit confused about >> Emacs Lisp's >> eval-when forms. > > No, (require 'compat) is sufficient. Ok, I have no objections then. -- MJF From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 10 17:06:48 2025 Received: (at control) by debbugs.gnu.org; 10 Mar 2025 21:06:48 +0000 Received: from localhost ([127.0.0.1]:40100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trkKm-0003o0-CO for submit@debbugs.gnu.org; Mon, 10 Mar 2025 17:06:48 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:53264) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1trkKk-0003nl-PW for control@debbugs.gnu.org; Mon, 10 Mar 2025 17:06:47 -0400 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5e5e1a38c1aso4150381a12.2 for ; Mon, 10 Mar 2025 14:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741640800; x=1742245600; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=QBvBuhpOWn9Q45XUvzpNA4OIny33fqKhuXgwFQVFLWY=; b=gLlFqjwWvGw3Vx2o53C5EEOhH0zIr0xmx5z8FgQ7Fo8zQbUaeWAWVSEJldiAoVZeXd Tvk3W0MelP0WpkQON2cB594XoyHysdEbRmHBcpqgj8+kxFdIldP2d48YHo/xwrEquNBc KAMR8oNxlaLXSOcX75FVke7MZ1LMiirq2i5FKWLZXBy1raDHtei4W69zQbhCgZhxH3Uc eXjUIPi9NKhOpfTQWs8QI7OygBF5P8icc8urFGghujEWjVjhVkCUReP0tJ9K6HwoEtqG NmsxLXgsnAL/HBUnZnN66rZn1E48qCyqymrqYf13KUrt8szUiMomsuVaeo1ax5iK788F utfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741640800; x=1742245600; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=QBvBuhpOWn9Q45XUvzpNA4OIny33fqKhuXgwFQVFLWY=; b=qnbOCfcYUpZA5qtvhvo91yzdXMZU2GrGsLKBPZAQFPw0y7myEZg+029KhfW6RETcnr oQF58pLVnY5yTDg5vj/i3JFwkWquyBi8Nq0jXTapM669dy8jJ2aU2NT/dfm2JpRjqnO/ 2CIf5OyvZsHdsEIKqc/anCdCkXQyHfb5Bsbuve6pCdBQ8ywu/wDpA4Vz70IhnEZF8dxa d/wX8IZ384/D8hERY2lq/8F/XaviUEhmRUBY3+aSZDaBAgtrl/s0UW31rk/ZxirKXtQ6 GOh+XbJzlF1lgj0lO1nuRG+isT4XHknJnZobzpaobGXtNpTo3tsTJMTgfvxf2k/T/0kw +D5A== X-Gm-Message-State: AOJu0YzTzEL+gMA8NvnPX2tGllG7h3MQr6ZzUeO7GFm7YXCcQvEjR5AF 5i7J8LPRDlNbTWHYFdpTyLzgCDj6h4FcTWYrqbUhjX4UrImtOfiKoRVMkLEvmJsCljPgHEXoEaN SvQE4aGfuedKVIajkdsDhTLEY1OI+Lo9s X-Gm-Gg: ASbGnctK55oiAm8unCXcft3OE9E0feWwCZ3UnUOc1ulM8EN0rUFaDJZMc2LZI2yWEWp c8D7jffZnEs4piZTdZ7Oh3wo1QVmGkh2jAoQCFqrz6quWrCGQVPL7MFUEtHm1+ma4pYI9WWNBda ujhII9TW2MFuyBnieMirgpPxU1Snw= X-Google-Smtp-Source: AGHT+IEVsY8iT/DO3f5NqRd99gE3bHxo/bmfKeYd5lfbE3o+pl4dRQCoM7YznKN+fswCLOfDIEW7x4A+DCU8n0IAVyo= X-Received: by 2002:a05:6402:40ce:b0:5dc:9589:9f64 with SMTP id 4fb4d7f45d1cf-5e5e22be6abmr46291413a12.13.1741640800480; Mon, 10 Mar 2025 14:06:40 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 10 Mar 2025 21:06:40 +0000 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 10 Mar 2025 21:06:40 +0000 X-Gm-Features: AQ5f1JrJv-zU2QFE2bEgChIValJLDyDSjaRMHhq7oqFwvfL028J3Jg0I77XbX1M Message-ID: Subject: control message for bug #76858 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 76858 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 01:59:25 2025 Received: (at 76858-done) by debbugs.gnu.org; 13 Mar 2025 05:59:26 +0000 Received: from localhost ([127.0.0.1]:52966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsbbJ-0005gC-JF for submit@debbugs.gnu.org; Thu, 13 Mar 2025 01:59:25 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:46293) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tsbbG-0005fp-Q3 for 76858-done@debbugs.gnu.org; Thu, 13 Mar 2025 01:59:24 -0400 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5e5e7fd051bso682999a12.0 for <76858-done@debbugs.gnu.org>; Wed, 12 Mar 2025 22:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741845556; x=1742450356; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=VYsdEjEd0115djQOWLAi9IqnmmRgAVHhn34AS6B764k=; b=LlUUO7JIoqyKkhNauSzDMn0UyM7wKW/n2fbgV+MuflPaq58Vx3v2xvLcpsAvB8lDzA 7h0K/kA1Dv98Aw0Jr4jIpsVzNuMxViXsCh+uZPOLJRI4dP/epAEYGnoKJxbi4Q4dC1qA +ksanaSpWKM9D796imJyazhJIj0lkadZfZOIvEuYgFYe0jbojIcmQ6pcanrdg39BzaRc +aoAWp+ziwg92x2cFnstsGmWaUfz/WDVNSRHuT9cie7t/LJ57TTCKo/mu0kmHNd9zHAK hcFllBZq7Z3EDQYTB+Hgdz84eB6lrxlDIHOqGgDwkbJd/3yPE/Cf05vwOowx6fMEC2Oc TOgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741845556; x=1742450356; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VYsdEjEd0115djQOWLAi9IqnmmRgAVHhn34AS6B764k=; b=lBzMuW8mYwEvXSRjVZ/l25c9vvkjVot88DBo+cxANLmVXG1F7pmJUrdIMGbJ9gD2xt m65ivRl9uYk5DaxDGu6k4w6VeKMjWq1/F2hY1Rf1j7gremEQvkYJueZsQ94SUNJWV6rL /NjmvoxxRgmaX2f3cRONhZg3mvi9lCRnUg3b+rxvdPEimNTCXZwALP9uguIjZs2YIXdH yyMdXqAb0eIXYgT3kDOvGMyjFinf7sV76QYRcsd9RFatqNdr13rYSWPAQzggMXQTEueW dGfPpXPnW0Cpn4jZlyaAeLXIXeWQ7STzKAWk29BJQcSBQXUzhdzRC+X9phSzNy/jjZp5 2CIg== X-Forwarded-Encrypted: i=1; AJvYcCULFGpT1QkIr8bmOreaEBKNrm6rx910RgN6sR33X/vb9KTYATwhYNKxzUzFgX5fHN1Thb7lgxUnV9x8@debbugs.gnu.org X-Gm-Message-State: AOJu0Yyhyjfiu8GoFupX5hnWFDWW1VNB1eNiSRAJVUroGABnS0UNXPG0 ERtbl6y5jQK0a0gRJFfB7M7HBv/NdTWQGCLnc1gPH7ejALqIGpm7vQuvpyL1H8lkZsN2pBVC4u2 ngiF64aalsix4x0ql6b9ootoOi2c= X-Gm-Gg: ASbGncslNDrA9ah9YdR6rAhbJhMl+Zn/VB0vJu2FGObNfVQIEX7AzCvHNz5atxEjidt BtNjLQqE3phKQ5TCwxnUgsiDHr31pgmBgaIsnE936dujSeaJU5dTGlshtckwb1bhzsz2GZYsQGK 8fYssLuA3mJnNg967gcoH96L65Vg== X-Google-Smtp-Source: AGHT+IF3JkotPl2HiwVhSN2FDUXg5/4Z7e7jYjaanLYxsJmtV71Ee30bFqY8VIM6g2QMfhlZnp6mB8bCFfcnYXm7oBU= X-Received: by 2002:a05:6402:4311:b0:5e7:9d01:109d with SMTP id 4fb4d7f45d1cf-5e79d0112a4mr10294546a12.32.1741845555953; Wed, 12 Mar 2025 22:59:15 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 12 Mar 2025 22:59:15 -0700 From: Stefan Kangas In-Reply-To: <33f37cdc30a4aea3dd40f80590618546@finder.org> References: <87zfhwq65q.fsf@daniel-mendler.de> <7f005d5f711081b11e5f27ad1bd094c3@finder.org> <87h643cyu3.fsf@daniel-mendler.de> <33f37cdc30a4aea3dd40f80590618546@finder.org> MIME-Version: 1.0 Date: Wed, 12 Mar 2025 22:59:15 -0700 X-Gm-Features: AQ5f1Jq5-8zUtCwZmv2SVCfJyYEVMI1IPHBaRYZhoiyQCKlC61VOMeS5FsuijGM Message-ID: Subject: Re: bug#76858: [PATCH] window-tool-bar: Use `static-if' from Compat 30 To: Jared Finder Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76858-done Cc: Daniel Mendler , 76858-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Jared Finder writes: > On 2025-03-08 07:43, Daniel Mendler wrote: >> Jared Finder writes: >> >>> On 2025-03-08 00:26, Daniel Mendler wrote: >>>> Tags: patch >>>> Compat 30 is available on ELPA and provides `static-if'. >>> I see this created Bug#76858. (apologies if a new bug is created here) >>> >>>> -;; Package-Requires: ((emacs "27.1") (compat "29.1")) >>>> +;; Package-Requires: ((emacs "27.1") (compat "30")) >>> I think this also needs (eval-when-compile (require 'compat)) since static-if >>> is >>> a macro. But I could be wrong here, I'm always a bit confused about Emacs >>> Lisp's >>> eval-when forms. >> No, (require 'compat) is sufficient. > > Ok, I have no objections then. > > -- MJF Thanks, installed on master as [1: ae33aad7f58]. [1: ae33aad7f58] 2025-03-13 window-tool-bar: Use `static-if' from Compat 30 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ae33aad7f582864a8dbb0fee10f891fd67abdbe3 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 13 01:59:43 2025 Received: (at 76858-done) by debbugs.gnu.org; 13 Mar 2025 05:59:43 +0000 Received: from localhost ([127.0.0.1]:52969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tsbbb-0005gj-0s for submit@debbugs.gnu.org; Thu, 13 Mar 2025 01:59:43 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:42115) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tsbbV-0005gS-IC for 76858-done@debbugs.gnu.org; Thu, 13 Mar 2025 01:59:38 -0400 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5dccaaca646so1119762a12.0 for <76858-done@debbugs.gnu.org>; Wed, 12 Mar 2025 22:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741845571; x=1742450371; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=VYsdEjEd0115djQOWLAi9IqnmmRgAVHhn34AS6B764k=; b=LiQXQoS2Rmz3Y8vrTOzUcf7guLpibIoyjb4xVD5pFFdRmrSEaVMmdEHTc1MBonH46o tr4M+yo4Lo50dAuvBJB0NcmmENa71fMuCXs7zxd0rh4QFl6paKWNZIATER8kVh91RLZ6 FZzV3CpowxmGP0KhPw6n+NLWigq/dxhoXtFicRZ+yJF9G3Wv6Wb233IPWGD8lYWhD7gP FgCcRQGOjU8IiKMTWt7BwDp3y0cc2pyW9qJEFvKlYP8CjSq5QsgIwToNHY4HOC1WjR2h cXraMzxCSKqefKLP4XbNupmSIK6tWl/KzUCrNC7W4QFUPr+1vv5xc7kutgKpub09QB7T +ssA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741845571; x=1742450371; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VYsdEjEd0115djQOWLAi9IqnmmRgAVHhn34AS6B764k=; b=XmZuCMXg2Zkk8kwuNHySXrIuelN4BLEKWGD7gYQCkzhG0sfcrAh9XXD0aXbI0NONKk k/9k0SygOzfZAM4Zbdr8USO2NZyae/idnMRQ2P3S3QSI4N8jXWLB2HJUgxFOY+S+Io7B 7e3kAj82nEm2dmoO/xSYpogCHz1sM+Tu7amYXKbWs/wkz3NFCB0D4wHIPT0ohGZanD8R uJCAOtb4jdBwyNyqevKD1BJM1QcGdfBO3pvvex7otv1g3hMqnEDDxkWfECiy7BZFzlNE uRY+RKXyygQLabvY9UynmmYAKKbCQgSMfifYbYTB8jnIhg5Vkn/mbwcr6YDS6gE4DMj9 zlvg== X-Forwarded-Encrypted: i=1; AJvYcCWINVfmG8rNgVfPlqeJ1VVE7aQLSj+Y5W88MlSaNUKnedlRB5gyiuGz1ct0WFxN3P6Muj4wjDSQalLB@debbugs.gnu.org X-Gm-Message-State: AOJu0YxOslnm60HcSb628s6/56R7OUIeW0fxlitosvVSpRaHj0sdJMiG uTVqaVVbhzTvY0AvvZFAzg/C1QAPWjihnlooPcnWza1VgwAMFJ15p8MzlGU6Eqg8wYkN0sYWf0F vlxqtKgQrO1yyJucGALS59J1dBs27EO1g X-Gm-Gg: ASbGncsuSUWAGWm3npfG1NxjLJlaVxDkcpxC/W7pcZbC177HWoHH4AtQbf3X6mlNrqK Qp5nJpA7N9k6u+DLngnSlQI1AY0x5pZ8K8/bt/F0blbyPG/KxfYtWFv/A4tzanejmkj7Mmdqyi6 kaFGg3lhT4rtzhRYcSWjpMH0Xp1g== X-Google-Smtp-Source: AGHT+IEnE5lz4eqdZwP1tJsTX14pHtLfKLpzkh/QZ3JZ+d/y7idg4WXpHnUkdIh5CiaZVCkD0SpzUVNtQf5DdQG5T08= X-Received: by 2002:a05:6402:42ca:b0:5e6:11be:f5d0 with SMTP id 4fb4d7f45d1cf-5e814f0b1f9mr1173676a12.12.1741845571217; Wed, 12 Mar 2025 22:59:31 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 12 Mar 2025 22:59:30 -0700 From: Stefan Kangas In-Reply-To: <33f37cdc30a4aea3dd40f80590618546@finder.org> References: <87zfhwq65q.fsf@daniel-mendler.de> <7f005d5f711081b11e5f27ad1bd094c3@finder.org> <87h643cyu3.fsf@daniel-mendler.de> <33f37cdc30a4aea3dd40f80590618546@finder.org> MIME-Version: 1.0 Date: Wed, 12 Mar 2025 22:59:30 -0700 X-Gm-Features: AQ5f1JrVqKrXIxTsyDXHS55gbsSeme2PPZ2VZNv6o3vZ6hQTNoHtzXmAbxrrUYs Message-ID: Subject: Re: bug#76858: [PATCH] window-tool-bar: Use `static-if' from Compat 30 To: Jared Finder Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76858-done Cc: Daniel Mendler , 76858-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Jared Finder writes: > On 2025-03-08 07:43, Daniel Mendler wrote: >> Jared Finder writes: >> >>> On 2025-03-08 00:26, Daniel Mendler wrote: >>>> Tags: patch >>>> Compat 30 is available on ELPA and provides `static-if'. >>> I see this created Bug#76858. (apologies if a new bug is created here) >>> >>>> -;; Package-Requires: ((emacs "27.1") (compat "29.1")) >>>> +;; Package-Requires: ((emacs "27.1") (compat "30")) >>> I think this also needs (eval-when-compile (require 'compat)) since static-if >>> is >>> a macro. But I could be wrong here, I'm always a bit confused about Emacs >>> Lisp's >>> eval-when forms. >> No, (require 'compat) is sufficient. > > Ok, I have no objections then. > > -- MJF Thanks, installed on master as [1: ae33aad7f58]. [1: ae33aad7f58] 2025-03-13 window-tool-bar: Use `static-if' from Compat 30 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ae33aad7f582864a8dbb0fee10f891fd67abdbe3 From unknown Wed Jun 18 23:10:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 10 Apr 2025 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator