From unknown Mon Jun 23 13:13:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix Resent-From: John Ciolfi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Mar 2025 06:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 76851 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 76851@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.17414141755013 (code B ref -1); Sat, 08 Mar 2025 06:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Mar 2025 06:09:35 +0000 Received: from localhost ([127.0.0.1]:52301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqnNO-0001Im-Pk for submit@debbugs.gnu.org; Sat, 08 Mar 2025 01:09:35 -0500 Received: from lists.gnu.org ([2001:470:142::17]:35502) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqnNL-0001IT-Nu for submit@debbugs.gnu.org; Sat, 08 Mar 2025 01:09:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqnNC-0001CF-CV for bug-gnu-emacs@gnu.org; Sat, 08 Mar 2025 01:09:23 -0500 Received: from us-smtp-delivery-120.mimecast.com ([170.10.129.120]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqnN8-0002Wl-9M for bug-gnu-emacs@gnu.org; Sat, 08 Mar 2025 01:09:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mathworks.com; s=mimecast20180117; t=1741414156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=6Jsj6DyGcTPtWuMixgR3jn5IqsqLml//LL17u0guPsU=; b=QtrEET43dKTomMReNfpPX/eh51Wg0PzZ+fSex9rHUiDCaZTCcmtfPBcewZ0VIhf9sQpSrr vyDspJ5b3y9qOqH2BDf4z2nlCCBcVI4qWktaqWLM5jfBQuDJsHqESM6xzeG6oJHp9PMI3i pZZFrUIBV7qVjNYKZUqRPhOt0ucD+jk= Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazlp17011024.outbound.protection.outlook.com [40.93.14.24]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-ZysMknbmN765HFn9Hlb6mQ-2; Sat, 08 Mar 2025 01:07:30 -0500 X-MC-Unique: ZysMknbmN765HFn9Hlb6mQ-2 X-Mimecast-MFC-AGG-ID: ZysMknbmN765HFn9Hlb6mQ_1741414050 Received: from BY3PR10CA0003.namprd10.prod.outlook.com (2603:10b6:a03:255::8) by SJ0PR05MB9280.namprd05.prod.outlook.com (2603:10b6:a03:477::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.19; Sat, 8 Mar 2025 06:07:26 +0000 Received: from MWH0EPF000A672E.namprd04.prod.outlook.com (2603:10b6:a03:255:cafe::88) by BY3PR10CA0003.outlook.office365.com (2603:10b6:a03:255::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.22 via Frontend Transport; Sat, 8 Mar 2025 06:07:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 144.212.100.35) smtp.mailfrom=mathworks.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=mathworks.com Received: from exedge.mathworks.com (144.212.100.35) by MWH0EPF000A672E.mail.protection.outlook.com (10.167.249.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.15 via Frontend Transport; Sat, 8 Mar 2025 06:07:25 +0000 Received: from EX1901AH.mathworks.com (172.31.53.42) by EX19EDGE00AH.mathworks.com (172.31.187.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sat, 8 Mar 2025 01:08:47 -0500 Received: from EX1900AH.mathworks.com (172.31.53.33) by EX1901AH.mathworks.com (172.31.53.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sat, 8 Mar 2025 01:07:24 -0500 Received: from mail-vif.mathworks.com (144.212.95.101) by EX1900AH.mathworks.com (172.31.53.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Sat, 8 Mar 2025 01:07:24 -0500 Received: from ah-ciolfi-l.dhcp.mathworks.com (ah-ciolfi-l.dhcp.mathworks.com [172.21.82.138]) by mail-vif.mathworks.com (8.14.7/8.14.7) with ESMTP id 52867OKT030422 for ; Sat, 8 Mar 2025 01:07:24 -0500 Received: from ah-ciolfi-l.dhcp.mathworks.com (localhost [127.0.0.1]) by ah-ciolfi-l.dhcp.mathworks.com (8.17.1.9/8.17.1.9/Debian-2+deb12u2) with ESMTP id 52867OKo3633489 for ; Sat, 8 Mar 2025 01:07:24 -0500 Received: (from ciolfi@localhost) by ah-ciolfi-l.dhcp.mathworks.com (8.17.1.9/8.17.1.9/Submit) id 52867OAc3633488; Sat, 8 Mar 2025 01:07:24 -0500 X-Authentication-Warning: ah-ciolfi-l.dhcp.mathworks.com: ciolfi set sender to ciolfi@mathworks.com using -f From: John Ciolfi Date: Sat, 8 Mar 2025 01:07:24 -0500 Message-ID: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A672E:EE_|SJ0PR05MB9280:EE_ X-MS-Office365-Filtering-Correlation-Id: 047a7f3d-16e4-4794-e1e9-08dd5e077fc2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|82310400026|376014|4053099003 X-Microsoft-Antispam-Message-Info: P6lAMxKFefYbEr0VFMOSMS6KzWxd4LLXYcpZ/lkcQK/1rI7UYZyrSkfq4ywpRc4AxqoYo0AfPsN+J2BZwY3ve1BbOLWQI9bM3uu+qTPem+wmSC3viZLRL736KiBFnyN3SFAs/hNiw4fi5vYR0F0B7WE8z9wTt0+yIyJ9reyWP38PkvPQwO46aXXKaRTo0GdPGb9I6tKKeEz8R8/JJ7UDH0woSHdHyWl9VejZepLZ7F6nl7RT6rvmI9v9sL26tmigQ4/nh4nAoqZMiKrA3Vvoy5kdz6E+Nrb0WTci42NYUXVkRbYt8nZEGTrGMncV39H4Ve862Esz7r/IvKvV8LEN0XCMqdwS4Z9RAbFR/OGTOPJWN8IZ1gTe+4wl4wOC+Lj/DxnNzMK8Sly0i0msPSb3tgzJpHSDkq+dTIp+D6df0HLNMrJ6cB7GfaMZYW9EypzYtotpM2qEUAc6p+/714nwXR2IDBbWtW14bEoyze3cOfd8U40dhJPFL480R4j6HLe6CAtpEOZSPUnFRv1kHv7pLzC0yyCwy94DcHbo4HJUCaVq6jv+6LuhkJvyneHVtrXWbC3onjTK/YM0uy/UdKql6BNWMzxNuPg0VIjbHqEuGd9cdoCs4Xx2v8uyuHE45gKu2877W8/wGc0HuZX5t6siX7lpQgwM3fpSbDpw89l49pqukpLpKXQJBct/MATzQYPsIsxZNop9DrxjcZr8GAOMhNCIn72fjWfjhqTuKXiD4ReNLNLqUujnEN2Hb2ANpen0iANXe75DKWM4FfGgnsbzAxHply7OI1u75njfpkFDIK1oZ9KJJPBHpOCkrWV0BPYPVhBgK1Wg6w0sCdmoU8hTfPHR4/XLwtoR8vJN0J7X0Q6t/wEIVv3WcUQ+Bon9sBacoiRNAKV0dWslL3bmL4FLetrNLT+xT4ucrAr4B8ZxKMgnjt+S9WLoK58UXhd5vh9fJ6n2YAWWiodJPe1nzluXybuo64neyDHe27Yt2EpXX6BXMPe6c3YwY8sU/JyvLTfpV+IfvslNUz0hCvECGa/RagjRcxxwOrjpK3c5B0IrWc4ppQDLvTsH1idYmFnJZLezMqjGWz757cc+Q9hJyUTtiOzZKt/0KtRrAhOtKehBUfgS2oGg74pbSQxcwpit6Vi1KpaBZZZy6y3XkjmGLuFA0vwCG9JSxHUOFPFmGWO95HUSRXMLAttDWy7v++JpE8+kyK3M7Frp8W0+S2ujSR6++BJe0zwlnRTMKnTJB+VvQPzzNy/4eoSeifHfdajDlYmaEcnRM3Ml0QpAk9JDzbksfl5sJGbUur9zwOX74dvX/m9/y/tHNFEMW4hnNDPVBdwItM2O/Wagq7kgU2gNsZXl60meqzrYtTMgT8GCN/Q5ljFn5k25vjUcsZcbYV59WjjI3ogEiYtLTuSLJlv346P1WM3ijmDOxXGvWz8v6Guj/3PsKb0xSgQ4anVjgWr3yDqmWjKf9LV4Gpltj9uGiNCWzg== X-Forefront-Antispam-Report: CIP:144.212.100.35; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:exedge.mathworks.com; PTR:mxgw-ah.mathworks.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014)(4053099003); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZAUrzqk2qmghaoN6P/YPP/+jOIbu7AA5k77kDvyL/zzjGiO2mbnHbpdGprzcsqX8A1bSNAR8njipk7WI9DmlGEI2p+IAX2mjSqNL44eLmvbB6we53ztY3DT3lOX1L3Qopacujo1Nmb9fdTxbgB7zgGJiO/0LScXgacxxaqFBLm57zk2ncBjGbxAPX1GJx5568miMlZkVhoHNUDIBOSFxjRqbsdXkidtSpRs4Rum36xqzWCi7Pt1/RBdh3JrKoFvB4jM0/G/Fj7s36jTCfypWh6UiHyN3/BUtlBsVYZ2xn2+buVtUDTzHfv0aQB6/IJsl+iBiDKKUaL9gMFK2lv6VTRdsf1NKbdCPE3TsEoc/bII8SKyDmGHi0bBAvX9qcv99gWa5L+M9SgTNIpklWLNF/AbPvAXvz0V0I9kWG3p+Bvr61HS1WEarBBpxpHW5wQClb/cT8gr20ty9NYkIzVpd2jFrvJGL1f4tclYwhzmESVWZ4IQKI2u7cVC0rjPleqOPQ2gCef/l5UE5sdni+IknMi3oHd7mXs0V/At+mRV7fgbTMgTSV7vZl3sR6qB/RObwrt3PWvA/P4ZomPAXPATICBRXQbvG9gmvteXsCNTKKHA= X-OriginatorOrg: mathworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2025 06:07:25.5082 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 047a7f3d-16e4-4794-e1e9-08dd5e077fc2 X-MS-Exchange-CrossTenant-Id: 99dd3a11-4348-4468-9bdd-e5072b1dc1e6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=99dd3a11-4348-4468-9bdd-e5072b1dc1e6; Ip=[144.212.100.35]; Helo=[exedge.mathworks.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A672E.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR05MB9280 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Ixwls0h0jdVbQ4OZcoM-3jdVH4AH8FvJA8U4AcV0NTU_1741414050 X-Mimecast-Originator: mathworks.com Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=170.10.129.120; envelope-from=ciolfi@mathworks.com; helo=us-smtp-delivery-120.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Hi Given this perl file: sub test { exec '/bin/echo', 'Your arguments are: ', @ARGV; } =20 sub exec_fcn { } =20 sub other { } The 'sub other' is indented incorrectly (and all code following it). The fix is in cperl-after-block-and-statement-beg to not match exec_, i.e. = we should not treat exec_fcn as a builtin. Attached is the fix. Thanks, John --=-=-= Content-Type: text/x-diff; name=cperl-mode-builtin-fix.patch; charset=WINDOWS-1252 Content-Disposition: inline; filename="cperl-mode-builtin-fix.patch" Content-Description: cperl-mode-builtin-fix.patch Content-Transfer-Encoding: quoted-printable --- a/cperl-mode.el +++ b/cperl-mode.el @@ -5606,8 +5606,16 @@ Do not look before LIM." =09 (progn =09 (forward-sexp -1) =09 (not + ;; Used to indent functions like: + ;; exec 'prog', + ;; @ARGS; + ;; [[:space:]] means we will not match exec_fcn and 'sub other= ' is indented correctly: + ;; sub exec_fcn { + ;; } + ;; sub other { + ;; } =09 (looking-at -=09 "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)\\>"))))= ))) +=09 "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)[[:space= :]]"))))))) =20 =0C (defun cperl-indent-exp () --=-=-= Content-Type: text/plain; name=ATT00001; charset=WINDOWS-1252 Content-Description: ATT00001 Content-Disposition: attachment; filename="ATT00001" Content-Transfer-Encoding: quoted-printable In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-07-22, modified by Debian built on x86-ubc-01 Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --build x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/libexec --localstatedir=3D/var/lib --infodir=3D/usr/share/info --mandir=3D/usr/share/man --with-libsystemd --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/29.4/site-lisp:= /usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/share= /emacs/site-lisp --with-sound=3Dalsa --without-gconf --with-mailutils --with-native-compilation --build x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/libexec --localstatedir=3D/var/lib --infodir=3D/usr/share/info --mandir=3D/usr/share/man --with-libsystemd --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/29.4/site-lisp:= /usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/share= /emacs/site-lisp --with-sound=3Dalsa --without-gconf --with-mailutils --with-native-compilation --with-cairo --with-x=3Dyes --with-x-toolkit=3Dgtk3 --with-toolkit-scroll-bars 'CFLAGS=3D-g -O2 -ffile-prefix-map=3D/build/reproducible-path/emacs-29.4+1=3D. -fstack-prot= ector-strong -Wformat -Werror=3Dformat-security -Wall' 'CPPFLAGS=3D-Wdate-time -D_FORTIFY_SOURCE=3D2' LDFLAGS=3D-Wl,-z,relro' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp comp-cstr warnings subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp byte-compile cus-edit pp cus-start cus-load icons wid-edit cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 105675 8530) (symbols 48 8853 7) (strings 32 23487 2243) (string-bytes 1 691014) (vectors 16 17555) (vector-slots 8 353713 18074) (floats 8 39 42) (intervals 56 579 2) (buffers 984 14)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 08 03:00:32 2025 Received: (at control) by debbugs.gnu.org; 8 Mar 2025 08:00:32 +0000 Received: from localhost ([127.0.0.1]:52621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqp6m-0007Jh-1K for submit@debbugs.gnu.org; Sat, 08 Mar 2025 03:00:32 -0500 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:46182) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tqp6k-0007JL-He for control@debbugs.gnu.org; Sat, 08 Mar 2025 03:00:30 -0500 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5e5e7fd051bso1784941a12.0 for ; Sat, 08 Mar 2025 00:00:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741420824; x=1742025624; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=GXGNQwBgz9e8STRF1qVcmjCFnQi3kpCbRnuLuGb/2NQ=; b=GX0EidyVbiUTnRNfPZ62zL3iXU4WWa98FPurE4wQ5SOXjCH1X82l3EAp+FQ+cHJ732 Od6rSb0urUeIA2kL/8hrGa0Onap2Q9jap54lRTc6PJBV7HSm4boBLnQz+BRxodR7KP0l FWDpd/YlZXlxZwbZmuPnbzouPyqTWZ1ERk5lWnsGDdJwzQfB+bISPCj5c70WQoIv2/Z5 O67T/yrq5ZRZCk35g5bJRGuTxGy3B/1axe/LW1rZRz1LtKfzbMIEQiLbPMTOlVixcgZl y7666a983eoRbNbxt0eAE9miIHptVbT6drbScNcagXvZGN/raU+wT7/w8X2ufu+3mviQ 56vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741420824; x=1742025624; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GXGNQwBgz9e8STRF1qVcmjCFnQi3kpCbRnuLuGb/2NQ=; b=Ic3HXJCNZvssnPJh6a7Oi5tUzW834eYOZVk3TGcjZrXe8RevON3oqo2f7Azpo/mhXB rjGkeV66Jrbygw3LNNtFV9JXR/xjWi/upWCR5si+1uqsglIH1bf2JvAlOVBuUmefM3YK e52hI+SMeDYXXqfJzE0R8s6PHoB10760iF+BcLE6jCD5wQyObi3i61keHC8B95NMQjF3 tYOalOADlqtT3A6OgbfgbcP2Q+QSTbG4QVFSXQPsHw+rG9cLS/Xkx27OECSrVyOiOhId K/Gk0e1gwKa7OiIpmx0b8/tYKz5L754xGxM2C4UNlVuyk4uxLux/AmLPG/8fgjtVoe8y INhg== X-Gm-Message-State: AOJu0YzipbhQG48bJ2kcQKY7GR9SnagDB/KIJ6kZf7EyIVv7hsGra3jA Pfu0EwjU7qPdthdfuFYWygz50RKh4Wz83v3KBwP8aWV8GXGqzYv6wXUsydYKq3Xx1Ggav0o/bUD /+bmKkqK/4X1CFG09PuJKYlMRl2jr7LSZDSY= X-Gm-Gg: ASbGncvHlZOusZQbL6o5MhwU2ojFtzM+Z+VUkIp20/uV0WaIi3EXm4xhawlwf1Ltenn 5M75VMNTjMSkqPgKfX5ey97Ao5ZGAjKuvXUWz1KEjPfAy0lPf8KeU3Z0ioIAfNu9TM/crQWCNPu Hi1IgRCryi+nObi1GVAcvWjZWF9w== X-Google-Smtp-Source: AGHT+IEBPoqz/BIWwJDNItEcpGVLWaZeyvOqgq2RWo8dz/F3sILPJKiIxe969KkRkTyoga5ctP2w1Qj3hE/aGk6eI3c= X-Received: by 2002:a05:6402:34ce:b0:5de:c9d0:6742 with SMTP id 4fb4d7f45d1cf-5e5e22bf528mr6521787a12.9.1741420823703; Sat, 08 Mar 2025 00:00:23 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 8 Mar 2025 08:00:23 +0000 From: Stefan Kangas MIME-Version: 1.0 Date: Sat, 8 Mar 2025 08:00:23 +0000 X-Gm-Features: AQ5f1JrTgMbUoV9XWZ2L5gW4NEa3XTUZzas5mpmSOJhYOpSEZInKbKRQg_U4scc Message-ID: Subject: control message for bug #76851 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 76851 + patch quit From unknown Mon Jun 23 13:13:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Mar 2025 08:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76851 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Ciolfi , 76851@debbugs.gnu.org Cc: Harald =?UTF-8?Q?J=C3=B6rg?= Received: via spool by 76851-submit@debbugs.gnu.org id=B76851.174142090928324 (code B ref 76851); Sat, 08 Mar 2025 08:02:02 +0000 Received: (at 76851) by debbugs.gnu.org; 8 Mar 2025 08:01:49 +0000 Received: from localhost ([127.0.0.1]:52627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqp80-0007Ml-Hc for submit@debbugs.gnu.org; Sat, 08 Mar 2025 03:01:49 -0500 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:53612) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tqp7v-0007MA-JG for 76851@debbugs.gnu.org; Sat, 08 Mar 2025 03:01:47 -0500 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5e033c2f106so2647984a12.3 for <76851@debbugs.gnu.org>; Sat, 08 Mar 2025 00:01:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741420897; x=1742025697; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=ElMbwrLA06vAefUbnhWRA9gXnYF7Az/ZsBiBVHzc8gA=; b=UyFlZfDeKa5BQ7WK1tow6HMFc2fOfP21bH7vlM13vXohSfiMr4jM6w+vWMWsn5YZuo rdjOS4qiHgwznQ7RdpvkXJMSROWr/7qEJ//3rB8oLjnX7uOyqPrrV1uUa8/LSJnjosur +hkB+1+uF0R07ZS8gtGqObs+lZh7q4d8qKV+Q5Ns8OIR6R+3WBvFh2/D+uvIK9gIaY0t mHp69yZ3jhldlEGdZxdup8D0OEO+NkBa6OWRmCr9hEI9A4BZvwKgA6wCHU8V+aJERokU 5qQg63vPd5h65o4eZxX+wfujiuQOAE7t0rHXxQrwSTF0mBtftG/SAkOtRzYCBEeMUMUO H6ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741420897; x=1742025697; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ElMbwrLA06vAefUbnhWRA9gXnYF7Az/ZsBiBVHzc8gA=; b=R/ridfolYn2thHBX1rNBbi8rEtnQA7526drzxzgr7M6itpFaGY1yASxC4jyEYmSMQV QO3U99NQ/CcOdZKF6ImhUeggEM/Zf2F12jpeom8ZYYyEYNzKeeztQ5ZTcKhJ+0Rk3hPe 8VBIZ96fXn9pygt59A02q12MWUMgPOs6nhs+uyvo6sWwnJylgbQ5GlgxIgveA2RqChgE 07yzmxvV6UrBIV+ubMIS2EcsW1IEcTn2DcBUC9laZihtJ2+gu56wnkfrsfx4RiVmLRbX 9oPzf5zpPRgkUOufxcE4Djh08M+MsXXP2hzXyFuq3av2oWpK5SsofzHoqlP1OPRzvvf4 Ww3A== X-Forwarded-Encrypted: i=1; AJvYcCUvo7L7p9CiQcfjaerWh8p/6WCrMleyDwX7wkdKXvB3h5vFEBxy3IlcgB4XJWs+Az/MyTyxlQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxwzorQ+TBn3HR6Hr1wZf7UGyVueo7XqeiR/7NFp+KtHVj56JmY mOWcBy+E5qV8EURxEtvc9/b+Xlnh5GziqdLYA0aobXe2KwuEhhB3mnNv4tEXHPipFlaRHciE+XM y4/h6pG4ECw3zmATia8t8TynMf24= X-Gm-Gg: ASbGncuysRBsnSDI2xa62IW6zxnWKAKr/YeQD3gYWYnsgHEXKuX9/RnQA4Aq2KGaA7Z b6kUPpmq5xZ0XB/Ed/IfViEbjcXVdkmb2JGPOSEu2w6v6JlOgRSkr73NrM38ffhET7Om+HGJCdi 8pPvkRh0GyZ0Ft6+L5avwM17P2eQ== X-Google-Smtp-Source: AGHT+IHAjEX029sC7PzeFwg4f+3hETrKzNZ/6ZOxDxQXv4o5W+MdIdFAXdFh8rQzim9yQ2q7SfNsTKhgsdhh6yUDsmU= X-Received: by 2002:a05:6402:1d4c:b0:5e5:b53:fd49 with SMTP id 4fb4d7f45d1cf-5e5e229e46emr13958549a12.3.1741420897021; Sat, 08 Mar 2025 00:01:37 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 8 Mar 2025 08:01:36 +0000 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Sat, 8 Mar 2025 08:01:36 +0000 X-Gm-Features: AQ5f1JpoZassyD0uKvI1s4HryawebF460jUnkyHCkRYYsTvE4FHzmFRhZSwL_2Q Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) John Ciolfi via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Hi > > Given this perl file: > > sub test { > exec '/bin/echo', > 'Your arguments are: ', @ARGV; > } > > sub exec_fcn { > } > > sub other { > } > > The 'sub other' is indented incorrectly (and all code following it). > > The fix is in cperl-after-block-and-statement-beg to not match exec_, i.e= . we should > not treat exec_fcn as a builtin. Attached is the fix. Harald, any comments on this patch? > > Thanks, > John > > --- a/cperl-mode.el > +++ b/cperl-mode.el > @@ -5606,8 +5606,16 @@ Do not look before LIM." > (progn > (forward-sexp -1) > (not > + ;; Used to indent functions like: > + ;; exec 'prog', > + ;; @ARGS; > + ;; [[:space:]] means we will not match exec_fcn and 'sub oth= er' is indented correctly: > + ;; sub exec_fcn { > + ;; } > + ;; sub other { > + ;; } > (looking-at > - "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)\\>"))))= ))) > + "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)[[:space= :]]"))))))) > > =0C > (defun cperl-indent-exp () > > In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, > cairo version 1.16.0) of 2024-07-22, modified by Debian built on > x86-ubc-01 > Windowing system distributor 'The X.Org Foundation', version 11.0.1210100= 6 > System Description: Debian GNU/Linux 12 (bookworm) > > Configured using: > 'configure --build x86_64-linux-gnu --prefix=3D/usr > --sharedstatedir=3D/var/lib --libexecdir=3D/usr/libexec > --localstatedir=3D/var/lib --infodir=3D/usr/share/info > --mandir=3D/usr/share/man --with-libsystemd --with-pop=3Dyes > --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/29.4/site-lis= p:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/sha= re/emacs/site-lisp > --with-sound=3Dalsa --without-gconf --with-mailutils > --with-native-compilation --build x86_64-linux-gnu --prefix=3D/usr > --sharedstatedir=3D/var/lib --libexecdir=3D/usr/libexec > --localstatedir=3D/var/lib --infodir=3D/usr/share/info > --mandir=3D/usr/share/man --with-libsystemd --with-pop=3Dyes > --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/29.4/site-lis= p:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/sha= re/emacs/site-lisp > --with-sound=3Dalsa --without-gconf --with-mailutils > --with-native-compilation --with-cairo --with-x=3Dyes > --with-x-toolkit=3Dgtk3 --with-toolkit-scroll-bars 'CFLAGS=3D-g -O2 > -ffile-prefix-map=3D/build/reproducible-path/emacs-29.4+1=3D. -fstack-pr= otector-strong > -Wformat -Werror=3Dformat-security -Wall' 'CPPFLAGS=3D-Wdate-time > -D_FORTIFY_SOURCE=3D2' LDFLAGS=3D-Wl,-z,relro' > > Configured features: > ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG > JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES > NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 > THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 > XPM GTK3 ZLIB > > Important settings: > value of $LANG: en_US.UTF-8 > locale-coding-system: utf-8-unix > > Major mode: Fundamental > > Minor modes in effect: > tooltip-mode: t > global-eldoc-mode: t > show-paren-mode: t > electric-indent-mode: t > mouse-wheel-mode: t > tool-bar-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > blink-cursor-mode: t > buffer-read-only: t > line-number-mode: t > indent-tabs-mode: t > transient-mark-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > > Load-path shadows: > None found. > > Features: > (shadow sort mail-extr emacsbug message mailcap yank-media puny dired > dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 > epg-config gnus-util text-property-search time-date mm-decode mm-bodies > mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail > rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp comp-cstr > warnings subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp > byte-compile cus-edit pp cus-start cus-load icons wid-edit cl-loaddefs > cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify > ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win > term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe > tabulated-list replace newcomment text-mode lisp-mode prog-mode register > page tab-bar menu-bar rfn-eshadow isearch easymenu timer select > scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors > frame minibuffer nadvice seq simple cl-generic indonesian philippine > cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao > korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech > european ethiopic indian cyrillic chinese composite emoji-zwj charscript > charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure > cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp > files window text-properties overlay sha1 md5 base64 format env > code-pages mule custom widget keymap hashtable-print-readable backquote > threads dbusbind inotify lcms2 dynamic-setting system-font-setting > font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty > make-network-process native-compile emacs) > > Memory information: > ((conses 16 105675 8530) > (symbols 48 8853 7) > (strings 32 23487 2243) > (string-bytes 1 691014) > (vectors 16 17555) > (vector-slots 8 353713 18074) > (floats 8 39 42) > (intervals 56 579 2) > (buffers 984 14)) From unknown Mon Jun 23 13:13:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix Resent-From: Harald =?UTF-8?Q?J=C3=B6rg?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Mar 2025 09:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76851 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: John Ciolfi , 76851@debbugs.gnu.org Received: via spool by 76851-submit@debbugs.gnu.org id=B76851.174142733019631 (code B ref 76851); Sat, 08 Mar 2025 09:49:02 +0000 Received: (at 76851) by debbugs.gnu.org; 8 Mar 2025 09:48:50 +0000 Received: from localhost ([127.0.0.1]:52885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqqna-00056W-5H for submit@debbugs.gnu.org; Sat, 08 Mar 2025 04:48:50 -0500 Received: from mout01.posteo.de ([185.67.36.65]:35827) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqqnU-00056C-7c for 76851@debbugs.gnu.org; Sat, 08 Mar 2025 04:48:47 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 73307240027 for <76851@debbugs.gnu.org>; Sat, 8 Mar 2025 10:48:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1741427316; bh=pFl7xJg3dHdqqw/TBkqkz1HJES2jLeL7iXwySFu78ek=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=S3Ma5KUewZvT+I4gZ8Irun8X7LuJmdg1i1sgvsB1E/Nw+d5fKw/AznYGrY6kMnpdU d00bNsVb3xTCXoII/ckDb59L/WCmjC6AtWRKCNXSu384aK4/Wr2b1bg2EaGCu7L5Wh SGI4W6UCOSAmsSZvi4jkrVNoR8ybsJL/bdMHwdY7+UsFo9ZDp8yRlPxBH0mByySQ8R Kv/sqWgJC2Xm5uOCFQrboTKxQdeHna68wSdH07Qd527uEg/UCJcqZBjXNKtC4RZaAY 4tPrQMAIRoQvGQfUMLXiyeOj6kEYZtRiS8ppBEyLMHScURXeCr86uyR4d8VCtRZMcs GAWD0enJ1PqfA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z8yyq4qPFz6typ; Sat, 8 Mar 2025 10:48:35 +0100 (CET) From: Harald =?UTF-8?Q?J=C3=B6rg?= In-Reply-To: (Stefan Kangas's message of "Sat, 8 Mar 2025 08:01:36 +0000") References: Date: Sat, 08 Mar 2025 09:48:35 +0000 Message-ID: <87zfhvetu4.fsf@oook.m.uunet.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > John Ciolfi via "Bug reports for GNU Emacs, the Swiss army knife of text > editors" writes: > >> Hi >> >> Given this perl file: >> >> sub test { >> exec '/bin/echo', >> 'Your arguments are: ', @ARGV; >> } >> >> sub exec_fcn { >> } >> >> sub other { >> } >> >> The 'sub other' is indented incorrectly (and all code following it). >> >> The fix is in cperl-after-block-and-statement-beg to not match exec_, i.e. we should >> not treat exec_fcn as a builtin. Attached is the fix. > > Harald, any comments on this patch? Yes :) I confirm this is a bug, and one of those nasty ones which affect all following code. I suggest a slightly improved patch. Instead of replacing \> (end of word) by [[:space:]] it should be replaced by \_> (end of symbol). A space is not required after the keywords in the list. In the case of exec, this is handled elsewhere, but there are keywords in the list where it matters. With [[:space:]], the following indentation happens: my %h = map{$_=>1} @ARGV; With \_>, @ARGV is correctly indented as a continuation line: my %h = map{$_=>1} @ARGV; This is less severe than the bug reported because it does not affect following code, but still should not happen. > >> >> Thanks, >> John >> >> --- a/cperl-mode.el >> +++ b/cperl-mode.el >> @@ -5606,8 +5606,16 @@ Do not look before LIM." >> (progn >> (forward-sexp -1) >> (not >> + ;; Used to indent functions like: >> + ;; exec 'prog', >> + ;; @ARGS; >> + ;; [[:space:]] means we will not match exec_fcn and 'sub other' is indented correctly: >> + ;; sub exec_fcn { >> + ;; } >> + ;; sub other { >> + ;; } >> (looking-at >> - "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)\\>"))))))) >> + "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)[[:space:]]"))))))) >> >> >> (defun cperl-indent-exp () >> >> In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, >> cairo version 1.16.0) of 2024-07-22, modified by Debian built on >> x86-ubc-01 >> Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 >> System Description: Debian GNU/Linux 12 (bookworm) >> >> Configured using: >> 'configure --build x86_64-linux-gnu --prefix=/usr >> --sharedstatedir=/var/lib --libexecdir=/usr/libexec >> --localstatedir=/var/lib --infodir=/usr/share/info >> --mandir=/usr/share/man --with-libsystemd --with-pop=yes >> --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/share/emacs/site-lisp >> --with-sound=alsa --without-gconf --with-mailutils >> --with-native-compilation --build x86_64-linux-gnu --prefix=/usr >> --sharedstatedir=/var/lib --libexecdir=/usr/libexec >> --localstatedir=/var/lib --infodir=/usr/share/info >> --mandir=/usr/share/man --with-libsystemd --with-pop=yes >> --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/share/emacs/site-lisp >> --with-sound=alsa --without-gconf --with-mailutils >> --with-native-compilation --with-cairo --with-x=yes >> --with-x-toolkit=gtk3 --with-toolkit-scroll-bars 'CFLAGS=-g -O2 >> -ffile-prefix-map=/build/reproducible-path/emacs-29.4+1=. -fstack-protector-strong >> -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time >> -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro' >> >> Configured features: >> ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG >> JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES >> NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 >> THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 >> XPM GTK3 ZLIB >> >> Important settings: >> value of $LANG: en_US.UTF-8 >> locale-coding-system: utf-8-unix >> >> Major mode: Fundamental >> >> Minor modes in effect: >> tooltip-mode: t >> global-eldoc-mode: t >> show-paren-mode: t >> electric-indent-mode: t >> mouse-wheel-mode: t >> tool-bar-mode: t >> menu-bar-mode: t >> file-name-shadow-mode: t >> global-font-lock-mode: t >> blink-cursor-mode: t >> buffer-read-only: t >> line-number-mode: t >> indent-tabs-mode: t >> transient-mark-mode: t >> auto-composition-mode: t >> auto-encryption-mode: t >> auto-compression-mode: t >> >> Load-path shadows: >> None found. >> >> Features: >> (shadow sort mail-extr emacsbug message mailcap yank-media puny dired >> dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 >> epg-config gnus-util text-property-search time-date mm-decode mm-bodies >> mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail >> rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp comp-cstr >> warnings subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp >> byte-compile cus-edit pp cus-start cus-load icons wid-edit cl-loaddefs >> cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify >> ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win >> term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe >> tabulated-list replace newcomment text-mode lisp-mode prog-mode register >> page tab-bar menu-bar rfn-eshadow isearch easymenu timer select >> scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors >> frame minibuffer nadvice seq simple cl-generic indonesian philippine >> cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao >> korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech >> european ethiopic indian cyrillic chinese composite emoji-zwj charscript >> charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure >> cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp >> files window text-properties overlay sha1 md5 base64 format env >> code-pages mule custom widget keymap hashtable-print-readable backquote >> threads dbusbind inotify lcms2 dynamic-setting system-font-setting >> font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty >> make-network-process native-compile emacs) >> >> Memory information: >> ((conses 16 105675 8530) >> (symbols 48 8853 7) >> (strings 32 23487 2243) >> (string-bytes 1 691014) >> (vectors 16 17555) >> (vector-slots 8 353713 18074) >> (floats 8 39 42) >> (intervals 56 579 2) >> (buffers 984 14)) -- Cheers, haj From unknown Mon Jun 23 13:13:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Mar 2025 09:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76851 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Harald =?UTF-8?Q?J=C3=B6rg?= Cc: John Ciolfi , 76851@debbugs.gnu.org Received: via spool by 76851-submit@debbugs.gnu.org id=B76851.174142750720349 (code B ref 76851); Sat, 08 Mar 2025 09:52:02 +0000 Received: (at 76851) by debbugs.gnu.org; 8 Mar 2025 09:51:47 +0000 Received: from localhost ([127.0.0.1]:52897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqqqR-0005I9-5X for submit@debbugs.gnu.org; Sat, 08 Mar 2025 04:51:47 -0500 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:47236) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tqqqO-0005Ht-Dg for 76851@debbugs.gnu.org; Sat, 08 Mar 2025 04:51:45 -0500 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5e60cfef9cfso1568037a12.2 for <76851@debbugs.gnu.org>; Sat, 08 Mar 2025 01:51:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741427498; x=1742032298; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=HYiyK9VNwAsNuPY3ZuY2TE4zMqKN6RCOTuX5if3y3oY=; b=BvBdPzknSX8biid9NByQkBSLoOigoFI6mVFhuD88MT5lqZ2tbFw9xNSDqOisxUC1kx y0ZDzaoXGObUR4Yjo4G8mFISWF4iSf+4uLy1ljfg3SwDg2a3Oe4vB2JJ7QkLMcH4EzGz ZSvjULMVa6OQV0mehbNXrKsdDIlSYaQ9DxdiuG3VPU9hBht76dY4Z+cSOxeN1ibaeKfm vTXgseB6fQYnQfB3A1ihAk9wvsFX3Yg1VQvUuH8BYIaFb8by3ZXjZ3zTxOZACBWsd/Go uWW2GHYHiBLt8Z7knbysXqbSauPblmU4ZzT8tgq0gCyPx2gYvIpG8MkEevk4rz0XNa5c A6UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741427498; x=1742032298; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HYiyK9VNwAsNuPY3ZuY2TE4zMqKN6RCOTuX5if3y3oY=; b=Yjtjx07bzxmJPekBd+S27JW3QxrcocBWXZs3lYV71qaPbHM1z8bKBGxuQ3vKKCPuhB V7SuRo4xRlMYB6+jMX++C1F41PhyZsNbluRBLVxhdDg120DkwuhRDVxO7xJIQHcy8yXH mw7ob42gujMsUHKO1Utdg8Gkx+44Gc5mC3a6OuNrLrktgVvo59X5eKyDb8GtXi7lXzq0 vpjzQdcOYAto/ehN2/ClTEgWjyHBy2fsMTp9h2VoCy8C/aFnns2dOvRR47Ha/yhCwsqK MmyYVA6odumxCCEVTF/k2SEN58GHy6C9lZEbnv2qVtxmmXX79addRzvNaWEZLN1apt7Z 1fWg== X-Forwarded-Encrypted: i=1; AJvYcCWPDGyMupiiuaRBDMuDW7serkEEg82IV+1narGv3tzTEvARfcEAvFOMuUL7KDB7ZZwBUQEp2Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz/4gtWnMNx0jzhd7AbrGwRNQl+0tzv4D1cyg4dujDFf6JHn44D ZJEE5FLQ89RyLp9iITpCmE5Iu4FMtBJF8wRixIm+vdS1JlnlbTd6XDav9RdnYaqUzKd8CG1cvlK zEDRrTDcxTlaH9lJc5Yf/IbVutSI= X-Gm-Gg: ASbGnct3exB1XYI87sa42B9lCZWwC2xCR/cz/Ug2ntZ1XpnMl2ETfSI4j6AIm/apFR1 i3au0tGg5fq4Yb8Yxo5MPQVSTwSd2FE+5sQf67BHKOKmHMd/5mZA03lAxjYDes32urCupEtBBKM 7zNyR5toGjJagrbc3OSqvbK6D3vg== X-Google-Smtp-Source: AGHT+IH+MvUtfdwx+ROI2Zr9P6L6yzMDm3nDWrj6UHHcfVSP7H8PASu6/y6uy74WwDwVWAK+RSQYvI54huwPPbzkbdk= X-Received: by 2002:a05:6402:2546:b0:5e5:c637:b69 with SMTP id 4fb4d7f45d1cf-5e5e22a929bmr6348606a12.6.1741427498035; Sat, 08 Mar 2025 01:51:38 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 8 Mar 2025 09:51:37 +0000 From: Stefan Kangas In-Reply-To: <87zfhvetu4.fsf@oook.m.uunet.de> References: <87zfhvetu4.fsf@oook.m.uunet.de> MIME-Version: 1.0 Date: Sat, 8 Mar 2025 09:51:37 +0000 X-Gm-Features: AQ5f1JpU6oJbPn6d5gG8wapwXiPUUPpH58dN45dyvB9r3VmfiwCQE6HX2E_uG1Q Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Harald J=C3=B6rg writes: > Stefan Kangas writes: > >> John Ciolfi via "Bug reports for GNU Emacs, the Swiss army knife of text >> editors" writes: >> >>> Hi >>> >>> Given this perl file: >>> >>> sub test { >>> exec '/bin/echo', >>> 'Your arguments are: ', @ARGV; >>> } >>> >>> sub exec_fcn { >>> } >>> >>> sub other { >>> } >>> >>> The 'sub other' is indented incorrectly (and all code following it). >>> >>> The fix is in cperl-after-block-and-statement-beg to not match exec_, i= .e. we should >>> not treat exec_fcn as a builtin. Attached is the fix. >> >> Harald, any comments on this patch? > > Yes :) > > I confirm this is a bug, and one of those nasty ones which affect all > following code. > > I suggest a slightly improved patch. Instead of replacing \> (end of > word) by [[:space:]] it should be replaced by \_> (end of symbol). > A space is not required after the keywords in the list. In the case of > exec, this is handled elsewhere, but there are keywords in the list > where it matters. > > With [[:space:]], the following indentation happens: > > my %h =3D map{$_=3D>1} > @ARGV; > > With \_>, @ARGV is correctly indented as a continuation line: > > my %h =3D map{$_=3D>1} > @ARGV; > > This is less severe than the bug reported because it does not affect > following code, but still should not happen. I recommend adding tests for the above. I think we already have good erts tests in cperl-indents.erts, that could easily be expanded. From unknown Mon Jun 23 13:13:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix Resent-From: Harald =?UTF-8?Q?J=C3=B6rg?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Mar 2025 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76851 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: John Ciolfi , 76851@debbugs.gnu.org Received: via spool by 76851-submit@debbugs.gnu.org id=B76851.174144018320277 (code B ref 76851); Sat, 08 Mar 2025 13:24:02 +0000 Received: (at 76851) by debbugs.gnu.org; 8 Mar 2025 13:23:03 +0000 Received: from localhost ([127.0.0.1]:53396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqu8s-0005Gz-JZ for submit@debbugs.gnu.org; Sat, 08 Mar 2025 08:23:03 -0500 Received: from mout01.posteo.de ([185.67.36.65]:58885) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqu8p-0005GD-I8 for 76851@debbugs.gnu.org; Sat, 08 Mar 2025 08:23:00 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1E392240027 for <76851@debbugs.gnu.org>; Sat, 8 Mar 2025 14:22:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1741440172; bh=qwugDfwkeS5fxBHU40yWr0ugGdcGdUqNP1AMvPSO6K4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=pbA4BX5tu3irvfi2vXFiylWYwOtnZU24zFxRz3/UnKFjOYRIkIi9lNVIACtMmfXHE fM8TKDafw/GCI5bhs7gMRY+mXMrsICwi+tGjFxHR5qY4MQlMFxG+b1soE5LsRgohPy oAebbb8Fn8U9qWbLl1s1L4AzXoR9WcyvOhwPaoVFQMzgeyaFRNUKFk9Zr5yXWS7O9f mrEJuIQgTTYHEXtdqVATS6RzHHUqOPC41PCWjPm+ElC9rhj8gyp/mNS4JKCXKkkOhu u0SIpudON/carPkpM4KCzwIocbLeFMJOJ70XQ8BnKh9VKb63HtimpImy75YtKJ6Mpl aNLmFLE859eaw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z93k33Y3Fz6txx; Sat, 8 Mar 2025 14:22:51 +0100 (CET) From: Harald =?UTF-8?Q?J=C3=B6rg?= In-Reply-To: (Stefan Kangas's message of "Sat, 8 Mar 2025 09:51:37 +0000") References: <87zfhvetu4.fsf@oook.m.uunet.de> Date: Sat, 08 Mar 2025 13:22:51 +0000 Message-ID: <87r037ejx0.fsf@oook.m.uunet.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > Harald J=C3=B6rg writes: > >> Stefan Kangas writes: >> >>> John Ciolfi via "Bug reports for GNU Emacs, the Swiss army knife of text >>> editors" writes: >>> >>>> Hi >>>> >>>> Given this perl file: >>>> >>>> sub test { >>>> exec '/bin/echo', >>>> 'Your arguments are: ', @ARGV; >>>> } >>>> >>>> sub exec_fcn { >>>> } >>>> >>>> sub other { >>>> } >>>> >>>> The 'sub other' is indented incorrectly (and all code following it). >>>> >>>> The fix is in cperl-after-block-and-statement-beg to not match exec_, = i.e. we should >>>> not treat exec_fcn as a builtin. Attached is the fix. >>> >>> Harald, any comments on this patch? >> >> Yes :) >> >> I confirm this is a bug, and one of those nasty ones which affect all >> following code. >> >> I suggest a slightly improved patch. Instead of replacing \> (end of >> word) by [[:space:]] it should be replaced by \_> (end of symbol). >> A space is not required after the keywords in the list. In the case of >> exec, this is handled elsewhere, but there are keywords in the list >> where it matters. >> >> With [[:space:]], the following indentation happens: >> >> my %h =3D map{$_=3D>1} >> @ARGV; >> >> With \_>, @ARGV is correctly indented as a continuation line: >> >> my %h =3D map{$_=3D>1} >> @ARGV; >> >> This is less severe than the bug reported because it does not affect >> following code, but still should not happen. > > I recommend adding tests for the above. I think we already have good > erts tests in cperl-indents.erts, that could easily be expanded. Sure, I plan to do that. CPerl indentation with its multitude of options is one of its messier corners, without extensive tests it is dangerous to change anything. How do we proceed? Shall I commit my patch to emacs-30 together with tests? --=20 Cheers, haj From unknown Mon Jun 23 13:13:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Mar 2025 14:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76851 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Harald =?UTF-8?Q?J=C3=B6rg?= Cc: John Ciolfi , 76851@debbugs.gnu.org Received: via spool by 76851-submit@debbugs.gnu.org id=B76851.174144342831081 (code B ref 76851); Sat, 08 Mar 2025 14:18:02 +0000 Received: (at 76851) by debbugs.gnu.org; 8 Mar 2025 14:17:08 +0000 Received: from localhost ([127.0.0.1]:53476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tquzE-00085D-DH for submit@debbugs.gnu.org; Sat, 08 Mar 2025 09:17:08 -0500 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:61942) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tquzC-00084Z-5S for 76851@debbugs.gnu.org; Sat, 08 Mar 2025 09:17:06 -0500 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5e5c9662131so4393392a12.3 for <76851@debbugs.gnu.org>; Sat, 08 Mar 2025 06:17:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741443420; x=1742048220; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fx3sHw09X1SAm1UIvlMhqCXzWvkavJ/0ln7+IFBqSOo=; b=HARfRyEvIAWWCKDcEoxQc9SH4eE3zSoVakVcYok0GjbqmN8NTUeJCdp6kcAcH4rrSf TCT2wFSoipO98HiPs2rsTLHbV4FGd8A7I2KXZFdcXepb1oH9C3ZL8OU4BKwnngMCjHVJ EKfmAcJzko/n55kl0zfqjBHKaaGtSsBf8selqkN5RuSaFM0K6GISMjGQdochiGu7nGM7 a5V/01h8pbWQ4l40O3hDvCNqgNyn1hQTim+tBXPLg/QFoeraDHiCgeld5vP4LqB3UTHp LUdkYOZ4H/8lk17ro9YQ5ykoUEpRTqv7v4MBh5DzSIy7j7VGyzi3IZvmsns5qyRqABTC h9CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741443420; x=1742048220; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Fx3sHw09X1SAm1UIvlMhqCXzWvkavJ/0ln7+IFBqSOo=; b=aqjDTPeL5EdkH6mCIIXC7FLPkvt8kP4YAMHHt9iDxqMrPXpsx6p/N6UiqJmelZLoc9 ykpdc7r4j6jZHqv5WSw3+O/XH50AE21GdVc2N//7HO1wosvyqGKiyvmZOtHggsq91Kcy 7GPFxzp0TAuXcHOo5vOEmkGfSPogxM1Vz6ECkMcOZzQ6LuM7O7SdeVqOFUoX05hV997Z 4Dp8yjmv+RG0IjkqLL+9htkVFhBq3m+ESvZ55lUdC/pnTLWLuUsWkVNu/F5fPvSP493u rvpj+Z+SHw7VyYAjx0PMKiFjEsgzZt17CkjLUXUs1oPv9vi/XnY5NBOqeXA5OXRY3cK7 S8Gw== X-Forwarded-Encrypted: i=1; AJvYcCVuxbgYKZWS9YkAq5HsNOhpxNPf1yetpgnxO9Jav1VHTdaK/KWqOxC5nKbwXT1U5Sv3fWVydA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz1HxbbTsAllo0o1OnAI/blNaGRCDO+ad4/SIamHKR8/WIHNswI 8Ak3ktYEVPnZhO0nAwaY0nM1UzVjsL9pT8RcQ3fjpO9tIjfivfGOw/cLoA2sBJUrVMOniztC9yN GyYh3ivM3v/uzIvmfqU8WAkZPHRA= X-Gm-Gg: ASbGncu3e55GkvrnRRpZ3BoSgjKCnFa9wb7sHG1jIHctsUcLIidcWci5AeG7s+AKZPd YTs6LNGCRccT655qsLpzykpYSE1KZ0u/URSBqVvcGSZ6OjUPhQaaFrEsFJKQtvQUuOfN8AaSJd6 hP7uDJa0TJY43pz+daHi8Y/piP5g== X-Google-Smtp-Source: AGHT+IHnof04apIRpWq52WSnd4d4oZ1OznVu3QD/h191mxaTc5S2UvP2N2Z4etLXZDCP97CVdwRiQXf1sK8Cg41Eo6I= X-Received: by 2002:a05:6402:13d0:b0:5e5:c5f5:f5b with SMTP id 4fb4d7f45d1cf-5e5e249af7bmr8942747a12.26.1741443419570; Sat, 08 Mar 2025 06:16:59 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 8 Mar 2025 14:16:59 +0000 From: Stefan Kangas In-Reply-To: <87r037ejx0.fsf@oook.m.uunet.de> References: <87zfhvetu4.fsf@oook.m.uunet.de> <87r037ejx0.fsf@oook.m.uunet.de> MIME-Version: 1.0 Date: Sat, 8 Mar 2025 14:16:59 +0000 X-Gm-Features: AQ5f1JqfwUQg-3gILPWjqSO3oe8KbwUV3dJ1HTkeQ3joV8-fEizvfq9AWJjzHas Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Harald J=C3=B6rg writes: > Stefan Kangas writes: > >> Harald J=C3=B6rg writes: >> >>> Stefan Kangas writes: >>> >>>> John Ciolfi via "Bug reports for GNU Emacs, the Swiss army knife of te= xt >>>> editors" writes: >>>> >>>>> Hi >>>>> >>>>> Given this perl file: >>>>> >>>>> sub test { >>>>> exec '/bin/echo', >>>>> 'Your arguments are: ', @ARGV; >>>>> } >>>>> >>>>> sub exec_fcn { >>>>> } >>>>> >>>>> sub other { >>>>> } >>>>> >>>>> The 'sub other' is indented incorrectly (and all code following it). >>>>> >>>>> The fix is in cperl-after-block-and-statement-beg to not match exec_,= i.e. we should >>>>> not treat exec_fcn as a builtin. Attached is the fix. >>>> >>>> Harald, any comments on this patch? >>> >>> Yes :) >>> >>> I confirm this is a bug, and one of those nasty ones which affect all >>> following code. >>> >>> I suggest a slightly improved patch. Instead of replacing \> (end of >>> word) by [[:space:]] it should be replaced by \_> (end of symbol). >>> A space is not required after the keywords in the list. In the case of >>> exec, this is handled elsewhere, but there are keywords in the list >>> where it matters. >>> >>> With [[:space:]], the following indentation happens: >>> >>> my %h =3D map{$_=3D>1} >>> @ARGV; >>> >>> With \_>, @ARGV is correctly indented as a continuation line: >>> >>> my %h =3D map{$_=3D>1} >>> @ARGV; >>> >>> This is less severe than the bug reported because it does not affect >>> following code, but still should not happen. >> >> I recommend adding tests for the above. I think we already have good >> erts tests in cperl-indents.erts, that could easily be expanded. > > Sure, I plan to do that. CPerl indentation with its multitude of > options is one of its messier corners, without extensive tests it is > dangerous to change anything. > > How do we proceed? Shall I commit my patch to emacs-30 together with > tests? I don't think I can fully assess the risks of installing or not installing this change, as cperl-mode is quite complex and I'm not too familiar with it. If this is a regression, we would tend to favor installing the fix on the release branch. Otherwise, especially if this is a messy corner and we feel that it's risky to change, perhaps we should install it on master. What is your estimation of this issue? Do you consider it important to fix on the release branch? From unknown Mon Jun 23 13:13:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix Resent-From: John Ciolfi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Mar 2025 15:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76851 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas , Harald =?UTF-8?Q?J=C3=B6rg?= Cc: "76851@debbugs.gnu.org" <76851@debbugs.gnu.org> Received: via spool by 76851-submit@debbugs.gnu.org id=B76851.174144630210929 (code B ref 76851); Sat, 08 Mar 2025 15:06:01 +0000 Received: (at 76851) by debbugs.gnu.org; 8 Mar 2025 15:05:02 +0000 Received: from localhost ([127.0.0.1]:56119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqvjX-0002q0-Lt for submit@debbugs.gnu.org; Sat, 08 Mar 2025 10:05:01 -0500 Received: from us-smtp-delivery-120.mimecast.com ([170.10.129.120]:51961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqvjJ-0002pV-R4 for 76851@debbugs.gnu.org; Sat, 08 Mar 2025 10:04:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mathworks.com; s=mimecast20180117; t=1741446284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3IckDxOHbxxW/LY13P/RLN/ba1JHbQ1ViSuNdn2cxFw=; b=BbRfUIrLW1PIWMd6krSuu5IYZ5krQlqo2FHnt9COKLiYcuHVUWahD/C4kTDaR87eKi4QAA M9a4iRilnjdl6a+irwXYQ3Q7c+e8rsOEYVAPf9H3TsNWYXA2ekheoGFQxz11yFiR/Qip36 IYrtlXHyHF2gHi58jjCktoFqQlFD0Ro= Received: from CY4PR02CU008.outbound.protection.outlook.com (mail-westcentralusazlp17011031.outbound.protection.outlook.com [40.93.6.31]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-365-txWVL9tQPOm_z-VaDr6J7Q-1; Sat, 08 Mar 2025 10:04:42 -0500 X-MC-Unique: txWVL9tQPOm_z-VaDr6J7Q-1 X-Mimecast-MFC-AGG-ID: txWVL9tQPOm_z-VaDr6J7Q_1741446281 Received: from MN2PR05MB6766.namprd05.prod.outlook.com (2603:10b6:208:185::15) by IA1PR05MB9789.namprd05.prod.outlook.com (2603:10b6:208:3fb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.19; Sat, 8 Mar 2025 15:04:38 +0000 Received: from MN2PR05MB6766.namprd05.prod.outlook.com ([fe80::5ea6:b1eb:653c:426f]) by MN2PR05MB6766.namprd05.prod.outlook.com ([fe80::5ea6:b1eb:653c:426f%4]) with mapi id 15.20.8511.023; Sat, 8 Mar 2025 15:04:37 +0000 From: John Ciolfi Thread-Topic: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix Thread-Index: AQHbkABVgcvzy8thGUmZywFCO/TL17No/2yqgAA7AVWAAA8UgIAADDsz Date: Sat, 8 Mar 2025 15:04:37 +0000 Message-ID: References: <87zfhvetu4.fsf@oook.m.uunet.de> <87r037ejx0.fsf@oook.m.uunet.de> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR05MB6766:EE_|IA1PR05MB9789:EE_ x-ms-office365-filtering-correlation-id: ae375c72-d448-468c-3703-08dd5e528b9e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|8096899003|38070700018|7053199007 x-microsoft-antispam-message-info: yVjU6+SDzb3HaOfqCAwtR9wd5R+rxJvb0ahWRmYd63vp4+RWANmLYYZz0mawMsrdP34b2f/jUOqvuEhiooUEYNBSuS5BdsDvq4S3gtPALRvc8xQdBYD6W/zWqfu+F96H5Pit+jSPedni38+MLIgep8bW2EV5xId45pICGlJt8yAuU/J02bWYEIc1fax+K5T4XKs0Yl2qXv78etWAsP3vSXflcrr8EoHRS72B3kD8BeOqoiFuvyFp5tPk7cUVM9Kmv1TVbpN7tt6NunqoHgRNfwO3k0fI6CDjRKU9c8MGcUxyCgvDW4YtT4eXN+4kz7rJF2BQfGSqsJ8EH49AMukIPgCPHcJ0Fl9j55yB3CaV5KMQLjbIKFakunRFjEfsF8S4ci3Gd3FCNPr/NF85clTyqWA8tWuKelqF4OAJ80jTQckvppBPbNOPfmHSe7zKsPuGXSLBkgWQuslToSLgw1Iz9BrylN4agERYmX6OUwgPLXuXiVEYWa+0EjejPga+brpPeeRqGYIuQQH/XMTgWTAS8epnl2kP6BA4XjIH509X7jDuqyoHuGQ4BUSYjIkk61ZSlxq0KguTlLB4b0ERGbu9o2jDSldy+y3ysb/eisawJUNlYTsfL6gTONfH3Gwv61yPDTFy6EMOex5RH1heNj7hgqs/MtRFwHv0T4akwIQ1XW0aTuLEAvOlga+EpPZWR7/csAFG9mcsEALd3/jKwmlbqfo03ljhGg5cNbkUGT3HgC3obi1trNLZ6v5uWpewIMIqgHDyH0kFmgXXEi6BFK8s4DG3O9vIJ7mf3sJpm0v8nRsQtZxXpAlb6uMBZ+mctWIUxd9MKqgtZRvRhQXOAmkYEuHvwQM2Q55XmGmyKyI2FlRZ3exwCh/5RWdRIHC4/IWTj9FZ3wyONLqET33IbjlSDiNZbRVQY18Ii4qrDp+Zo/gly7HTGJGeulQqTL9WvXJhEdgf7whp7wQb3hWVX8TDDP7XJmNz8P4/EL8XGQdUNUaMOiAwgd4IJlOU37nvtlglBXfJ2NQExXrCyMC52oMa6dTjHOwyOJ69EmJDGjrzahwogT2y5NdPHrzo6paEYLS6LLO8kk5BHNTZkKNQ6EmwgSVGN2oPuR/9w3jzuA8IQifQ5TKlxI12vl9/BQKPXjEaswTcKWGb8t7PwCEof4Q+1MoITLns0JOJxwlPS2v+WgzvzOsha6Qn3+wMuI1RoBErUxknK8cOzB3U18Tc2KFfiXy5ANVsmEh1EeWHsJbw871utL1ruqBFDCVFaHUHbZXkj0auvXSgnk8dwDhnowSz5PkBSLW1nrlYLh/hKN40vn0S72f9gwIPeFuDf3CokAwdlg1+IirpRm98Rg3ZztHPoziITn6bH/uqrtEkhfLwdF4IwIIZYBDEXHuQIXwUrbBOcSzIuFq6VXMwfnugZyqslfJZfmBJX50F7Qa2KIDLGDg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR05MB6766.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(8096899003)(38070700018)(7053199007); DIR:OUT; SFP:1101 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: V3c1cDH2fsT+sUjj9ZFdaGFFE9zTESPWfOTnh5QPeVkvi50i5v5V2j2iPUk+GfF0xAZ6lO/5FrH2le5L4w9olaSbg3zpv5zPIQ/rsWPo3zDh6Zcq/Txg8NRTeI4LHbT3TOT+aggKxwL/rLSKYDeAdtxeGqoIg+plC4W15dbY8uzSMUzSakmgQVdiId0ehz+HnMyErkJPVHHUxjBMLuuDtzDh64eLDuQ7/H5kI8r9khYaZ0pQVw0P3jRT5F0rXa8a5HYVcVEE4sNrcnGvPxfQ0t3W7N1KZQ+wLfr+CYUGnAasHWCUp8GpEVhECX6ygqzSQMK+rWR4rttwedA8PZ++vPHRAdOjjJHxawcuLaFTP3D0t6GXXqbSORhZzs+jCIvkqnhU0dyKm0b+c7o1jya0SlyiJQVSiF71HN4aDtvGmga7PwqrlIQ09TDY1Z+lYJEiZAJFDkOwcEMFP7/AZNDxc4GtuZfYT2O6/LhCU3o66V0FZBy984Sf4y2CAitNP3A3/JEVI2PgPGObUBMXmoqzVQuekRsMIQuCqtCboAtU9MHoJGdxvNRK2+M7ZicQh1D6l6gImHLtqcJhblU+GvTBmj5LRTVP7Vtb4wICC2Gh74igzweveY8jMViGv7fVAZTYan78VmAb0eS8AUaaDupuSDBzg52vlTu6d84dLHs3PNNXImxcxf5sVHlqumjuJ/83dDViyr1Mw7MSnQeRWvU5U8jWg8zq8eIYg0kvCTooryIvYnQukcMmFJFLsm//Dbvg92oKOYR9ry6fKtM+jNigLyZ4wizhGMbzxQ5X7h+yYbS8ji3DUZZZR/8ms79e2V7C1tLj9KIPaRU108dwi47dKM5/u37x27nzV37NvdYCWtZ5J8S9BSSJoRDfelzPma30FOBgFEG7TMp5iNEPXvamz8AwSekDMAvOgzZA0wlhs5WCiaJbCh+thRKhA5kHzIFakwj+ZjrBzPVgMQFBNlrZ6086KeeoPr1dsiGJOzGJSIti9+8katlXbAHwkZvI8pi4hItB448f/L11dkP7W6xK5/PNXrG/+JLKvHfYpKeFfAe8bAi6pQLIKnnS17eNzGjMD9hpc1p3+wpDdqom3NvpwOAbt/lCSnOXDVIp5wGDYJdhIW9WDM3hyBiOiIqo5Gr5S5IMMkE2DuaFdvo+JAY4diSY9RMa59mLmRQLDj3NB0/PYTBmOpOwAZYHKAqe43sFmM2MTRO6NqKrGynUbyV4QEErMx/y0ExYm2KzDFMMjWqDJCebnpzVo2Fqe0uMBK20PpvXmifquzanxL93RjJXU/XGPaDuVpI2pN9GaxaA8XOFSw+zfoTYeAkwhiJEQ2f8Om1wuUBsDd4jnwLoUyW14XtVIJ53xy7AVNWSa4KV2TLUGuduxM98aQ6vA4wUIt0Wt2m99RgOuoB0MoG64QZfm3ef5YhjRg80j8HGfgor+vw9JdObgX0NLy/ZYciswFYptKP4iRbtbraYVcgTkoN4EPGFCfZf1Gqayd4u9e4fQ3oZKwbMgEtLgeQ4vrg0FPFFO4heJdYEz5JYiiHzkQbDdg/Xtjj5wWpMfyk5gS9jW7m5fHnnIfR2VLWLlQF/XpOk MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kJlUPFz45psZ9jlZ4Zw3GGjVbnC0J+gQ2gz5mpQuPrIqpnSnm0bhh2zCt0Vxhtd6vscZH71PVZ6SeaPd+mAHfvA/x9WOoKuvu9h3Ui/hEn0yePtHcyCqf2FdKrM9Df/38KrtlC9gpJz8CuGQM4cHxi5lOK1XTSpcZrwYOI3Mu20sEEy51kQdN9TlfF66spq88hNslFC9hyZzTAPzSsllnbwh2vWcmX/SMND5Cf3MlnBb1nwM0n4MO59R7CcskhqFvZXwlKkMhRvoGEM0xRKriaHaZg0h7dEEolW0aDV2bfr8jbxy61c98jBywxMdYyFz1I1zEJs6ZQcN0BKSrl/d27rVD9aBOky+pkCMU9yykWF6A7N/eKtBrj+bHhwcMr/rZHtdVfguB6CqQh2Bcg34+6G6wRPkCzVyov9gxhEgw7/EI0hVKnPivWetzHUxhm1VtqvfMkXu4QKGIZ4C+oI0X5Xru0iiDXhOXzy35MHTcg/fW//QWK6CSjYHeN0LRW8cnUknXcHJkEm2nVQRHNNTJ0ymSyUSZ6/QGnRX6UvKtf575vBmkB50nDTIPzMuRrWp+dSp4nebI/VhwSvg1exHYeLjMh/2PoozibJSUi90qHI= X-OriginatorOrg: mathworks.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR05MB6766.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae375c72-d448-468c-3703-08dd5e528b9e X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2025 15:04:37.8787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 99dd3a11-4348-4468-9bdd-e5072b1dc1e6 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7u44aDmVtnBZuwPKq8Xk8Bxmhlvho0yxs7YpjjjrWOgykKj7bgqiH1pIzQdBhyHSC1J6yjvWSVDtcQB/iTwYgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR05MB9789 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8jcM0bdC64W4_JZowTw7OldoyOnjQXiixblvMZwJWpE_1741446281 X-Mimecast-Originator: mathworks.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR05MB6766369F0319AEDB8E1584BED1D42MN2PR05MB6766namp_" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --_000_MN2PR05MB6766369F0319AEDB8E1584BED1D42MN2PR05MB6766namp_ Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Thanks for the quick responses. The change is not a regression. The issue h= as been there for a while. I debugged though the code and it is a very safe= change. The frequency of hitting it is somewhat low. You have to start a f= unction name using one of the built-in functions, e.g. if you use map_fcn i= t would trigger the bug because map is one of the built-ins. Not sure how m= any people would do that. Thanks ________________________________ From: Stefan Kangas Sent: Saturday, March 8, 2025 9:16 AM To: Harald J=F6rg Cc: John Ciolfi ; 76851@debbugs.gnu.org <76851@debbug= s.gnu.org> Subject: Re: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix Harald J=F6rg writes: > Stefan Kangas writes: > >> Harald J=F6rg writes: >> >>> Stefan Kangas writes: >>> >>>> John Ciolfi via "Bug reports for GNU Emacs, the Swiss army knife of te= xt >>>> editors" writes: >>>> >>>>> Hi >>>>> >>>>> Given this perl file: >>>>> >>>>> sub test { >>>>> exec '/bin/echo', >>>>> 'Your arguments are: ', @ARGV; >>>>> } >>>>> >>>>> sub exec_fcn { >>>>> } >>>>> >>>>> sub other { >>>>> } >>>>> >>>>> The 'sub other' is indented incorrectly (and all code following it). >>>>> >>>>> The fix is in cperl-after-block-and-statement-beg to not match exec_,= i.e. we should >>>>> not treat exec_fcn as a builtin. Attached is the fix. >>>> >>>> Harald, any comments on this patch? >>> >>> Yes :) >>> >>> I confirm this is a bug, and one of those nasty ones which affect all >>> following code. >>> >>> I suggest a slightly improved patch. Instead of replacing \> (end of >>> word) by [[:space:]] it should be replaced by \_> (end of symbol). >>> A space is not required after the keywords in the list. In the case of >>> exec, this is handled elsewhere, but there are keywords in the list >>> where it matters. >>> >>> With [[:space:]], the following indentation happens: >>> >>> my %h =3D map{$_=3D>1} >>> @ARGV; >>> >>> With \_>, @ARGV is correctly indented as a continuation line: >>> >>> my %h =3D map{$_=3D>1} >>> @ARGV; >>> >>> This is less severe than the bug reported because it does not affect >>> following code, but still should not happen. >> >> I recommend adding tests for the above. I think we already have good >> erts tests in cperl-indents.erts, that could easily be expanded. > > Sure, I plan to do that. CPerl indentation with its multitude of > options is one of its messier corners, without extensive tests it is > dangerous to change anything. > > How do we proceed? Shall I commit my patch to emacs-30 together with > tests? I don't think I can fully assess the risks of installing or not installing this change, as cperl-mode is quite complex and I'm not too familiar with it. If this is a regression, we would tend to favor installing the fix on the release branch. Otherwise, especially if this is a messy corner and we feel that it's risky to change, perhaps we should install it on master. What is your estimation of this issue? Do you consider it important to fix on the release branch? --_000_MN2PR05MB6766369F0319AEDB8E1584BED1D42MN2PR05MB6766namp_ Content-Type: text/html; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable
Thanks for the quick responses. The change is not a regression. The issue h= as been there for a while. I debugged though the code and it is a very safe= change. The frequency of hitting it is somewhat low. You have to start a f= unction name using one of the built-in functions, e.g. if you use map_fcn it would trigger the bug because map is= one of the built-ins. Not sure how many people would do that.

Thanks

Sent: Saturday, March 8, 2025 9:16 AM
To: Harald J=F6rg <haj@posteo.de>
Cc: John Ciolfi <ciolfi@mathworks.com>; 76851@debbugs.gnu= .org <76851@debbugs.gnu.org>
Subject: Re: bug#76851: 29.4; cperl-mode builtin fcn indent bug= and fix
 
Harald J=F6rg <haj@posteo.de> writes:=

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Harald J=F6rg <haj@posteo.de> writes:
>>
>>> Stefan Kangas <stefankangas@gmail.com> writes:
>>>
>>>> John Ciolfi via "Bug reports for GNU Emacs, the Swiss= army knife of text
>>>> editors" <bug-gnu-emacs@gnu.org> writes:
>>>>
>>>>> Hi
>>>>>
>>>>> Given this perl file:
>>>>>
>>>>>     sub test {
>>>>>         exec '= /bin/echo',
>>>>>         &= nbsp;   'Your arguments are: ', @ARGV;
>>>>>     }
>>>>>
>>>>>     sub exec_fcn {
>>>>>     }
>>>>>
>>>>>         sub ot= her {
>>>>>         }
>>>>>
>>>>> The 'sub other' is indented incorrectly (and all code = following it).
>>>>>
>>>>> The fix is in cperl-after-block-and-statement-beg to n= ot match exec_, i.e. we should
>>>>> not treat exec_fcn as a builtin. Attached is the fix.<= br> >>>>
>>>> Harald, any comments on this patch?
>>>
>>> Yes :)
>>>
>>> I confirm this is a bug, and one of those nasty ones which aff= ect all
>>> following code.
>>>
>>> I suggest a slightly improved patch.  Instead of replacin= g \> (end of
>>> word) by [[:space:]] it should be replaced by \_> (end of s= ymbol).
>>> A space is not required after the keywords in the list.  = In the case of
>>> exec, this is handled elsewhere, but there are keywords in the= list
>>> where it matters.
>>>
>>> With [[:space:]], the following indentation happens:
>>>
>>>     my %h =3D map{$_=3D>1}
>>>     @ARGV;
>>>
>>> With \_>, @ARGV is correctly indented as a continuation lin= e:
>>>
>>>     my %h =3D map{$_=3D>1}
>>>         @ARGV;
>>>
>>> This is less severe than the bug reported because it does not = affect
>>> following code, but still should not happen.
>>
>> I recommend adding tests for the above.  I think we already h= ave good
>> erts tests in cperl-indents.erts, that could easily be expanded. >
> Sure, I plan to do that.  CPerl indentation with its multitude of=
> options is one of its messier corners, without extensive tests it is > dangerous to change anything.
>
> How do we proceed? Shall I commit my patch to emacs-30 together with > tests?

I don't think I can fully assess the risks of installing or not
installing this change, as cperl-mode is quite complex and I'm not
too familiar with it.

If this is a regression, we would tend to favor installing the fix on
the release branch.  Otherwise, especially if this is a messy corner a= nd
we feel that it's risky to change, perhaps we should install it on
master.

What is your estimation of this issue?  Do you consider it important t= o
fix on the release branch?

--_000_MN2PR05MB6766369F0319AEDB8E1584BED1D42MN2PR05MB6766namp_-- From unknown Mon Jun 23 13:13:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix Resent-From: Harald =?UTF-8?Q?J=C3=B6rg?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Mar 2025 18:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76851 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: John Ciolfi , 76851@debbugs.gnu.org Received: via spool by 76851-submit@debbugs.gnu.org id=B76851.174145812019771 (code B ref 76851); Sat, 08 Mar 2025 18:22:02 +0000 Received: (at 76851) by debbugs.gnu.org; 8 Mar 2025 18:22:00 +0000 Received: from localhost ([127.0.0.1]:56763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqyoC-00058p-6R for submit@debbugs.gnu.org; Sat, 08 Mar 2025 13:22:00 -0500 Received: from mout02.posteo.de ([185.67.36.66]:35829) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqyo9-00058V-Og for 76851@debbugs.gnu.org; Sat, 08 Mar 2025 13:21:58 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id CA8FD240101 for <76851@debbugs.gnu.org>; Sat, 8 Mar 2025 19:21:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1741458110; bh=Ajdh0s+mmLvphHl2hlIdh41IZy4xJhKaIAfKwCAH5tA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=TYI3RByFjqlwaBlUdkGrkdn4NgNdIMg8eehbfj0Wauq1yRSsmi+n5HVJDZp3WEXy3 kJwKfDAx2wC+2LQ+CP7PftSrifhztukzh9GJP6DCF20dJxf5EJycduxOm3+vj7V9iN q2uy/YGYCjkE5N0U5Y+4cmBtxD9D/jKim7TkAaAIttVJxpbZzPFOojD6aiFjOgTM8Y cvHWWVEk+KRavlPkOViDl4DQR6VyjoVgkHrq6Ab8pGTstG4KI11PqoiFViUOUtMTCr LQKMiWqhO0QdgjdC+nP54XTR5758Fttd11NZv3VmfFR0qMowx3DeEpcEdn43gG+z7N Xb0HxL1PFP+LQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z9BM22KD5z6txx; Sat, 8 Mar 2025 19:21:50 +0100 (CET) From: Harald =?UTF-8?Q?J=C3=B6rg?= In-Reply-To: (Stefan Kangas's message of "Sat, 8 Mar 2025 14:16:59 +0000") References: <87zfhvetu4.fsf@oook.m.uunet.de> <87r037ejx0.fsf@oook.m.uunet.de> Date: Sat, 08 Mar 2025 18:21:50 +0000 Message-ID: <87a59ve62p.fsf@oook.m.uunet.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > Harald J=C3=B6rg writes: > >> Stefan Kangas writes: >> >>> Harald J=C3=B6rg writes: >>> >>>> Stefan Kangas writes: >>>> >>>>> John Ciolfi via "Bug reports for GNU Emacs, the Swiss army knife of t= ext >>>>> editors" writes: >>>>> >>>>>> Hi >>>>>> >>>>>> Given this perl file: >>>>>> >>>>>> sub test { >>>>>> exec '/bin/echo', >>>>>> 'Your arguments are: ', @ARGV; >>>>>> } >>>>>> >>>>>> sub exec_fcn { >>>>>> } >>>>>> >>>>>> sub other { >>>>>> } >>>>>> >>>>>> The 'sub other' is indented incorrectly (and all code following it). >>>>>> >>>>>> The fix is in cperl-after-block-and-statement-beg to not match exec_= , i.e. we should >>>>>> not treat exec_fcn as a builtin. Attached is the fix. >>>>> >>>>> Harald, any comments on this patch? >>>> >>>> Yes :) >>>> >>>> I confirm this is a bug, and one of those nasty ones which affect all >>>> following code. >>>> >>>> I suggest a slightly improved patch. Instead of replacing \> (end of >>>> word) by [[:space:]] it should be replaced by \_> (end of symbol). >>>> A space is not required after the keywords in the list. In the case of >>>> exec, this is handled elsewhere, but there are keywords in the list >>>> where it matters. >>>> >>>> With [[:space:]], the following indentation happens: >>>> >>>> my %h =3D map{$_=3D>1} >>>> @ARGV; >>>> >>>> With \_>, @ARGV is correctly indented as a continuation line: >>>> >>>> my %h =3D map{$_=3D>1} >>>> @ARGV; >>>> >>>> This is less severe than the bug reported because it does not affect >>>> following code, but still should not happen. >>> >>> I recommend adding tests for the above. I think we already have good >>> erts tests in cperl-indents.erts, that could easily be expanded. >> >> Sure, I plan to do that. CPerl indentation with its multitude of >> options is one of its messier corners, without extensive tests it is >> dangerous to change anything. >> >> How do we proceed? Shall I commit my patch to emacs-30 together with >> tests? > > I don't think I can fully assess the risks of installing or not > installing this change, as cperl-mode is quite complex and I'm not > too familiar with it. Replacing end-of-word by end-of-symbol here is very low risk. The same change has been applied to other regular expressions in the past, e.g. to fix Bug#18985. The function patched here is one of the last "tie-breakers" to distinguish whether a } character ends a statement. > If this is a regression, we would tend to favor installing the fix on > the release branch. Otherwise, especially if this is a messy corner and > we feel that it's risky to change, perhaps we should install it on > master. I _guess_ this bug sits here since 1999, commit 8f2222484972. Before that, the underscore character was considered a word character by CPerl mode, so the regexp was "correct" unless someone fiddled with the option cperl-under-as-char (deprecated since Emacs 24.4, and its replacement superword-mode affects only movement, not regexps). > What is your estimation of this issue? Do you consider it important to > fix on the release branch? The chance to hit this bug is low, as indicated by the fact that it didn't surface for that long. I find it nasty, because it affects the following code ... until it finds an extra semicolon which it takes as end of the statement. So, that's also a workaround: Add a semicolon after the closing brace. sub exec_fcn {...}; So, to summarize: + Risk: Very low. + Probability to hit: Very low. + Bug impact: annoying. + Workaround: exists and is easy (albeit ugly). Pushing it to master works for me just fine, too. --=20 Cheers, haj From unknown Mon Jun 23 13:13:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Mar 2025 11:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76851 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Harald =?UTF-8?Q?J=C3=B6rg?= Cc: John Ciolfi , 76851@debbugs.gnu.org Received: via spool by 76851-submit@debbugs.gnu.org id=B76851.174151863915194 (code B ref 76851); Sun, 09 Mar 2025 11:11:01 +0000 Received: (at 76851) by debbugs.gnu.org; 9 Mar 2025 11:10:39 +0000 Received: from localhost ([127.0.0.1]:58611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trEYI-0003x0-OK for submit@debbugs.gnu.org; Sun, 09 Mar 2025 07:10:39 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:46470) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1trEYG-0003wl-Bo for 76851@debbugs.gnu.org; Sun, 09 Mar 2025 07:10:37 -0400 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5e5b6f3025dso4495788a12.1 for <76851@debbugs.gnu.org>; Sun, 09 Mar 2025 04:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741518629; x=1742123429; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=jFk/jaWYBvpzd4KqdSmWIkoF63oRJiqnvbb8ChhjFjc=; b=mG27OfPktdCHSv2gHwJmdqPhDP2XHTaWck+UaHUVUKP2fsdi2CmK56GktD/bevw3gq 7w6oI3XlqLL6DySAN0AJlJ0oQ5WZjzN1HchZtt2hFFH00RUHTglRUS3QzR0ZVtlrZQ19 iA0/vXw9T2jwpAK6fYh7O7Dm6GJ2Q+kmHcotVe2pDq056zMfrkUJE14azeIdD88wJ8yo OCD5adsfX8feTIHJN7bgueuMMWf6Y7u6BLaYa5P8omxZoqJF9uA3NqFnE+HH4Pu6DtdI bPWEfL6F+wMJDQDTznnPjVP5k3SI+9U26nCgTNWjz0MIvETBY8b+NklW9snvTInMK++6 1h3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741518629; x=1742123429; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jFk/jaWYBvpzd4KqdSmWIkoF63oRJiqnvbb8ChhjFjc=; b=R2RKCy+QThC5UDYly2FLfCF1RGuVDalEStYSmkqCILTkrR/OyP7XuwDHN1m8u5LRRo zJQA9BJef+pvr1mn06jqhAIRo13F/G3CP63QukPvc0wldZnIWcCiuoZHDbb3RXAfPINT UrWHkhVk9THRNkSG19jzhV0GQo3XbZ5092qKwLiPUzOGMbpA3S3pXPbv0V8+rA86K/UU SSAjF3K90A0woaEM7fhJdpg7sG9GV04k5DXbchmWa/KLV5ia/G0/EnA/RQGrGVvvijN+ Xt68vtvSV9hVVHivottjfkc27i1RNK+ZBNSWAIYV1cTfGvBfLQHhs1XcIKWO5fFjN5qU yr0Q== X-Forwarded-Encrypted: i=1; AJvYcCUlhTD1SLv0fhf850vY8Vtf9YiXDZvIG6ex9GxHPneDsG88jyZh/wbJu4WCsVr21g+X+1UDYg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzQL4y/kbfHSv7IeAK570QXt6F54o8FYDO1hc8l3NQfoXJv4rD3 djJ8uA0lDtXZxnqTEbrFJOqFNGKPKH4XEiZcTf7i91P1WRifdpb9xL69dWf5GEGCpkDjMMV7dKB pvEPIOZGTwR9OrLTqU+AuKPTIG/E= X-Gm-Gg: ASbGncuv++x4Ks9k20yRGmJI6uVY8D2knrc8ir4cstt7tPY+uuV1opjb3XTP+92sX6d slf+WC0TEGCXo07i7ATjFH8BY3V1XLP65wGz1YUuidl4j+ZXE5EzGTU9VMd/rwaU7WJhb5j35tP doofZzbWPiJtOAQPUtfMkrscyZ8Zo= X-Google-Smtp-Source: AGHT+IFY6JljTDcEnrM/z1VZQQJzI/si/aFHqXV6jfRfNF7bKbSHMsrv71gLeoMqAdx5MlOiu/h0L6Gc33o65JAdO6M= X-Received: by 2002:a05:6402:34ce:b0:5de:c9d0:6742 with SMTP id 4fb4d7f45d1cf-5e5e22bf528mr10532048a12.9.1741518629454; Sun, 09 Mar 2025 04:10:29 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 9 Mar 2025 11:10:29 +0000 From: Stefan Kangas In-Reply-To: <87a59ve62p.fsf@oook.m.uunet.de> References: <87zfhvetu4.fsf@oook.m.uunet.de> <87r037ejx0.fsf@oook.m.uunet.de> <87a59ve62p.fsf@oook.m.uunet.de> MIME-Version: 1.0 Date: Sun, 9 Mar 2025 11:10:29 +0000 X-Gm-Features: AQ5f1Jq8iaDbtLHLuZbNklixTSBDCf3psn1FVjpHrlj-I5OCyCIaeXMgUMCUM0s Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Harald J=C3=B6rg writes: > Stefan Kangas writes: > >> Harald J=C3=B6rg writes: >> >>> Stefan Kangas writes: >>> >>>> Harald J=C3=B6rg writes: >>>> >>>>> Stefan Kangas writes: >>>>> >>>>>> John Ciolfi via "Bug reports for GNU Emacs, the Swiss army knife of = text >>>>>> editors" writes: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> Given this perl file: >>>>>>> >>>>>>> sub test { >>>>>>> exec '/bin/echo', >>>>>>> 'Your arguments are: ', @ARGV; >>>>>>> } >>>>>>> >>>>>>> sub exec_fcn { >>>>>>> } >>>>>>> >>>>>>> sub other { >>>>>>> } >>>>>>> >>>>>>> The 'sub other' is indented incorrectly (and all code following it)= . >>>>>>> >>>>>>> The fix is in cperl-after-block-and-statement-beg to not match exec= _, i.e. we should >>>>>>> not treat exec_fcn as a builtin. Attached is the fix. >>>>>> >>>>>> Harald, any comments on this patch? >>>>> >>>>> Yes :) >>>>> >>>>> I confirm this is a bug, and one of those nasty ones which affect all >>>>> following code. >>>>> >>>>> I suggest a slightly improved patch. Instead of replacing \> (end of >>>>> word) by [[:space:]] it should be replaced by \_> (end of symbol). >>>>> A space is not required after the keywords in the list. In the case = of >>>>> exec, this is handled elsewhere, but there are keywords in the list >>>>> where it matters. >>>>> >>>>> With [[:space:]], the following indentation happens: >>>>> >>>>> my %h =3D map{$_=3D>1} >>>>> @ARGV; >>>>> >>>>> With \_>, @ARGV is correctly indented as a continuation line: >>>>> >>>>> my %h =3D map{$_=3D>1} >>>>> @ARGV; >>>>> >>>>> This is less severe than the bug reported because it does not affect >>>>> following code, but still should not happen. >>>> >>>> I recommend adding tests for the above. I think we already have good >>>> erts tests in cperl-indents.erts, that could easily be expanded. >>> >>> Sure, I plan to do that. CPerl indentation with its multitude of >>> options is one of its messier corners, without extensive tests it is >>> dangerous to change anything. >>> >>> How do we proceed? Shall I commit my patch to emacs-30 together with >>> tests? >> >> I don't think I can fully assess the risks of installing or not >> installing this change, as cperl-mode is quite complex and I'm not >> too familiar with it. > > Replacing end-of-word by end-of-symbol here is very low risk. The same > change has been applied to other regular expressions in the past, > e.g. to fix Bug#18985. The function patched here is one of the last > "tie-breakers" to distinguish whether a } character ends a statement. > >> If this is a regression, we would tend to favor installing the fix on >> the release branch. Otherwise, especially if this is a messy corner and >> we feel that it's risky to change, perhaps we should install it on >> master. > > I _guess_ this bug sits here since 1999, commit 8f2222484972. Before > that, the underscore character was considered a word character by CPerl > mode, so the regexp was "correct" unless someone fiddled with the option > cperl-under-as-char (deprecated since Emacs 24.4, and its replacement > superword-mode affects only movement, not regexps). > >> What is your estimation of this issue? Do you consider it important to >> fix on the release branch? > > The chance to hit this bug is low, as indicated by the fact that it > didn't surface for that long. I find it nasty, because it affects the > following code ... until it finds an extra semicolon which it takes as > end of the statement. > > So, that's also a workaround: Add a semicolon after the closing brace. > sub exec_fcn {...}; > > So, to summarize: > + Risk: Very low. > + Probability to hit: Very low. > + Bug impact: annoying. > + Workaround: exists and is easy (albeit ugly). > > Pushing it to master works for me just fine, too. Based on the above, and John Ciolfi's explanation, installing the fix on emacs-30 sounds okay to me. Thanks. From unknown Mon Jun 23 13:13:03 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: John Ciolfi Subject: bug#76851: closed (Fixed in the repository: branch emacs-30) Message-ID: References: <87ecz6fanx.fsf@oook.m.uunet.de> X-Gnu-PR-Message: they-closed 76851 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 76851@debbugs.gnu.org Date: Sun, 09 Mar 2025 16:10:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1741536602-9651-1" This is a multi-part message in MIME format... ------------=_1741536602-9651-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #76851: 29.4; cperl-mode builtin fcn indent bug and fix which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 76851@debbugs.gnu.org. --=20 76851: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76851 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1741536602-9651-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 76851-done) by debbugs.gnu.org; 9 Mar 2025 16:09:51 +0000 Received: from localhost ([127.0.0.1]:33923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trJDr-0002V9-IQ for submit@debbugs.gnu.org; Sun, 09 Mar 2025 12:09:51 -0400 Received: from mout02.posteo.de ([185.67.36.66]:39649) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1trJDo-0002Ut-Aj for 76851-done@debbugs.gnu.org; Sun, 09 Mar 2025 12:09:50 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8023F240101 for <76851-done@debbugs.gnu.org>; Sun, 9 Mar 2025 17:09:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1741536580; bh=xfCDHvuNGpnah1uiVg//h2GHJT0OsRvFu5v4xCWRfXA=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=ftDEKsKQ6qtA47uHAiucJ/q+eXk+wt+IKf8wyI4P7fv/A1pFp7n34zKrJUTBiOEF+ HXX3CpPeEoHVSuYNxwToWs5ecfL28NICN6peFOGWJPYifDDwP0eRUyyG60ZOWY2pQc ck8YePR0Xvkjny333J469d7Y4iXo+h5EJO/OzmWohRJF5T6zKo/kp0NIR5t/H6Wx0p IZAd4QKegPmTcLX5yFBeKCrXz6psdic+NnfmZpxcm7kRs/GsE7gG7DXZ/dTYd05cq5 88FAmJHF5dypfc+mH8DkSWIA1ghXom5XvpapsqWmtB4BjLjKexNF+E2fAtL0pxHVRE db1ZzHrBIqZ6Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z9lN36yKgz6tw5 for <76851-done@debbugs.gnu.org>; Sun, 9 Mar 2025 17:09:38 +0100 (CET) From: =?utf-8?Q?Harald_J=C3=B6rg?= To: 76851-done@debbugs.gnu.org Subject: Fixed in the repository: branch emacs-30 Date: Sun, 09 Mar 2025 16:09:38 +0000 Message-ID: <87ecz6fanx.fsf@oook.m.uunet.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76851-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is now fixed in the release branch for Emacs and will be published with the next bugfix release. -- Cheers, haj ------------=_1741536602-9651-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Mar 2025 06:09:35 +0000 Received: from localhost ([127.0.0.1]:52301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqnNO-0001Im-Pk for submit@debbugs.gnu.org; Sat, 08 Mar 2025 01:09:35 -0500 Received: from lists.gnu.org ([2001:470:142::17]:35502) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqnNL-0001IT-Nu for submit@debbugs.gnu.org; Sat, 08 Mar 2025 01:09:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqnNC-0001CF-CV for bug-gnu-emacs@gnu.org; Sat, 08 Mar 2025 01:09:23 -0500 Received: from us-smtp-delivery-120.mimecast.com ([170.10.129.120]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqnN8-0002Wl-9M for bug-gnu-emacs@gnu.org; Sat, 08 Mar 2025 01:09:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mathworks.com; s=mimecast20180117; t=1741414156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=6Jsj6DyGcTPtWuMixgR3jn5IqsqLml//LL17u0guPsU=; b=QtrEET43dKTomMReNfpPX/eh51Wg0PzZ+fSex9rHUiDCaZTCcmtfPBcewZ0VIhf9sQpSrr vyDspJ5b3y9qOqH2BDf4z2nlCCBcVI4qWktaqWLM5jfBQuDJsHqESM6xzeG6oJHp9PMI3i pZZFrUIBV7qVjNYKZUqRPhOt0ucD+jk= Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazlp17011024.outbound.protection.outlook.com [40.93.14.24]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-ZysMknbmN765HFn9Hlb6mQ-2; Sat, 08 Mar 2025 01:07:30 -0500 X-MC-Unique: ZysMknbmN765HFn9Hlb6mQ-2 X-Mimecast-MFC-AGG-ID: ZysMknbmN765HFn9Hlb6mQ_1741414050 Received: from BY3PR10CA0003.namprd10.prod.outlook.com (2603:10b6:a03:255::8) by SJ0PR05MB9280.namprd05.prod.outlook.com (2603:10b6:a03:477::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.19; Sat, 8 Mar 2025 06:07:26 +0000 Received: from MWH0EPF000A672E.namprd04.prod.outlook.com (2603:10b6:a03:255:cafe::88) by BY3PR10CA0003.outlook.office365.com (2603:10b6:a03:255::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.22 via Frontend Transport; Sat, 8 Mar 2025 06:07:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 144.212.100.35) smtp.mailfrom=mathworks.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=mathworks.com Received: from exedge.mathworks.com (144.212.100.35) by MWH0EPF000A672E.mail.protection.outlook.com (10.167.249.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.15 via Frontend Transport; Sat, 8 Mar 2025 06:07:25 +0000 Received: from EX1901AH.mathworks.com (172.31.53.42) by EX19EDGE00AH.mathworks.com (172.31.187.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sat, 8 Mar 2025 01:08:47 -0500 Received: from EX1900AH.mathworks.com (172.31.53.33) by EX1901AH.mathworks.com (172.31.53.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Sat, 8 Mar 2025 01:07:24 -0500 Received: from mail-vif.mathworks.com (144.212.95.101) by EX1900AH.mathworks.com (172.31.53.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Sat, 8 Mar 2025 01:07:24 -0500 Received: from ah-ciolfi-l.dhcp.mathworks.com (ah-ciolfi-l.dhcp.mathworks.com [172.21.82.138]) by mail-vif.mathworks.com (8.14.7/8.14.7) with ESMTP id 52867OKT030422 for ; Sat, 8 Mar 2025 01:07:24 -0500 Received: from ah-ciolfi-l.dhcp.mathworks.com (localhost [127.0.0.1]) by ah-ciolfi-l.dhcp.mathworks.com (8.17.1.9/8.17.1.9/Debian-2+deb12u2) with ESMTP id 52867OKo3633489 for ; Sat, 8 Mar 2025 01:07:24 -0500 Received: (from ciolfi@localhost) by ah-ciolfi-l.dhcp.mathworks.com (8.17.1.9/8.17.1.9/Submit) id 52867OAc3633488; Sat, 8 Mar 2025 01:07:24 -0500 X-Authentication-Warning: ah-ciolfi-l.dhcp.mathworks.com: ciolfi set sender to ciolfi@mathworks.com using -f From: John Ciolfi To: Subject: 29.4; cperl-mode builtin fcn indent bug and fix Date: Sat, 8 Mar 2025 01:07:24 -0500 Message-ID: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A672E:EE_|SJ0PR05MB9280:EE_ X-MS-Office365-Filtering-Correlation-Id: 047a7f3d-16e4-4794-e1e9-08dd5e077fc2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|82310400026|376014|4053099003 X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?P6lAMxKFefYbEr0VFMOSMS6KzWxd4LLXYcpZ/lkcQK/1rI7UYZyrSkfq4ywp?= =?us-ascii?Q?Rc4AxqoYo0AfPsN+J2BZwY3ve1BbOLWQI9bM3uu+qTPem+wmSC3viZLRL736?= =?us-ascii?Q?KiBFnyN3SFAs/hNiw4fi5vYR0F0B7WE8z9wTt0+yIyJ9reyWP38PkvPQwO46?= =?us-ascii?Q?aXXKaRTo0GdPGb9I6tKKeEz8R8/JJ7UDH0woSHdHyWl9VejZepLZ7F6nl7RT?= =?us-ascii?Q?6rvmI9v9sL26tmigQ4/nh4nAoqZMiKrA3Vvoy5kdz6E+Nrb0WTci42NYUXVk?= =?us-ascii?Q?RbYt8nZEGTrGMncV39H4Ve862Esz7r/IvKvV8LEN0XCMqdwS4Z9RAbFR/OGT?= =?us-ascii?Q?OPJWN8IZ1gTe+4wl4wOC+Lj/DxnNzMK8Sly0i0msPSb3tgzJpHSDkq+dTIp+?= =?us-ascii?Q?D6df0HLNMrJ6cB7GfaMZYW9EypzYtotpM2qEUAc6p+/714nwXR2IDBbWtW14?= =?us-ascii?Q?bEoyze3cOfd8U40dhJPFL480R4j6HLe6CAtpEOZSPUnFRv1kHv7pLzC0yyCw?= =?us-ascii?Q?y94DcHbo4HJUCaVq6jv+6LuhkJvyneHVtrXWbC3onjTK/YM0uy/UdKql6BNW?= =?us-ascii?Q?MzxNuPg0VIjbHqEuGd9cdoCs4Xx2v8uyuHE45gKu2877W8/wGc0HuZX5t6si?= =?us-ascii?Q?X7lpQgwM3fpSbDpw89l49pqukpLpKXQJBct/MATzQYPsIsxZNop9DrxjcZr8?= =?us-ascii?Q?GAOMhNCIn72fjWfjhqTuKXiD4ReNLNLqUujnEN2Hb2ANpen0iANXe75DKWM4?= =?us-ascii?Q?FfGgnsbzAxHply7OI1u75njfpkFDIK1oZ9KJJPBHpOCkrWV0BPYPVhBgK1Wg?= =?us-ascii?Q?6w0sCdmoU8hTfPHR4/XLwtoR8vJN0J7X0Q6t/wEIVv3WcUQ+Bon9sBacoiRN?= =?us-ascii?Q?AKV0dWslL3bmL4FLetrNLT+xT4ucrAr4B8ZxKMgnjt+S9WLoK58UXhd5vh9f?= =?us-ascii?Q?J6n2YAWWiodJPe1nzluXybuo64neyDHe27Yt2EpXX6BXMPe6c3YwY8sU/Jyv?= =?us-ascii?Q?LTfpV+IfvslNUz0hCvECGa/RagjRcxxwOrjpK3c5B0IrWc4ppQDLvTsH1idY?= =?us-ascii?Q?mFnJZLezMqjGWz757cc+Q9hJyUTtiOzZKt/0KtRrAhOtKehBUfgS2oGg74pb?= =?us-ascii?Q?SQxcwpit6Vi1KpaBZZZy6y3XkjmGLuFA0vwCG9JSxHUOFPFmGWO95HUSRXML?= =?us-ascii?Q?AttDWy7v++JpE8+kyK3M7Frp8W0+S2ujSR6++BJe0zwlnRTMKnTJB+VvQPzz?= =?us-ascii?Q?Ny/4eoSeifHfdajDlYmaEcnRM3Ml0QpAk9JDzbksfl5sJGbUur9zwOX74dvX?= =?us-ascii?Q?/m9/y/tHNFEMW4hnNDPVBdwItM2O/Wagq7kgU2gNsZXl60meqzrYtTMgT8GC?= =?us-ascii?Q?N/Q5ljFn5k25vjUcsZcbYV59WjjI3ogEiYtLTuSLJlv346P1WM3ijmDOxXGv?= =?us-ascii?Q?Wz8v6Guj/3PsKb0xSgQ4anVjgWr3yDqmWjKf9LV4Gpltj9uGiNCWzg=3D=3D?= X-Forefront-Antispam-Report: CIP:144.212.100.35; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:exedge.mathworks.com; PTR:mxgw-ah.mathworks.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014)(4053099003); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZAUrzqk2qmghaoN6P/YPP/+jOIbu7AA5k77kDvyL/zzjGiO2mbnHbpdGprzcsqX8A1bSNAR8njipk7WI9DmlGEI2p+IAX2mjSqNL44eLmvbB6we53ztY3DT3lOX1L3Qopacujo1Nmb9fdTxbgB7zgGJiO/0LScXgacxxaqFBLm57zk2ncBjGbxAPX1GJx5568miMlZkVhoHNUDIBOSFxjRqbsdXkidtSpRs4Rum36xqzWCi7Pt1/RBdh3JrKoFvB4jM0/G/Fj7s36jTCfypWh6UiHyN3/BUtlBsVYZ2xn2+buVtUDTzHfv0aQB6/IJsl+iBiDKKUaL9gMFK2lv6VTRdsf1NKbdCPE3TsEoc/bII8SKyDmGHi0bBAvX9qcv99gWa5L+M9SgTNIpklWLNF/AbPvAXvz0V0I9kWG3p+Bvr61HS1WEarBBpxpHW5wQClb/cT8gr20ty9NYkIzVpd2jFrvJGL1f4tclYwhzmESVWZ4IQKI2u7cVC0rjPleqOPQ2gCef/l5UE5sdni+IknMi3oHd7mXs0V/At+mRV7fgbTMgTSV7vZl3sR6qB/RObwrt3PWvA/P4ZomPAXPATICBRXQbvG9gmvteXsCNTKKHA= X-OriginatorOrg: mathworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2025 06:07:25.5082 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 047a7f3d-16e4-4794-e1e9-08dd5e077fc2 X-MS-Exchange-CrossTenant-Id: 99dd3a11-4348-4468-9bdd-e5072b1dc1e6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=99dd3a11-4348-4468-9bdd-e5072b1dc1e6; Ip=[144.212.100.35]; Helo=[exedge.mathworks.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A672E.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR05MB9280 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Ixwls0h0jdVbQ4OZcoM-3jdVH4AH8FvJA8U4AcV0NTU_1741414050 X-Mimecast-Originator: mathworks.com Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=170.10.129.120; envelope-from=ciolfi@mathworks.com; helo=us-smtp-delivery-120.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Hi Given this perl file: sub test { exec '/bin/echo', 'Your arguments are: ', @ARGV; } =20 sub exec_fcn { } =20 sub other { } The 'sub other' is indented incorrectly (and all code following it). The fix is in cperl-after-block-and-statement-beg to not match exec_, i.e. = we should not treat exec_fcn as a builtin. Attached is the fix. Thanks, John --=-=-= Content-Type: text/x-diff; name=cperl-mode-builtin-fix.patch; charset=WINDOWS-1252 Content-Disposition: inline; filename="cperl-mode-builtin-fix.patch" Content-Description: cperl-mode-builtin-fix.patch Content-Transfer-Encoding: quoted-printable --- a/cperl-mode.el +++ b/cperl-mode.el @@ -5606,8 +5606,16 @@ Do not look before LIM." =09 (progn =09 (forward-sexp -1) =09 (not + ;; Used to indent functions like: + ;; exec 'prog', + ;; @ARGS; + ;; [[:space:]] means we will not match exec_fcn and 'sub other= ' is indented correctly: + ;; sub exec_fcn { + ;; } + ;; sub other { + ;; } =09 (looking-at -=09 "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)\\>"))))= ))) +=09 "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)[[:space= :]]"))))))) =20 =0C (defun cperl-indent-exp () --=-=-= Content-Type: text/plain; name=ATT00001; charset=WINDOWS-1252 Content-Description: ATT00001 Content-Disposition: attachment; filename="ATT00001" Content-Transfer-Encoding: quoted-printable In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-07-22, modified by Debian built on x86-ubc-01 Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --build x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/libexec --localstatedir=3D/var/lib --infodir=3D/usr/share/info --mandir=3D/usr/share/man --with-libsystemd --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/29.4/site-lisp:= /usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/share= /emacs/site-lisp --with-sound=3Dalsa --without-gconf --with-mailutils --with-native-compilation --build x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/libexec --localstatedir=3D/var/lib --infodir=3D/usr/share/info --mandir=3D/usr/share/man --with-libsystemd --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/29.4/site-lisp:= /usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/share= /emacs/site-lisp --with-sound=3Dalsa --without-gconf --with-mailutils --with-native-compilation --with-cairo --with-x=3Dyes --with-x-toolkit=3Dgtk3 --with-toolkit-scroll-bars 'CFLAGS=3D-g -O2 -ffile-prefix-map=3D/build/reproducible-path/emacs-29.4+1=3D. -fstack-prot= ector-strong -Wformat -Werror=3Dformat-security -Wall' 'CPPFLAGS=3D-Wdate-time -D_FORTIFY_SOURCE=3D2' LDFLAGS=3D-Wl,-z,relro' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp comp-cstr warnings subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp byte-compile cus-edit pp cus-start cus-load icons wid-edit cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 105675 8530) (symbols 48 8853 7) (strings 32 23487 2243) (string-bytes 1 691014) (vectors 16 17555) (vector-slots 8 353713 18074) (floats 8 39 42) (intervals 56 579 2) (buffers 984 14)) --=-=-=-- ------------=_1741536602-9651-1-- From unknown Mon Jun 23 13:13:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix Resent-From: Harald =?UTF-8?Q?J=C3=B6rg?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Mar 2025 16:13:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76851 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: John Ciolfi , 76851@debbugs.gnu.org Received: via spool by 76851-submit@debbugs.gnu.org id=B76851.174153676010360 (code B ref 76851); Sun, 09 Mar 2025 16:13:03 +0000 Received: (at 76851) by debbugs.gnu.org; 9 Mar 2025 16:12:40 +0000 Received: from localhost ([127.0.0.1]:33946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trJGa-0002h1-Es for submit@debbugs.gnu.org; Sun, 09 Mar 2025 12:12:40 -0400 Received: from mout02.posteo.de ([185.67.36.66]:34617) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1trJGY-0002ge-Q6 for 76851@debbugs.gnu.org; Sun, 09 Mar 2025 12:12:39 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id DE345240101 for <76851@debbugs.gnu.org>; Sun, 9 Mar 2025 17:12:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1741536752; bh=b3t0jayzoTs8IOh+zRUinOlqTmtgRAdUuhX3uERlrxE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=OR2KCZm/+fnnRzTzBdena2bd1Fs/uBH5Sj7sCrTEGJUYkWAnD0W6TiOs3BrYe+dfA ILmB9JceD3FSesmwSCAopmAdOq7519fXreSWUv3hUI0tWb+nO5eMPVtG+AoXxoRlK8 2oB03D6ZzcAWtVedoPsxWnR2X1K1CBQPD2wBzchuDD1SLzgsHgihT/PJc059iC1evc 8Yhxg7zUEaGID9bfLCZy6wwOU6SEO4b7yjQxbtu+hPgWMNAoo3mI3pIrppHGx4L8di WxsPiZH6cfhp/OBdnnwVulm+o45+9wKByDM56uSqTFyH+mhuZTnc/4vF4AWj94r7cL XGhHuN2KIYoTA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z9lRN44Wtz6tw3; Sun, 9 Mar 2025 17:12:32 +0100 (CET) From: Harald =?UTF-8?Q?J=C3=B6rg?= In-Reply-To: (Stefan Kangas's message of "Sun, 9 Mar 2025 11:10:29 +0000") References: <87zfhvetu4.fsf@oook.m.uunet.de> <87r037ejx0.fsf@oook.m.uunet.de> <87a59ve62p.fsf@oook.m.uunet.de> Date: Sun, 09 Mar 2025 16:12:32 +0000 Message-ID: <878qpefaj3.fsf@oook.m.uunet.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > [...] > Based on the above, and John Ciolfi's explanation, installing the fix on > emacs-30 sounds okay to me. Thanks. Done! Thanks for your review and approval. -- Cheers, haj