GNU bug report logs - #76850
tests/pack.scm failure (AppImage)

Previous Next

Full log

Message #20 received at 76850 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noelopez <at> free.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, 76850 <at> debbugs.gnu.org,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Christopher Baines <guix <at> cbaines.net>
Subject: Re: bug#76850: [PATCH] tests: pack: Fix nondeterministic AppImage
 tests.
Date: Tue, 08 Apr 2025 21:11:31 +0200

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Noé,
>
> Noé Lopez <noelopez <at> free.fr> skribis:
>
>> As reported in #76850, the tested AppImages were not actually relocatable and
>> would rely on items being available on the environment’s store (apart from
>> glibc).
>>
>> * guix/scripts/pack.scm (wrapped-manifest): New function.
>> (guix-pack): Extract relocatable manifest to wrapped-manifest.
>> * tests/pack.scm: Use relocatable profiles in AppImage tests.
>>
>> Change-Id: Ib3123054913fce903d215dc0629d806e9fceebc7
>
> Please add a “Fixes” line and a “Reported-by” tag as is usually done.
>
>> +(define*-public (wrapped-manifest manifest #:rest args)
>
> Simply ‘define*’.
>

Then how do I use it in the test? @@ won’t work, I think because the
module is declarative and guile is inlining it.

Or did you mean I should use define* and add it to the module exports in
define-module?

> Otherwise LGTM, thanks for fixing it!
>
> Ludo’.

Thanks for the review,
Noé

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.