Subject: Re: bug#76850: [PATCH] tests: pack: Fix nondeterministic AppImage tests.

From: Ludovic Courtès <[email-masked]>
Date: Tue, 08 Apr 2025 12:26:37 +0200

Hi Noé,

Noé Lopez <[email-masked]> skribis:

> As reported in #76850, the tested AppImages were not actually relocatable and
> would rely on items being available on the environment’s store (apart from
> glibc).
>
> * guix/scripts/pack.scm (wrapped-manifest): New function.
> (guix-pack): Extract relocatable manifest to wrapped-manifest.
> * tests/pack.scm: Use relocatable profiles in AppImage tests.
>
> Change-Id: Ib3123054913fce903d215dc0629d806e9fceebc7

Please add a “Fixes” line and a “Reported-by” tag as is usually done.

> +(define*-public (wrapped-manifest manifest #:rest args)

Simply ‘define*’.

Otherwise LGTM, thanks for fixing it!

Ludo’.