GNU bug report logs - #76839
[PATCH] Fix 'Skip' behavior in erts files

Previous Next

Full log

View this message in rfc822 format

From: Roi Martin <jroi.martin <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>, 76839 <at> debbugs.gnu.org
Subject: bug#76839: [Roi Martin] [PATCH] Fix 'Skip' behavior in erts files
Date: Sat, 08 Mar 2025 20:37:20 +0100

[Message part 1 (text/plain, inline)]

Stefan Kangas <stefankangas <at> gmail.com> writes:

>> I guess I could handle the `ert-test-failed' error signaled by
>> `ert-test-erts-file' when it calls `ert-fail', but is it much better?
>
> I think it's better, because then you reduce the scope to just that one
> error.
>
> The test could also fail for any other reason, including that some form
> couldn't be read, an incorrect erts file, and so on.  We would want such
> things to be flagged, in case they happen.
>
> Does that make sense?  Could you propose an updated patch along these
> lines?

Yes, it makes sense.  I attached a new version that implements your
suggestions.

[0001-Fix-Skip-behavior-in-erts-files-Bug-76839.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.