GNU bug report logs - #76815
31.0.50; [PATCH] Turning off semantic-mode should apply to each buffer

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76815: closed (31.0.50; [PATCH] Turning off semantic-mode
 should apply to each buffer)
Date: Sat, 07 Jun 2025 07:38:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 07 Jun 2025 10:37:38 +0300
with message-id <86y0u4j931.fsf <at> gnu.org>
and subject line Re: bug#76815: 31.0.50; [PATCH] Turning off semantic-mode should apply to each buffer)
has caused the debbugs.gnu.org bug report #76815,
regarding 31.0.50; [PATCH] Turning off semantic-mode should apply to each buffer
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76815: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76815
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Lin Sun <sunlin7 <at> hotmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 31.0.50; [PATCH] Turning off semantic-mode should apply to each buffer
Date: Fri, 7 Mar 2025 17:22:16 +0000

[Message part 3 (text/plain, inline)]

Hi,
There is a bug that turn off semantic-mode it only restores current buffer's imenu-create-index-function but actually turning on semantic-mode had changed each buffer's variable.
Reproduce steps:
1) Open two files (eg /tmp/a.c, /tmp/b.c) in two buffers; 
2) Turn on semantic-mode, it will change the imenu-create-index-function value for each buffer;
3) Turn off semantic-mode, it will restore current buffer's value (eg: b.c), but another one (eg: a.c) won't restored.

When turning on semantic-mode, it applies changes to each buffer, 
 1048         (dolist (b (buffer-list))
 1049           (with-current-buffer b
 1050             (semantic-new-buffer-fcn))))

But turning off semantic does not restore the var for each buffer, only restores current buffer.

This patch will fix the issue. Please help review it. Thanks.
Best Regards, Lin

[0001-lisp-cedet-semantic.el-Turning-off-semantic-mode-app.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7 <at> hotmail.com>
Cc: 76815-done <at> debbugs.gnu.org
Subject: Re: bug#76815: 31.0.50; [PATCH] Turning off semantic-mode should
 apply to each buffer)
Date: Sat, 07 Jun 2025 10:37:38 +0300

> From: Lin Sun <sunlin7 <at> hotmail.com>
> Date: Sat, 10 May 2025 05:15:17 +0000
> msip_labels:
> 
> Hi Eli, Please help review the patch, thank you!
> 
> From: Lin Sun
> > There is a bug that turn off semantic-mode it only restores current buffer's imenu-create-index-function but actually turning on semantic-mode had changed each buffer's variable.
> > Reproduce steps:
> > 1) Open two files (eg /tmp/a.c, /tmp/b.c) in two buffers;
> > 2) Turn on semantic-mode, it will change the imenu-create-index-function value for each buffer;
> > 3) Turn off semantic-mode, it will restore current buffer's value (eg: b.c), but another one (eg: a.c) won't restored.
> >
> > When turning on semantic-mode, it applies changes to each buffer,
> >  1048         (dolist (b (buffer-list))
> >  1049           (with-current-buffer b
> >  1050             (semantic-new-buffer-fcn))))
> >
> > But turning off semantic does not restore the var for each buffer, only restores current buffer.
> >
> > This patch will fix the issue. Please help review it. Thanks.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.