From unknown Sat Aug 09 09:37:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#76811] [PATCH] services: nginx: Replace invoke with spawn-command. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Mar 2025 13:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 76811 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 76811@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17413526003336 (code B ref -1); Fri, 07 Mar 2025 13:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Mar 2025 13:03:20 +0000 Received: from localhost ([127.0.0.1]:47410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqXMF-0000rj-IW for submit@debbugs.gnu.org; Fri, 07 Mar 2025 08:03:19 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55818) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqXMD-0000qa-Uh for submit@debbugs.gnu.org; Fri, 07 Mar 2025 08:03:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqXLK-0007ai-0g for guix-patches@gnu.org; Fri, 07 Mar 2025 08:02:26 -0500 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tqXLH-00045Y-9R for guix-patches@gnu.org; Fri, 07 Mar 2025 08:02:21 -0500 Received: from localhost (unknown [IPv6:2a02:6b67:e390:8b00::1ce5]) by mira.cbaines.net (Postfix) with ESMTPSA id 880D427BBE2 for ; Fri, 7 Mar 2025 13:02:16 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 21498c0b for ; Fri, 7 Mar 2025 13:02:15 +0000 (UTC) From: Christopher Baines Date: Fri, 7 Mar 2025 13:02:15 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) I'm not sure where invoke is coming from here, but it could be from (guix build utils), that uses system* which uses waitpid, which might cause problems with recent versions of the shepherd? At least I'm seeing issues on multiple machines where attempting to restart the nginx service sometimes causes the shepherd to hang. * gnu/services/web.scm (nginx-shepherd-service): Replace invoke with spawn-command. Change-Id: Ie9ce4be9a4df121465b28148612b4fbc45fb5126 --- gnu/services/web.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/services/web.scm b/gnu/services/web.scm index 7593cd2eaa..b46a4db73f 100644 --- a/gnu/services/web.scm +++ b/gnu/services/web.scm @@ -870,7 +870,8 @@ (define (nginx-shepherd-service config) (nginx-action (lambda args #~(lambda _ - (invoke #$nginx-binary "-c" #$config-file #$@args) + (spawn-command + (list #$nginx-binary "-c" #$config-file #$@args)) (match '#$args (("-s" . _) #t) (_ base-commit: 9bc4c9f521caab8aa8d88aa948a650945bb55838 -- 2.48.1 From unknown Sat Aug 09 09:37:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#76811] [PATCH] services: nginx: Replace invoke with spawn-command. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Mar 2025 13:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76811 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 76811@debbugs.gnu.org Received: via spool by 76811-submit@debbugs.gnu.org id=B76811.174135577612368 (code B ref 76811); Fri, 07 Mar 2025 13:57:01 +0000 Received: (at 76811) by debbugs.gnu.org; 7 Mar 2025 13:56:16 +0000 Received: from localhost ([127.0.0.1]:47504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqYBU-0003DQ-D0 for submit@debbugs.gnu.org; Fri, 07 Mar 2025 08:56:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48480) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqYBR-0003DD-Mj for 76811@debbugs.gnu.org; Fri, 07 Mar 2025 08:56:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqYBL-0002Z4-Uu; Fri, 07 Mar 2025 08:56:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=QcBPQGMwkLwD0TXpwNt1OoXIhGnjewMcgMYDf2N/nC8=; b=F12mdsgHho3CLuHaF83y NeZFmGmgH63qR5CEOItSI4HsWl2rzv6vHajvqpFdInwiSdTYVKYxSk6ZuDOUH5QnFli43+MF1NWiG tC3PoPqvg3Vay3EKoLrHyFVxADnJIc4XWLy2cnNqPDTfP/W8eFmVkP9d2eg/fcO2ecBwb34c9oEZV m5u4dgC5BJrq1S4Mlg49teEug5waC0OHgyhdNZESf0CxgdlM8+RPpXCSjoNMApJv94itu0YxTXsNk QzvsYYdImSXBgAcxAJ3i4N0+hlfrT5xe7ls0zc3CszRKFcQFdARUrPSKpUKDbrfLFuaVTmOguZnue vIcKJjs8kjdAhg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Christopher Baines's message of "Fri, 7 Mar 2025 13:02:15 +0000") References: Date: Fri, 07 Mar 2025 14:56:03 +0100 Message-ID: <878qphvtak.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Christopher Baines skribis: > I'm not sure where invoke is coming from here, but it could be from (guix > build utils), that uses system* which uses waitpid, which might cause pro= blems > with recent versions of the shepherd? > > At least I'm seeing issues on multiple machines where attempting to resta= rt > the nginx service sometimes causes the shepherd to hang. > > * gnu/services/web.scm (nginx-shepherd-service): Replace invoke with > spawn-command. > > Change-Id: Ie9ce4be9a4df121465b28148612b4fbc45fb5126 Hi! =E2=80=98invoke=E2=80=99 uses =E2=80=98system*=E2=80=99, which is an a= lias for =E2=80=98spawn-command=E2=80=99 (see =E2=80=98replace-core-bindings!=E2=80=99 in =E2=80=98shepherd.scm=E2=80=99)= so the only effect of this patch is that errors from =E2=80=9Cnginx -c nginx.conf =E2=80=A6=E2=80=9D w= ould be ignored. I think we need a reproducer for the hang so we can pinpoint the problem because it=E2=80=99s a pretty serious bug! Ludo=E2=80=99. From unknown Sat Aug 09 09:37:14 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christopher Baines Subject: bug#76811: closed (Re: [bug#76811] [PATCH] services: nginx: Replace invoke with spawn-command.) Message-ID: References: <87v7skn4hv.fsf@cbaines.net> X-Gnu-PR-Message: they-closed 76811 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 76811@debbugs.gnu.org Date: Fri, 07 Mar 2025 17:19:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1741367942-10727-1" This is a multi-part message in MIME format... ------------=_1741367942-10727-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #76811: [PATCH] services: nginx: Replace invoke with spawn-command. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 76811@debbugs.gnu.org. --=20 76811: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76811 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1741367942-10727-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 76811-close) by debbugs.gnu.org; 7 Mar 2025 17:19:01 +0000 Received: from localhost ([127.0.0.1]:49874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqbLg-0002ml-Eo for submit@debbugs.gnu.org; Fri, 07 Mar 2025 12:19:01 -0500 Received: from mira.cbaines.net ([212.71.252.8]:44146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqbLd-0002mZ-4x for 76811-close@debbugs.gnu.org; Fri, 07 Mar 2025 12:18:58 -0500 Received: from localhost (unknown [IPv6:2a02:6b67:e390:8b00::1ce5]) by mira.cbaines.net (Postfix) with ESMTPSA id 096B727BBE2; Fri, 7 Mar 2025 17:18:55 +0000 (GMT) Received: from fang (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id bc6c80c9; Fri, 7 Mar 2025 17:18:54 +0000 (UTC) From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#76811] [PATCH] services: nginx: Replace invoke with spawn-command. In-Reply-To: <878qphvtak.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 07 Mar 2025 14:56:03 +0100") References: <878qphvtak.fsf@gnu.org> Date: Fri, 07 Mar 2025 17:18:52 +0000 Message-ID: <87v7skn4hv.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76811-close Cc: 76811-close@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Christopher Baines skribis: > >> I'm not sure where invoke is coming from here, but it could be from (guix >> build utils), that uses system* which uses waitpid, which might cause pr= oblems >> with recent versions of the shepherd? >> >> At least I'm seeing issues on multiple machines where attempting to rest= art >> the nginx service sometimes causes the shepherd to hang. >> >> * gnu/services/web.scm (nginx-shepherd-service): Replace invoke with >> spawn-command. >> >> Change-Id: Ie9ce4be9a4df121465b28148612b4fbc45fb5126 > > Hi! =E2=80=98invoke=E2=80=99 uses =E2=80=98system*=E2=80=99, which is an= alias for =E2=80=98spawn-command=E2=80=99 (see > =E2=80=98replace-core-bindings!=E2=80=99 in =E2=80=98shepherd.scm=E2=80= =99) so the only effect of this > patch is that errors from =E2=80=9Cnginx -c nginx.conf =E2=80=A6=E2=80=9D= would be ignored. Ah, yes, I see, I've tried to verify this and it does seem that the nginx server is using this system* replacement. > I think we need a reproducer for the hang so we can pinpoint the > problem because it=E2=80=99s a pretty serious bug! I did try restarting nginx over and over again in the system test os, but that seemed to work. On a VM I have though, it only takes a few restarts for it to hang, I'm not sure why though. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmfLKnxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xc5hg//eqeCGGeQfU5tA7YNpXMUXd1bCXziPi6W KSPjSu5k/dxArwO/XN3c61qeVRBujKLiVmmvjCcjFZsMMm7Zlg3cKNaDRBGc1S/V OLRIpJcMBdtNjtZ3OKSasPFmQidIazGulRS/yfHJWvYVHyV0lTrRADY0Ydo8u7ro 6NRhG/D33gYiwt7bqsmXhAU9+dHcAV83sKwEygFdo8T0EYaoRgPJOCfLAev7AUjE iWRC8vgVJWGfR7kvREl2MwFJNzgwvt+v4NkOy+3EMAvQDVCbN8SoRjYrIBtKtCdT /ZuOA80d6eZV0fXMUTyoC+jjALoO9by9gfShzeYLnwZisd7zjZ7VF1EQeg4SqJjP F61J4BYRkrH79y4v+4pvHqIypGl9a2PWHgn8iHBpGQNKT1KLC8eJJri2u7xP6uX8 qMOyVSqkeacEvLKAvi4z1q68dFnpFSrr6KASC9Vge8K9axbE2Kxv83jYKFr8M08t InuWAC5dRPncu1J81aorXb1HB68YtLwEmUvbAVbm6rlonrWP2dVeMXjW+B0pQk1t fozbp21Kto66ZJLZbOMcq3VtsjiDcCDYsuCmZqOTguiQMhlmPr6+MmX2tIaMgMlx 6xuFubVjXegnSyS5GfhfnConXprOw/wCXiQlQX/3fth+SF5ks3c7kO9Zpn18zbBl Zi+QqbF8mKY= =EGYK -----END PGP SIGNATURE----- --=-=-=-- ------------=_1741367942-10727-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Mar 2025 13:03:20 +0000 Received: from localhost ([127.0.0.1]:47410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqXMF-0000rj-IW for submit@debbugs.gnu.org; Fri, 07 Mar 2025 08:03:19 -0500 Received: from lists.gnu.org ([2001:470:142::17]:55818) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqXMD-0000qa-Uh for submit@debbugs.gnu.org; Fri, 07 Mar 2025 08:03:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqXLK-0007ai-0g for guix-patches@gnu.org; Fri, 07 Mar 2025 08:02:26 -0500 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tqXLH-00045Y-9R for guix-patches@gnu.org; Fri, 07 Mar 2025 08:02:21 -0500 Received: from localhost (unknown [IPv6:2a02:6b67:e390:8b00::1ce5]) by mira.cbaines.net (Postfix) with ESMTPSA id 880D427BBE2 for ; Fri, 7 Mar 2025 13:02:16 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 21498c0b for ; Fri, 7 Mar 2025 13:02:15 +0000 (UTC) From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] services: nginx: Replace invoke with spawn-command. Date: Fri, 7 Mar 2025 13:02:15 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) I'm not sure where invoke is coming from here, but it could be from (guix build utils), that uses system* which uses waitpid, which might cause problems with recent versions of the shepherd? At least I'm seeing issues on multiple machines where attempting to restart the nginx service sometimes causes the shepherd to hang. * gnu/services/web.scm (nginx-shepherd-service): Replace invoke with spawn-command. Change-Id: Ie9ce4be9a4df121465b28148612b4fbc45fb5126 --- gnu/services/web.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/services/web.scm b/gnu/services/web.scm index 7593cd2eaa..b46a4db73f 100644 --- a/gnu/services/web.scm +++ b/gnu/services/web.scm @@ -870,7 +870,8 @@ (define (nginx-shepherd-service config) (nginx-action (lambda args #~(lambda _ - (invoke #$nginx-binary "-c" #$config-file #$@args) + (spawn-command + (list #$nginx-binary "-c" #$config-file #$@args)) (match '#$args (("-s" . _) #t) (_ base-commit: 9bc4c9f521caab8aa8d88aa948a650945bb55838 -- 2.48.1 ------------=_1741367942-10727-1-- From unknown Sat Aug 09 09:37:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#76811] [PATCH] services: nginx: Replace invoke with spawn-command. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Mar 2025 23:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76811 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 76811@debbugs.gnu.org Received: via spool by 76811-submit@debbugs.gnu.org id=B76811.17413889422323 (code B ref 76811); Fri, 07 Mar 2025 23:10:02 +0000 Received: (at 76811) by debbugs.gnu.org; 7 Mar 2025 23:09:02 +0000 Received: from localhost ([127.0.0.1]:51054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqgoP-0000bE-JR for submit@debbugs.gnu.org; Fri, 07 Mar 2025 18:09:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35740) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqgoM-0000ar-4v for 76811@debbugs.gnu.org; Fri, 07 Mar 2025 18:08:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqgoG-0001vE-6I; Fri, 07 Mar 2025 18:08:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=17/gFpX/do1NV9g6f+adoeO5zmU8lStCxwxGv+CBV0c=; b=BOk89ietEfkg3UQ1WTGV ajFPb5vjMB9E5JGvWhoNu0wXhbb41vK2lPZCUJAv/170BfL3e0voOditsqQ/OuYfbazmsLaNUe63S lqCrOdy1g9Jbz3zs6uCJB+AeXEwPu/mQHwmUK3PDFxMWgHIvwH6vg9GCk8nMPWC0uDJaAsdkwvsJ8 AbFaqu05w0mVQcSdcZyjmv9wwSdi4Lkzab2XpWd9NXBCBuoRnlMQAzYNZJ0n8A8TdBMJMeoY+9JI/ aA8MIiCCSixro9X4T2zpjZ80szZrKZph4uT5Nd1RB8OBRc5De2dSpQDK2CqFt2Dl81iPbN8WTZHrd 9LIsg68GlM6Jzg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <878qphvtak.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 07 Mar 2025 14:56:03 +0100") References: <878qphvtak.fsf@gnu.org> Date: Sat, 08 Mar 2025 00:08:44 +0100 Message-ID: <87y0xgv3pf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > I did try restarting nginx over and over again in the system test os, > but that seemed to work. > > On a VM I have though, it only takes a few restarts for it to hang, I'm > not sure why though. It could be that nginx alone would work well, but combining it with another service that does unusual things triggers the bug. One way to investigate would be to start from =E2=80=98bayfront.scm=E2=80= =99 (which I think has that problem) and boil it down until we have something that can run in a VM and reproduces the problem. I don=E2=80=99t see any =E2=80=98waitpid=E2=80=99 uses left in Shepherd ser= vices under gnu/services/*.scm. One thing I found that is risky is =E2=80=98guix-data-service-setup-databas= e=E2=80=99: it loads a bunch of (guix-data-service =E2=80=A6) modules into PID 1 and ru= ns non-trivial code in there; I strongly recommend doing this in a separate process, similar to how =E2=80=98bffe-shepherd-services=E2=80=99 does it. Ludo=E2=80=99. From unknown Sat Aug 09 09:37:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#76811] [PATCH] services: nginx: Replace invoke with spawn-command. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Mar 2025 22:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76811 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 76811@debbugs.gnu.org Received: via spool by 76811-submit@debbugs.gnu.org id=B76811.174164426828140 (code B ref 76811); Mon, 10 Mar 2025 22:05:02 +0000 Received: (at 76811) by debbugs.gnu.org; 10 Mar 2025 22:04:28 +0000 Received: from localhost ([127.0.0.1]:40253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trlEZ-0007Jo-7J for submit@debbugs.gnu.org; Mon, 10 Mar 2025 18:04:27 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:38368) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1trlEQ-0007JO-3u for 76811@debbugs.gnu.org; Mon, 10 Mar 2025 18:04:24 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 3551C54B; Mon, 10 Mar 2025 23:04:11 +0100 (CET) Authentication-Results: hera.aquilenet.fr; none X-Virus-Scanned: Debian amavis at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavis, port 10024) with ESMTP id 4U07i2lIBO8p; Mon, 10 Mar 2025 23:04:10 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id F2CF951E; Mon, 10 Mar 2025 23:04:09 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87y0xgv3pf.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 08 Mar 2025 00:08:44 +0100") References: <878qphvtak.fsf@gnu.org> <87y0xgv3pf.fsf@gnu.org> Date: Mon, 10 Mar 2025 23:04:08 +0100 Message-ID: <877c4wmtk7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: hera X-Rspamd-Queue-Id: 3551C54B X-Spamd-Result: default: False [-6.10 / 15.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM(-3.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spamd-Bar: ------ X-Rspamd-Action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Ludovic Court=C3=A8s skribis: > One thing I found that is risky is =E2=80=98guix-data-service-setup-datab= ase=E2=80=99: > it loads a bunch of (guix-data-service =E2=80=A6) modules into PID 1 and = runs > non-trivial code in there; I strongly recommend doing this in a separate > process, similar to how =E2=80=98bffe-shepherd-services=E2=80=99 does it. The guix-data-service tests shows that: https://ci.guix.gnu.org/build/9557216/log Namely: --8<---------------cut here---------------start------------->8--- [ 5.788985] shepherd[1]: Service loopback started. [ 5.790001] shepherd[1]: Service loopback running with value #t. Uncaught exception in task: In fibers.scm: 172:8 6 (_) In shepherd/service/system-log.scm: 180:10 5 (run-system-log #< getq: # ?) In srfi/srfi-1.scm: 586:17 4 (map1 (# #)) In shepherd/service/system-log.scm: 181:33 3 (_ #) In fibers/io-wakeup.scm: 72:13 2 (make-wait-operation # ?) 72:13 1 (make-wait-operation #f # ?) In ice-9/boot-9.scm: 1685:16 0 (raise-exception _ #:continuable? _) ice-9/boot-9.scm:1685:16: In procedure raise-exception: Wrong type to apply: # --8<---------------cut here---------------end--------------->8--- Here bindings in (fibers io-wakeup) are likely =E2=80=9Cpolluted=E2=80=9D b= y loading guile-fibers-next via the (guix-data-service =E2=80=A6) modules. Ludo=E2=80=99.