GNU bug report logs - #76796
[PATCH] gnu: fish: Add support for guix home profile.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76796: closed ([PATCH] gnu: fish: Add support for guix home
 profile.)
Date: Sun, 09 Mar 2025 21:37:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 09 Mar 2025 22:36:49 +0100
with message-id <87msdtq426.fsf <at> gnu.org>
and subject line Re: [bug#76796] [PATCH] gnu: fish: Add support for guix home profile.
has caused the debbugs.gnu.org bug report #76796,
regarding [PATCH] gnu: fish: Add support for guix home profile.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76796: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76796
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Luis Guilherme Coelho <lgcoelho <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: Luis Guilherme Coelho <lgcoelho <at> disroot.org>
Subject: [PATCH] gnu: fish: Add support for guix home profile.
Date: Thu,  6 Mar 2025 21:18:04 -0300

* gnu/packages/shells.scm (fish)[arguments]<#:phases>
{patch-fish-extra-paths}: Add `~/.guix-home/profile' to `__guix_profile_paths'.

Change-Id: If896cfc4f948d86c52073235a6f4a2c1d085e7a6
---
Currently, the completions, configurations and functions installed in
~/.guix-home/profile/etc/fish/{completions,conf.d,functions} are ignored,
as these directories aren't listed under __fish_vendor_completionsdirs,
__fish_vendor_confdirs and __fish_vendor_functionsdirs. This patch
addresses, and fixes, this issue.

 gnu/packages/shells.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
index 63bdf69705..e177a90de0 100644
--- a/gnu/packages/shells.scm
+++ b/gnu/packages/shells.scm
@@ -223,10 +223,10 @@ (define-public fish
                 (string-append
                  "\n\n"
                  "# Patched by Guix.\n"
-                 "# Enable completions, functions and configurations in user's"
-                 " and system's guix profiles by adding them to __extra_*"
+                 "# Enable completions, functions and configurations in user's,"
+                 " home's and system's guix profiles by adding them to __extra_*"
                  " variables.\n"
-                 "set -l __guix_profile_paths ~/.guix-profile"
+                 "set -l __guix_profile_paths ~/.guix-profile ~/.guix-home/profile"
                  " /run/current-system/profile\n"
                  "set __extra_completionsdir"
                  " $__guix_profile_paths\"/etc/fish/completions\""

base-commit: 310adf4ce70cbb864859274fcc7842bd519bbddc
-- 
2.48.1

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Luis Guilherme Coelho <lgcoelho <at> disroot.org>
Cc: 76796-done <at> debbugs.gnu.org
Subject: Re: [bug#76796] [PATCH] gnu: fish: Add support for guix home profile.
Date: Sun, 09 Mar 2025 22:36:49 +0100

Luis Guilherme Coelho <lgcoelho <at> disroot.org> skribis:

> * gnu/packages/shells.scm (fish)[arguments]<#:phases>
> {patch-fish-extra-paths}: Add `~/.guix-home/profile' to `__guix_profile_paths'.
>
> Change-Id: If896cfc4f948d86c52073235a6f4a2c1d085e7a6

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.