GNU bug report logs - #76770
[PATCH] gnu: lua: compile with readline support

Previous Next

Full log

Message #8 received at 76770 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: kimapr <kimapr <at> mail.ru>, 76770 <at> debbugs.gnu.org
Subject: Re: [bug#76770] [PATCH] gnu: lua: compile with readline support
Date: Mon, 10 Mar 2025 15:46:48 -0700

[Message part 1 (text/plain, inline)]

On 2025-03-05, kimapr wrote:
> * gnu/packages/lua.scm (lua)[arguments]: change target to
>   "linux-readline".
> ---
>  gnu/packages/lua.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm
> index 4c65bcbf12..b3d4cbf5d2 100644
> --- a/gnu/packages/lua.scm
> +++ b/gnu/packages/lua.scm
> @@ -109,7 +109,7 @@ (define-public lua
>               (string-append "CC=" ,(cc-for-target))
>               (string-append "SYSLIBS=-L" (assoc-ref %build-inputs
> "readline")
>                              "/lib")
> -             "linux")
> +             "linux-readline")
>         #:phases
>         (modify-phases %standard-phases
>           (delete 'configure)
> -- 
> 2.47.1

Patch was slightly malformed for some reason, but being a one-liner, was
easy to apply manually!

At first glance, it increases the results from guix size only slightly
from 77.0MB to 84.4MB, and has a smallish number of dependents...

But lua <at> 5.1 lua <at> 5.2 and lua <at> 5.3 inherit from lua, so the impact is much
larger than a quick glance suggests (especially lua <at> 5.3):

    $ guix refresh --list-dependent lua <at> 5.1 lua <at> 5.2 lua <at> 5.3 lua <at> 5.4
    Building the following 359 packages would ensure 604 dependent
    packages are rebuilt: grafx2 <at> 2.4 hedgewars <at> 1.0.2 btanks <at> 0.9.8083
    crawl-tiles <at> 0.32.1 fillets-ng <at> 1.0.1 ...

I did successfully build lua <at> 5.4 and it's four dependents.

https://guix.gnu.org/manual/devel/en/guix.html#Managing-Patches-and-Branches

  Changes which affect more than 300 dependent packages (see Invoking guix
  refresh) should first be pushed to a topic branch other than master

Would it make sense to exclude the older versions from the change? Then
it could go to the git master banch, in my opinion.


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.