Subject: Re: [bug#76770] [PATCH] gnu: lua: compile with readline support

From: Vagrant Cascadian <[email-masked]>
Date: Mon, 10 Mar 2025 16:34:44 -0700

On 2025-03-10, Vagrant Cascadian wrote:
> On 2025-03-05, kimapr wrote:
> At first glance, it increases the results from guix size only slightly
> from 77.0MB to 84.4MB, and has a smallish number of dependents...
>
> But [email-masked] [email-masked] and [email-masked] inherit from lua, so the impact is much
> larger than a quick glance suggests (especially [email-masked]):

Oops, I had this slightly wrong... lua-5.1, lua-5.2 and lua-5.4 inherit
from lua (which is effectively [email-masked]).

> Would it make sense to exclude the older versions from the change? Then
> it could go to the git master banch, in my opinion.

In fact versions 5.1, 5.2 and 5.3 do not support this option passed to
make at all, and fail to build with the patch applied!

I just checked that [email-masked], [email-masked] and [email-masked] all do support
readline, so it is only [email-masked] that does not currently have readline
support.

So the patch needs to be re-worked ot only apply to lua-5.4. But then
should be able to be pushed directly as it does not have many
dependents.

live well,
  vagrant