GNU bug report logs - #76759
[PATCH] 31.0.50; makefile-mode: incorrectly highlights make-instructions as make targets

Previous Next

Full log

Message #28 received at 76759 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>, Paul Smith <psmith <at> gnu.org>
Cc: arne_bab <at> web.de, 76759 <at> debbugs.gnu.org, maurooaranda <at> gmail.com,
 emacs-devel <at> gnu.org
Subject: Re: bug#76759: [PATCH] 31.0.50;
 makefile-mode: incorrectly highlights make-instructions as make
 targets
Date: Sun, 09 Mar 2025 08:34:40 +0200

[Message part 1 (text/plain, inline)]

> Cc: 76759 <at> debbugs.gnu.org,
>  "Ergus via Emacs development discussions." <emacs-devel <at> gnu.org>
> From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
> Date: Sat, 8 Mar 2025 22:54:22 +0100
> 
> Any news on this one?
> 
> Has anyone tested this? Anyone have any objection to the change?

The Makefile syntax is tricky wrt whitespace, and target names can
include colons, definitely on MS-Windows, but also on Posix systems.
Also, there are various old formats, like that of Imakefile, that
should still be supported, AFAIK.  And we don't have a test suite for
this mode.  So I very much wonder whether this change will introduce
regressions.

Maybe Paul Smith, the maintainer of GNU Make (CC'ed), could help us
here.  Or maybe Stefan has comments?  For their convenience, I
re-attach the proposed patch below.

Thanks.

[0001-Fix-fontification-error-in-makefile-mode.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.