GNU bug report logs - #76759
[PATCH] 31.0.50; makefile-mode: incorrectly highlights make-instructions as make targets

Previous Next

Package: emacs;

Reported by: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>

Date: Wed, 5 Mar 2025 09:34:02 UTC

Severity: normal

Tags: confirmed, patch

Merged with 17400, 33681, 33900, 35299, 36245, 37934, 45037, 46052, 46221, 48052

Found in version 26.1

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

Message #25 received at 76759 <at> debbugs.gnu.org (full text, mbox):

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: Mauro Aranda <maurooaranda <at> gmail.com>,
 "Dr. Arne Babenhauserheide" <arne_bab <at> web.de>
Cc: 76759 <at> debbugs.gnu.org,
 "Ergus via Emacs development discussions." <emacs-devel <at> gnu.org>
Subject: Re: [PATCH] 31.0.50; makefile-mode: incorrectly highlights
 make-instructions as make targets
Date: Sat, 8 Mar 2025 22:54:22 +0100

[Message part 1 (text/plain, inline)]
Any news on this one?

Has anyone tested this? Anyone have any objection to the change?

—
Kind Regards
Jostein Kjønigsen

> On 5 Mar 2025, at 14:28, Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> wrote:
> 
> Tested with \t and that works too. Attached is a patch containing these changes and which fixes this (these) bug(s).
> 
> <0001-Fix-fontification-error-in-makefile-mode.patch>
> —
> Kind Regards
> Jostein Kjønigsen
> 
>> On 5 Mar 2025, at 14:19, Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> wrote:
>> 
>>> From the Makefile format, I think this should not be leading whitespace, but only leading tabs. Leading spaces in rules are a syntax error. Can you check whether \t instead of \s also works?
>> 
>> 
>> Good catch, Arne. Will check.
>> 
>>> Looks like the 10th duplicate of Bug#17400.
>> 
>> 
>> Also good catch, Mauro. Can someone merge these 2 bugs?
>> 
>> But honestly: A more than 10 year old bug!!! About time we get it fixed!
>> 
>> I'll report back as soon as I have a new patch!
>> 
>> —
>> Kind Regards
>> Jostein Kjønigsen
>> 
> 


[Message part 2 (text/html, inline)]
This bug report was last modified 71 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.