From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 04:33:16 2025 Received: (at submit) by debbugs.gnu.org; 5 Mar 2025 09:33:17 +0000 Received: from localhost ([127.0.0.1]:35268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpl7q-0000sH-3T for submit@debbugs.gnu.org; Wed, 05 Mar 2025 04:33:16 -0500 Received: from lists.gnu.org ([2001:470:142::17]:45934) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tpl7j-0000rk-Vg for submit@debbugs.gnu.org; Wed, 05 Mar 2025 04:33:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tpl7d-0007Yl-6A; Wed, 05 Mar 2025 04:33:01 -0500 Received: from fhigh-a1-smtp.messagingengine.com ([103.168.172.152]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tpl7Z-0002sh-DK; Wed, 05 Mar 2025 04:33:00 -0500 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id 0622B11401C0; Wed, 5 Mar 2025 04:32:53 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Wed, 05 Mar 2025 04:32:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm3; t=1741167173; x=1741253573; bh=jb mLETdglPZAT+FD7LdRGuW5RnFSZkR1yh1CskMZvBY=; b=tvyBuENwxd6HdA8BKY 2DqVQT3SVc64DHeakXWYyCU2kaXAOhUYjwD3SVa9oq0yvBO43kRAsMZXKcTd57k7 +lirpSyNaNZfdnVaOkCjpNfA4+jZwVN0nFh+YbXLQzw0GbiHnWMAmd5I19lQohWe 47RfhNjL+zWjvmd2FLqmMiq+/WVQERobGVx3duFLYX2AUjSBcpwjYzedTDkDekj7 V4fJZ1D4hjD6YO/WZXm2N8QloO3mkLD/7ysnD94zapxK7bOgg351jGRfGJwNhOce Uq3Pe7QgUTAvsqNMqpSo75exvdrSVfR8LujiKvXOUDW5GLOLlXHjkoVFmTBWBdjR vBZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1741167173; x= 1741253573; bh=jbmLETdglPZAT+FD7LdRGuW5RnFSZkR1yh1CskMZvBY=; b=z /hsOVXdNIxb9z2XXbbr19KZ4BLvFcyzDyosUazlDayI9tenYUamd5kPAFc5vDPGU DZpiKZD78aQ/m/4GXsUB0CSTTpj6dMmRngvCq1oLxX3M24mPQMH14c/Wcr7d/1jf Gn6ypZt6EjcDIMsVuwMefVDEdjlPy0LTanIk6EEFAw9Qp6+KGUjDeV5fj20/V7b6 8DVb5V3SM/8ISWtEpGyl/0iuu7/IEQkYY4ZxM16g0cAnae/5FukuqcgqNseClxjs 4Gwv1Hiwe+0wwk/u3CHPG5bncaQtTZG2q/9ZBg1/mAHXWoiKmiFQ6bc1AtaWCTuq lZRfZ1IE1Ld4YJvdCqRHQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddutdeggeeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephfgtggfukfffvefvofesrgdtmherhhdtvden ucfhrhhomheplfhoshhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvg gtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepleetveeu ffeihfdvgeeivdeiveelleegtedujefhjeekkeffueekjefgffeggfelnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgv tghurhgvrdhkjhhonhhighhsvghnrdhnvghtpdhnsggprhgtphhtthhopedvpdhmohguvg epshhmthhpohhuthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdho rhhgpdhrtghpthhtohepvghmrggtshdquggvvhgvlhesghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Mar 2025 04:32:51 -0500 (EST) From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Content-Type: multipart/alternative; boundary="Apple-Mail=_DCC3467D-9594-44D0-A1AF-E72761DF7A0B" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: [PATCH] 31.0.50; makefile-mode: incorrectly highlights make-instructions as make targets Message-Id: Date: Wed, 5 Mar 2025 10:32:39 +0100 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3826.400.131.1.6) Received-SPF: pass client-ip=103.168.172.152; envelope-from=jostein@secure.kjonigsen.net; helo=fhigh-a1-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: "Ergus via Emacs development discussions." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --Apple-Mail=_DCC3467D-9594-44D0-A1AF-E72761DF7A0B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hey everyone. I found a bug in makefile-mode fontification. Currently shell-commands/make-instructions within a target may get = fontified as make-targets if they contain a : (colon) sign. Consider the following make-target: ------- Makefile ------ run-docker: build-docker docker run -p 8080:8080 imagename -------------------------- This defined a make-target called "run-docker" which depends on = "build-docker", which runs the command "docker run -p 8080:8080 = imagename". In the current code, since the command contains a ":" the whole text up = to that point ("docker run -p 8080") gets fontified as a make-target, = even though it's clearly not declared at the beginning of the line. Based on my digging, this seems to be due to the matching criteria = defined in makefile-dependency-regex. A common pattern used in this regex is "[^\n$#]" (with slight = variations), which (from how I read regexps) aims to match anything = which is not a lineshift, a $-sign or a #-sign. "Anything" in this case would then also include whitespace, which IMO is = the source of the bug. I've tried changing this part of the statement in parts of the regex to = "[^\n\s$#]", like in the attached patch. Ie also exclude leading = whitespace. =46rom what I've tested, it does not seem to have any = adverse effects, although I may not have tested all areas affected by = this change. Feel free to test the suggested changes, and let me know if they can be = improved in any way. =EF=BF=BC =E2=80=94 Kind Regards Jostein Kj=C3=B8nigsen In GNU Emacs 31.0.50 (build 19, aarch64-apple-darwin24.3.0, NS appkit-2575.40 Version 15.3.1 (Build 24D70)) of 2025-03-03 built on SOK67R3KWV97 Repository revision: 38ed2238316a83ad2c95db04f115c38ade48514f Repository branch: master Windowing system distributor 'Apple', version 10.3.2575 System Description: macOS 15.3.1 Configured using: 'configure --with-tree-sitter --with-native-compilation --with-imagemagick --with-harfbuzz' Configured features: ACL GLIB GNUTLS IMAGEMAGICK LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 value of $LC_CTYPE: UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: BSDmakefile Minor modes in effect: treemacs-filewatch-mode: t treemacs-follow-mode: t treemacs-hide-gitignored-files-mode: t treemacs-git-mode: t treemacs-fringe-indicator-mode: t global-git-commit-mode: t magit-auto-revert-mode: t electric-pair-mode: t highlight-symbol-mode: t flycheck-mode: t editorconfig-mode: t indent-bars-mode: t completion-preview-mode: t which-function-mode: t delete-selection-mode: t global-auto-revert-mode: t poetry-tracking-mode: t all-the-icons-completion-mode: t marginalia-mode: t vertico-mode: t global-nlinum-mode: t nlinum-mode: t override-global-mode: t server-mode: t global-hl-line-mode: t pixel-scroll-precision-mode: t doom-modeline-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t hs-minor-mode: t Load-path shadows: /Users/josteink/.emacs.d/elpa/transient-20250301.2218/transient hides = /Users/josteink/build/emacs/lisp/transient Features: (shadow sort mail-extr emacsbug lisp-mnt re-builder make-mode dockerfile-ts-mode conf-mode em-unix em-term term ehelp em-script em-prompt em-pred em-ls em-hist em-glob em-extpipe em-cmpl em-dirs em-basic em-banner em-alias esh-mode esh-var expand-region text-mode-expansions the-org-mode-expansions python-el-fgallina-expansions html-mode-expansions er-basic-expansions expand-region-core expand-region-custom whitespace hydra lv treemacs-hydras tabify treemacs-mouse-interface treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-bookmarks treemacs-tags treemacs-interface treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering treemacs-annotations treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-faces treemacs-icons treemacs-scope treemacs-themes treemacs-core-utils pfuture ht treemacs-logging treemacs-customization treemacs-macros ido yaml-ts-mode display-line-numbers misearch multi-isearch help-fns radix-tree bicep-ts-mode magit-gitignore git-rebase goto-addr magit-extras vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view vc bug-reference magit-bookmark magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode git-commit log-edit pcvs-util magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode benchmark magit-git magit-base magit-section cursor-sensor crm llama markdown-mode add-log elec-pair json-ts-mode vc-git vc-dispatcher tramp-cache time-stamp tramp-sh pulse org-duration diary-lib diary-loaddefs cal-iso disp-table oc-basic ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win ol-docview doc-view jka-compr image-mode exif dired dired-loaddefs ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi org-agenda elisp-slime-nav etags fileloop paredit highlight-symbol flycheck editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch indent-bars-ts indent-bars cus-edit cus-start cus-load face-remap color eglot tree-widget external-completion jsonrpc flymake diff ert ewoc debug backtrace compile completion-preview which-func hideshow eww vtable url-queue shr pixel-fill kinsoku url-file svg xml puny mm-url gnus nnheader gnus-util mail-utils range wid-edit mm-util mail-prsvr tramp trampver tramp-integration tramp-message tramp-compat shell parse-time iso8601 tramp-loaddefs imenu ob-plantuml delsel autorevert filenotify embark-org org-element org-persist org-id org-refile org-element-ast inline avl-tree org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src sh-script smie executable ob-comint org-pcomplete org-list org-footnote org-faces org-entities time-date noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs poetry pyvenv eshell esh-cmd esh-ext esh-proc esh-opt esh-io esh-arg pcomplete esh-module esh-module-loaddefs esh-util embark-consult consult bookmark text-property-search embark ffap orderless all-the-icons-completion marginalia vertico nlinum linum use-package-bind-key bind-key server hl-line pixel-scroll cua-base all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core shrink-path f s dash nerd-icons nerd-icons-faces nerd-icons-data nerd-icons-data-mdicon nerd-icons-data-flicon nerd-icons-data-codicon nerd-icons-data-devicon nerd-icons-data-sucicon nerd-icons-data-wicon nerd-icons-data-faicon nerd-icons-data-powerline nerd-icons-data-octicon nerd-icons-data-pomicon nerd-icons-data-ipsicon dracula-theme use-package-ensure use-package-core finder-inf all-the-icons-completion-autoloads all-the-icons-autoloads bmx-mode-autoloads cargo-autoloads cmake-mode-autoloads combobulate-autoloads combobulate-go combobulate-json combobulate-yaml combobulate-css combobulate-js-ts combobulate-python combobulate-html combobulate-toml combobulate-cursor multiple-cursors mc-separate-operations rectangular-region-mode mc-mark-pop mc-edit-lines mc-hide-unmatched-lines-mode mc-mark-more sgml-mode facemenu dom thingatpt mc-cycle-cursors multiple-cursors-core advice comp comp-cstr cl-extra help-mode warnings comp-run comp-common rect combobulate-query savehist xref files-x scheme combobulate-ui transient pp format-spec edmacro kmacro combobulate-display combobulate-ztree combobulate-envelope combobulate-manipulation python rx project compat comint ansi-osc ring ansi-color combobulate-procedure combobulate-navigation combobulate-misc combobulate-setup tempo combobulate-interface combobulate-settings diff-mode track-changes easy-mmode treesit generator combobulate-rules company-autoloads copilot-mode-autoloads crontab-mode-autoloads dap-mode-autoloads bui-autoloads doom-modeline-autoloads dracula-theme-autoloads elisp-slime-nav-autoloads embark-consult-autoloads consult-autoloads embark-autoloads expand-region-autoloads flycheck-autoloads highlight-symbol-autoloads indent-bars-autoloads lsp-docker-autoloads lsp-treemacs-autoloads lsp-mode-autoloads magit-autoloads pcase magit-section-autoloads llama-autoloads marginalia-autoloads markdown-mode-autoloads multiple-cursors-autoloads nerd-icons-autoloads nlinum-autoloads orderless-autoloads paredit-autoloads poetry-autoloads powershell-autoloads pyvenv-autoloads shrink-path-autoloads f-autoloads spinner-autoloads transient-autoloads treemacs-autoloads cfrs-autoloads posframe-autoloads ht-autoloads hydra-autoloads lv-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads s-autoloads dash-autoloads undo-tree-autoloads queue-autoloads vertico-autoloads wgrep-autoloads info with-editor-autoloads wsd-mode-autoloads yaml-autoloads package browse-url xdg url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process tty-child-frames native-compile emacs) Memory information: ((conses 16 1136723 236110) (symbols 48 57070 3) (strings 32 315761 12126) (string-bytes 1 9424642) (vectors 16 112250) (vector-slots 8 2121204 187375) (floats 8 1899 10828) (intervals 56 21125 6631) (buffers 992 88)) --Apple-Mail=_DCC3467D-9594-44D0-A1AF-E72761DF7A0B Content-Type: multipart/mixed; boundary="Apple-Mail=_7D2A2F88-BB78-40DB-8AAF-5DD1DFEA48D5" --Apple-Mail=_7D2A2F88-BB78-40DB-8AAF-5DD1DFEA48D5 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
Hey = everyone.

I found a bug in makefile-mode = fontification.

Currently = shell-commands/make-instructions within a target may get fontified as = make-targets if they contain a : (colon) = sign.

Consider the following = make-target:

------- Makefile = ------

run-docker: = build-docker
docker run -p 8080:8080 = imagename

--------------------------
<= div>
This defined a make-target called "run-docker" which = depends on "build-docker", which runs the command "docker run -p = 8080:8080 imagename".

In the current code, = since the command contains a ":" the whole text up to that point = ("docker run -p 8080") gets fontified as a make-target, even though it's = clearly not declared at the beginning of the = line.

Based on my digging, this seems to be due = to the matching criteria defined = in makefile-dependency-regex.

A = common pattern used in this regex is "[^\n$#]" (with slight = variations), which (from how I read regexps) aims to match anything = which is not a lineshift, a $-sign or a = #-sign.

"Anything" in this case would then also = include whitespace, which IMO is the source of the = bug.

I've tried changing this part of the = statement in parts of the regex to "[^\n\s$#]", like in the = attached patch. Ie also exclude leading whitespace. =46rom what I've = tested, it does not seem to have any adverse effects, although I may not = have tested all areas affected by this = change.

Feel free to test the suggested = changes, and let me know if they can be improved in any = way.

= --Apple-Mail=_7D2A2F88-BB78-40DB-8AAF-5DD1DFEA48D5 Content-Disposition: attachment; filename=0001-Fix-fontification-error-in-makefile-mode.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-fontification-error-in-makefile-mode.patch" Content-Transfer-Encoding: quoted-printable =46rom=209774fe6028b0c5341aa7bf85adf20464e9ac4b5e=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Jostein=3D20Kj=3DC3=3DB8nigsen?=3D=20= =0ADate:=20Wed,=205=20Mar=202025=2010:24:09=20= +0100=0ASubject:=20[PATCH]=20Fix=20fontification=20error=20in=20= makefile-mode.=0A=0A-=20lisp/progmodes/make-mode.el:=20= makefile-dependency-regex=0A=0AEnsure=20we=20check=20for=20leading=20= spaces=20when=20trying=20to=20match=20make-targets.=0A---=0A=20= lisp/progmodes/make-mode.el=20|=202=20+-=0A=201=20file=20changed,=201=20= insertion(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/lisp/progmodes/make-mode.el=20b/lisp/progmodes/make-mode.el=0Aindex=20= 0ae74630cff..7e0ccb0697e=20100644=0A---=20a/lisp/progmodes/make-mode.el=0A= +++=20b/lisp/progmodes/make-mode.el=0A@@=20-226,7=20+226,7=20@@=20= makefile-runtime-macros-list=0A=20;;=20index=20in=20= makefile-imenu-generic-expression.=0A=20(defvar=20= makefile-dependency-regex=0A=20=20=20;;=20Allow=20for=20two=20nested=20= levels=20$(v1:$(v2:$(v3:a=3Db)=3Dc)=3Dd)=0A-=20=20= "^\\(\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[^({]\\|.[^\n$#})]+?[}= )]\\)\\|[^\n$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n$#)}]\\)+?[})]\\|[^({]\\)\\|[^= \n$#:=3D]\\)+?\\)\\(:\\)\\(?:[=20\t]*$\\|[^=3D\n]\\(?:[^#\n]*?;[=20= \t]*\\(.+\\)\\)?\\)"=0A+=20=20= "^\\(\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[^({]\\|.[^\n\s$#})]+?= [})]\\)\\|[^\n\s$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n\s$#)}]\\)+?[})]\\|[^({]\\= )\\|[^\n\s$#:=3D]\\)+?\\)\\(:\\)\\(?:[=20\t]*$\\|[^=3D\n]\\(?:[^#\n]*?;[=20= \t]*\\(.+\\)\\)?\\)"=0A=20=20=20"Regex=20used=20to=20find=20dependency=20= lines=20in=20a=20makefile.")=0A=20=0A=20(defconst=20= makefile-bsdmake-dependency-regex=0A--=20=0A2.48.1=0A=0A= --Apple-Mail=_7D2A2F88-BB78-40DB-8AAF-5DD1DFEA48D5 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
=E2=80=94
Kind Regards
Jostein = Kj=C3=B8nigsen


In GNU Emacs 31.0.50 (build 19, = aarch64-apple-darwin24.3.0, NS
 appkit-2575.40 Version = 15.3.1 (Build 24D70)) of 2025-03-03 built = on
 SOK67R3KWV97
Repository revision: = 38ed2238316a83ad2c95db04f115c38ade48514f
Repository branch: = master
Windowing system distributor 'Apple', version = 10.3.2575
System Description:  macOS = 15.3.1

Configured = using:
 'configure --with-tree-sitter = --with-native-compilation
 --with-imagemagick = --with-harfbuzz'

Configured = features:
ACL GLIB GNUTLS IMAGEMAGICK LCMS2 LIBXML2 MODULES = NATIVE_COMP NOTIFY
KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS = TOOLKIT_SCROLL_BARS
TREE_SITTER WEBP XIM = ZLIB

Important settings:
  value = of $LC_ALL: en_US.UTF-8
  value of $LC_CTYPE: = UTF-8
  value of $LANG: en_US.UTF-8
  = locale-coding-system: utf-8-unix

Major mode: = BSDmakefile

Minor modes in = effect:
  treemacs-filewatch-mode: t
  = treemacs-follow-mode: t
  = treemacs-hide-gitignored-files-mode: t
  = treemacs-git-mode: t
  treemacs-fringe-indicator-mode: = t
  global-git-commit-mode: t
  = magit-auto-revert-mode: t
  electric-pair-mode: = t
  highlight-symbol-mode: t
  = flycheck-mode: t
  editorconfig-mode: t
  = indent-bars-mode: t
  completion-preview-mode: = t
  which-function-mode: t
  = delete-selection-mode: t
  global-auto-revert-mode: = t
  poetry-tracking-mode: t
  = all-the-icons-completion-mode: t
  marginalia-mode: = t
  vertico-mode: t
  global-nlinum-mode: = t
  nlinum-mode: t
  override-global-mode: = t
  server-mode: t
  global-hl-line-mode: = t
  pixel-scroll-precision-mode: t
  = doom-modeline-mode: t
  tooltip-mode: t
  = global-eldoc-mode: t
  show-paren-mode: = t
  electric-indent-mode: t
  = mouse-wheel-mode: t
  menu-bar-mode: t
  = file-name-shadow-mode: t
  global-font-lock-mode: = t
  font-lock-mode: t
  blink-cursor-mode: = t
  minibuffer-regexp-mode: t
  = column-number-mode: t
  line-number-mode: = t
  indent-tabs-mode: t
  = transient-mark-mode: t
  auto-composition-mode: = t
  auto-encryption-mode: t
  = auto-compression-mode: t
  hs-minor-mode: = t

Load-path = shadows:
/Users/josteink/.emacs.d/elpa/transient-20250301.2218/t= ransient hides = /Users/josteink/build/emacs/lisp/transient

Featur= es:
(shadow sort mail-extr emacsbug lisp-mnt re-builder = make-mode
dockerfile-ts-mode conf-mode em-unix em-term term = ehelp em-script
em-prompt em-pred em-ls em-hist em-glob = em-extpipe em-cmpl em-dirs
em-basic em-banner em-alias = esh-mode esh-var expand-region
text-mode-expansions = the-org-mode-expansions
python-el-fgallina-expansions = html-mode-expansions er-basic-expansions
expand-region-core = expand-region-custom whitespace hydra lv
treemacs-hydras = tabify treemacs-mouse-interface treemacs
treemacs-header-line = treemacs-compatibility treemacs-mode
treemacs-bookmarks = treemacs-tags treemacs-interface = treemacs-persistence
treemacs-filewatch-mode = treemacs-follow-mode treemacs-rendering
treemacs-annotations = treemacs-async treemacs-workspaces = treemacs-dom
treemacs-visuals treemacs-fringe-indicator = treemacs-faces treemacs-icons
treemacs-scope treemacs-themes = treemacs-core-utils pfuture ht
treemacs-logging = treemacs-customization treemacs-macros ido = yaml-ts-mode
display-line-numbers misearch multi-isearch = help-fns radix-tree
bicep-ts-mode magit-gitignore git-rebase = goto-addr magit-extras vc-hg
vc-bzr vc-src vc-sccs vc-svn = vc-cvs vc-rcs log-view vc bug-reference
magit-bookmark = magit-submodule magit-blame magit-stash = magit-reflog
magit-bisect magit-push magit-pull magit-fetch = magit-clone magit-remote
magit-commit magit-sequence = magit-notes magit-worktree magit-tag
magit-merge magit-branch = magit-reset magit-files magit-refs magit-status
magit = magit-repos magit-apply magit-wip magit-log magit-diff = smerge-mode
git-commit log-edit pcvs-util magit-core = magit-autorevert magit-margin
magit-transient magit-process = with-editor magit-mode benchmark magit-git
magit-base = magit-section cursor-sensor crm llama markdown-mode = add-log
elec-pair json-ts-mode vc-git vc-dispatcher = tramp-cache time-stamp
tramp-sh pulse org-duration diary-lib = diary-loaddefs cal-iso disp-table
oc-basic ol-eww ol-rmail = ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art
mm-uu mml2015 = mm-view mml-smime smime gnutls dig gnus-sum = gnus-group
gnus-undo gnus-start gnus-dbus dbus gnus-cloud = nnimap nnmail mail-source
utf7 nnoo gnus-spec gnus-int = gnus-range message sendmail yank-media
rfc822 mml mml-sec epa = derived epg rfc6068 epg-config mm-decode
mm-bodies mm-encode = mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mailabbrev = gmm-utils mailheader gnus-win ol-docview doc-view = jka-compr
image-mode exif dired dired-loaddefs ol-bibtex = bibtex ol-bbdb ol-w3m
ol-doi org-link-doi org-agenda = elisp-slime-nav etags fileloop paredit
highlight-symbol = flycheck editorconfig = editorconfig-core
editorconfig-core-handle = editorconfig-fnmatch indent-bars-ts indent-bars
cus-edit = cus-start cus-load face-remap color eglot = tree-widget
external-completion jsonrpc flymake diff ert ewoc = debug backtrace
compile completion-preview which-func hideshow = eww vtable url-queue shr
pixel-fill kinsoku url-file svg xml = puny mm-url gnus nnheader gnus-util
mail-utils range wid-edit = mm-util mail-prsvr tramp trampver
tramp-integration = tramp-message tramp-compat shell parse-time = iso8601
tramp-loaddefs imenu ob-plantuml delsel autorevert = filenotify embark-org
org-element org-persist org-id = org-refile org-element-ast inline
avl-tree org ob ob-tangle = ob-ref ob-lob ob-table ob-exp org-macro
org-src sh-script smie = executable ob-comint org-pcomplete org-list
org-footnote = org-faces org-entities time-date noutline = outline
ob-emacs-lisp ob-core ob-eval org-cycle org-table ol = org-fold
org-fold-core org-keys oc org-loaddefs find-func = cal-menu calendar
cal-loaddefs org-version org-compat org-macs = poetry pyvenv eshell
esh-cmd esh-ext esh-proc esh-opt esh-io = esh-arg pcomplete esh-module
esh-module-loaddefs esh-util = embark-consult consult bookmark
text-property-search embark = ffap orderless all-the-icons-completion
marginalia vertico = nlinum linum use-package-bind-key bind-key server
hl-line = pixel-scroll cua-base all-the-icons = all-the-icons-faces
data-material data-weathericons = data-octicons data-fileicons
data-faicons data-alltheicons = doom-modeline doom-modeline-segments
doom-modeline-env = doom-modeline-core shrink-path f s dash = nerd-icons
nerd-icons-faces nerd-icons-data = nerd-icons-data-mdicon
nerd-icons-data-flicon = nerd-icons-data-codicon = nerd-icons-data-devicon
nerd-icons-data-sucicon = nerd-icons-data-wicon = nerd-icons-data-faicon
nerd-icons-data-powerline = nerd-icons-data-octicon
nerd-icons-data-pomicon = nerd-icons-data-ipsicon dracula-theme
use-package-ensure = use-package-core finder-inf
all-the-icons-completion-autoloads = all-the-icons-autoloads
bmx-mode-autoloads cargo-autoloads = cmake-mode-autoloads
combobulate-autoloads combobulate-go = combobulate-json combobulate-yaml
combobulate-css = combobulate-js-ts combobulate-python = combobulate-html
combobulate-toml combobulate-cursor = multiple-cursors
mc-separate-operations = rectangular-region-mode mc-mark-pop = mc-edit-lines
mc-hide-unmatched-lines-mode mc-mark-more = sgml-mode facemenu dom
thingatpt mc-cycle-cursors = multiple-cursors-core advice comp comp-cstr
cl-extra help-mode = warnings comp-run comp-common rect combobulate-query
savehist = xref files-x scheme combobulate-ui transient pp = format-spec
edmacro kmacro combobulate-display = combobulate-ztree
combobulate-envelope = combobulate-manipulation python rx project compat
comint = ansi-osc ring ansi-color = combobulate-procedure
combobulate-navigation combobulate-misc = combobulate-setup tempo
combobulate-interface = combobulate-settings diff-mode track-changes
easy-mmode = treesit generator combobulate-rules = company-autoloads
copilot-mode-autoloads = crontab-mode-autoloads dap-mode-autoloads
bui-autoloads = doom-modeline-autoloads = dracula-theme-autoloads
elisp-slime-nav-autoloads = embark-consult-autoloads consult-autoloads
embark-autoloads = expand-region-autoloads = flycheck-autoloads
highlight-symbol-autoloads = indent-bars-autoloads = lsp-docker-autoloads
lsp-treemacs-autoloads lsp-mode-autoloads = magit-autoloads pcase
magit-section-autoloads llama-autoloads = marginalia-autoloads
markdown-mode-autoloads = multiple-cursors-autoloads = nerd-icons-autoloads
nlinum-autoloads orderless-autoloads = paredit-autoloads poetry-autoloads
powershell-autoloads = pyvenv-autoloads shrink-path-autoloads = f-autoloads
spinner-autoloads transient-autoloads = treemacs-autoloads cfrs-autoloads
posframe-autoloads = ht-autoloads hydra-autoloads lv-autoloads
pfuture-autoloads = ace-window-autoloads avy-autoloads s-autoloads
dash-autoloads = undo-tree-autoloads queue-autoloads = vertico-autoloads
wgrep-autoloads info with-editor-autoloads = wsd-mode-autoloads
yaml-autoloads package browse-url xdg url = url-proxy url-privacy
url-expand url-methods url-history = url-cookie generate-lisp-file
url-domsuf url-util mailcap = url-handlers url-parse auth-source cl-seq
eieio eieio-core = cl-macs icons password-cache json subr-x map byte-opt
gv = bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc = iso-transl
tooltip cconv eldoc paren electric uniquify = ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel = term/ns-win ns-win ucs-normalize
mule-util term/common-win = tool-bar dnd fontset image regexp-opt fringe
tabulated-list = replace newcomment text-mode lisp-mode prog-mode register
page = tab-bar menu-bar rfn-eshadow isearch easymenu timer = select
scroll-bar mouse jit-lock font-lock syntax font-core = term/tty-colors
frame minibuffer nadvice seq simple cl-generic = indonesian philippine
cham georgian utf-8-lang misc-lang = vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms = cp51932 hebrew greek romanian slovak czech
european ethiopic = indian cyrillic chinese composite emoji-zwj = charscript
charprop case-table epa-hook jka-cmpr-hook help = abbrev obarray oclosure
cl-preloaded button loaddefs = theme-loaddefs faces cus-face macroexp
files window = text-properties overlay sha1 md5 base64 format env
code-pages = mule custom widget keymap hashtable-print-readable = backquote
threads kqueue cocoa ns lcms2 multi-tty = make-network-process
tty-child-frames native-compile = emacs)

Memory information:
((conses = 16 1136723 236110) (symbols 48 57070 3)
 (strings 32 = 315761 12126) (string-bytes 1 9424642)
 (vectors 16 = 112250) (vector-slots 8 2121204 187375)
 (floats 8 1899 = 10828) (intervals 56 21125 6631) (buffers 992 = 88))

= --Apple-Mail=_7D2A2F88-BB78-40DB-8AAF-5DD1DFEA48D5-- --Apple-Mail=_DCC3467D-9594-44D0-A1AF-E72761DF7A0B-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 06:55:07 2025 Received: (at submit) by debbugs.gnu.org; 5 Mar 2025 11:55:07 +0000 Received: from localhost ([127.0.0.1]:35926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpnL9-0002eu-Ap for submit@debbugs.gnu.org; Wed, 05 Mar 2025 06:55:07 -0500 Received: from lists.gnu.org ([2001:470:142::17]:50660) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tpnL6-0002aX-Nm for submit@debbugs.gnu.org; Wed, 05 Mar 2025 06:55:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tpnKt-0008TR-07; Wed, 05 Mar 2025 06:54:51 -0500 Received: from mout.web.de ([217.72.192.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tpnKr-0002dH-7i; Wed, 05 Mar 2025 06:54:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1741175685; x=1741780485; i=arne_bab@web.de; bh=6hLvZGCJlD9DLE7251z0fCm9BkMRurDNxtTUfScZ1kM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=Avs3qSYtuAKGs8c90uPAmrMoHCMVwoxzWoSCJ61rhWm1UuQq4yEjyMxs1EbkhRbP Yku14O4pWm74QV57vxzRy1nOhjUIuHV6n4CWFc5E8haOcQ5lzf6C+PTZAVhZwMA2h +6XVntX2llpNpUlKKgCCbsr/z29K9NsiBPt1QAIHyIlk7iWKVZqbgNCLTrj/S1HLJ Ji3QMFU0eD2TRyF8c/U7uErojDWxUURdwz8VIMlNJnzF5hDdxbOSQJsCjsGwe4aPS gP1ajWmXWFMfqt4cbJkMnQ3wZG8eytUJ0Jgsc06lPCiAgq+i/hjML46noP7dhckOA dgoClTeah4MzBirwCw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from fluss ([84.165.28.160]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N7QQB-1tBWOm06G5-00woIs; Wed, 05 Mar 2025 12:54:45 +0100 From: "Dr. Arne Babenhauserheide" To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= Subject: Re: [PATCH] 31.0.50; makefile-mode: incorrectly highlights make-instructions as make targets In-Reply-To: ("Jostein =?utf-8?Q?Kj=C3=B8nigsen=22's?= message of "Wed, 5 Mar 2025 10:32:39 +0100") References: User-Agent: mu4e 1.12.8; emacs 30.0.92 Date: Wed, 05 Mar 2025 12:54:41 +0100 Message-ID: <87wmd33d6m.fsf@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:I05O7+SF2zYV4R6CP95kuoHfTwqICNUbzBR8TjDGErgHK+ZvKTN TVNUp6P9kpwY5LBdZegvKeWkHRf91L3PFtqDS2CDrQluhweOyTPXf8fkE4koo6qu/I3Ldr6 lQNFnhyLOFI1OEB3dlxilBQ9VxVWaH4agPLMNKsJlR6sgMGKnIDaYb4oFMS8uG5UvH5tTry rDgZ2bC47lKEXxGSxJK6w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:lDpbybPSxKc=;AkLGkmnLejTa79tK8Kx6yaGzVA/ 3a/f0OfnIJA2TsAAsoj1pv/DzUvtTNUbQ/lKD254eVQXEAI5kQh1Oao4APbtXdCFXoywgQ6WI WFZGVycjJg+kGM0I1Kw5eVkJQHvd+bjNMnzjcKHMhWBXzXxztG3jB/26qXjA2NE07LvvRuD9g FmJFFhwzkiMJFzjDztSt48IrN8jxzbIFGdfu08jWUQRltl0Ueb7DWIRIv33hVW464dx8dsSpw 2Jd47c8YeuUX3H9PBPsyHW11c90VmJEbYXaNvIX/1Oj/bT8HD+pVEAHKvmB9W8XnoAxraTSvP 8l7EJ+hJOWGKcBlXYnkOjkuuw43K2rpuBhpl2+0vo4cvf8Kf/IjgtWNGk7bpRyCbtrzgE1ARC fjT08++68PJ97dSkfTmBcz9ri1RG1H0iOuYdX3iPo+tFfNAD4K9d/edA35/KIrflaumdsd/iQ JKCa3b+VlzQybHZYMPK6Gb0J6vH1koJBL2nLx0NZfbDsTc3Odw4xDsivSHSkPv5w+3HRZQkTf gmLydqlDgiyAfX7hpCYbkUazCiG3XOsrw6Esu24tSmVzZjtO1f1zReU9wGEklL3zX1OvT6qA3 1ZiZnq/HVrmXQZ/5Ut7jl3RCneH/KNNiqmO/oR4i9LRsZSL+F1KwKwsTCpxqa7JI5LaqoqJff YIv2VpanGfsqdqpccNIVJRSyOJ40Nrj4wONGauT/V8rIa0EmiB1HQY2BbrLhtB60+ke0e2wCi v6ajc/49DH9silu99sTX16NHcIKPeTLMBgM/Q21KAip5KvMXfoRbRGo62fDz+WgfNrUuA5YXG k28t77q+Z6LsV6y+haIMWm6QebX3ffwIwUokrvEOG92Ck5m/Jm+x5kyb/P5lRAJriJm3G9QKX s1u67vIil2rtw5hqsq8PuYLfWa8Rz4BukkefpfBCCSZ3mDq9+gIrzboV/ZXx955GFza0ImwuP nr/UEIddeFwQERV7BY6p/5jd7u334lLfYs2Z6MV0KA7xh27dZvmHfeg15Gnjcn/Fq7S2cQw1P JE3xzqRvlqlzQ7WY8ACHAbfndXzooEu0/pobzOEl2Kui/fzNMidK+r1jgqvrl/9L+fir+0NDd nQvyac7nNCNQiMWcXKQ8lz83VKRQnp0XdOh9BoKmCMUJrfhxFwMJ4r5ZvvDyX69UGvjDevWLh DgqxKTOYaksUHPvUAtJynaKQmmmzA0q0uUdfkXpjXK4QSTRcNkpYQVrCukv8mD2agS5Y+eUED Sq0ReSCfbyMn8pzt2MGpFI+xqeuJdbp3hair1KV33w6rFo0H6v7c0I044AOALfyRvF5k0vAOd fbjN0JRe/kziMBPg88r/I18rYIdznGv5VhmvzBsYG45FZahMmHtfCJM/n1j+WEjQz4e4BOfvD lBMXb/c6HlD08V8eQwl8e20YXo85YvUB7onVo= Received-SPF: pass client-ip=217.72.192.78; envelope-from=arne_bab@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, "Ergus via Emacs development discussions." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Jostein, Jostein Kj=C3=B8nigsen writes: > A common pattern used in this regex is "[^\n$#]" (with slight variations)= , which (from how I read regexps) aims to match anything which is not a > lineshift, a $-sign or a #-sign. > > "Anything" in this case would then also include whitespace, which IMO is = the source of the bug. > > I've tried changing this part of the statement in parts of the regex to "= [^\n\s$#]", like in the attached patch. Ie also exclude leading whitespace. > From what I've tested, it does not seem to have any adverse effects, alth= ough I may not have tested all areas affected by this change. From=20the Makefile format, I think this should not be leading whitespace, but only leading tabs. Leading spaces in rules are a syntax error. Can you check whether \t instead of \s also works? Best wishes, Arne =2D-=20 Unpolitisch sein hei=C3=9Ft politisch sein, ohne es zu merken. draketo.de --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEE801qEjXQSQPNItXAE++NRSQDw+sFAmfIO4EQHGFybmVfYmFi QHdlYi5kZQAKCRAT741FJAPD6403EACKovVuo4u/9KHg9HbU1/07mlb67Xaju8Hp CHA3Nt9QXvR3TIuwbyJGnmbGsZ1h9Bx727hJJRNQIvimnkn8n4kjPWoimvLcqbwb Xb8SGi7kQrPvWtaH3zY1ZHdPpr3zIYQrRnaoP9vqWWpJzgNmNioSs1XBn+JxBWwk WVHc3Ypk9XtolAB8xjTDKl7JZ//JS+W6Fj5PqSnDgmm+yvrde8yaN0qU86HhDusw laVNfDvr5gXm/uTDPJPO6/AYj1s0TJ5FsPMjbgnlgNxO/0NQeQmo2L4i7S4pBqip UCLyXMpRofAbhJ1Rk/jPpPAR9MMEJ5qDTgPvGTzDgvf0DSxPQo0sSDhwGMU2Fplu BIypZzp03jN6mw0N+EDbluFI6NswVUg5iDQuOz+ztsyaXNIdDxduCV8cuXfAWRof yAtkDlvB+i6lxyq79ykMqrQFju+7sqhoiucVEqDc5qUTnbyOhy5smowKaJvwwoT0 Wy7QUSMqKLEt50L642UT5T5Fqa1ET9k/qdWlWc/dyHEHIpln1NrazzJbW/AtLpe7 rmPr6/3U0MJxsxUf2K9qI5fbfh3FNmuePq7P0FV6G05Btz33Xxc/XTMMWbL/374K 8myhUsza4llHp/EncYE/zfj08sA40FoZG/jVw4TaiwtBhfeqr0eUHH6w8ebR/xZk MnyGiC9C1YjEBAEBCAAuFiEE3Si95tmHXKvOSosd3M8NswvBBUgFAmfIO4EQHGFy bmVfYmFiQHdlYi5kZQAKCRDczw2zC8EFSIMyBACCXLuBV5himltN0okMMOhQdGWD SHFIiTSXoC2kp4svNyipQLYyZTKLWpBhXRjHAdYd8c5+T5gVDgmMHqrkDaDFT9Zq 9HDACt2tnqA3UVIsJehup6p3CJIujc3cvJwGFMZJtoyQhHH3YjbJ5QNhL8gEPrpy BQnevD4mE1xhP59bMg== =l6F5 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 08:01:02 2025 Received: (at 76759) by debbugs.gnu.org; 5 Mar 2025 13:01:02 +0000 Received: from localhost ([127.0.0.1]:36060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpoMw-0000Mp-0T for submit@debbugs.gnu.org; Wed, 05 Mar 2025 08:01:02 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:56767) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tpoMt-0000MB-H8 for 76759@debbugs.gnu.org; Wed, 05 Mar 2025 08:01:00 -0500 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-223785beedfso87333185ad.1 for <76759@debbugs.gnu.org>; Wed, 05 Mar 2025 05:00:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741179653; x=1741784453; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=NrJAaC8JtjRDeJquhk0d6yolO9E04qvj/fjhmTb3Y+c=; b=EZ+ESaySlkvabX5V1P7C351hs2H7wFYSH/jxETkIwri9h2xlAoIo9S5jgJ52vQPA3/ HSxeISSAbhIz5kunYWZpLA5RQ2Zaf/ah/WQHvkaksil5/uo2YEdTR338lTfA8EU6QK7m QyNTrnbkIuyeMvA09bMbAXjKqAzObLGB1cJcrccavlVVY6LEb039DpI25MMZbSQSjS7q XSBQv34KQ2qOJgcsFM56BLCG1BYcVnRNyJkynlOWrbYky6ukMiRMqTl2numKmiXxc0uF kpjXBqD4z8+LHukc+n2ztSm0iUYKPwfyxzzGWXqtuOWi/8HNJjm9cTfnG4rAY/llOY/Q AC1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741179653; x=1741784453; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NrJAaC8JtjRDeJquhk0d6yolO9E04qvj/fjhmTb3Y+c=; b=QQLfSSxGmHeGIXANMUefA02cv1lv9hcSe+HMXQIorM4pI/0jY2pJXNXE6l8Ftqa125 zxbcGnJz/j2n3MVhAdkQ+n4ZJk18wPVu1RfY10/aqYruejgUlDoW0qVdT4k6QT6PUu7J e8SqOkymPVA+DoqTJAcUA6BkbBEl02WG174r1M0fuANg/T2If7gLlIRkwom5TMQNHB2y n8KPZSo3po+i1DATNyyiW5eLSUnJOFeOxfji4dRsHP1+JyNVPiD13FEHTNw1WG2cKAkM JGJaWWuZ4NLQwqLO7w5SIg5R4GoM6hjAuC9BKMSWSqs/mABCJSnOTG8Mu1xPp84lDMgG 9XxQ== X-Forwarded-Encrypted: i=1; AJvYcCUaqhh9MtEfdzxrw22vLegYS1RNQyHdZWoiB1uOXtOuXpAEGjGnOZ7v6Kl2njQzWVcL9UnKag==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywlc2sZCJDSXibdcwGgmAi5Cij9Nd9AjvD187jpUoCBjvPL0xwo fRhifQTH1LP1twFjUhHnadWKTKGjIH5hI8mgJL5bjiRnF0QVqmh9 X-Gm-Gg: ASbGncsJ1RgPIP9IDhpgICIaz/+f7y3bNon1ycje6itiHJgM2DsEIIDxf2Nd8g97xKz u93ADEmfkhulSnAQPn1eJaZQ4AuQNSOVqM4Xp7EgHacQ1Z7pua9WDyK3NM3chbrjuIYxswRcgxA sbLMoGY8BSu5ZuFd2IZ47VAGsI0Y0uVmcTH9TmDl6enIJHUX7eL5LUawAUJTP+xCIp1dGRdU9EY MO9C0JqUu6UzDthAv0lEAzo3bZ7+gMHCwKbQvGhdFChz1AEzjx3IF+rOWOStwSq3+4G5aE+9xns rWYP4RrsUvPJ14jJTOTzEYnNOdUlQqrlEjtXJKy8rioQ1+NfXuU= X-Google-Smtp-Source: AGHT+IGn0X/nifGozhMi/gPWIpGsmPBFbyWUbDxLrvHZyaX8q2dmmeiQBNImo1myI6FtkQFqeNBDRg== X-Received: by 2002:a17:902:f682:b0:223:37b8:c213 with SMTP id d9443c01a7336-223f1d359fdmr43831675ad.52.1741179652992; Wed, 05 Mar 2025 05:00:52 -0800 (PST) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ff4e77629asm1257678a91.13.2025.03.05.05.00.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Mar 2025 05:00:52 -0800 (PST) Message-ID: <140fffe4-79a9-4bff-9148-9debd208e6fc@gmail.com> Date: Wed, 5 Mar 2025 10:00:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] 31.0.50; makefile-mode: incorrectly highlights make-instructions as make targets To: =?UTF-8?Q?Jostein_Kj=C3=B8nigsen?= , 76759@debbugs.gnu.org References: Content-Language: en-US From: Mauro Aranda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76759 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kjønigsen writes: > Hey everyone. > > I found a bug in makefile-mode fontification. > > Currently shell-commands/make-instructions within a target may get > fontified as make-targets if they contain a : (colon) sign. > > Consider the following make-target: > > ------- Makefile ------ > > run-docker: build-docker > docker run -p 8080:8080 imagename > > -------------------------- > > This defined a make-target called "run-docker" which depends on > "build-docker", which runs the command "docker run -p 8080:8080 > imagename". > > In the current code, since the command contains a ":" the whole text up > to that point ("docker run -p 8080") gets fontified as a make-target, even > though it's clearly not declared at the beginning of the line. > Looks like the 10th duplicate of Bug#17400. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 08:19:34 2025 Received: (at 76759) by debbugs.gnu.org; 5 Mar 2025 13:19:34 +0000 Received: from localhost ([127.0.0.1]:36101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpoes-00018b-9o for submit@debbugs.gnu.org; Wed, 05 Mar 2025 08:19:34 -0500 Received: from fout-b4-smtp.messagingengine.com ([202.12.124.147]:49393) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tpoep-00018N-OJ for 76759@debbugs.gnu.org; Wed, 05 Mar 2025 08:19:32 -0500 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id 0F69811401F8; Wed, 5 Mar 2025 08:19:26 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Wed, 05 Mar 2025 08:19:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1741180765; x=1741267165; bh=GwMACskg75D2lc9qflalow7YzUsaB8LVhmI8gjB4t/E=; b= ql6s/e+VFlqysTg3USNJVRD/3nR4On9XBDYjolChn9JZkzB1S9Vzc1khdw/xInBH xrzNJofZJAm4FG1BkosPypQ5qSF989YdVquRAx3t8kPYDL+wGsJi5K4xg/B2wd5h bMfcV9PMMMEQ7y52l6nooIdHKGXF0/+N0E05s2PhO/Fy3NTF6rrtjB46zyxm+wor gJ4iHz6mEjHwC38O8qT/dDUXxZk3TjcAJtOsKLiLAtgvSokiDZcJvUNfuMoNTtcC L6lHNnZNid/IACeH7wkkix+vgkzIxqpRN7DC3t/83A/dKQmMLryar3+e4kS9BeQk +dp+9C8u/8AyRzdFb4h1aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1741180765; x=1741267165; bh=GwMACskg75D2lc9qflalow7YzUsaB8LVhmI 8gjB4t/E=; b=aN/gBR9bJvdm4uPTqkVg0pF2dtNYd/t5jm2Hi7tjKHAQkjcaec4 B+r9loYROnjcWvcHZgtYUkQoZX/Szh1IpyE8VDv3+2Y+lAUJSsVaNBhbVNgUMNjp AkB+/WlSUiLNZOPGqru/ChzoSOAY6Izxktr1SlwJcUqarn22fAImJpGD/3fR2dve 3XLt/stpZJJlArhO6TipKihjmPIOsqf8LmIncvwR4iifb4n+DewK7TKouTa6mdFg x7L/cCW9qet96DWQ3YjI3BXZ4YVUxc2z5Lt6nu4FYMjKZO0b1nNwbSmohT+Qj5p7 vYGoh/ZhxB0tb6Gh36/qULGhnsgYJXmq3zQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddutdegleduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffktgggufffjgevvfhfofesrgdtmherhhdt jeenucfhrhhomheplfhoshhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnse hsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdei tdeuheelfeefteejgfegvdevleduveekffefhffgjeekteejheetffegueegnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhes shgvtghurhgvrdhkjhhonhhighhsvghnrdhnvghtpdhnsggprhgtphhtthhopeefpdhmoh guvgepshhmthhpohhuthdprhgtphhtthhopehmrghurhhoohgrrhgrnhgurgesghhmrghi lhdrtghomhdprhgtphhtthhopegrrhhnvggpsggrsgesfigvsgdruggvpdhrtghpthhtoh epjeeijeehleesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Mar 2025 08:19:25 -0500 (EST) From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_24BF04F4-94C2-46C6-8B4B-832CEE20E26E" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: [PATCH] 31.0.50; makefile-mode: incorrectly highlights make-instructions as make targets Date: Wed, 5 Mar 2025 14:19:12 +0100 In-Reply-To: <140fffe4-79a9-4bff-9148-9debd208e6fc@gmail.com> To: Mauro Aranda , "Dr. Arne Babenhauserheide" References: <140fffe4-79a9-4bff-9148-9debd208e6fc@gmail.com> X-Mailer: Apple Mail (2.3826.400.131.1.6) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76759 Cc: 76759@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_24BF04F4-94C2-46C6-8B4B-832CEE20E26E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > =46rom the Makefile format, I think this should not be leading = whitespace, but only leading tabs. Leading spaces in rules are a syntax = error. Can you check whether \t instead of \s also works? Good catch, Arne. Will check. > Looks like the 10th duplicate of Bug#17400. Also good catch, Mauro. Can someone merge these 2 bugs? But honestly: A more than 10 year old bug!!! About time we get it fixed! I'll report back as soon as I have a new patch! =E2=80=94 Kind Regards Jostein Kj=C3=B8nigsen --Apple-Mail=_24BF04F4-94C2-46C6-8B4B-832CEE20E26E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
=46rom the Makefile = format, I think this should not be leading whitespace, but only leading = tabs. Leading spaces in rules are a syntax error. Can you check whether = \t instead of \s also works?

Good = catch, Arne. Will check.

Looks like the 10th duplicate of = Bug#17400.

Also good catch, = Mauro. Can someone merge these 2 bugs?

But = honestly: A more than 10 year old bug!!! About time we get it = fixed!

I'll report back as soon as I have = a new patch!

=E2=80=94
Kind Regards
Jostein = Kj=C3=B8nigsen

= --Apple-Mail=_24BF04F4-94C2-46C6-8B4B-832CEE20E26E-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 08:28:30 2025 Received: (at 76759) by debbugs.gnu.org; 5 Mar 2025 13:28:30 +0000 Received: from localhost ([127.0.0.1]:36124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tponW-0001ZS-4X for submit@debbugs.gnu.org; Wed, 05 Mar 2025 08:28:30 -0500 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:56699) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tponS-0001Z7-UC; Wed, 05 Mar 2025 08:28:27 -0500 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2f9d3d0f55dso11000628a91.1; Wed, 05 Mar 2025 05:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741181301; x=1741786101; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ULzSnmD1ItcDA5CMOaAR27mfki7S5XkZbmga5Ve+e4M=; b=FRZVkyORDLTAZE5w8ZKPHss5QvOhnUYoAUeZTORNsExfaGbtt400kzEx7nOzNAR7Eq /iQuc1/fDf+Q4K4QKTBtzvItk+f6LE0+yB3vDL//rArjco+WE4rKFT+8qIvuYGIA0Iy2 gIRRQ9n2rGFBKJbdDykB/b36WqPEj2EucmYX3pBPcStD00hyQ0zZQQIiN8q10Jon3v3l LJh54ltDM2A2a0lteKBM0L6uffWLtcmZZ0dJnZQX7MNJKd/I8rp6noTH6Z0DKWkImzKt ZPqJiF61y9JMsf7mgbCP4hxNZDflC/hEKPcKY/gfwRp32r2t93fACX07aoewxegNGaSe SoOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741181301; x=1741786101; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ULzSnmD1ItcDA5CMOaAR27mfki7S5XkZbmga5Ve+e4M=; b=IOzlNSufHAqJsibpshcIF1aQFuQ7t4C/xYn/XLOCFBfNddLw0Y2B9HDCbfWJkf9Iwd Ma8BgefIrM028TREJewozlGjjiJh02zZuuwkOs7IISaVKdnNcFHsogRlaNcawOxTlDrp U/qfksVmHIQriV6TfRw+k5GPm97RG78kusXSo5EXcvdcyumYqJRNHhwZjW0Ulz91xzPZ a2n9RfcphLPKh29678PtgRdPP1cOsArDNif4HfuxT606Fbldjra+GgElwfcfShfxlKKi iyPNDcqQgvEqoAZLAGg9a0U6Msttw0Brx60434gUA2KXzqQwmAbP1SSiJfTYv+AlKpnP zrZQ== X-Forwarded-Encrypted: i=1; AJvYcCWFlr6WIRDWOiGxmAPwrCaYd0gk/WReJmxbkRJcwV7DH4U/roc66UJ5vOCa7vSA5BhHipfoloSy@debbugs.gnu.org X-Gm-Message-State: AOJu0YyqAHSvF4IoNjqyzbHpTnomhtWLp41tRTTYw8eb9lCppAKO6pUb YF1GyH5gdl5+1FpYcrUz8LomlJW7HSYWEyFOXirG9pdhhH7kOn1d X-Gm-Gg: ASbGncumzIKZ5EgrA9lC1WZIbdYErVjzUHVdRDCRKgZGoq1CjSw2X0pESuWZvX8ZFOM pidd95xTZpfP8TshDsXLcrXPN2+DdQ/1jdb8AINiJyqp7w+KeuAQhZMmdPHK0pS9fsrKiOWeyF8 T0YxUaLQmWhHRP9KOf232ePMGxJxEVLtGB/xadIFQWp81AnCFcZKeU5Bkb0E8DDic0k91JjjWrl gP3EhdWgPMRMPbkTGif9PJ2Je2nHenipH/7YajLKT8mM8WrmxRATIh/82TZYErDb9xHFGozFwba AnO1SgPCaHcURAJfiBUJNdWWvsLq3Xi8gzDJJqCpLzb4YK2pbQU= X-Google-Smtp-Source: AGHT+IEF2f6/1XtOy+PyzZu/s2DhIyO/ZyJxFZSgZAqr1h/Jz/KxM//uOQLF+GYhImliKzntdzmC/w== X-Received: by 2002:a17:90b:2e44:b0:2ee:c918:cd60 with SMTP id 98e67ed59e1d1-2ff49753517mr5374086a91.20.1741181300714; Wed, 05 Mar 2025 05:28:20 -0800 (PST) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223501d2778sm112891595ad.36.2025.03.05.05.28.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Mar 2025 05:28:20 -0800 (PST) Message-ID: Date: Wed, 5 Mar 2025 10:28:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] 31.0.50; makefile-mode: incorrectly highlights make-instructions as make targets To: =?UTF-8?Q?Jostein_Kj=C3=B8nigsen?= References: <140fffe4-79a9-4bff-9148-9debd208e6fc@gmail.com> Content-Language: en-US From: Mauro Aranda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76759 Cc: "Dr. Arne Babenhauserheide" , 76759@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 17400 76759 quit Jostein Kjønigsen writes: >  Looks like the 10th duplicate of Bug#17400. > > Also good catch, Mauro. Can someone merge these 2 bugs? Thanks for confirming.  Merging the bugs now. > But honestly: A more than 10 year old bug!!! About time we get it fixed! > > I'll report back as soon as I have a new patch! Thanks for working on this. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 05 08:29:12 2025 Received: (at 76759) by debbugs.gnu.org; 5 Mar 2025 13:29:12 +0000 Received: from localhost ([127.0.0.1]:36137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpooC-0001bX-D1 for submit@debbugs.gnu.org; Wed, 05 Mar 2025 08:29:12 -0500 Received: from fout-b4-smtp.messagingengine.com ([202.12.124.147]:36061) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tpoo8-0001ax-Vw for 76759@debbugs.gnu.org; Wed, 05 Mar 2025 08:29:09 -0500 Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id 6C5651140176; Wed, 5 Mar 2025 08:29:03 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Wed, 05 Mar 2025 08:29:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1741181343; x=1741267743; bh=e6HBT0b7kd9jrw2lXu71P9B+llfED88z1umU75GlAII=; b= A1yAGaTYvfvmJIoEZs6VNHkMxl7Egfsj7vEgwEQDIstl8NTji5vy2A1OtlX9FBkG iviHKkHlwUXC2KaHjMWPEoUEFqnBEQg6fX1W39+/pPLVjFPTzCKIg2qFJD9/1BdY RZggAxRUfurbY4Mxy3rmm7cSCKB383aYmiOk2qyjzHZfltFvyBiVK5Gq+zupQDCp Npmh9IjriyayG71FHlizHXXQTcoA7wvHGFTdOzcdzKy8LWkCXF748365x+qSMvXU /oHo72uODWhJdZ6fi4bURxyI/TMb5i1O5qL7n04+IFr04j4LEqiRZ8355sD+WQpt ZOcxuGzT8D0yafVXElLXYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1741181343; x=1741267743; bh=e6HBT0b7kd9jrw2lXu71P9B+llfED88z1um U75GlAII=; b=MQR8pT9+j1L35pXkO5vtGxzhRedHjw0Pix67GvQ0C95ZZ1u0c2H jGGBZDn3Msj1R5N+0DZYdoPxxl87pApKMtqnAfJBsht7yzO5FFnuJGpU7iEswaDM VzghgnOZghokRGtD3F6b7vhBxA8j88740UT2zsEYMrhwIWmpwsXUBRBQu9wXPONG d81fNYuTllrjhpBfT9m/NPKCk4jtl9kP8gdugAL+lAoa26xKa+7dkAeCzMcurODO LOgvBLZvtmC1vCIIpoaPVXKElIYWPFWE+zKVCVEoqZidFLgFeyHDP+yiFFLVhJJq vhT6IbmPl1GNblOzBaUVq6TFog8qMWJeWDg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddutdegleefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffktgggufffjgevvfhfofesrgdtmherhhdt vdenucfhrhhomheplfhoshhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnse hsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepgeeg ffevieeggedujeehhfeftdegtddugeejuedvteeujeeutdekieejieejteelnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhes shgvtghurhgvrdhkjhhonhhighhsvghnrdhnvghtpdhnsggprhgtphhtthhopeegpdhmoh guvgepshhmthhpohhuthdprhgtphhtthhopehmrghurhhoohgrrhgrnhgurgesghhmrghi lhdrtghomhdprhgtphhtthhopegrrhhnvggpsggrsgesfigvsgdruggvpdhrtghpthhtoh epjeeijeehleesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvmhgrtghs qdguvghvvghlsehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Mar 2025 08:29:02 -0500 (EST) From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_C05E37ED-D71A-4B2C-BDC1-1A0F1DF65426" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: [PATCH] 31.0.50; makefile-mode: incorrectly highlights make-instructions as make targets Date: Wed, 5 Mar 2025 14:28:49 +0100 In-Reply-To: To: Mauro Aranda , "Dr. Arne Babenhauserheide" References: <140fffe4-79a9-4bff-9148-9debd208e6fc@gmail.com> X-Mailer: Apple Mail (2.3826.400.131.1.6) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76759 Cc: 76759@debbugs.gnu.org, "Ergus via Emacs development discussions." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_C05E37ED-D71A-4B2C-BDC1-1A0F1DF65426 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Tested with \t and that works too. Attached is a patch containing these = changes and which fixes this (these) bug(s). =EF=BF=BC =E2=80=94 Kind Regards Jostein Kj=C3=B8nigsen > On 5 Mar 2025, at 14:19, Jostein Kj=C3=B8nigsen = wrote: >=20 >> =46rom the Makefile format, I think this should not be leading = whitespace, but only leading tabs. Leading spaces in rules are a syntax = error. Can you check whether \t instead of \s also works? >=20 >=20 > Good catch, Arne. Will check. >=20 >> Looks like the 10th duplicate of Bug#17400. >=20 >=20 > Also good catch, Mauro. Can someone merge these 2 bugs? >=20 > But honestly: A more than 10 year old bug!!! About time we get it = fixed! >=20 > I'll report back as soon as I have a new patch! >=20 > =E2=80=94 > Kind Regards > Jostein Kj=C3=B8nigsen >=20 --Apple-Mail=_C05E37ED-D71A-4B2C-BDC1-1A0F1DF65426 Content-Type: multipart/mixed; boundary="Apple-Mail=_ED394EC3-E220-409E-B5C9-D008B6A74791" --Apple-Mail=_ED394EC3-E220-409E-B5C9-D008B6A74791 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii
Tested with \t and that works too. Attached is a patch containing these changes and which fixes this (these) bug(s).

--Apple-Mail=_ED394EC3-E220-409E-B5C9-D008B6A74791 Content-Disposition: attachment; filename=0001-Fix-fontification-error-in-makefile-mode.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-fontification-error-in-makefile-mode.patch" Content-Transfer-Encoding: quoted-printable =46rom=20ca150c19ae03f55a7f83026d3e52327ad7f37a4f=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Jostein=3D20Kj=3DC3=3DB8nigsen?=3D=20= =0ADate:=20Wed,=205=20Mar=202025=2010:24:09=20= +0100=0ASubject:=20[PATCH]=20Fix=20fontification=20error=20in=20= makefile-mode.=0A=0A-=20lisp/progmodes/make-mode.el:=20= makefile-dependency-regex=0A=0AEnsure=20we=20check=20for=20leading=20= spaces=20when=20trying=20to=20match=20make-targets.=0A---=0A=20= lisp/progmodes/make-mode.el=20|=202=20+-=0A=201=20file=20changed,=201=20= insertion(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/lisp/progmodes/make-mode.el=20b/lisp/progmodes/make-mode.el=0Aindex=20= 0ae74630cff..29c1d025fef=20100644=0A---=20a/lisp/progmodes/make-mode.el=0A= +++=20b/lisp/progmodes/make-mode.el=0A@@=20-226,7=20+226,7=20@@=20= makefile-runtime-macros-list=0A=20;;=20index=20in=20= makefile-imenu-generic-expression.=0A=20(defvar=20= makefile-dependency-regex=0A=20=20=20;;=20Allow=20for=20two=20nested=20= levels=20$(v1:$(v2:$(v3:a=3Db)=3Dc)=3Dd)=0A-=20=20= "^\\(\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[^({]\\|.[^\n$#})]+?[}= )]\\)\\|[^\n$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n$#)}]\\)+?[})]\\|[^({]\\)\\|[^= \n$#:=3D]\\)+?\\)\\(:\\)\\(?:[=20\t]*$\\|[^=3D\n]\\(?:[^#\n]*?;[=20= \t]*\\(.+\\)\\)?\\)"=0A+=20=20= "^\\(\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[^({]\\|.[^\n\t$#})]+?= [})]\\)\\|[^\n\t$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n\t$#)}]\\)+?[})]\\|[^({]\\= )\\|[^\n\t$#:=3D]\\)+?\\)\\(:\\)\\(?:[=20\t]*$\\|[^=3D\n]\\(?:[^#\n]*?;[=20= \t]*\\(.+\\)\\)?\\)"=0A=20=20=20"Regex=20used=20to=20find=20dependency=20= lines=20in=20a=20makefile.")=0A=20=0A=20(defconst=20= makefile-bsdmake-dependency-regex=0A--=20=0A2.48.1=0A=0A= --Apple-Mail=_ED394EC3-E220-409E-B5C9-D008B6A74791 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
=E2=80=94
Kind Regards
Jostein = Kj=C3=B8nigsen

On 5 Mar 2025, at 14:19, Jostein = Kj=C3=B8nigsen <jostein@secure.kjonigsen.net> wrote:

=46rom the Makefile = format, I think this should not be leading whitespace, but only leading = tabs. Leading spaces in rules are a syntax error. Can you check whether = \t instead of \s also works?

Good = catch, Arne. Will check.

Looks like the 10th duplicate of = Bug#17400.

Also good catch, = Mauro. Can someone merge these 2 bugs?

But = honestly: A more than 10 year old bug!!! About time we get it = fixed!

I'll report back as soon as I have = a new patch!

=E2=80=94
Kind Regards
Jostein = Kj=C3=B8nigsen


= --Apple-Mail=_ED394EC3-E220-409E-B5C9-D008B6A74791-- --Apple-Mail=_C05E37ED-D71A-4B2C-BDC1-1A0F1DF65426-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 08 16:54:42 2025 Received: (at 76759) by debbugs.gnu.org; 8 Mar 2025 21:54:42 +0000 Received: from localhost ([127.0.0.1]:57083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tr281-0004Rj-O0 for submit@debbugs.gnu.org; Sat, 08 Mar 2025 16:54:42 -0500 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]:32889) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tr27z-0004RV-Mm for 76759@debbugs.gnu.org; Sat, 08 Mar 2025 16:54:40 -0500 Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfhigh.phl.internal (Postfix) with ESMTP id 9756C11400FB; Sat, 8 Mar 2025 16:54:33 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Sat, 08 Mar 2025 16:54:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1741470873; x=1741557273; bh=+mc4qUeYPvTvRNKXeP1qQYLmrPju5Bo/KbBA/zHRYVk=; b= IQ2AfhGbTka346Zfy8iNg5pdAgD48tYaET6C60PDEZ/uvJmdLvmms4bEozNjiAWf xpOwHBJ0mYpHKohqrtKie5PnqOZP7+r1m0AOLpvppHrNLRzTj00q9ioCphtdTtpJ 4JDisO3tP8USr3orzp0uEfmETf8eBm0lbb70mYYxyE5uUzCVmCsd79LNlwpHyCQV J0spmbnC5ZqwS8Vnii3CR9cDvtO79hKPvCQrfm3YRiKt5K3b52VpY1uV+qs1xpwc Yg7xR20It+wnL5cL6cYQxs60zDMKGnMGlX9bAbi7sr3Mg/MqEhf/GZ8QAsg/pwtq 5s75gEIrVghyVh6r+4xG6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1741470873; x=1741557273; bh=+mc4qUeYPvTvRNKXeP1qQYLmrPju5Bo/KbB A/zHRYVk=; b=M22Nq2C90iIxpOltNiaKSczuG0eWZaS5jS8dtE3cktVWflEjLfN 6sHatnpYGGCfIIEbdOo2FGLDekI9vLkYXQFSCq7DZkMmb4fMj9Hl1kpXzyI/025d AXoQj5wCQtTY86oAw4aJpaMOVTXyBCqj88lfOWFYRIBaGYDqVZMRdQEa3FFq11Za rynSPNOS8mSPae/YqPHHJFDeKJb0F4dPOXzLAl6D9fSbE0CzjIqS/dYzJmabh6Hv iE1AfyO2V/oPuNfRTfP2l3kFQ7OUZc+NS9AaHXSjcRIdEkV2M/IfFmPJhgImiDsl p6dxU69tw+LFhHD2wwhHvU9vK2uCQ2asKcA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduudegieelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffktgggufffjgevvfhfofesrgdtmherhhdt jeenucfhrhhomheplfhoshhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnse hsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdei tdeuheelfeefteejgfegvdevleduveekffefhffgjeekteejheetffegueegnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhes shgvtghurhgvrdhkjhhonhhighhsvghnrdhnvghtpdhnsggprhgtphhtthhopeegpdhmoh guvgepshhmthhpohhuthdprhgtphhtthhopehmrghurhhoohgrrhgrnhgurgesghhmrghi lhdrtghomhdprhgtphhtthhopegrrhhnvggpsggrsgesfigvsgdruggvpdhrtghpthhtoh epjeeijeehleesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvmhgrtghs qdguvghvvghlsehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 8 Mar 2025 16:54:32 -0500 (EST) From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Message-Id: <86DE0998-C0C7-403E-88E9-4272DCCFB0FD@secure.kjonigsen.net> Content-Type: multipart/alternative; boundary="Apple-Mail=_F362A61D-34A7-4A8F-9FEB-B565D3C59929" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: [PATCH] 31.0.50; makefile-mode: incorrectly highlights make-instructions as make targets Date: Sat, 8 Mar 2025 22:54:22 +0100 In-Reply-To: To: Mauro Aranda , "Dr. Arne Babenhauserheide" References: <140fffe4-79a9-4bff-9148-9debd208e6fc@gmail.com> X-Mailer: Apple Mail (2.3826.400.131.1.6) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76759 Cc: 76759@debbugs.gnu.org, "Ergus via Emacs development discussions." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_F362A61D-34A7-4A8F-9FEB-B565D3C59929 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Any news on this one? Has anyone tested this? Anyone have any objection to the change? =E2=80=94 Kind Regards Jostein Kj=C3=B8nigsen > On 5 Mar 2025, at 14:28, Jostein Kj=C3=B8nigsen = wrote: >=20 > Tested with \t and that works too. Attached is a patch containing = these changes and which fixes this (these) bug(s). >=20 > <0001-Fix-fontification-error-in-makefile-mode.patch> > =E2=80=94 > Kind Regards > Jostein Kj=C3=B8nigsen >=20 >> On 5 Mar 2025, at 14:19, Jostein Kj=C3=B8nigsen = wrote: >>=20 >>> =46rom the Makefile format, I think this should not be leading = whitespace, but only leading tabs. Leading spaces in rules are a syntax = error. Can you check whether \t instead of \s also works? >>=20 >>=20 >> Good catch, Arne. Will check. >>=20 >>> Looks like the 10th duplicate of Bug#17400. >>=20 >>=20 >> Also good catch, Mauro. Can someone merge these 2 bugs? >>=20 >> But honestly: A more than 10 year old bug!!! About time we get it = fixed! >>=20 >> I'll report back as soon as I have a new patch! >>=20 >> =E2=80=94 >> Kind Regards >> Jostein Kj=C3=B8nigsen >>=20 >=20 --Apple-Mail=_F362A61D-34A7-4A8F-9FEB-B565D3C59929 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Any news on = this one?

Has anyone tested this? Anyone have any = objection to the change?

=E2=80=94
Kind Regards
Jostein = Kj=C3=B8nigsen

On 5 Mar 2025, at 14:28, Jostein = Kj=C3=B8nigsen <jostein@secure.kjonigsen.net> wrote:

Tested with \t and that works too. Attached is = a patch containing these changes and which fixes this (these) = bug(s).

<0001-Fix-fontification= -error-in-makefile-mode.patch>
=E2=80=94
Kind Regards
Jostein = Kj=C3=B8nigsen

On 5 Mar 2025, at 14:19, Jostein = Kj=C3=B8nigsen <jostein@secure.kjonigsen.net> wrote:

=46rom the Makefile = format, I think this should not be leading whitespace, but only leading = tabs. Leading spaces in rules are a syntax error. Can you check whether = \t instead of \s also works?

Good = catch, Arne. Will check.

Looks like the 10th duplicate of = Bug#17400.

Also good catch, = Mauro. Can someone merge these 2 bugs?

But = honestly: A more than 10 year old bug!!! About time we get it = fixed!

I'll report back as soon as I have = a new patch!

=E2=80=94
Kind Regards
Jostein = Kj=C3=B8nigsen
=



= --Apple-Mail=_F362A61D-34A7-4A8F-9FEB-B565D3C59929-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 09 01:34:53 2025 Received: (at 76759) by debbugs.gnu.org; 9 Mar 2025 06:34:54 +0000 Received: from localhost ([127.0.0.1]:57817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trAFR-0006tS-Hd for submit@debbugs.gnu.org; Sun, 09 Mar 2025 01:34:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51448) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1trAFP-0006tB-Ms for 76759@debbugs.gnu.org; Sun, 09 Mar 2025 01:34:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trAFJ-0000Vv-I4; Sun, 09 Mar 2025 01:34:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:Subject:In-Reply-To:To:From: Date; bh=dpfiI2XO+vdHL1kT/swhzk5wnvlZpXPmM5iX6mcKYBE=; b=PEFOewRet+UtelDOMqYo TsbyQH+LGIBGjuEj2R6anEPcOqgpp2xi8WWB726UBnbDjAB4YOiWvA90zjHnx67kigufLFdlrzwh+ 124WnuDoK6mi7Az7NWly2nTrosg1kqRQYVhcOfQm8U7KEJjyxtOmuXG64H8CH0caaC70xNIDTV4vB p3FhXYJadqEF5vpkylzMEugsJEyRFLCSBGCKYUAiQzmKFZbxAog+K7tRDKmu44R14PE4Tc6DN0kwl f/mipRscNxnEX2SyMR0ayP58260JI83hN3652wfYz4xkHx3aXK+izmda8cPwwyXlgqIACUGW/1XNi ramKW8jM/tzfQQ==; Date: Sun, 09 Mar 2025 08:34:40 +0200 Message-Id: <86ecz6iuf3.fsf@gnu.org> From: Eli Zaretskii To: Jostein =?iso-8859-1?Q?Kj=F8nigsen?= , Stefan Monnier , Paul Smith In-Reply-To: <86DE0998-C0C7-403E-88E9-4272DCCFB0FD@secure.kjonigsen.net> (message from Jostein =?iso-8859-1?Q?Kj=F8nigsen?= on Sat, 8 Mar 2025 22:54:22 +0100) Subject: Re: bug#76759: [PATCH] 31.0.50; makefile-mode: incorrectly highlights make-instructions as make targets References: <140fffe4-79a9-4bff-9148-9debd208e6fc@gmail.com> <86DE0998-C0C7-403E-88E9-4272DCCFB0FD@secure.kjonigsen.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76759 Cc: arne_bab@web.de, 76759@debbugs.gnu.org, maurooaranda@gmail.com, emacs-devel@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable > Cc: 76759@debbugs.gnu.org, > "Ergus via Emacs development discussions." > From: Jostein Kj=F8nigsen > Date: Sat, 8 Mar 2025 22:54:22 +0100 >=20 > Any news on this one? >=20 > Has anyone tested this? Anyone have any objection to the change? The Makefile syntax is tricky wrt whitespace, and target names can include colons, definitely on MS-Windows, but also on Posix systems. Also, there are various old formats, like that of Imakefile, that should still be supported, AFAIK. And we don't have a test suite for this mode. So I very much wonder whether this change will introduce regressions. Maybe Paul Smith, the maintainer of GNU Make (CC'ed), could help us here. Or maybe Stefan has comments? For their convenience, I re-attach the proposed patch below. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-fontification-error-in-makefile-mode.patch >From 9774fe6028b0c5341aa7bf85adf20464e9ac4b5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jostein=20Kj=C3=B8nigsen?= Date: Wed, 5 Mar 2025 10:24:09 +0100 Subject: [PATCH] Fix fontification error in makefile-mode. - lisp/progmodes/make-mode.el: makefile-dependency-regex Ensure we check for leading spaces when trying to match make-targets. --- lisp/progmodes/make-mode.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/make-mode.el b/lisp/progmodes/make-mode.el index 0ae74630cff..7e0ccb0697e 100644 --- a/lisp/progmodes/make-mode.el +++ b/lisp/progmodes/make-mode.el @@ -226,7 +226,7 @@ makefile-runtime-macros-list ;; index in makefile-imenu-generic-expression. (defvar makefile-dependency-regex ;; Allow for two nested levels $(v1:$(v2:$(v3:a=b)=c)=d) - "^\\(\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[^({]\\|.[^\n$#})]+?[})]\\)\\|[^\n$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n$#:=]\\)+?\\)\\(:\\)\\(?:[ \t]*$\\|[^=\n]\\(?:[^#\n]*?;[ \t]*\\(.+\\)\\)?\\)" + "^\\(\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[^({]\\|.[^\n\s$#})]+?[})]\\)\\|[^\n\s$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n\s$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n\s$#:=]\\)+?\\)\\(:\\)\\(?:[ \t]*$\\|[^=\n]\\(?:[^#\n]*?;[ \t]*\\(.+\\)\\)?\\)" "Regex used to find dependency lines in a makefile.") (defconst makefile-bsdmake-dependency-regex -- 2.48.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 09 22:16:13 2025 Received: (at 76759-done) by debbugs.gnu.org; 10 Mar 2025 02:16:13 +0000 Received: from localhost ([127.0.0.1]:35280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1trSgf-00014U-DE for submit@debbugs.gnu.org; Sun, 09 Mar 2025 22:16:13 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30555) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1trSgc-000147-IU for 76759-done@debbugs.gnu.org; Sun, 09 Mar 2025 22:16:11 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 00DB810004C; Sun, 9 Mar 2025 22:08:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1741572486; bh=2gCWTxzhV3+OS7BQrbQBBvR/ao+UvJRf4YW3uB49t5s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gQ4POv+A3bjs7tLlosoDYKpH1CNnJ212j89toN8fapJ74W6Bf6Ubs5iG6nHevRa0d eRgvFCleL2MtvSXEzchignOVG+5ly2gblJL4b3XG9jZNoFY/8TU3fvgaqZpP67ztiv BlEa+sNPuWRRRI63JZ+7TgGjcYWvZoeHCRmQDP52jAumhyQz0NUMGqrTu+TykVBaHK SAdgFhjiqoLgw+fWToYWwFA83gl8DbfCEUd30QsI9FRc9lhpHqFXofCCOOgobi9a1A ePI5hm4HkSmGkC+bFVIcsXr456TCMGQxO2Q0nCjKltzqQrDSFRgavibbhy/j+gRfsF nLBj5Wn1elc4Q== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 474DC100034; Sun, 9 Mar 2025 22:08:06 -0400 (EDT) Received: from alfajor (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 047521204EE; Sun, 9 Mar 2025 22:08:05 -0400 (EDT) From: Stefan Monnier To: Jostein =?windows-1252?Q?Kj=F8nigsen?= Subject: Re: bug#76759: [PATCH] 31.0.50; makefile-mode: incorrectly highlights make-instructions as make targets In-Reply-To: <86DE0998-C0C7-403E-88E9-4272DCCFB0FD@secure.kjonigsen.net> Message-ID: References: <140fffe4-79a9-4bff-9148-9debd208e6fc@gmail.com> <86DE0998-C0C7-403E-88E9-4272DCCFB0FD@secure.kjonigsen.net> Date: Sun, 09 Mar 2025 22:08:04 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.299 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76759-done Cc: "Dr. Arne Babenhauserheide" , "Ergus via Emacs development discussions." , Mauro Aranda , 76759-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Any news on this one? Looks OK, tho I think it's a bit more strict than necessary: the TABs we need to avoid can be only at the beginning of the line, so not inside the $(...). So it's only one of the [^...] that needs the \t. Here's what I did: - Start from the current monster: "^\\(\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[^({]\\|.[^\n$#})]+?[})]\\)\\|[^\n$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n$#:=]\\)+?\\)\\(:\\)\\(?:[ \t]*$\\|[^=\n]\\(?:[^#\n]*?;[ \t]*\\(.+\\)\\)?\\)" - Change the `\\(?:[^({]\\|.` to `\\(?:[^({]\\|[({]` because I think the `.` was just an optimization. And since the two alternatives are now mutually exclusive, swap them: \\(?:[^({]\\|.[^\n$#})]+?[})]\\) => \\(?:[({][^\n$#})]+?[})]\\|[^({]\\) - Now the regexp has become: "^\\(\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[({]\\(?:\\$\\(?:[({][^\n$#})]+?[})]\\|[^({]\\)\\|[^\n$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n$#)}]\\)+?[})]\\|[^({]\\)\\|[^\n$#:=]\\)+?\\)\\(:\\)\\(?:[ \t]*$\\|[^=\n]\\(?:[^#\n]*?;[ \t]*\\(.+\\)\\)?\\)" - Make the nested construction explicit, so it's a bit more manageable: (letrec ((elems-re (lambda (n &optional outer) (if (< n 1) "[^\n$#})]+?" (concat "\\(?:\\$\\(?:" "[({]" (funcall elems-re (- n 1)) "[})]" "\\|[^({]\\)" "\\|[^\n$#" (if outer ":=" ")}") "]\\)+?"))))) (concat ;; Allow for two nested levels $(v1:$(v2:$(v3:a=b)=c)=d) "^\\(" (funcall elems-re 3 'outer) "\\)\\(:\\)\\(?:[ \t]*$\\|[^=\n]\\(?:[^#\n]*?;[ \t]*\\(.+\\)\\)?\\)")) - Disallow TABs in the outer case by replacing ":=" with "\t:=" (that's one of the TABs you added in your version of the patch). This is still not quite right, since AFAIK TABs are allowed to appear outside of $(...) as long as they're not at BOL, but I think it's better than what we've had so far (and the regexp still has several other limitations anyway). Pushed to `master`. Stefan From unknown Thu Jun 19 14:21:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 07 Apr 2025 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator