GNU bug report logs - #76728
[PATCH] gnu: avogadro2: fix open babel input

Previous Next

Full log

Message #35 received at 76728 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Jakob Kirsch via Guix-patches via <guix-patches <at> gnu.org>
Cc: Jakob Kirsch <jakob.kirsch <at> web.de>, 76728 <at> debbugs.gnu.org
Subject: Re: [bug#76728] [PATCH] gnu: avogadro2: update to 1.100.0
Date: Fri, 11 Apr 2025 11:59:50 +0100

[Message part 1 (text/plain, inline)]

Jakob Kirsch via Guix-patches via <guix-patches <at> gnu.org> writes:

> I fixed all the issues. It's good to merge now.
>
> [2. text/plain; 0001-gnu-avogadro2-update-to-1.100.0.patch]...

It would be clearer to add each new package in a separate commit/patch
rather than one big commit. Alternatively, I'm unsure if these new
packages should exist, why would someone install avogadro-fragments for
example? If they just exist to be symlinked in avogadrolibs, you can
directly pass the origin records you're using as sources for the new
packages as inputs.

Regarding the origin changes to spglib, doing the substitute* operations
as a package build phase is preferable if doing them on the source isn't
required since that results in one less derivation.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.