GNU bug report logs - #76719
[PATCH 0/2] Update Dosbox-Staging.

Previous Next

Package: guix-patches;

Reported by: Andrew Wong <wongandj <at> icloud.com>

Date: Mon, 3 Mar 2025 20:29:02 UTC

Severity: normal

Tags: patch

Done: 宋文武 <iyzsong <at> envs.net>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Gabriel Wicki <gabriel <at> erlikon.ch>
To: Andrew Wong <wongandj <at> icloud.com>
Cc: 76719 <at> debbugs.gnu.org
Subject: [bug#76719] [PATCH 1/2] gnu: Add mt32emu.
Date: Tue, 4 Mar 2025 11:19:52 +0100

Hi there!

First of all: thanks for your time and effort.

On Mon, Mar 03, 2025 at 03:30:22PM -0500, Andrew Wong wrote:
> +(use-modules (guix build utils))
This is usually part of the header of the scheme module.

> +    (arguments
> +     (list
> +      #:tests? #f
Please comment why tests are deactivated - are they missing?

> +      #:phases #~(modify-phases %standard-phases
> +                   (add-after 'unpack 'chdir
> +                     (lambda _ (chdir "mt32emu"))))))
Not sure if this couldn't be specified in a dedicated argument for the
cmake-build-system.  But if it works (and this argument does not exist)
this is ok to me.


Otherwise this patch looks good to me.


Thanks again
gabber
This bug report was last modified 139 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.