Subject: [bug#76719] [PATCH 1/2] gnu: Add mt32emu.

From: Gabriel Wicki <[email-masked]>
Date: Tue, 4 Mar 2025 11:19:52 +0100

Hi there!

First of all: thanks for your time and effort.

On Mon, Mar 03, 2025 at 03:30:22PM -0500, Andrew Wong wrote:
> +(use-modules (guix build utils))
This is usually part of the header of the scheme module.

> +    (arguments
> +     (list
> +      #:tests? #f
Please comment why tests are deactivated - are they missing?

> +      #:phases #~(modify-phases %standard-phases
> +                   (add-after 'unpack 'chdir
> +                     (lambda _ (chdir "mt32emu"))))))
Not sure if this couldn't be specified in a dedicated argument for the
cmake-build-system.  But if it works (and this argument does not exist)
this is ok to me.

Otherwise this patch looks good to me.

Thanks again
gabber