GNU bug report logs - #76717
[PATCH] services: readymedia-activation: Change directory permissions to 775.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76717 in the body.
You can then email your comments to 76717 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: Sughosha <sughosha <at> disroot.org>
Subject: [PATCH] services: readymedia-activation: Change directory permissions
 to 775.
Date: Mon,  3 Mar 2025 22:37:15 +0530

Allow users in readymedia group to write in the directory created by
readymedia-activation.

* gnu/services/upnp.scm (readymedia-activation): Change directory permissions
to 775.

Change-Id: Ifda8e4fe8594fb5a1cdf6e329a8c83551eab9c06
---
 gnu/services/upnp.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/upnp.scm b/gnu/services/upnp.scm
index e5d05add28..c125c07af2 100644
--- a/gnu/services/upnp.scm
+++ b/gnu/services/upnp.scm
@@ -187,7 +187,7 @@ (define (readymedia-activation config)
                       (unless (file-exists? directory)
                         (mkdir-p/perms directory
                                        (getpw #$%readymedia-user-account)
-                                       #o755)))
+                                       #o775)))
                     (list #$cache-directory
                           #$log-directory
                           #$@(map readymedia-media-directory-path

base-commit: f3f09fb4a370fd0363fd216f73736164a2a29f7b
-- 
2.47.1

Message #10 received at 76717-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sughosha <sughosha <at> disroot.org>
Cc: 76717-done <at> debbugs.gnu.org
Subject: Re: [bug#76717] [PATCH] services: readymedia-activation: Change
 directory permissions to 775.
Date: Sat, 08 Mar 2025 18:06:11 +0100

Sughosha <sughosha <at> disroot.org> skribis:

> Allow users in readymedia group to write in the directory created by
> readymedia-activation.
>
> * gnu/services/upnp.scm (readymedia-activation): Change directory permissions
> to 775.
>
> Change-Id: Ifda8e4fe8594fb5a1cdf6e329a8c83551eab9c06
> ---

Applied, thanks!

Message #13 received at 76717 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sughosha <sughosha <at> disroot.org>
Cc: 76717 <at> debbugs.gnu.org
Subject: Re: [bug#76717] [PATCH] services: readymedia-activation: Change
 directory permissions to 775.
Date: Mon, 10 Mar 2025 23:06:10 +0100

Sughosha <sughosha <at> disroot.org> skribis:

> Allow users in readymedia group to write in the directory created by
> readymedia-activation.
>
> * gnu/services/upnp.scm (readymedia-activation): Change directory permissions
> to 775.
>
> Change-Id: Ifda8e4fe8594fb5a1cdf6e329a8c83551eab9c06

I noticed (but too late) that this triggers failures of the ‘readymedia’
system test:

--8<---------------cut here---------------start------------->8---
PASS: ReadyMedia user exists
PASS: ReadyMedia group exists
PASS: cache directory exists
PASS: cache directory has correct ownership
/gnu/store/hz3am9anh55m4d0951wq9gqr1z7n5zas-readymedia-test-builder:1: FAIL cache directory has expected permissions
PASS: log directory exists
PASS: log directory has correct ownership
/gnu/store/hz3am9anh55m4d0951wq9gqr1z7n5zas-readymedia-test-builder:1: FAIL log directory has expected permissions
PASS: log file exists
PASS: log file has expected permissions
PASS: ReadyMedia service is running
PASS: ReadyMedia service is listening for connections
# of expected passes      10
# of unexpected failures  2
--8<---------------cut here---------------end--------------->8---

(From <https://ci.guix.gnu.org/build/9557295/log>.)

Could you send a patch adjusting the test or suggest the way forward?

Thanks, and apologies for overlooking it!

Ludo’.

Message #16 received at 76717 <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <sughosha <at> disroot.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 76717 <at> debbugs.gnu.org, Sughosha <sughosha <at> disroot.org>
Subject: [PATCH] services: readymedia: Change cache and log directory
 permissions to 755.
Date: Tue, 11 Mar 2025 08:33:06 +0530

Create cache directory and log directory with 755 permission, which passes
run-readymedia-test.

* gnu/services/upnp.scm (readymedia-activation): Change directory permissions
of cache-directory and log-directory to 755.

Change-Id: Iff30040c3fd52564510f66d3568dab0ef89e0449
---
 gnu/services/upnp.scm | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/gnu/services/upnp.scm b/gnu/services/upnp.scm
index c125c07af24..47c32f0a1ef 100644
--- a/gnu/services/upnp.scm
+++ b/gnu/services/upnp.scm
@@ -188,10 +188,14 @@ (define (readymedia-activation config)
                         (mkdir-p/perms directory
                                        (getpw #$%readymedia-user-account)
                                        #o775)))
-                    (list #$cache-directory
-                          #$log-directory
-                          #$@(map readymedia-media-directory-path
-                                  media-directories)))))))
+                    (list #$@(map readymedia-media-directory-path
+                                  media-directories)))
+          (for-each (lambda (directory)
+                      (unless (file-exists? directory)
+                        (mkdir-p/perms directory
+                                       (getpw #$%readymedia-user-account)
+                                       #o755)))
+                    (list #$cache-directory #$log-directory))))))
 
 (define readymedia-service-type
   (service-type

base-commit: 42773718d5d5d42137ac84826850256fd6bed606
-- 
2.48.1

Message #19 received at 76717-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sughosha <sughosha <at> disroot.org>
Cc: 76717-done <at> debbugs.gnu.org
Subject: Re: [PATCH] services: readymedia: Change cache and log directory
 permissions to 755.
Date: Tue, 25 Mar 2025 10:01:49 +0100

Sughosha <sughosha <at> disroot.org> skribis:

> Create cache directory and log directory with 755 permission, which passes
> run-readymedia-test.
>
> * gnu/services/upnp.scm (readymedia-activation): Change directory permissions
> of cache-directory and log-directory to 755.
>
> Change-Id: Iff30040c3fd52564510f66d3568dab0ef89e0449

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.