From unknown Sat Aug 16 18:47:12 2025 X-Loop: don@donarmstrong.com Subject: bug#767: 23.0.60; compilation-start gives bad default-directory Reply-To: "Lennart Borgman (gmail)" , 767@debbugs.gnu.org Resent-From: "Lennart Borgman (gmail)" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 23 Aug 2008 13:15:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 767 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.121949672410208 (code B ref -1); Sat, 23 Aug 2008 13:15:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.8 required=4.0 tests=AWL,BAYES_00,MIXEDBDN, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 23 Aug 2008 13:05:24 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7ND5K6u010125 for ; Sat, 23 Aug 2008 06:05:21 -0700 Received: from mail.gnu.org ([199.232.76.166]:50273 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KWsmZ-0002cQ-Tq for emacs-pretest-bug@gnu.org; Sat, 23 Aug 2008 09:03:56 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KWsns-0007q5-FA for emacs-pretest-bug@gnu.org; Sat, 23 Aug 2008 09:05:19 -0400 Received: from ch-smtp02.sth.basefarm.net ([80.76.149.213]:37959) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KWsnr-0007ph-R1 for emacs-pretest-bug@gnu.org; Sat, 23 Aug 2008 09:05:16 -0400 Received: from c83-254-151-176.bredband.comhem.se ([83.254.151.176]:64313 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KWsnp-0002B3-8K for emacs-pretest-bug@gnu.org; Sat, 23 Aug 2008 15:05:14 +0200 Message-ID: <48B00B00.1050305@gmail.com> Date: Sat, 23 Aug 2008 15:05:04 +0200 From: "Lennart Borgman (gmail)" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: emacs-pretest-bug@gnu.org X-Enigmail-Version: 0.95.7 Content-Type: multipart/mixed; boundary="------------090807080508020201020009" X-Antivirus: avast! (VPS 080822-0, 2008-08-22), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.176 X-Scan-Result: No virus found in message 1KWsnp-0002B3-8K. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1KWsnp-0002B3-8K c4a2a738de338ade0c6f654a20dd1712 X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) This is a multi-part message in MIME format. --------------090807080508020201020009 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit If on w32 default-directory is something like c:\top\sub then the subprocess started by compilation-start will get pwd=c:\top. This can be cured by the attached patch for this special case, but it is only a demonstration of the problem, not the right fix for this problem. The attached patch only does (let ((default-directory (file-name-as-directory default-directory)) just before calling `start-file-process-shell-command'. A slightly better fix would probably be to add the same thing in `start-file-process', but it seems to me that this should handled at the C level to catch all cases. I do not know where to do that but it must be done somewhere before make_process in start-process. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-08-10 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' --------------090807080508020201020009 Content-Type: text/plain; name="compile-start-default-directory.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="compile-start-default-directory.diff" ? compile-start-default-directory.diff Index: compile.el =================================================================== RCS file: /sources/emacs/emacs/lisp/progmodes/compile.el,v retrieving revision 1.476 diff -b -u -r1.476 compile.el --- compile.el 13 Jun 2008 16:22:16 -0000 1.476 +++ compile.el 23 Aug 2008 12:49:59 -0000 @@ -1246,7 +1246,8 @@ (funcall compilation-process-setup-function)) (compilation-set-window-height outwin) ;; Start the compilation. - (let ((proc + (let* ((default-directory (file-name-as-directory default-directory)) + (proc (if (eq mode t) ;; comint uses `start-file-process'. (get-buffer-process --------------090807080508020201020009-- From unknown Sat Aug 16 18:47:12 2025 X-Loop: don@donarmstrong.com Subject: bug#767: 23.0.60; compilation-start gives bad default-directory Reply-To: Chong Yidong , 767@debbugs.gnu.org Resent-From: Chong Yidong Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 26 Aug 2008 22:25:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 767 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 767-submit@emacsbugs.donarmstrong.com id=B767.121978899230257 (code B ref 767); Tue, 26 Aug 2008 22:25:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,BAYES_00,FOURLA, MURPHY_DRUGS_REL8 autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 767) by emacsbugs.donarmstrong.com; 26 Aug 2008 22:16:32 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7QMGTR3030251 for <767@emacsbugs.donarmstrong.com>; Tue, 26 Aug 2008 15:16:30 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id EC32A57E34B; Tue, 26 Aug 2008 18:18:14 -0400 (EDT) To: "Lennart Borgman \(gmail\)" Cc: 767@debbugs.gnu.org From: Chong Yidong Date: Tue, 26 Aug 2008 18:18:14 -0400 Message-ID: <87ej4bl8t5.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > If on w32 default-directory is something like c:\top\sub then the > subprocess started by compilation-start will get pwd=c:\top. Does the following patch fix this? *** trunk/src/callproc.c.~1.240.~ 2008-07-31 12:19:14.000000000 -0400 --- trunk/src/callproc.c 2008-08-26 18:15:59.000000000 -0400 *************** *** 374,379 **** --- 374,381 ---- a sensible default. */ current_dir = build_string ("~/"); current_dir = expand_and_dir_to_file (current_dir, Qnil); + current_dir = Ffile_name_as_directory (current_dir); + if (NILP (Ffile_accessible_directory_p (current_dir))) report_file_error ("Setting current directory", Fcons (current_buffer->directory, Qnil)); From unknown Sat Aug 16 18:47:12 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: "Lennart Borgman (gmail)" Subject: bug#767 closed by Chong Yidong (Re: 23.0.60; compilation-start gives bad default-directory) Message-ID: References: <87prnfu5sl.fsf@cyd.mit.edu> <48B00B00.1050305@gmail.com> X-Emacs-PR-Message: they-closed 767 X-Emacs-PR-Package: emacs Reply-To: 767@debbugs.gnu.org Content-Type: multipart/mixed; boundary="----------=_1220815203-5665-1" This is a multi-part message in MIME format... ------------=_1220815203-5665-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #767: 23.0.60; compilation-start gives bad default-directory It has been closed by Chong Yidong . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Chong Yidong by replying to this email. --=20 767: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D767 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1220815203-5665-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From cyd@stupidchicken.com Sun Sep 7 12:12:05 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.8 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 767-done) by emacsbugs.donarmstrong.com; 7 Sep 2008 19:12:05 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m87JC2fD003666 for <767-done@emacsbugs.donarmstrong.com>; Sun, 7 Sep 2008 12:12:03 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id A043557E355; Sun, 7 Sep 2008 15:14:50 -0400 (EDT) From: Chong Yidong To: "Lennart Borgman \(gmail\)" Cc: 767-done@debbugs.gnu.org Subject: Re: 23.0.60; compilation-start gives bad default-directory Date: Sun, 07 Sep 2008 15:14:50 -0400 Message-ID: <87prnfu5sl.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii I've checked in the fix. ------------=_1220815203-5665-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From lennart.borgman@gmail.com Sat Aug 23 06:05:24 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.8 required=4.0 tests=AWL,BAYES_00,MIXEDBDN, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 23 Aug 2008 13:05:24 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7ND5K6u010125 for ; Sat, 23 Aug 2008 06:05:21 -0700 Received: from mail.gnu.org ([199.232.76.166]:50273 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KWsmZ-0002cQ-Tq for emacs-pretest-bug@gnu.org; Sat, 23 Aug 2008 09:03:56 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KWsns-0007q5-FA for emacs-pretest-bug@gnu.org; Sat, 23 Aug 2008 09:05:19 -0400 Received: from ch-smtp02.sth.basefarm.net ([80.76.149.213]:37959) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KWsnr-0007ph-R1 for emacs-pretest-bug@gnu.org; Sat, 23 Aug 2008 09:05:16 -0400 Received: from c83-254-151-176.bredband.comhem.se ([83.254.151.176]:64313 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KWsnp-0002B3-8K for emacs-pretest-bug@gnu.org; Sat, 23 Aug 2008 15:05:14 +0200 Message-ID: <48B00B00.1050305@gmail.com> Date: Sat, 23 Aug 2008 15:05:04 +0200 From: "Lennart Borgman (gmail)" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: emacs-pretest-bug@gnu.org Subject: 23.0.60; compilation-start gives bad default-directory X-Enigmail-Version: 0.95.7 Content-Type: multipart/mixed; boundary="------------090807080508020201020009" X-Antivirus: avast! (VPS 080822-0, 2008-08-22), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.176 X-Scan-Result: No virus found in message 1KWsnp-0002B3-8K. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1KWsnp-0002B3-8K c4a2a738de338ade0c6f654a20dd1712 X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) This is a multi-part message in MIME format. --------------090807080508020201020009 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit If on w32 default-directory is something like c:\top\sub then the subprocess started by compilation-start will get pwd=c:\top. This can be cured by the attached patch for this special case, but it is only a demonstration of the problem, not the right fix for this problem. The attached patch only does (let ((default-directory (file-name-as-directory default-directory)) just before calling `start-file-process-shell-command'. A slightly better fix would probably be to add the same thing in `start-file-process', but it seems to me that this should handled at the C level to catch all cases. I do not know where to do that but it must be done somewhere before make_process in start-process. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-08-10 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' --------------090807080508020201020009 Content-Type: text/plain; name="compile-start-default-directory.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="compile-start-default-directory.diff" ? compile-start-default-directory.diff Index: compile.el =================================================================== RCS file: /sources/emacs/emacs/lisp/progmodes/compile.el,v retrieving revision 1.476 diff -b -u -r1.476 compile.el --- compile.el 13 Jun 2008 16:22:16 -0000 1.476 +++ compile.el 23 Aug 2008 12:49:59 -0000 @@ -1246,7 +1246,8 @@ (funcall compilation-process-setup-function)) (compilation-set-window-height outwin) ;; Start the compilation. - (let ((proc + (let* ((default-directory (file-name-as-directory default-directory)) + (proc (if (eq mode t) ;; comint uses `start-file-process'. (get-buffer-process --------------090807080508020201020009-- ------------=_1220815203-5665-1-- From unknown Sat Aug 16 18:47:12 2025 X-Loop: don@donarmstrong.com Subject: bug#767: 23.0.60; compilation-start gives bad default-directory Reply-To: Stefan Monnier , 767@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 07 Sep 2008 19:40:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 767 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122081606110733 (code B ref -1); Sun, 07 Sep 2008 19:40:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.7 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 7 Sep 2008 19:34:21 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m87JYILi010725 for ; Sun, 7 Sep 2008 12:34:19 -0700 Received: from mx10.gnu.org ([199.232.76.166]:43303) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KcPzt-00014g-Uw for emacs-pretest-bug@gnu.org; Sun, 07 Sep 2008 15:32:34 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KcQ1W-0004Zu-HQ for emacs-pretest-bug@gnu.org; Sun, 07 Sep 2008 15:34:17 -0400 Received: from ironport2-out.pppoe.ca ([206.248.154.182]:33934 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KcQ1W-0004Zn-5z for emacs-pretest-bug@gnu.org; Sun, 07 Sep 2008 15:34:14 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AiQFAP3Jw0hFxIqP/2dsb2JhbACBZbABgWaBBw X-IronPort-AV: E=Sophos;i="4.32,352,1217822400"; d="scan'208";a="26486195" Received: from 69-196-138-143.dsl.teksavvy.com (HELO ceviche.home) ([69.196.138.143]) by ironport2-out.teksavvy.com with ESMTP; 07 Sep 2008 15:34:11 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 469D4B4062; Sun, 7 Sep 2008 15:34:10 -0400 (EDT) From: Stefan Monnier To: "Lennart Borgman \(gmail\)" Cc: 767@debbugs.gnu.org, emacs-pretest-bug@gnu.org Message-ID: References: <48B00B00.1050305@gmail.com> Date: Sun, 07 Sep 2008 15:34:10 -0400 In-Reply-To: <48B00B00.1050305@gmail.com> (Lennart Borgman's message of "Sat, 23 Aug 2008 15:05:04 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. > If on w32 default-directory is something like c:\top\sub then the Then it's a bug. C-h v default-directory says: Name of default directory of current buffer. Should end with slash. To interactively change the default directory, use command `cd'. So if it doesn't end in slash, we have a problem. Stefan From unknown Sat Aug 16 18:47:12 2025 X-Loop: don@donarmstrong.com Subject: bug#767: 23.0.60; compilation-start gives bad default-directory Reply-To: "Lennart Borgman (gmail)" , 767@debbugs.gnu.org Resent-From: "Lennart Borgman (gmail)" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 07 Sep 2008 19:50:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 767 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 767-submit@emacsbugs.donarmstrong.com id=B767.122081645713729 (code B ref 767); Sun, 07 Sep 2008 19:50:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.5 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 767) by emacsbugs.donarmstrong.com; 7 Sep 2008 19:40:57 +0000 Received: from ch-smtp01.sth.basefarm.net (ch-smtp01.sth.basefarm.net [80.76.149.212]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m87JerIU013723 for <767@emacsbugs.donarmstrong.com>; Sun, 7 Sep 2008 12:40:55 -0700 Received: from c83-254-151-87.bredband.comhem.se ([83.254.151.87]:64693 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KcQ7w-0005mo-5t; Sun, 07 Sep 2008 21:40:53 +0200 Message-ID: <48C42E3D.3000709@gmail.com> Date: Sun, 07 Sep 2008 21:40:45 +0200 From: "Lennart Borgman (gmail)" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Stefan Monnier CC: 767@debbugs.gnu.org References: <48B00B00.1050305@gmail.com> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 080907-0, 2008-09-07), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.87 X-Scan-Result: No virus found in message 1KcQ7w-0005mo-5t. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1KcQ7w-0005mo-5t aa63a0c70e439154ce1d11478e8effce Stefan Monnier wrote: >> If on w32 default-directory is something like c:\top\sub then the > > Then it's a bug. C-h v default-directory says: > > Name of default directory of current buffer. Should end with slash. > To interactively change the default directory, use command `cd'. > > So if it doesn't end in slash, we have a problem. I never noticed that it must end with a slash and in many circumstances it works without it. I suggested that this should be fixed somewhere in start-process and I think Chong added something along those lines. Do you suggest something else? (Making Emacs actually require the ending slash seems is not very backwards compatible.) From unknown Sat Aug 16 18:47:12 2025 X-Loop: don@donarmstrong.com Subject: bug#767: 23.0.60; compilation-start gives bad default-directory Reply-To: Stefan Monnier , 767@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 07 Sep 2008 20:05:06 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 767 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 767-submit@emacsbugs.donarmstrong.com id=B767.122081756719210 (code B ref 767); Sun, 07 Sep 2008 20:05:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.7 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 767) by emacsbugs.donarmstrong.com; 7 Sep 2008 19:59:27 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m87JxN2w019203 for <767@emacsbugs.donarmstrong.com>; Sun, 7 Sep 2008 12:59:24 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AiQFAK7Pw0hFxIqP/2dsb2JhbACBZbAggWaBBw X-IronPort-AV: E=Sophos;i="4.32,352,1217822400"; d="scan'208";a="26486685" Received: from 69-196-138-143.dsl.teksavvy.com (HELO ceviche.home) ([69.196.138.143]) by ironport2-out.teksavvy.com with ESMTP; 07 Sep 2008 15:59:17 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 112ACB4062; Sun, 7 Sep 2008 15:59:17 -0400 (EDT) From: Stefan Monnier To: "Lennart Borgman \(gmail\)" Cc: 767@debbugs.gnu.org Message-ID: References: <48B00B00.1050305@gmail.com> <48C42E3D.3000709@gmail.com> Date: Sun, 07 Sep 2008 15:59:17 -0400 In-Reply-To: <48C42E3D.3000709@gmail.com> (Lennart Borgman's message of "Sun, 07 Sep 2008 21:40:45 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > I never noticed that it must end with a slash and in many circumstances > it works without it. I know it does in many cases, but as you've found out it doesn't always work. > I suggested that this should be fixed somewhere in start-process and I > think Chong added something along those lines. I saw that yes. And I think that given the docstring, the patch should not let-bind default-directory but just setq it (or do nothing at all). > (Making Emacs actually require the ending slash seems is not very > backwards compatible.) AFAIK it's been that way for ever, so backward compatibility is not really relevant. Stefan From unknown Sat Aug 16 18:47:12 2025 X-Loop: don@donarmstrong.com Subject: bug#767: 23.0.60; compilation-start gives bad default-directory Reply-To: "Lennart Borgman (gmail)" , 767@debbugs.gnu.org Resent-From: "Lennart Borgman (gmail)" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 07 Sep 2008 20:10:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 767 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 767-submit@emacsbugs.donarmstrong.com id=B767.122081790221055 (code B ref 767); Sun, 07 Sep 2008 20:10:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.5 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 767) by emacsbugs.donarmstrong.com; 7 Sep 2008 20:05:02 +0000 Received: from ch-smtp02.sth.basefarm.net (ch-smtp02.sth.basefarm.net [80.76.149.213]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m87K4vjl020916 for <767@emacsbugs.donarmstrong.com>; Sun, 7 Sep 2008 13:04:59 -0700 Received: from c83-254-151-87.bredband.comhem.se ([83.254.151.87]:64969 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KcQVE-0007Kf-9Q; Sun, 07 Sep 2008 22:04:57 +0200 Message-ID: <48C433E2.3090101@gmail.com> Date: Sun, 07 Sep 2008 22:04:50 +0200 From: "Lennart Borgman (gmail)" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Stefan Monnier CC: 767@debbugs.gnu.org References: <48B00B00.1050305@gmail.com> <48C42E3D.3000709@gmail.com> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 080907-0, 2008-09-07), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.87 X-Scan-Result: No virus found in message 1KcQVE-0007Kf-9Q. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1KcQVE-0007Kf-9Q d2b50c3878476833e8356d7e6a61835a Stefan Monnier wrote: >> I suggested that this should be fixed somewhere in start-process and I >> think Chong added something along those lines. > > I saw that yes. And I think that given the docstring, the patch should > not let-bind default-directory but just setq it (or do nothing at all). Why not change the doc string instead and say that it is recommended that default-directory ends with a slash? I do not understand the reason for your suggestions above. From unknown Sat Aug 16 18:47:12 2025 X-Loop: don@donarmstrong.com Subject: bug#767: 23.0.60; compilation-start gives bad default-directory Reply-To: Stefan Monnier , 767@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 07 Sep 2008 20:45:06 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 767 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 767-submit@emacsbugs.donarmstrong.com id=B767.12208199291041 (code B ref 767); Sun, 07 Sep 2008 20:45:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.7 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 767) by emacsbugs.donarmstrong.com; 7 Sep 2008 20:38:49 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m87Kck5L001035 for <767@emacsbugs.donarmstrong.com>; Sun, 7 Sep 2008 13:38:47 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AiQFAP/Yw0hFxIqP/2dsb2JhbACBZbAbgWaBBw X-IronPort-AV: E=Sophos;i="4.32,352,1217822400"; d="scan'208";a="26487445" Received: from 69-196-138-143.dsl.teksavvy.com (HELO ceviche.home) ([69.196.138.143]) by ironport2-out.teksavvy.com with ESMTP; 07 Sep 2008 16:38:40 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 9EC42B4062; Sun, 7 Sep 2008 16:38:29 -0400 (EDT) From: Stefan Monnier To: "Lennart Borgman \(gmail\)" Cc: 767@debbugs.gnu.org Message-ID: References: <48B00B00.1050305@gmail.com> <48C42E3D.3000709@gmail.com> <48C433E2.3090101@gmail.com> Date: Sun, 07 Sep 2008 16:38:29 -0400 In-Reply-To: <48C433E2.3090101@gmail.com> (Lennart Borgman's message of "Sun, 07 Sep 2008 22:04:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >>> I suggested that this should be fixed somewhere in start-process and I >>> think Chong added something along those lines. >> I saw that yes. And I think that given the docstring, the patch should >> not let-bind default-directory but just setq it (or do nothing at all). > Why not change the doc string instead and say that it is recommended > that default-directory ends with a slash? Because it worked just fine as it is. You still haven't told us where the offending (non slash-terminated) value came from (which is the thing that needs to be fixed). Stefan From unknown Sat Aug 16 18:47:12 2025 X-Loop: don@donarmstrong.com Subject: bug#767: 23.0.60; compilation-start gives bad default-directory Reply-To: "Lennart Borgman (gmail)" , 767@debbugs.gnu.org Resent-From: "Lennart Borgman (gmail)" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 07 Sep 2008 21:05:06 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 767 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 767-submit@emacsbugs.donarmstrong.com id=B767.12208211838040 (code B ref 767); Sun, 07 Sep 2008 21:05:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.5 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 767) by emacsbugs.donarmstrong.com; 7 Sep 2008 20:59:43 +0000 Received: from ch-smtp02.sth.basefarm.net (ch-smtp02.sth.basefarm.net [80.76.149.213]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m87KxdX7008033 for <767@emacsbugs.donarmstrong.com>; Sun, 7 Sep 2008 13:59:40 -0700 Received: from c83-254-151-87.bredband.comhem.se ([83.254.151.87]:64329 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KcRMA-0007Xu-7p; Sun, 07 Sep 2008 22:59:38 +0200 Message-ID: <48C440B6.3000102@gmail.com> Date: Sun, 07 Sep 2008 22:59:34 +0200 From: "Lennart Borgman (gmail)" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Stefan Monnier CC: 767@debbugs.gnu.org References: <48B00B00.1050305@gmail.com> <48C42E3D.3000709@gmail.com> <48C433E2.3090101@gmail.com> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 080907-0, 2008-09-07), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.87 X-ACL-Warn: Too high rate of unknown addresses received from you X-Scan-Result: No virus found in message 1KcRMA-0007Xu-7p. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1KcRMA-0007Xu-7p c02f2886dccabf9bdb53c7e8d966b8ae Stefan Monnier wrote: >>>> I suggested that this should be fixed somewhere in start-process and I >>>> think Chong added something along those lines. >>> I saw that yes. And I think that given the docstring, the patch should >>> not let-bind default-directory but just setq it (or do nothing at all). >> Why not change the doc string instead and say that it is recommended >> that default-directory ends with a slash? > > Because it worked just fine as it is. You still haven't told us where > the offending (non slash-terminated) value came from (which is the > thing that needs to be fixed). It is not a bad question, but I can't remember now. Whatever I try to do I get an ending slash there (unless I do not set default-directory myself of course). However I am quite sure I did not get that before. Something must be different ... The value of default-directory on w32 may still use \ instead of /. That is the case after "emacs -Q", but that is another problem. From unknown Sat Aug 16 18:47:12 2025 X-Loop: don@donarmstrong.com Subject: bug#767: 23.0.60; compilation-start gives bad default-directory Reply-To: Eli Zaretskii , 767@debbugs.gnu.org Resent-From: Eli Zaretskii Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 07 Sep 2008 21:25:07 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 767 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122082240415657 (code B ref -1); Sun, 07 Sep 2008 21:25:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.9 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 7 Sep 2008 21:20:04 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m87LJxhl015575 for ; Sun, 7 Sep 2008 14:20:00 -0700 Received: from mail.gnu.org ([199.232.76.166]:37442 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KcReB-0002ki-DR for emacs-pretest-bug@gnu.org; Sun, 07 Sep 2008 17:18:15 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KcRfm-0000PM-JB for emacs-pretest-bug@gnu.org; Sun, 07 Sep 2008 17:19:58 -0400 Received: from mtaout5.012.net.il ([84.95.2.13]:36547) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KcRfm-0000PG-8I for emacs-pretest-bug@gnu.org; Sun, 07 Sep 2008 17:19:54 -0400 Received: from HOME-C4E4A596F7 ([84.229.211.50]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K6U00J8MGL8SDD2@i_mtaout5.012.net.il> for emacs-pretest-bug@gnu.org; Mon, 08 Sep 2008 00:19:56 +0300 (IDT) Date: Mon, 08 Sep 2008 00:19:15 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier , 767@debbugs.gnu.org Cc: lennart.borgman@gmail.com, emacs-pretest-bug@gnu.org Message-id: References: <48B00B00.1050305@gmail.com> X-detected-kernel: by monty-python.gnu.org: Solaris 9.1 X-CrossAssassin-Score: 2 > From: Stefan Monnier > Date: Sun, 07 Sep 2008 15:34:10 -0400 > Cc: 767@emacsbugs.donarmstrong.com, emacs-pretest-bug@gnu.org > > > If on w32 default-directory is something like c:\top\sub then the > > Then it's a bug. C-h v default-directory says: > > Name of default directory of current buffer. Should end with slash. > To interactively change the default directory, use command `cd'. > > So if it doesn't end in slash, we have a problem. It does end in a slash on my machine (also on MS-Windows). I think the original problem is that it uses backslashes instead of forward slashes. From unknown Sat Aug 16 18:47:12 2025 X-Loop: don@donarmstrong.com Subject: bug#767: 23.0.60; compilation-start gives bad default-directory Reply-To: "Lennart Borgman (gmail)" , 767@debbugs.gnu.org Resent-From: "Lennart Borgman (gmail)" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 07 Sep 2008 23:55:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 767 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 767-submit@emacsbugs.donarmstrong.com id=B767.12208313402615 (code B ref 767); Sun, 07 Sep 2008 23:55:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.5 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 767) by emacsbugs.donarmstrong.com; 7 Sep 2008 23:49:00 +0000 Received: from ch-smtp02.sth.basefarm.net (ch-smtp02.sth.basefarm.net [80.76.149.213]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m87NmunI002609 for <767@emacsbugs.donarmstrong.com>; Sun, 7 Sep 2008 16:48:57 -0700 Received: from c83-254-151-87.bredband.comhem.se ([83.254.151.87]:59359 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KcTzy-0008KU-82; Mon, 08 Sep 2008 01:48:54 +0200 Message-ID: <48C46860.4060209@gmail.com> Date: Mon, 08 Sep 2008 01:48:48 +0200 From: "Lennart Borgman (gmail)" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Eli Zaretskii CC: Stefan Monnier , 767@debbugs.gnu.org References: <48B00B00.1050305@gmail.com> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 080907-0, 2008-09-07), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.87 X-ACL-Warn: Too high rate of unknown addresses received from you X-Scan-Result: No virus found in message 1KcTzy-0008KU-82. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1KcTzy-0008KU-82 2c808cb043851c3db1f9e468b64e4cb8 Eli Zaretskii wrote: >> From: Stefan Monnier >> Date: Sun, 07 Sep 2008 15:34:10 -0400 >> Cc: 767@emacsbugs.donarmstrong.com, emacs-pretest-bug@gnu.org >> >>> If on w32 default-directory is something like c:\top\sub then the >> Then it's a bug. C-h v default-directory says: >> >> Name of default directory of current buffer. Should end with slash. >> To interactively change the default directory, use command `cd'. >> >> So if it doesn't end in slash, we have a problem. > > It does end in a slash on my machine (also on MS-Windows). > > I think the original problem is that it uses backslashes instead of > forward slashes. No, but I do not understand now why the final forward slash was missing. But of course it might also mean trouble that default-directory when you start Emacs on w32 uses backslashes. Is there any reason not to change that?