GNU bug report logs - #76699
[PATCH emacs-guix 0/4] Refresh package emacs-guix

Previous Next

Full log

Message #23 received at 76699 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 76699 <at> debbugs.gnu.org
Subject: Re: [bug#76699] [PATCH 4/5] Use a development channel instead of
 guix.scm
Date: Sat, 08 Mar 2025 17:55:43 +0100

Hi Nicolas,

Nicolas Graves <ngraves <at> ngraves.fr> skribis:

> ---
>  .guix-channel                              |   3 +
>  guix.scm => channel/emacs-guix-channel.scm |  69 ++++++--------
>  channel/emacs-guix-channel.scm.next        | 104 +++++++++++++++++++++
>  3 files changed, 137 insertions(+), 39 deletions(-)
>  create mode 100644 .guix-channel
>  rename guix.scm => channel/emacs-guix-channel.scm (50%)
>  create mode 100644 channel/emacs-guix-channel.scm.next
>
> diff --git a/.guix-channel b/.guix-channel
> new file mode 100644
> index 0000000..bb2ac66
> --- /dev/null
> +++ b/.guix-channel
> @@ -0,0 +1,3 @@
> +(channel
> + (version 0)
> + (directory "channel"))
> diff --git a/guix.scm b/channel/emacs-guix-channel.scm
> similarity index 50%
> rename from guix.scm
> rename to channel/emacs-guix-channel.scm
> index d35b0ba..ea8a6e7 100644
> --- a/guix.scm
> +++ b/channel/emacs-guix-channel.scm
> @@ -2,6 +2,7 @@

I’d suggest:

  1. Renaming ‘channel’ to ‘.guix/modules’;
  2. Making ‘guix.scm’ a symlink to
     ‘.guix/modules/emacs-guix-packages.scm’.

This would follow the conventions described in the cookbook (info
"(guix-cookbook) Software Development").

> +(define-module (emacs-guix-channel))
> +
>  (use-modules
> + (git)
>   (ice-9 popen)
>   (ice-9 rdelim)

While you’re at it, I’d suggest grouping things together:

  (define-module (emacs-guix-packages)
    #:use-module (git)
    #:use-module …)

> +++ b/channel/emacs-guix-channel.scm.next

What is this supposed to be?  I suspect it’s unnecessary.  :-)

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.