GNU bug report logs - #76690
[PATCH emacs-team 0/4] Emacs build fixes + enable native comp by default?

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: bug#76690: closed (Re: [bug#76690] [PATCH 4/4] Use
 #:lisp-directory instead of a custom phase)
Date: Sun, 09 Mar 2025 20:02:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#76690: [PATCH emacs-team 0/4] Emacs build fixes + enable native comp by default?

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 76690 <at> debbugs.gnu.org.

-- 
76690: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76690
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Morgan Smith <morgan.j.smith <at> outlook.com>
Cc: 76690-done <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Cayetano Santos <csantosb <at> inventati.org>, Andrew Tropin <andrew <at> trop.in>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>
Subject: Re: [bug#76690] [PATCH 4/4] Use #:lisp-directory instead of a
 custom phase
Date: Sun, 09 Mar 2025 21:02:01 +0100

Am Sonntag, dem 02.03.2025 um 17:20 -0500 schrieb Morgan Smith:
> Done!  See attached
Aaaaaaaaaaaand it's pushed.

Cheers

[Message part 3 (message/rfc822, inline)]

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: guix-patches <at> gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH emacs-team 0/4] Emacs build fixes + enable native comp by
 default?
Date: Sun,  2 Mar 2025 15:52:34 -0500

I got a couple fixes here:

1. simple fix.  plz apply

2. Maybe involves a discussion.  Upstream has enabled native compilation by
default so it'd be nice for us to do the same.  However, this bumps the
closure size of emacs-minimal up by 500MiB which is substantial.  It also
increases compile time of both emacs-minimal and now all emacs packages
substantially.

Note: You can install the other 3 patches and just leave this one out for now
if you'd like.

3 and 4. We have many packages (like emacs-stgit) that have a 'chdir' phase.
This messes with the emacs build system so those packages don't have their
autoloads generated, a description generated, the load path stuff is messed
up, and native compilation files get installed into the wrong directories.


Morgan Smith (4):
  gnu: emacs->emacs-next: Don't use file that doesn't exist
  gnu: emacs-minimal: Enable native compilations
  guix: emacs-build-system: Add 'lisp-directory' key
  Use #:lisp-directory instead of a custom phase

 gnu/packages/agda.scm             |   5 +-
 gnu/packages/cmake.scm            |   7 +-
 gnu/packages/emacs-xyz.scm        | 144 ++++++++--------------------
 gnu/packages/emacs.scm            | 153 +++++++++++++-----------------
 gnu/packages/engineering.scm      |   8 +-
 gnu/packages/erlang.scm           |   5 +-
 gnu/packages/mail.scm             |   6 +-
 gnu/packages/music.scm            |   5 +-
 gnu/packages/protobuf.scm         |   5 +-
 gnu/packages/scheme.scm           |   5 +-
 gnu/packages/version-control.scm  |   4 +-
 guix/build-system/emacs.scm       |   2 +
 guix/build/emacs-build-system.scm |   6 +-
 13 files changed, 120 insertions(+), 235 deletions(-)


base-commit: 725917beddf8454f92d01de7a3cfcc283100f43b
-- 
2.48.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.