GNU bug report logs - #76690
[PATCH emacs-team 0/4] Emacs build fixes + enable native comp by default?

Previous Next

Full log

Message #35 received at 76690 <at> debbugs.gnu.org (full text, mbox):

From: Morgan Smith <morgan.j.smith <at> outlook.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Ian Eure <ian <at> retrospec.tv>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Cayetano Santos <csantosb <at> inventati.org>, Andrew Tropin <andrew <at> trop.in>,
 76690 <at> debbugs.gnu.org, Divya Ranjan Pattanaik <divya <at> subvertising.org>
Subject: Re: [bug#76690] [PATCH 4/4] Use #:lisp-directory instead of a
 custom phase
Date: Sun, 02 Mar 2025 17:20:36 -0500

[Message part 1 (text/plain, inline)]

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Sonntag, dem 02.03.2025 um 16:04 -0500 schrieb Morgan Smith:
>> Using a custom phase might not order the 'chdir' at the correct time
>> and might
>> cause problems with some of the early phases in the 'emacs-build-
>> system' (like
>> 'ensure-package-description', 'expand-load-path', etc...)
>> 
>> * gnu/packages/agda.scm (emacs-agda2-mode):
>> * gnu/packages/cmake.scm (emacs-cmake-mode):
>> * gnu/packages/emacs-xyz.scm (emacs-casual-avy, emacs-casual-calc,
>> emacs-casual-dired, emacs-casual-info, emacs-chronometrist, emacs-
>> edit-server,
>> emacs-epkg, emacs-exwm-firefox, emacs-flymake-collection, emacs-
>> forge,
>> emacs-ghub, emacs-know-your-http-well, emacs-org-contrib, emacs-php-
>> mode,
>> emacs-stumpwm-mode, emacs-telega-contrib, emacs-transient, emacs-
>> treemacs,
>> emacs-treemacs-extra, emacs-with-editor, emacs-xenops):
>> * gnu/packages/engineering.scm (emacs-scad-mode):
>> * gnu/packages/erlang.scm (emacs-erlang):
>> * gnu/packages/mail.scm (emacs-notmuch):
>> * gnu/packages/music.scm (emacs-lilypond-mode):
>> * gnu/packages/protobuf.scm (emacs-protobuf-mode):
>> * gnu/packages/scheme.scm (emacs-gerbil-mode):
>> * gnu/packages/version-control.scm (emacs-stgit): Use '#:lisp-
>> directory'
>> instead of a custom phase.
>> ---
> Note: ChangeLog continuation lines should end with a closing
> parenthesis.
> Each file should have a message, even if that is "Likewise."
>
> Not sure if one patch is the right approach here.  I think one patch
> per package might be a better idea.

I've attached the relevant patches to this email.  Let me know if you'd
rather I use 'git send-email' (and how I should do that without filling
up everyone's inbox).

>
> I would use (and=> lisp-directory chdir) and allow chdir to be #f.
>

Done!  See attached

> Cheers

[v2-0001-guix-emacs-build-system-Add-lisp-directory-key.patch (text/x-patch, attachment)]

[v2-0002-gnu-emacs-agda2-mode-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0003-gnu-emacs-cmake-mode-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0004-gnu-emacs-with-editor-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0005-gnu-emacs-ghub-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0006-gnu-emacs-flymake-collection-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0007-gnu-emacs-xenops-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0008-gnu-emacs-chronometrist-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0009-gnu-emacs-org-contrib-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0010-gnu-emacs-php-mode-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0011-gnu-emacs-epkg-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0012-gnu-emacs-edit-server-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0013-gnu-emacs-know-your-http-well-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0014-gnu-emacs-stumpwm-mode-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0015-gnu-emacs-treemacs-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0016-gnu-emacs-treemacs-extra-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0017-gnu-emacs-transient-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0018-gnu-emacs-forge-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0019-gnu-emacs-exwm-firefox-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0020-gnu-emacs-casual-avy-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0021-gnu-emacs-casual-calc-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0022-gnu-emacs-casual-dired-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0023-gnu-emacs-casual-info-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0024-gnu-emacs-telega-contrib-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0025-gnu-emacs-scad-mode-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0026-gnu-emacs-erlang-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0027-gnu-emacs-notmuch-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0028-gnu-emacs-lilypond-mode-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0029-gnu-emacs-protobuf-mode-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0030-gnu-emacs-gerbil-mode-Use-lisp-directory.patch (text/x-patch, attachment)]

[v2-0031-gnu-emacs-stgit-Use-lisp-directory.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.