Subject: Re: [bug#76690] [PATCH 4/4] Use #:lisp-directory instead of a custom phase

From: Liliana Marie Prikler <[email-masked]>
Date: Sun, 02 Mar 2025 22:16:14 +0100

Am Sonntag, dem 02.03.2025 um 16:04 -0500 schrieb Morgan Smith:
> Using a custom phase might not order the 'chdir' at the correct time
> and might
> cause problems with some of the early phases in the 'emacs-build-
> system' (like
> 'ensure-package-description', 'expand-load-path', etc...)
> 
> * gnu/packages/agda.scm (emacs-agda2-mode):
> * gnu/packages/cmake.scm (emacs-cmake-mode):
> * gnu/packages/emacs-xyz.scm (emacs-casual-avy, emacs-casual-calc,
> emacs-casual-dired, emacs-casual-info, emacs-chronometrist, emacs-
> edit-server,
> emacs-epkg, emacs-exwm-firefox, emacs-flymake-collection, emacs-
> forge,
> emacs-ghub, emacs-know-your-http-well, emacs-org-contrib, emacs-php-
> mode,
> emacs-stumpwm-mode, emacs-telega-contrib, emacs-transient, emacs-
> treemacs,
> emacs-treemacs-extra, emacs-with-editor, emacs-xenops):
> * gnu/packages/engineering.scm (emacs-scad-mode):
> * gnu/packages/erlang.scm (emacs-erlang):
> * gnu/packages/mail.scm (emacs-notmuch):
> * gnu/packages/music.scm (emacs-lilypond-mode):
> * gnu/packages/protobuf.scm (emacs-protobuf-mode):
> * gnu/packages/scheme.scm (emacs-gerbil-mode):
> * gnu/packages/version-control.scm (emacs-stgit): Use '#:lisp-
> directory'
> instead of a custom phase.
> ---
Note: ChangeLog continuation lines should end with a closing
parenthesis.
Each file should have a message, even if that is "Likewise."

Not sure if one patch is the right approach here.  I think one patch
per package might be a better idea.

Cheers