Subject: Re: [bug#76686] [PATCH emacs-team] gnu: emacs-explain-pause-mode: Skip tests.

From: Liliana Marie Prikler <[email-masked]>
Date: Sat, 12 Apr 2025 23:18:24 +0200

Am Samstag, dem 12.04.2025 um 17:22 +0200 schrieb Cayetano Santos:
> * gnu/packages/emacs-xyz.scm (emacs-explain-pause-mode): Skip tests.
> 
> Change-Id: I03d5931978db95899b34afc587906f2a7b1e4da8
> ---
>  gnu/packages/emacs-xyz.scm | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 2a377f5a08..6218743e5c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -8032,20 +8032,7 @@ (define-public emacs-explain-pause-mode
>        (build-system emacs-build-system)
>        (native-inputs
>         (list emacs-buttercup))
> -      (arguments
> -       '(#:phases
> -         (modify-phases %standard-phases
> -           ;; This causes the byte-compilation before unit-tests to
> fail.
> -           (add-after 'unpack 'remove-error-on-warn
> -             (lambda _
> -               (substitute* "Makefile"
> -                 (("--eval '\\(setq byte-compile-error-on-warn
> t\\)'") "")))))
> -         ;; Don't run case-tests as they will fail to create sockets
> because
> -         ;; the path is too long
> -         #:test-command '("make" "byte-compile" "unit-tests")
> -         ;; Parallel testing will cause the tests to run before
> -         ;; byte-compilation is finished
> -         #:parallel-tests? #f))
> +      (arguments '(#:tests? #f)) ; fail, package is out of
> maintenance
>        (home-page
> "https://github.com/lastquestion/explain-pause-mode")
>        (synopsis "Top-like interface to determine why Emacs paused")
>        (description
If possible, prefer to fix the test suite over disabling it.  It's also
a good idea to not just drop all arguments and to give a hint as to how
many tests are broken if they still end up disabled.

Cheers